GRI-1873: devices and IP rules API (signage #13) #103

Merged
vivy merged 4 commits from feature/GRI-1873-devices-ip-rules-api into dev 2026-11-10 04:45:59 +00:00
Member

Signage #13: devices and IP rules API, following #12 (merged).

  • GET /devices (optional ?status=pending|approved|blocked), GET /devices/{id}, PATCH /devices/{id} (rename).
  • POST /devices/{id}/approve — admits a pending device and issues its token in the same response, shown once (plan/server/enrolment.md, "Tokens").
  • POST /devices/{id}/block — blocks a pending or approved device; optional add_to_blocklist/blocklist_label adds its current IP to the blocklist.
  • GET /ip-rules, POST/DELETE /ip-rules/blocklist*, POST/DELETE /ip-rules/auto-approve*.

All routes sit behind CurrentUser (signage #10, already in dev). plan/server/rest-api.md's "Devices" and "IP rules" tables are the contract.

Schema needed no changes — devices and ip_rules already carry everything (GRI-1873 #12).

Signage #13: devices and IP rules API, following #12 (merged). - `GET /devices` (optional `?status=pending|approved|blocked`), `GET /devices/{id}`, `PATCH /devices/{id}` (rename). - `POST /devices/{id}/approve` — admits a pending device and issues its token in the same response, shown once (`plan/server/enrolment.md`, "Tokens"). - `POST /devices/{id}/block` — blocks a pending or approved device; optional `add_to_blocklist`/`blocklist_label` adds its current IP to the blocklist. - `GET /ip-rules`, `POST`/`DELETE /ip-rules/blocklist*`, `POST`/`DELETE /ip-rules/auto-approve*`. All routes sit behind `CurrentUser` (signage #10, already in dev). `plan/server/rest-api.md`'s "Devices" and "IP rules" tables are the contract. Schema needed no changes — `devices` and `ip_rules` already carry everything (GRI-1873 #12).
GRI-1873: devices and IP rules API (signage #13)
Some checks failed
CI / the pre-push hook (pull_request) Successful in 4s
CI / cargo fmt (pull_request) Successful in 5s
CI / cargo deny (pull_request) Successful in 45s
CI / cargo deny advisories (pull_request) Failing after 45s
CI / cargo test (pull_request) Failing after 5m49s
CI / repository boundary (pull_request) Successful in 5s
CI / cargo clippy (pull_request) Successful in 9m55s
CI / frontend-web (pull_request) Successful in 9m41s
CI / CI (pull_request) Failing after 5s
CI / Notify gate failed (pull_request) Successful in 5s
c072a3a04f
Merge remote-tracking branch 'origin/dev' into feature/GRI-1873-devices-ip-rules-api
Some checks failed
CI / cargo fmt (pull_request) Successful in 7s
CI / the pre-push hook (pull_request) Successful in 8s
CI / cargo test (pull_request) Failing after 5m50s
CI / cargo deny advisories (pull_request) Failing after 2m18s
CI / repository boundary (pull_request) Successful in 6s
CI / cargo deny (pull_request) Failing after 2m34s
CI / cargo clippy (pull_request) Successful in 10m7s
CI / frontend-web (pull_request) Successful in 9m49s
CI / CI (pull_request) Failing after 4s
CI / Notify gate failed (pull_request) Successful in 6s
b5a63ab0fd
ip_address::text rendered an inet as CIDR (e.g. 203.0.113.5/32), which
IpAddr::from_str rejects, so row_to_device always read ip_address as
None and the blocklist insert on block_device was silently skipped.
Merge origin/dev into feature/GRI-1873-devices-ip-rules-api
Some checks failed
CI / cargo fmt (pull_request) Successful in 8s
CI / the pre-push hook (pull_request) Successful in 8s
CI / cargo deny advisories (pull_request) Failing after 1m12s
CI / cargo deny (pull_request) Successful in 1m15s
CI / repository boundary (pull_request) Successful in 6s
CI / cargo clippy (pull_request) Successful in 10m7s
CI / frontend-web (pull_request) Successful in 9m43s
CI / cargo test (pull_request) Successful in 11m22s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 3s
585ca9ff34
vivy merged commit 6ff9c3f6eb into dev 2026-11-10 04:45:59 +00:00
vivy deleted branch feature/GRI-1873-devices-ip-rules-api 2026-11-10 04:46:00 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
Grimoirix/grimoire-of-digital-signage!103
No description provided.