GRI-1896: device groups claim devices by a name rule #140
No reviewers
Labels
No labels
Area/Backend
Area/Database
Area/Docs
Area/Frontend
Area/Infra
Area/Security
Area/Tests
Area/Tooling
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Lang/Python
Lang/Rust
Lang/Shell
Lang/SQL
Lang/TypeScript
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Routing
Auto
Routing
Hold
Routing
Human
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
Grimoirix/grimoire-of-digital-signage!140
Loading…
Reference in a new issue
No description provided.
Delete branch "feature/GRI-1896-device-groups"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Part of #35. GRI-1896.
What
crates/server/src/groups.rs: aDeviceGroupwith an optionalNameRule(StartsWith,EndsWith,Contains,Regex).DeviceGroup::claims(name)says whether a device with that name is in the group by rule.NameRule::is_validrefuses a regular expression that does not parse, so the panel can refuse it before saving (plan/server/enrolment.md, "Device groups").A group without a rule is a manual group and claims nothing by name.
Test
a_device_named_lobby_03_joins_the_lobby_group_by_the_starts_with_ruleis the "done when" line of #35. Five more cover a non-match, manual placement, a regex match and an invalid regex.New dependency
regex = "1"(MIT/Apache-2.0).cargo denypasses.Not in this PR
No table, no API and no playlist-to-group assignment yet. #35 stays open for those.
Local
--rust-onlygates: all green.