GRI-1937: session.secure_cookie setting #144

Merged
vivy merged 1 commit from feature/GRI-1937-secure-cookie-setting into dev 2026-11-12 17:25:54 +00:00
Owner

Part 2 of the GRI-1937 plan (setup-wizard-plan), server side only.

  • New key session.secure_cookie (default true), env SIGNAGE_SESSION_SECURE_COOKIE. When false the session cookie has no Secure attribute, so a plain-HTTP install can sign in. HttpOnly and SameSite=Strict stay.
  • Handlers read it as an optional Extension<CookieSecurity>; a router without the layer gets Secure (fails closed).
  • The server prints a warning at start-up when it is off.
  • Documented in plan/server/configuration.md; the installer's closing hint names the option.

Not here (part 3): setup wizard steps and the Settings screen that writes this key.

Tests: unit tests for the header and the config/env parsing; integration test with_secure_cookie_off_the_session_cookie_has_no_secure_attribute. Local: clippy -D warnings clean, cargo test -p server --lib 149 ok, auth_integration 13 ok, setup_session_integration 6 ok.

Part 2 of the GRI-1937 plan (`setup-wizard-plan`), server side only. - New key `session.secure_cookie` (default `true`), env `SIGNAGE_SESSION_SECURE_COOKIE`. When `false` the session cookie has no `Secure` attribute, so a plain-HTTP install can sign in. `HttpOnly` and `SameSite=Strict` stay. - Handlers read it as an optional `Extension<CookieSecurity>`; a router without the layer gets `Secure` (fails closed). - The server prints a warning at start-up when it is off. - Documented in `plan/server/configuration.md`; the installer's closing hint names the option. Not here (part 3): setup wizard steps and the Settings screen that writes this key. Tests: unit tests for the header and the config/env parsing; integration test `with_secure_cookie_off_the_session_cookie_has_no_secure_attribute`. Local: clippy -D warnings clean, `cargo test -p server --lib` 149 ok, `auth_integration` 13 ok, `setup_session_integration` 6 ok.
GRI-1937: session.secure_cookie setting — Secure stays the default, plain HTTP is an explicit choice
Some checks failed
CI / the pre-push hook (pull_request) Successful in 30s
CI / cargo fmt (pull_request) Successful in 34s
CI / cargo deny (pull_request) Successful in 1m22s
CI / cargo clippy (pull_request) Successful in 1m57s
CI / cargo deny advisories (pull_request) Failing after 1m47s
CI / frontend-web (pull_request) Successful in 2m11s
CI / repository boundary (pull_request) Successful in 54s
CI / cargo test (pull_request) Successful in 5m55s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 3s
75b063017f
vivy merged commit 5adcbe9366 into dev 2026-11-12 17:25:54 +00:00
vivy deleted branch feature/GRI-1937-secure-cookie-setting 2026-11-12 17:25:55 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
Grimoirix/grimoire-of-digital-signage!144
No description provided.