GRI-1937: session.secure_cookie setting #144
No reviewers
Labels
No labels
Area/Backend
Area/Database
Area/Docs
Area/Frontend
Area/Infra
Area/Security
Area/Tests
Area/Tooling
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Lang/Python
Lang/Rust
Lang/Shell
Lang/SQL
Lang/TypeScript
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Routing
Auto
Routing
Hold
Routing
Human
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
Grimoirix/grimoire-of-digital-signage!144
Loading…
Reference in a new issue
No description provided.
Delete branch "feature/GRI-1937-secure-cookie-setting"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Part 2 of the GRI-1937 plan (
setup-wizard-plan), server side only.session.secure_cookie(defaulttrue), envSIGNAGE_SESSION_SECURE_COOKIE. Whenfalsethe session cookie has noSecureattribute, so a plain-HTTP install can sign in.HttpOnlyandSameSite=Strictstay.Extension<CookieSecurity>; a router without the layer getsSecure(fails closed).plan/server/configuration.md; the installer's closing hint names the option.Not here (part 3): setup wizard steps and the Settings screen that writes this key.
Tests: unit tests for the header and the config/env parsing; integration test
with_secure_cookie_off_the_session_cookie_has_no_secure_attribute. Local: clippy -D warnings clean,cargo test -p server --lib149 ok,auth_integration13 ok,setup_session_integration6 ok.