GRI-2014: render a real slideshow instead of a blank one #192
No reviewers
Labels
No labels
Area/Backend
Area/Database
Area/Docs
Area/Frontend
Area/Infra
Area/Security
Area/Tests
Area/Tooling
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Lang/Python
Lang/Rust
Lang/Shell
Lang/SQL
Lang/TypeScript
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Routing
Auto
Routing
Hold
Routing
Human
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
Grimoirix/grimoire-of-digital-signage!192
Loading…
Reference in a new issue
No description provided.
Delete branch "fix/GRI-2014-pptx-slideshow-render"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
soffice --showleft the Impress slideshow permanently blank on thishost (no
/dev/dri): the presentation window never got its first paint.Loading the document normally, waiting for its window, then sending a
synthetic F5 over XTEST (with OpenGL/Skia disabled in the profile)
renders real content instead.
crates/server/src/bin/pptx_video_presenter.rs(pure-Rustx11rb,no new host package) drives that keypress and tracks the slideshow via
the EWMH
_NET_WM_STATE_FULLSCREENhint, sincesofficeno longerself-closes on its own when a show ends now that nothing passes
--show.render_to_mp4shells out to it the same way it shells out tosoffice/ffmpeg/Xvfb/gs— newPptxVideoConfig::presenter_path(GRI-1884).
code (0 = finished, 2 = still running at the timeout) the same way they
already fake every other tool; none of this needs a real X server to run
in CI.
Full root-cause writeup and a fidelity report (3 real decks, including one
with a transition and one with both a transition and an entrance
animation, run through the real pipeline on this host) are on forge #189.
That comment also flags two things not fixed here: the Docker image has
none of these binaries (pre-existing, from #190), and a slideshow does not
end on its own even when fully auto-timed, so
render_to_mp4's existing"discard on timeout" contract means most real uploads still fall back to
slide images in practice — a product/acceptance-criteria decision, not a
bug this PR introduces.
Test plan
cargo fmt --all --checkcargo clippy --workspace --all-targets --locked -- -D warningscargo test -p server --lib pptx_video(unit tests, fake tools)cargo test -p server --test pptx_video_acceptance_integration(
SIGNAGE_TEST_DATABASE_URLset)cargo deny check bans licenses sourcessoffice/Xvfb/ffmpeg:plain deck, a deck with an auto-advancing fade transition, and a
deck with both a transition and a fade entrance animation — all
render real, correct content (see forge #189 for frames/detail).