GRI-2014: gate the .pptx MP4 render behind config, default off, and fix the presenter/idle race #196
No reviewers
Labels
No labels
Area/Backend
Area/Database
Area/Docs
Area/Frontend
Area/Infra
Area/Security
Area/Tests
Area/Tooling
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Lang/Python
Lang/Rust
Lang/Shell
Lang/SQL
Lang/TypeScript
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Routing
Auto
Routing
Hold
Routing
Human
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
Grimoirix/grimoire-of-digital-signage!196
Loading…
Reference in a new issue
No description provided.
Delete branch "fix/GRI-2014-pptx-mp4-flag-fallback"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What
Step 1 of the 15:3x decision on forge #189, given Monday's campus deadline:
PptxVideoConfig.mp4_enabled: bool(defaultfalse,SIGNAGE_PPTX_VIDEO_MP4_ENABLED, GRI-1884-compliant).convert_pptxonly triesrender_to_mp4when it'strue— otherwise every.pptxupload goes straight to the slide-image fallback.render_to_mp4'stokio::select!racesrun_presenter(reports "never went fullscreen" only after the fullrender_timeout_seconds) againstwatch_for_idle_screen(reports idle after the much shorteridle_end_seconds). A deck stuck on its loading screen is just as "idle" as one that finished normally, so idle always won and the presenter'sErrwas silently dropped. Fixed:pptx_video_presenternow printsFULLSCREENto stdout the instant it first observes fullscreen;run_presenterreads that live and sets a shared signal;watch_for_idle_screenwill not start its stillness count until that signal is set, so a presenter that never reaches fullscreen can only be resolved by its own, eventualErr.Testing
cargo test -p server --lib pptx_video— 25/25, including a new regression test (a_presenter_that_never_reaches_fullscreen_is_not_overridden_by_an_idle_screen) that fails against the pre-fix code.cargo test -p server --lib config::— 19/19, including the newmp4_enableddefault/env-override test.mp4_is_off_by_default_the_upload_still_falls_back_to_pages../scripts/local-gates.sh --rust-only: every gate passed.Forge #189 stays open: step 2 (root cause of the real-host blank render, content-based acceptance check) is separate, unstarted work.
Review (vivy, 15:5x): held —
cargo testis red, and it is the new test, not the product code.Reproduced locally on
02e8b12with Postgres:mp4_is_off_by_default_the_upload_still_falls_back_to_pagesfails with400 invalid_pptx: the deck produced no pages. The other 3 acceptance tests and all 25pptx_videounit tests pass.Cause: the test starts from
fake_successful_render_opts, whose fakesofficeonly runssleep 30and writes no PDF, and whose rasterizer is the default one. So the fallback path has no pages. Fix: takesoffice_pathandrasterizer_pathfromfallback_only_opts. With this patch, 4/4 pass:Please apply it, push, and I merge on green. The gate and the race fix themselves look right to me.