GRI-2014: build .pptx video from slide images and ffmpeg xfade #199
No reviewers
Labels
No labels
Area/Backend
Area/Database
Area/Docs
Area/Frontend
Area/Infra
Area/Security
Area/Tests
Area/Tooling
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Lang/Python
Lang/Rust
Lang/Shell
Lang/SQL
Lang/TypeScript
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Routing
Auto
Routing
Hold
Routing
Human
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
Grimoirix/grimoire-of-digital-signage!199
Loading…
Reference in a new issue
No description provided.
Delete branch "feature/GRI-2014-pptx-xfade-video"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What
Replaces the Xvfb-recorded slideshow render (PRs #190–#196) with GRI-2043's
"option D": read each slide's transition and
advTmout of the.pptxXML,render the same slide images the fallback already produces, and join them
with
ffmpeg xfadeusing the closest matching effect. No display server, norecording, no focus race — deterministic, and fully covered by tests that run
without
soffice/ffmpeg/gsinstalled (CI has none of the three).Changes
crates/server/src/pptx_video.rs: rewritten.render_fallback_pagesisunchanged (now also the first step of the video path, not just the
fallback); the Xvfb/presenter machinery is replaced with
join_slides_into_mp4,read_slide_timings(zip + regex XML reader forppt/presentation.xml+ its.rels+ each slide part, skipping hiddenslides),
map_transition(the PowerPoint →xfadetable), andTimeline(the chained-offset arithmetic for
ffmpeg's-filter_complex).src/bin/pptx_video_presenter.rsand thex11rbdependency —nothing here opens an X display any more.
crate::config::PptxVideoConfig: droppedxvfb_path,window_manager_path,presenter_path,idle_end_seconds.mp4_enablednow defaults on(my call, as the decision asked — the render has nothing left to default
off for: no
Xvfb, no recording, covered by the acceptance tests below).crate::playback_settings::effective_default_duration_seconds: new publichelper so
media::handlers::convert_pptxcan look up the uploadingcampus's configured page duration as the dwell time for a slide with no
advTmof its own.crate::media::handlers::convert_pptx: always renders slide images first,then tries the join on top of them — a join failure keeps the
already-rendered images rather than re-running anything.
plan/server/media-pipeline.md,plan/server/content-model.md: updatedfor the new approach.
Done when (forge #189 / GRI-2043)
.pptxwith a fade and a push, one slide withadvTmand onewithout: one video item; the slide times are
advTmand the campusdefault; a frame mid-transition shows both slides — verified manually
with real
soffice/gs/ffmpegon this host (fade and push framesboth show the expected blend/slide; details in the forge comment).
table row); acceptance test without
#[ignore].Test plan
cargo test -p server --lib pptx_video— 23/23 unit tests (XML reader,transition map table, timeline/offset arithmetic, filter-complex
construction, the join and fallback paths against fake tools).
cargo test -p server --test pptx_video_acceptance_integration— 4/4,against a real Postgres, with fake
soffice/gs/ffmpeg../scripts/local-gates.sh --rust-only— every gate green (fmt, clippy,cargo denybans/licenses/sources, the full workspace test suite includingthe acceptance tests above, repo-boundary, pre-push hook). Pre-existing,
branch-unrelated
cargo denyadvisories failure (RUSTSEC-2024-0429, glibvia the client crate) unchanged.
transition +
advTm=500mson slide 2 and a push transition with noadvTmon slide 3, ran it through the realsoffice/gs/ffmpegpipeline, and inspected frames mid-transition — both show the expected
blend between slides.
CI green on the gating
CI / CIcontext (commit7e5a777f): clippy, cargo deny bans/licenses/sources, fmt, cargo test, frontend-web, repository boundary, pre-push hook all pass. Onlycargo deny advisoriesis red — the same pre-existing, branch-unrelated RUSTSEC-2024-0429 issue flagged on every PR in this chain (#190/#192/#193/#194/#196); this branch touches no Cargo.toml/Cargo.lock. Mergeable, no conflicts. Handing to the CTO for review/merge into dev.