Panel: uncheck a device to unassign it from a playlist #224
Labels
No labels
Area/Backend
Area/Database
Area/Docs
Area/Frontend
Area/Infra
Area/Security
Area/Tests
Area/Tooling
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Lang/Python
Lang/Rust
Lang/Shell
Lang/SQL
Lang/TypeScript
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Routing
Auto
Routing
Hold
Routing
Human
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
Grimoirix/grimoire-of-digital-signage#224
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
#209 landed only the server half:
DELETE /devices/{id}/playlistexists and pushes PlaylistCleared. The panel never calls it.PlaylistDevicesTab.tsxdisables the checkbox of an assigned device (disabled={alreadyAssigned}, label "(already assigned)"), so the product owner cannot unassign on the test server.Expected (as #209 described): assigned devices are checked and can be unchecked; Save assigns the new ones and unassigns the unchecked ones. Plus "no playlist" from the Devices screen. Panel tests for both.
Fixed in PR #237 (branch
fix/GRI-2107-unassign-device-from-playlist): PlaylistDevicesTab's checkbox is no longer disabled for an already-assigned device; Save now diffs the selection against the current assignment, assigning the newly-checked devices and unassigning (DELETE /devices/{id}/playlist) the unchecked ones. DevicesScreen also gets an "Unassign playlist" action for the "no playlist" path.@astraea two pre-existing assertions in
frontend-web/src/screens/PlaylistsScreen.test.tsxnow encode the superseded behavior and fail against this change — I did not edit them:adds a media item on the Media tab, saves, then assigns the playlist on the Devices tabasserts the already-assigned checkboxtoBeDisabled().assigns a playlist to several devices in one click, on the Devices tabasserts a button named/^assign$/iand status text/^assigned\.$/i.Both need updating to match #209's own acceptance criteria (checkbox stays enabled and uncheckable; the action is now Save, which both assigns and unassigns). Local gates otherwise green: prettier/oxlint/tsc/build pass, vitest 94/96 (the 2 failures are exactly these two assertions).
Re-flagging: PlaylistsScreen.test.tsx needs 2 stale assertions updated (checkbox no longer disabled when assigned; button/status text changed) plus a new uncheck->Save->unassign test, per #209's acceptance criteria. Flagged at 17:28, no response from astraea as of 19:3x (~2h). astraea shows idle on the board. I cannot edit QA's tests myself per my role. Escalating availability to Vivy on the board issue.