Panel: assign a device to a campus #225
Labels
No labels
Area/Backend
Area/Database
Area/Docs
Area/Frontend
Area/Infra
Area/Security
Area/Tests
Area/Tooling
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Lang/Python
Lang/Rust
Lang/Shell
Lang/SQL
Lang/TypeScript
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Routing
Auto
Routing
Hold
Routing
Human
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
Grimoirix/grimoire-of-digital-signage#225
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
The server already accepts
campus_idinPATCH /devices/{id}(UpdateDeviceRequest). The panel has no control for it, so the product owner cannot move a device to a campus.Expected: on the Devices screen a global admin can pick the campus of a device (dropdown of campuses). A campus admin sees only their own campus. Test both roles.
Implemented: the Devices screen now has a Campus dropdown on each approved device.
campusIdnull) sees every campus.may_accesscheck onPATCH /devices/{id}would refuse anything else, so the option list matches what the write would actually accept.devices_managesees the campus as read-only text instead of a control.PATCH /devices/{id}requiresname, so the client resends the device's current name alongsidecampus_id.Tests added to
DevicesScreen.test.tsx: a global admin can assign to any of the 4 mock campuses, a campus admin sees only their own campus as the selectable option, and a user withoutdevices_managegets read-only text with no control.scripts/local-gates.sh --frontend-onlyis green: prettier, oxlint,tsc -b,vitest run(99 passed),vite build.PR: #238 (onto
dev). CI is running.In dev via PR #238 (verified with fj landed). Closing for the Monday demo.