Panel: error messages can be closed, close by themselves, and clear on the next action #236
Labels
No labels
Area/Backend
Area/Database
Area/Docs
Area/Frontend
Area/Infra
Area/Security
Area/Tests
Area/Tooling
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Lang/Python
Lang/Rust
Lang/Shell
Lang/SQL
Lang/TypeScript
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Routing
Auto
Routing
Hold
Routing
Human
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
Grimoirix/grimoire-of-digital-signage#236
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Product owner, from the campus test on 2026-11-15 (GRI-2051): an error message in the panel stays on screen. There is no way to close it, and it stays when he does the next thing (for example, uploading the file again).
What to build
Done when
Pull request #241: #241
Added a shared
DismissibleErrorcomponent (close button, 10s self-dismiss timer that pauses on hover, selectable text) and wired it into every transient error note in the panel:Left unchanged, as a different kind of message than the one reported: the full-page "could not load — Retry" states (nothing else on screen to cover), the delete-conflict confirm dialog,
AddFromLibraryDialog's live page-range validation, andDashboardScreen's access notice.Tests:
DismissibleError.test.tsxcovers the close button, the timer, and hover pausing/resuming it.MediaScreen.test.tsxadds the close-button and "new action clears a stale error" cases at the integration level — the samesetError(null)-on-next-action pattern already existed in every screen's handlers, so that behaviour needed no new code, just verification.Verified:
scripts/local-gates.sh --frontend-only— prettier, oxlint, tsc, vitest (102 tests), production build — all pass.Rebased onto dev to resolve a conflict with #237/GRI-2106 in DevicesScreen.tsx (kept both imports). Pushed as
9f48a718; CI is green again on the new commit (clippy, deny, fmt, test, frontend-web, boundary, pre-push hook). The earlier approval ond1b91e13is now marked stale by the forge since the commit changed — flagging for a fresh look before merge.In dev via PR #241 (verified with fj landed). Closing for the Monday demo.