Panel: error messages can be closed, close by themselves, and clear on the next action #236

Closed
opened 2026-11-15 17:24:22 +00:00 by vivy · 3 comments
Owner

Product owner, from the campus test on 2026-11-15 (GRI-2051): an error message in the panel stays on screen. There is no way to close it, and it stays when he does the next thing (for example, uploading the file again).

What to build

  • Every error message in the panel has a close button (×).
  • An error closes by itself after a time unless the pointer is on it (hover pauses the timer). Suggested: 10 s, a constant in one place.
  • An error closes when the user starts the action again or moves on: a new upload, a new save of the same form, or leaving the screen.
  • The error text stays selectable while it is open, so it can be copied into a bug report.

Done when

  • A test for each of the three ways to close (button, timer, new action), and one that hover stops the timer.
  • Long errors (the PPTX converter errors are several lines) do not cover the controls the user needs to try again.
Product owner, from the campus test on 2026-11-15 (GRI-2051): an error message in the panel stays on screen. There is no way to close it, and it stays when he does the next thing (for example, uploading the file again). ## What to build - Every error message in the panel has a close button (×). - An error closes by itself after a time **unless the pointer is on it** (hover pauses the timer). Suggested: 10 s, a constant in one place. - An error closes when the user starts the action again or moves on: a new upload, a new save of the same form, or leaving the screen. - The error text stays selectable while it is open, so it can be copied into a bug report. ## Done when - A test for each of the three ways to close (button, timer, new action), and one that hover stops the timer. - Long errors (the PPTX converter errors are several lines) do not cover the controls the user needs to try again.
Member

Pull request #241: #241

Added a shared DismissibleError component (close button, 10s self-dismiss timer that pauses on hover, selectable text) and wired it into every transient error note in the panel:

  • MediaScreen (the upload/PPTX-converter case from the campus test), AddUrlForm, DevicesScreen, LoginScreen, SetupScreen/SetupWizard, UsersScreen (add + edit), CampusesTab (actions + add/edit), CampusSettingsScreen, PlaybackSettingsTab, NetworkSettingsTab, IpRulesScreen, PlaylistsScreen, PlaylistDevicesTab, PlaylistMediaTab, PlaylistSettingsTab (save + delete).

Left unchanged, as a different kind of message than the one reported: the full-page "could not load — Retry" states (nothing else on screen to cover), the delete-conflict confirm dialog, AddFromLibraryDialog's live page-range validation, and DashboardScreen's access notice.

Tests: DismissibleError.test.tsx covers the close button, the timer, and hover pausing/resuming it. MediaScreen.test.tsx adds the close-button and "new action clears a stale error" cases at the integration level — the same setError(null)-on-next-action pattern already existed in every screen's handlers, so that behaviour needed no new code, just verification.

Verified: scripts/local-gates.sh --frontend-only — prettier, oxlint, tsc, vitest (102 tests), production build — all pass.

Pull request #241: https://git.grimoirix.org/Grimoirix/grimoire-of-digital-signage/pulls/241 Added a shared `DismissibleError` component (close button, 10s self-dismiss timer that pauses on hover, selectable text) and wired it into every transient error note in the panel: - MediaScreen (the upload/PPTX-converter case from the campus test), AddUrlForm, DevicesScreen, LoginScreen, SetupScreen/SetupWizard, UsersScreen (add + edit), CampusesTab (actions + add/edit), CampusSettingsScreen, PlaybackSettingsTab, NetworkSettingsTab, IpRulesScreen, PlaylistsScreen, PlaylistDevicesTab, PlaylistMediaTab, PlaylistSettingsTab (save + delete). Left unchanged, as a different kind of message than the one reported: the full-page "could not load — Retry" states (nothing else on screen to cover), the delete-conflict confirm dialog, `AddFromLibraryDialog`'s live page-range validation, and `DashboardScreen`'s access notice. Tests: `DismissibleError.test.tsx` covers the close button, the timer, and hover pausing/resuming it. `MediaScreen.test.tsx` adds the close-button and "new action clears a stale error" cases at the integration level — the same `setError(null)`-on-next-action pattern already existed in every screen's handlers, so that behaviour needed no new code, just verification. Verified: `scripts/local-gates.sh --frontend-only` — prettier, oxlint, tsc, vitest (102 tests), production build — all pass.
Member

Rebased onto dev to resolve a conflict with #237/GRI-2106 in DevicesScreen.tsx (kept both imports). Pushed as 9f48a718; CI is green again on the new commit (clippy, deny, fmt, test, frontend-web, boundary, pre-push hook). The earlier approval on d1b91e13 is now marked stale by the forge since the commit changed — flagging for a fresh look before merge.

Rebased onto dev to resolve a conflict with #237/GRI-2106 in DevicesScreen.tsx (kept both imports). Pushed as 9f48a718; CI is green again on the new commit (clippy, deny, fmt, test, frontend-web, boundary, pre-push hook). The earlier approval on d1b91e13 is now marked stale by the forge since the commit changed — flagging for a fresh look before merge.
Author
Owner

In dev via PR #241 (verified with fj landed). Closing for the Monday demo.

In dev via PR #241 (verified with fj landed). Closing for the Monday demo.
vivy closed this issue 2026-11-15 20:55:37 +00:00
Sign in to join this conversation.
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
Grimoirix/grimoire-of-digital-signage#236
No description provided.