GRI-2102: install soffice, gs and ffmpeg on every server path, warn when one is missing #243
No reviewers
Labels
No labels
Area/Backend
Area/Database
Area/Docs
Area/Frontend
Area/Infra
Area/Security
Area/Tests
Area/Tooling
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Lang/Python
Lang/Rust
Lang/Shell
Lang/SQL
Lang/TypeScript
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Routing
Auto
Routing
Hold
Routing
Human
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
Grimoirix/grimoire-of-digital-signage!243
Loading…
Reference in a new issue
No description provided.
Delete branch "fix/GRI-2102-install-converters"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Closes #229.
What was wrong
install.shinstalledpoppler-utilsonly, so on a native server every PowerPoint upload failed with "soffice is not installed".gsandffmpeg, whichpptx_video.rsalso calls, were missing too. Installing the package alone would not have been enough: the systemd unit runs the server as aDynamicUserwithProtectHome=yes, sosofficehas no home to create its profile in and exits 77 ("User installation could not be completed").What changed
SERVER_CONVERTER_PACKAGES="poppler-utils libreoffice-impress ghostscript ffmpeg", installed byserver_native.upgrade serverreruns the same function, so the upgrade path gets them too.--no-install-recommends(headless, no Java).sofficegets its own profile per conversion insidework_dirthrough-env:UserInstallation=file://…(percent-encoded). One per conversion because LibreOffice locks its profile, so two uploads at once would collide.warning:line per converter it cannot find (ffmpegonly while MP4 is enabled), naming the path it looked for and what stops working.local-gates.shand CI.Evidence
HOMEnot writable: without the argumentsofficeexits 77. With it, and also with a path containing a space (render%20dir), it exits 0 and writes the PDF.dev../scripts/local-gates.sh --rust-onlyon05c0e69: exit 0, every gate passed. The front end is untouched.The design is right (one package list, a profile per conversion, the start-up warning). CI cargo test is red because of the branch itself:
crates/server/tests/pptx_video_acceptance_integration.rs:222 still has the old fake soffice,
echo fake-pdf > "$5/input.pdf". The new -env:UserInstallation argument is now $1, so $5 is the literal '--outdir' and three tests fail with 'cannot create --outdir/input.pdf'. Same fix as in the unit test: shift to --outdir and use $2.Those tests are Postgres integration tests, so a local --rust-only run with no database (or --skip-db) skips them. Please run local-gates.sh with the database before you push again.
4633fd8fixes it: the integration fake soffice now finds --outdir by flag, not by position, so the -env:UserInstallation argument can move freely. The rest since my review is the dev merge. CI green on69462aa8, including cargo test with Postgres. Approved.Approval stands, but this branch now conflicts with
dev(after #234 and #246 landed) in two files:.github/workflows/ci.ymlscripts/local-gates.shBoth are gate files, so I will not resolve them on the forge. Please
agit merge origin/devin your working tree, keep both sides (your converter install steps and whatdevadded), run./scripts/local-gates.sh, and push. I merge on a greenfj ci 243.My approval on
69462aastands for the content. The branch now conflicts with dev in .github/workflows/ci.yml and scripts/local-gates.sh (both got new gate steps on dev, from the client kiosk test). Merge origin/dev, keep both the converter test and the kiosk test steps, run the gates, push. I will re-approve the new head.New commits pushed, approval review dismissed automatically according to repository settings