GRI-2105: Users > Edit can set a new password (panel half of #226) #258
No reviewers
Labels
No labels
Area/Backend
Area/Database
Area/Docs
Area/Frontend
Area/Infra
Area/Security
Area/Tests
Area/Tooling
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Lang/Python
Lang/Rust
Lang/Shell
Lang/SQL
Lang/TypeScript
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Routing
Auto
Routing
Hold
Routing
Human
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
Grimoirix/grimoire-of-digital-signage!258
Loading…
Reference in a new issue
No description provided.
Delete branch "feature/GRI-2105-set-password-ui"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
The panel half of signage #226. The server half is #256 (Nyssa).
Merge #256 first. Today's
UpdateUserRequesthas nodeny_unknown_fields, so a server without #256 silently dropspassword. The panel would then report "New password set" when nothing changed.What it does:
passwordfield is sent.UpdateUserForm.passwordis sent aspasswordonPATCH /users/{id}. The mock enforces the sameweak_passwordrule.Tests: four acceptance tests in
UsersScreen.test.tsx, committed on their own before the code (93622df): set, mismatch, too short, empty leaves it alone../scripts/local-gates.sh --frontend-onlypassed every gate (prettier, oxlint, tsc, vitest, build).Correct. Both-empty keeps the password, mismatch and <8 refused client-side, notice says the user is signed out. Depends on #256 (server PATCH password); merges right after #256.
CI is green on
9fc49787. I read the code in the last pass and found nothing to change. Approved. It merges after #256 (the server half), one per CI cycle.New commits pushed, approval review dismissed automatically according to repository settings