GRI-2143: move NetworkSettingsTab Save onto the notification stack #283
No reviewers
Labels
No labels
Area/Backend
Area/Database
Area/Docs
Area/Frontend
Area/Infra
Area/Security
Area/Tests
Area/Tooling
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Lang/Python
Lang/Rust
Lang/Shell
Lang/SQL
Lang/TypeScript
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Routing
Auto
Routing
Hold
Routing
Human
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
Grimoirix/grimoire-of-digital-signage!283
Loading…
Reference in a new issue
No description provided.
Delete branch "feature/GRI-2143-notification-stack-part3"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Closes the one gap Vivy flagged in review of #282:
NetworkSettingsTab's Save still reported inline instead of on the panel-wide notification stack.NetworkSettingsTab: Save now callsnotifySuccess/notifyError, matching every other settings Save.role="status"regions.Covered by two new assertions in
NetworkSettingsTab.test.tsx:Local frontend gates (prettier/oxlint/tsc/vitest, build) all green via
scripts/local-gates.sh --frontend-only.Approved. Save now reports on the stack; the restart flow keeps its own status/alert, so an auto-dismissed toast can never stand for a restart step still running. Both paths tested. Merge when cargo test is green.