GRI-2143: move NetworkSettingsTab Save onto the notification stack #283

Merged
vivy merged 1 commit from feature/GRI-2143-notification-stack-part3 into dev 2026-11-16 12:14:51 +00:00
Member

Closes the one gap Vivy flagged in review of #282: NetworkSettingsTab's Save still reported inline instead of on the panel-wide notification stack.

  • NetworkSettingsTab: Save now calls notifySuccess/notifyError, matching every other settings Save.
  • The restart flow (restart → wait for the server → re-point the browser, or fail) keeps its own inline status/error pair, separate from the stack. It's a multi-step sequence, and a toast that auto-dismisses mid-restart would misreport a step that's still running as finished — so this is the "give the restart its own status element" option from Vivy's review, rather than splitting the test to tolerate two concurrent role="status" regions.

Covered by two new assertions in NetworkSettingsTab.test.tsx:

  • the save notice shows up on the notification stack (and not on the restart's own element) before the restart flow starts;
  • a failed restart reports on its own dismissible alert, not the stack, and leaves "Restart now" usable again.

Local frontend gates (prettier/oxlint/tsc/vitest, build) all green via scripts/local-gates.sh --frontend-only.

Closes the one gap Vivy flagged in review of #282: `NetworkSettingsTab`'s Save still reported inline instead of on the panel-wide notification stack. - `NetworkSettingsTab`: Save now calls `notifySuccess`/`notifyError`, matching every other settings Save. - The restart flow (restart → wait for the server → re-point the browser, or fail) keeps its own inline status/error pair, separate from the stack. It's a multi-step sequence, and a toast that auto-dismisses mid-restart would misreport a step that's still running as finished — so this is the "give the restart its own status element" option from Vivy's review, rather than splitting the test to tolerate two concurrent `role="status"` regions. Covered by two new assertions in `NetworkSettingsTab.test.tsx`: - the save notice shows up on the notification stack (and not on the restart's own element) before the restart flow starts; - a failed restart reports on its own dismissible alert, not the stack, and leaves "Restart now" usable again. Local frontend gates (prettier/oxlint/tsc/vitest, build) all green via `scripts/local-gates.sh --frontend-only`.
GRI-2143: move NetworkSettingsTab Save onto the notification stack
All checks were successful
CI / the pre-push hook (pull_request) Successful in 4s
CI / cargo fmt (pull_request) Successful in 3s
CI / install.sh client upgrade (pull_request) Successful in 12s
CI / cargo deny (pull_request) Successful in 13s
CI / cargo deny advisories (pull_request) Successful in 19s
CI / cargo clippy (pull_request) Successful in 1m0s
CI / repository boundary (pull_request) Successful in 3s
CI / frontend-web (pull_request) Successful in 56s
CI / cargo test (pull_request) Successful in 3m25s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 1s
aa33cb8deb
Restart keeps its own status/error element, separate from the stack: a
multi-step flow that a toast's auto-dismiss could misreport as finished
while a later step is still running.
vivy approved these changes 2026-11-16 11:59:30 +00:00
vivy left a comment

Approved. Save now reports on the stack; the restart flow keeps its own status/alert, so an auto-dismissed toast can never stand for a restart step still running. Both paths tested. Merge when cargo test is green.

Approved. Save now reports on the stack; the restart flow keeps its own status/alert, so an auto-dismissed toast can never stand for a restart step still running. Both paths tested. Merge when cargo test is green.
vivy merged commit a61eed0849 into dev 2026-11-16 12:14:51 +00:00
vivy deleted branch feature/GRI-2143-notification-stack-part3 2026-11-16 12:14:51 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
Grimoirix/grimoire-of-digital-signage!283
No description provided.