GRI-2156: acceptance test for in-slide object animations (forge #197) #291
No reviewers
Labels
No labels
Area/Backend
Area/Database
Area/Docs
Area/Frontend
Area/Infra
Area/Security
Area/Tests
Area/Tooling
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Lang/Python
Lang/Rust
Lang/Shell
Lang/SQL
Lang/TypeScript
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Routing
Auto
Routing
Hold
Routing
Human
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
Grimoirix/grimoire-of-digital-signage!291
Loading…
Reference in a new issue
No description provided.
Delete branch "test/GRI-2156-pptx-object-animations"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
Acceptance test, before implementation, for forge #197 (GRI-2156): the "done
when" criterion that a deck with an entrance, an emphasis and a motion path
must play those build steps on the screen, not only the slide's final state.
crates/server/tests/fixtures/animated-deck.pptx: a one-slidedeck built with
python-pptx, with a realp:timingtree injected intothe slide XML afterwards (entrance "Appear", emphasis colour change,
motion path), since
python-pptxitself cannot author animations.pptx_video::tests::a_deck_with_object_animations_shows_its_build_steps_over_time(
#[ignore]d, real tools, same convention as the existingthe_sample_deck_renders_with_the_real_soffice_and_pdftoppm): renders thefixture with the real
render_fallback_pages+join_slides_into_mp4,then pulls two frames out of the joined MP4 at different points in the
one slide's dwell time and asserts they differ.
This fails today:
render_fallback_pagesrenders exactly one PNG per slide(the slide's final design state, animations or not — see this module's own
doc comment, "What this cannot do"), and for a single slide
build_filter_complexis[v0]copy[outv], so the two sampled frames comeout byte-identical regardless of the deck's animations.
Ran on this build host with a locally-extracted
pdftoppm(poppler-utils isnot installed on this particular sandbox, though
install.shputs it onevery real deployment target):
./scripts/local-gates.sh --rust-onlypasses clean on this branch (fmt,clippy, the full
cargo testincluding the real-DB acceptance suites andpptx_video_acceptance_integration.rs,cargo test --doc,cargo deny).The new test does not run under that gate — it is
#[ignore]d like itssibling, needing real
soffice/pdftoppm/ffmpegonPATH.Criterion mapping
screen" →
a_deck_with_object_animations_shows_its_build_steps_over_time.Not covered by this PR — a contract gap for GRI-2133/Nyssa
The ticket's second criterion — "the #189 upload note is not shown for a
fully supported deck, and is still shown for a deck with unsupported
effects" — has no existing interface to test against. There is no "note"
or "warning" field anywhere in the server's media API or the frontend
upload flow today (
#189's own scope never added one; it was proposed onlyfor the SVG-slideshow option that was not chosen). Writing a test for it
means picking where that note surfaces (a new media-item field? a response
on upload? a job-result field?), which is an interface decision, not a test
case. Flagging this on GRI-2156 and GRI-2133 rather than guessing a shape.
Test plan
cargo test -p server --lib "pptx_video::tests::a_deck_with_object_animations_shows_its_build_steps_over_time" -- --ignored --exactfails against unimplemented code (output above)./scripts/local-gates.sh --rust-onlypasses on this branchcargo fmt -p server -- --checkclean