GRI-2148: playlist Settings control for the default-playtime override #292
No reviewers
Labels
No labels
Area/Backend
Area/Database
Area/Docs
Area/Frontend
Area/Infra
Area/Security
Area/Tests
Area/Tooling
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Lang/Python
Lang/Rust
Lang/Shell
Lang/SQL
Lang/TypeScript
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Routing
Auto
Routing
Hold
Routing
Human
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
Grimoirix/grimoire-of-digital-signage!292
Loading…
Reference in a new issue
No description provided.
Delete branch "fix/GRI-2148-playlist-inherit-control"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
The playlist Settings tab had no way to see or change a playlist's own
default-playtime override — item 1 from the follow-up list on forge #277
(GRI-2147's merged PR #281 left the server contract and the create-time
bug fixed, but no control).
PlaylistSettingsTab: a "Default playtime" field. Inheriting shows"Default (N s, from <campus / All campuses>)" with an "Override with a
custom value…" button; overriding shows the seconds field with "Save
default playtime" and "Use the default (...)" (clears to inherit) and,
while already overriding, a Cancel back to the read view.
PATCH /playlists/{id}already supporteddefault_duration_secondsasa double-option (nyssa's work on #281) — added the one missing client
call,
updatePlaylistDefaultDuration, to both the HTTP and mock API.Test plan
./scripts/local-gates.sh --frontend-only— prettier, oxlint, tsc,vitest (184/184), build all green.
switching to an override and back to inherit both work end to end
against the mock API.
A playlist created or reset to inherit shows 'Default (N s, from <campus or All campuses>)' with an 'Override with a custom value…' button; one with its own value shows the field and a 'Use the default (...)' button back to inherit — PATCH /playlists/{id} with null (signage #277, item 1).CI on
a6131478failed cargo test: pdf::tests::refuses_a_pdf_that_produces_no_pages panicked (assertion failed: matches!(error, PdfError::NoPages)). This PR touches only frontend-web files (httpPlaylistsApi.ts, mockPlaylistsApi.ts, playlistsApi.ts, PlaylistsScreen.test.tsx, PlaylistSettingsTab.tsx) — no backend/pdf.rs changes. Reproduced locally: the test passes in isolation and the fullcargo test -p server --libsuite passed clean 3/3 times with no failures. This reads as a load-related CI flake, not a regression from this change. Pushed an empty commit (a1bbfe0) to re-trigger CI.