GRI-2148: playlist Settings control for the default-playtime override #292

Merged
vivy merged 2 commits from fix/GRI-2148-playlist-inherit-control into dev 2026-11-16 19:09:18 +00:00
Member

Summary

The playlist Settings tab had no way to see or change a playlist's own
default-playtime override — item 1 from the follow-up list on forge #277
(GRI-2147's merged PR #281 left the server contract and the create-time
bug fixed, but no control).

  • PlaylistSettingsTab: a "Default playtime" field. Inheriting shows
    "Default (N s, from <campus / All campuses>)" with an "Override with a
    custom value…" button; overriding shows the seconds field with "Save
    default playtime" and "Use the default (...)" (clears to inherit) and,
    while already overriding, a Cancel back to the read view.
  • PATCH /playlists/{id} already supported default_duration_seconds as
    a double-option (nyssa's work on #281) — added the one missing client
    call, updatePlaylistDefaultDuration, to both the HTTP and mock API.

Test plan

  • ./scripts/local-gates.sh --frontend-only — prettier, oxlint, tsc,
    vitest (184/184), build all green.
  • New test: a playlist with no override shows the inherited value,
    switching to an override and back to inherit both work end to end
    against the mock API.
## Summary The playlist Settings tab had no way to see or change a playlist's own default-playtime override — item 1 from the follow-up list on forge #277 (GRI-2147's merged PR #281 left the server contract and the create-time bug fixed, but no control). - `PlaylistSettingsTab`: a "Default playtime" field. Inheriting shows "Default (N s, from <campus / All campuses>)" with an "Override with a custom value…" button; overriding shows the seconds field with "Save default playtime" and "Use the default (...)" (clears to inherit) and, while already overriding, a Cancel back to the read view. - `PATCH /playlists/{id}` already supported `default_duration_seconds` as a double-option (nyssa's work on #281) — added the one missing client call, `updatePlaylistDefaultDuration`, to both the HTTP and mock API. ## Test plan - [x] `./scripts/local-gates.sh --frontend-only` — prettier, oxlint, tsc, vitest (184/184), build all green. - [x] New test: a playlist with no override shows the inherited value, switching to an override and back to inherit both work end to end against the mock API.
GRI-2148: playlist Settings control to show or clear its default-playtime override
Some checks failed
CI / the pre-push hook (pull_request) Successful in 3s
CI / cargo fmt (pull_request) Successful in 3s
CI / install.sh client upgrade (pull_request) Successful in 12s
CI / cargo deny (pull_request) Successful in 16s
CI / cargo deny advisories (pull_request) Successful in 20s
CI / repository boundary (pull_request) Successful in 6s
CI / cargo clippy (pull_request) Successful in 1m7s
CI / frontend-web (pull_request) Successful in 1m2s
CI / cargo test (pull_request) Failing after 2m16s
CI / CI (pull_request) Failing after 1s
CI / Notify gate failed (pull_request) Successful in 1s
a6131478f4
A playlist created or reset to inherit shows 'Default (N s, from <campus or
All campuses>)' with an 'Override with a custom value…' button; one with
its own value shows the field and a 'Use the default (...)' button back to
inherit — PATCH /playlists/{id} with null (signage #277, item 1).
GRI-2148: re-trigger CI (cargo test flaked on refuses_a_pdf_that_produces_no_pages, unrelated to this frontend-only change)
All checks were successful
CI / the pre-push hook (pull_request) Successful in 4s
CI / cargo fmt (pull_request) Successful in 3s
CI / install.sh client upgrade (pull_request) Successful in 12s
CI / cargo deny (pull_request) Successful in 24s
CI / cargo deny advisories (pull_request) Successful in 22s
CI / repository boundary (pull_request) Successful in 5s
CI / cargo clippy (pull_request) Successful in 1m8s
CI / frontend-web (pull_request) Successful in 58s
CI / cargo test (pull_request) Successful in 3m27s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 1s
a1bbfe00d2
Author
Member

CI on a6131478 failed cargo test: pdf::tests::refuses_a_pdf_that_produces_no_pages panicked (assertion failed: matches!(error, PdfError::NoPages)). This PR touches only frontend-web files (httpPlaylistsApi.ts, mockPlaylistsApi.ts, playlistsApi.ts, PlaylistsScreen.test.tsx, PlaylistSettingsTab.tsx) — no backend/pdf.rs changes. Reproduced locally: the test passes in isolation and the full cargo test -p server --lib suite passed clean 3/3 times with no failures. This reads as a load-related CI flake, not a regression from this change. Pushed an empty commit (a1bbfe0) to re-trigger CI.

CI on a6131478 failed cargo test: pdf::tests::refuses_a_pdf_that_produces_no_pages panicked (assertion failed: matches!(error, PdfError::NoPages)). This PR touches only frontend-web files (httpPlaylistsApi.ts, mockPlaylistsApi.ts, playlistsApi.ts, PlaylistsScreen.test.tsx, PlaylistSettingsTab.tsx) — no backend/pdf.rs changes. Reproduced locally: the test passes in isolation and the full `cargo test -p server --lib` suite passed clean 3/3 times with no failures. This reads as a load-related CI flake, not a regression from this change. Pushed an empty commit (a1bbfe0) to re-trigger CI.
vivy merged commit c623280d22 into dev 2026-11-16 19:09:18 +00:00
vivy deleted branch fix/GRI-2148-playlist-inherit-control 2026-11-16 19:09:18 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
Grimoirix/grimoire-of-digital-signage!292
No description provided.