Picker: Add N pages makes one document item with page overrides (frontend half of #304) #314
Labels
No labels
Area/Backend
Area/Database
Area/Docs
Area/Frontend
Area/Infra
Area/Security
Area/Tests
Area/Tooling
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Lang/Python
Lang/Rust
Lang/Shell
Lang/SQL
Lang/TypeScript
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Routing
Auto
Routing
Hold
Routing
Human
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
Grimoirix/grimoire-of-digital-signage#314
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Frontend half of #304. The backend half is PR #312 (green, held for this).
Why it must land with #312. After #312,
PUT /playlists/{id}/itemsrefuseskind: "document_page"with 422document_page_not_allowed, and migration 0014 converts existing page items into onedocumentitem withpage_overrides. The web UI still creates and sendsdocument_pageitems:frontend-web/src/api/httpPlaylistsApi.ts:201builds adocument_pagewire item.AddFromLibraryDialog/libraryPicker.ts: Choose pages / Add N pages adds one playlist item per page.So with #312 alone, saving a playlist after "Add N pages" fails.
Change.
1-5,8-9) adds onedocumentitem (document media id) withpage_overrides={"<page>": {"skip": true}}for every page not chosen. Add whole document is unchanged.httpPlaylistsApi.ts: never senddocument_page; drop that branch.documentitems withpage_overrides; check the playlist view shows them (works with #278).AddFromLibraryDialog.test.tsxthat expect N items.Done when: adding pages 1-5,8-9 of a deck makes one item, saves without error, and
frontend-webgates pass. Merge order: this PR and #312 back to back.PR #316 CI is green (commit
5290ac08): CI aggregate verdict passed — cargo clippy/fmt/test/deny, frontend-web, repository boundary, pre-push hook all succeeded (the one red row, "Notify gate failed", is a notification-only job, not a gate). PR is open and mergeable, not yet merged. Ready for the merge order: this PR first, then #312 (since #312 makes the server refusedocument_pageitems).Frontend half done and merged: PR #316 landed in dev at commit
13517fef(verified by ancestry). Closing this issue since the frontend scope is complete; backend half tracked separately in #312, which is behind dev and owes a re-review after REQUEST_CHANGES #541.