GRI-2215: fix curl fallback and hostname update on reconnect #330
No reviewers
Labels
No labels
Area/Backend
Area/Database
Area/Docs
Area/Frontend
Area/Infra
Area/Security
Area/Tests
Area/Tooling
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Lang/Python
Lang/Rust
Lang/Shell
Lang/SQL
Lang/TypeScript
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Routing
Auto
Routing
Hold
Routing
Human
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
Grimoirix/grimoire-of-digital-signage!330
Loading…
Reference in a new issue
No description provided.
Delete branch "fix/GRI-2215-curl-fallback-and-hostname-update"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
Fixes grimoire-of-digital-signage#325: two fresh-install defects found on a Dell OptiPlex 3060 running Ubuntu Desktop 26.04.1 (GRI-2051).
curl. Ubuntu Desktop 26.04 shipswget, notcurl. The three bootstrap one-liners (server install, client install, download-first fallback) now usewget -qO-/wget -qO. The remaining internalcurluses ininstall.sh(rustup, Node download, health check) run afterfetch_sourcehas alreadyapt-get installedcurl, so they are unaffected.Registrationframe on everyAcceptedhello (not only whilePending), and the server applies it via a newdevices::update_reported_infothat updateshostname/reported_infowithout touching the admin-setname. Documented inplan/shared/protocol.mdandplan/server/enrolment.md.A pre-existing client test (
sync_survives_restart.rs) needed itsreceive()helper's handling of the new unconditional post-AcceptedRegistrationecho fixed: an earlier attempt filtered everyRegistrationframe out ofreceive(), which deadlocked thea_pending_device_registers_and_reconnects_with_its_temporary_idtest (it explicitly expects to receive that frame). Fixed by revertingreceive()to filter only heartbeats, and draining the post-Acceptedecho explicitly at each call site that triggers it.Test plan
cargo fmt --checkcargo clippy -p client -p server --all-targets -- -D warningscargo test -p client(103 tests, including the fixedsync_survives_restartsuite)cargo test -p server --test ws_integration(17/17, includinga_reconnect_with_a_changed_hostname_updates_it_but_not_the_panel_name)