GRI-1856: media acceptance tests (AC-3-01..AC-3-07) #100
No reviewers
Labels
No labels
Area/Backend
Area/Database
Area/Docs
Area/Frontend
Area/Infra
Area/Security
Area/Tests
Area/Tooling
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Lang/Python
Lang/Rust
Lang/Shell
Lang/SQL
Lang/TypeScript
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Routing
Auto
Routing
Hold
Routing
Human
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
Grimoirix/grimoire-of-digital-signage!100
Loading…
Reference in a new issue
No description provided.
Delete branch "test/GRI-1856-media-acceptance-tests"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Independent acceptance tests for
plan/tests/mvp-acceptance.mdsection 3 ("Media"), AC-3-01 through AC-3-07, derived from the spec table andplan/server/rest-api.md/plan/server/media-pipeline.md— not from readingcrates/server/tests/media_integration.rs(the implementer-authored test file that merged with the feature in PR #95, flagged separately on GRI-1856).New file
crates/server/tests/media_acceptance_integration.rs, reusing the real-TCP harness (tests/support::TestServer) from PR #92/#96. Addedsupport::send_bytessince multipart file bodies are not valid UTF-8 and the existingsupport::sendonly takes&str.Criterion-to-test mapping
ac_3_01_uploading_an_image_stores_it_with_a_checksum_and_lists_one_image_itemac_3_02_uploading_a_video_stores_the_original_with_its_checksumac_3_03_uploading_a_multi_page_pdf_creates_one_document_page_item_per_page(#[ignore]d, see below)ac_3_04_adding_a_url_creates_a_url_item_with_no_stored_fileac_3_05_an_upload_with_no_file_is_rejected_and_creates_no_itemac_3_06_a_corrupt_pdf_fails_cleanly_and_creates_no_itemac_3_07_an_unauthenticated_upload_is_refused_and_stores_nothingFail-first, run against
devas mergedThe other 6 pass for real against the real routes.
Findings (not blocking this PR)
#[ignore]d with that reason.POST /mediarefuses every PDF outright (pdf_not_yet_supportedincrates/server/src/media/handlers.rs). The page converter is GRI-1868 / signage #15a (forge PR #97, open with a merge conflict as of 2026-11-10); wiring it in is tracked separately as signage #15b per the handler's own comment. Un-ignore once both land.upload_mediastores a video row synchronously and returns 201 immediately — classified, checksummed, listed — exactly like an image. There is no job id, status or progress field anywhere inMediaView. This is a contract gap, not a missing test: nothing in the REST or WebSocket surface documents what a client would read to show progress. I wrote the test for the part that is implemented (original stored with its checksum) and left the job/progress half out rather than encode an assertion against a field that doesn't exist. Flagging for the CTO to decide whether this needs a design addition before the MVP test week, or is deliberately deferred.Repeating from my earlier comment on GRI-1856, for visibility here too:
media_integration.rs(PR #95) was written by the feature's own implementer rather than independently from the spec, which is the separation this role exists to keep. This PR is the independent version, mapped to the acceptance-criteria IDs the implementer's tests don't use.