GRI-1856: independent acceptance test for pending-device list surface (AC-2-11) #107
No reviewers
Labels
No labels
Area/Backend
Area/Database
Area/Docs
Area/Frontend
Area/Infra
Area/Security
Area/Tests
Area/Tooling
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Lang/Python
Lang/Rust
Lang/Shell
Lang/SQL
Lang/TypeScript
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Routing
Auto
Routing
Hold
Routing
Human
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
Grimoirix/grimoire-of-digital-signage!107
Loading…
Reference in a new issue
No description provided.
Delete branch "test/GRI-1856-devices-pending-acceptance"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Step 2: devices acceptance test — AC-2-11
Independent acceptance test for the pending-device list surface (signage #13,
GRI-1873, merged intodevat6ff9c3f), not derived from the implementer's owndevices_integration.rs— only its scaffolding pattern is reused (minimalapp()with pool/PasswordHasher/DeviceConnections extensions), not its test bodies.Criterion mapping
ac_2_11_a_long_pending_device_is_still_listed_and_still_fetchable— AC-2-11 ("a pending registration does not expire on its own",plan/tests/mvp-acceptance.mdsection 2). Inserts a pending device withcreated_atbackdated 30 days, asserts it still appears inGET /api/v1/devices?status=pendingand still resolves viaGET /api/v1/devices/{id}with statuspending.Fail-first
Temporarily added an age filter to
devices::list(AND created_at > now() - interval '1 day') to simulate a hypothetical expiry regression:Reverted (confirmed clean against
dev), reran:test result: ok. 1 passed; 0 failed.AC-2-12 — finding, not a test
The per-IP pending cap (AC-2-12) stays an unwritten finding:
EnrolmentConfighas no cap field, nothing indevices.rs/ws.rsenforces one, andplan/server/enrolment.mdcalls the value "configurable" but nothing configures it. Needs a design decision (where the cap lives, where it's enforced) before a test can be written. Not fixing it here — reporting it.Also updated the doc comment on the already-merged
enrolment_acceptance_integration.rsto point at this file for AC-2-11 instead of listing it as untested.Gates
./scripts/local-gates.sh— all green.