GRI-1856: correct AC-3-03 ignore reason to missing poppler-utils #108

Merged
vivy merged 1 commit from test/GRI-1856-pdf-page-acceptance into dev 2026-11-10 06:36:28 +00:00
Member

What

AC-3-03 (multi-page PDF → one DocumentPage item per page) in
crates/server/tests/media_acceptance_integration.rs was #[ignore]d with a
reason that is now stale: PDF upload was wired into POST /media by
GRI-1877 / signage #15b, which landed on dev since this test was written.

Un-ignoring the test and running it against the merged code shows it still
can't run — but for a different, non-code reason:

POST /media returns 400 invalid_pdf ("pdftoppm is not installed")

poppler-utils (pdftoppm) is not on this build host or in the CI image.
This is the exact gap the implementer already hit and ignored their own unit
test for (crates/server/src/pdf.rs, #[ignore = "needs poppler-utils (pdftoppm)"]). Production's packaging/server/Dockerfile already installs
it, so this is a CI/build-host image gap, not a code bug or a design
question — nothing for the back-end engineer to fix.

Re-ignored the test with the corrected reason so the acceptance-test plan
stays honest about why AC-3-03 isn't running. No logic change to the test
itself — only the #[ignore] reason string and its doc comment.

Criterion mapping

  • ac_3_03_uploading_a_multi_page_pdf_creates_one_document_page_item_per_page → AC-3-03 (still #[ignore]d, reason updated)

Verification

$ SIGNAGE_TEST_DATABASE_URL=postgres://postgres:postgres@localhost:5432/postgres?sslmode=disable \
  cargo test -p server --test media_acceptance_integration ac_3_03 -- --ignored --test-threads=1
running 1 test
test ac_3_03_uploading_a_multi_page_pdf_creates_one_document_page_item_per_page ... FAILED
thread '...' panicked: POST /media for a PDF returned 400, body: {"error":"invalid_pdf","message":"pdftoppm is not installed"}
test result: FAILED. 0 passed; 1 failed

Confirmed pdftoppm is not on PATH on this host and .github/workflows/ci.yml
has no apt-get install for it.

Un-ignore once poppler-utils is on the CI/build-host image.

./scripts/local-gates.sh passed in full.

## What `AC-3-03` (multi-page PDF → one `DocumentPage` item per page) in `crates/server/tests/media_acceptance_integration.rs` was `#[ignore]`d with a reason that is now stale: PDF upload was wired into `POST /media` by GRI-1877 / signage #15b, which landed on `dev` since this test was written. Un-ignoring the test and running it against the merged code shows it still can't run — but for a different, non-code reason: ``` POST /media returns 400 invalid_pdf ("pdftoppm is not installed") ``` `poppler-utils` (`pdftoppm`) is not on this build host or in the CI image. This is the exact gap the implementer already hit and ignored their own unit test for (`crates/server/src/pdf.rs`, `#[ignore = "needs poppler-utils (pdftoppm)"]`). Production's `packaging/server/Dockerfile` already installs it, so this is a CI/build-host image gap, not a code bug or a design question — nothing for the back-end engineer to fix. Re-ignored the test with the corrected reason so the acceptance-test plan stays honest about why AC-3-03 isn't running. No logic change to the test itself — only the `#[ignore]` reason string and its doc comment. ## Criterion mapping - `ac_3_03_uploading_a_multi_page_pdf_creates_one_document_page_item_per_page` → AC-3-03 (still `#[ignore]`d, reason updated) ## Verification ``` $ SIGNAGE_TEST_DATABASE_URL=postgres://postgres:postgres@localhost:5432/postgres?sslmode=disable \ cargo test -p server --test media_acceptance_integration ac_3_03 -- --ignored --test-threads=1 running 1 test test ac_3_03_uploading_a_multi_page_pdf_creates_one_document_page_item_per_page ... FAILED thread '...' panicked: POST /media for a PDF returned 400, body: {"error":"invalid_pdf","message":"pdftoppm is not installed"} test result: FAILED. 0 passed; 1 failed ``` Confirmed `pdftoppm` is not on `PATH` on this host and `.github/workflows/ci.yml` has no `apt-get install` for it. Un-ignore once `poppler-utils` is on the CI/build-host image. `./scripts/local-gates.sh` passed in full.
GRI-1856: correct AC-3-03 ignore reason to missing poppler-utils
Some checks failed
CI / the pre-push hook (pull_request) Successful in 5s
CI / cargo fmt (pull_request) Successful in 7s
CI / cargo deny (pull_request) Successful in 48s
CI / cargo deny advisories (pull_request) Failing after 53s
CI / repository boundary (pull_request) Successful in 5s
CI / cargo clippy (pull_request) Successful in 10m1s
CI / cargo test (pull_request) Successful in 11m5s
CI / frontend-web (pull_request) Successful in 9m50s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 3s
e1e75d2e04
PDF upload is now wired to the page converter (GRI-1877/signage #15b landed).
The test still can't run, but for a different reason: pdftoppm (poppler-utils)
isn't on this host/CI image, so render_pages fails before the page-splitting
logic under test ever runs. Production's Dockerfile already installs it.
vivy merged commit e7c82bd755 into dev 2026-11-10 06:36:28 +00:00
vivy deleted branch test/GRI-1856-pdf-page-acceptance 2026-11-10 06:36:29 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
Grimoirix/grimoire-of-digital-signage!108
No description provided.