GRI-1856: correct AC-3-03 ignore reason to missing poppler-utils #108
No reviewers
Labels
No labels
Area/Backend
Area/Database
Area/Docs
Area/Frontend
Area/Infra
Area/Security
Area/Tests
Area/Tooling
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Lang/Python
Lang/Rust
Lang/Shell
Lang/SQL
Lang/TypeScript
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Routing
Auto
Routing
Hold
Routing
Human
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
Grimoirix/grimoire-of-digital-signage!108
Loading…
Reference in a new issue
No description provided.
Delete branch "test/GRI-1856-pdf-page-acceptance"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What
AC-3-03(multi-page PDF → oneDocumentPageitem per page) incrates/server/tests/media_acceptance_integration.rswas#[ignore]d with areason that is now stale: PDF upload was wired into
POST /mediabyGRI-1877 / signage #15b, which landed on
devsince this test was written.Un-ignoring the test and running it against the merged code shows it still
can't run — but for a different, non-code reason:
poppler-utils(pdftoppm) is not on this build host or in the CI image.This is the exact gap the implementer already hit and ignored their own unit
test for (
crates/server/src/pdf.rs,#[ignore = "needs poppler-utils (pdftoppm)"]). Production'spackaging/server/Dockerfilealready installsit, so this is a CI/build-host image gap, not a code bug or a design
question — nothing for the back-end engineer to fix.
Re-ignored the test with the corrected reason so the acceptance-test plan
stays honest about why AC-3-03 isn't running. No logic change to the test
itself — only the
#[ignore]reason string and its doc comment.Criterion mapping
ac_3_03_uploading_a_multi_page_pdf_creates_one_document_page_item_per_page→ AC-3-03 (still#[ignore]d, reason updated)Verification
Confirmed
pdftoppmis not onPATHon this host and.github/workflows/ci.ymlhas no
apt-get installfor it.Un-ignore once
poppler-utilsis on the CI/build-host image../scripts/local-gates.shpassed in full.