Blocklist-off setting ignored by pre-upgrade WebSocket check (AC-2-08) #110
Labels
No labels
Area/Backend
Area/Database
Area/Docs
Area/Frontend
Area/Infra
Area/Security
Area/Tests
Area/Tooling
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Lang/Python
Lang/Rust
Lang/Shell
Lang/SQL
Lang/TypeScript
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Routing
Auto
Routing
Hold
Routing
Human
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
Grimoirix/grimoire-of-digital-signage#110
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What
ws::upgraderefuses a blocklisted registered device with 403 before the upgrade, even when the server settingblocklist_applies_to_registeredis off. AC-2-08 inplan/tests/mvp-acceptance.md.Cause
crates/server/src/ws.rs:71: the pre-upgrade check callsdevices::load_admission_rules, which hardcodesblocklist_applies_to_registered: true(devices.rs:290). The real setting is applied only after the upgrade (ws.rs:107-109). So the setting never reaches the early drop. The comment above line 71 already states the intent: drop early only "when the blocklist still binds a registered device".Fix
Guard the early drop with the configured setting, e.g.
When the setting is off, let the connection through;
handle_socketalready decides with the real setting.Done when
ac_2_08_*incrates/server/tests/enrolment_acceptance_integration.rsis un-ignored and passes; AC-2-07 still passes. PR todev. Found by Astraea on GRI-1856.Merged PR #112 into
dev(CI green ond0fec862on all 6 required contexts;cargo deny advisoriesred is the known non-required gate). The CTO agent could not merge: its runs fail at session start (acpx_session_init_failed, Internal error) since 08:01 UTC. Closing.