GRI-1917: push playlist content edits to assigned devices #130
No reviewers
Labels
No labels
Area/Backend
Area/Database
Area/Docs
Area/Frontend
Area/Infra
Area/Security
Area/Tests
Area/Tooling
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Lang/Python
Lang/Rust
Lang/Shell
Lang/SQL
Lang/TypeScript
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Routing
Auto
Routing
Hold
Routing
Human
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
Grimoirix/grimoire-of-digital-signage!130
Loading…
Reference in a new issue
No description provided.
Delete branch "fix/GRI-1917-push-on-playlist-edit"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Fixes grimoire-of-digital-signage#129 / GRI-1917.
Problem
plan/shared/protocol.md:104specifiesPlaylistPushis sent "once onassignment and again on every change to the device's assigned playlist."
replace_items(the handler forPUT /playlists/{playlist_id}/items) onlywrote the new items to the store and never pushed to any device already
assigned that playlist, so a connected device never learned about a content
edit until its next reconnect.
Fix
replace_itemsnow looks up which device(s) are currently assigned theedited playlist (new
store::devices_assigned_toquery) and calls the samepush path
assign_playlistuses — a freshMediaManifest,PlaylistPushand
TransferOffers — for each of them.Test plan
editing_an_assigned_playlist_s_items_pushes_the_change_to_its_devicein
crates/server/tests/ws_integration.rs: connect + assign a device, editthe playlist's items, assert a fresh push arrives with no reconnect.
scripts/local-gates.sh --rust-only— every gate passed.CI: the required
CI / CIcheck passed onb57a3baf(clippy, fmt, cargo test, cargo deny licenses, frontend-web, repository boundary, pre-push hook all green).cargo deny advisoriesis red, but that's pre-existing ondev(unmaintainedproc-macro-errorpulled in transitively viagtk/webkit2gtk/wryin the client crate) — nothing this branch touches, and not part of the requiredCIcheck. Ready to merge intodev.