signage#115: playlist content edits never push to an already-assigned device #129
Labels
No labels
Area/Backend
Area/Database
Area/Docs
Area/Frontend
Area/Infra
Area/Security
Area/Tests
Area/Tooling
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Lang/Python
Lang/Rust
Lang/Shell
Lang/SQL
Lang/TypeScript
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Routing
Auto
Routing
Hold
Routing
Human
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
Grimoirix/grimoire-of-digital-signage#129
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What happened
Smoke test (#115) run8, dev tip
91e72c4(with #127/#128's server-side media transfer landed): enroll, approve, upload, assign, and initial playback all now work end to end for the first time. The test then edits the already-assigned playlist's items (PUT /api/v1/playlists/{id}/items) and waits for the real client to pick up the change. It never does — the client keeps looping the original two-item playlist forever (confirmed: 30s+ of continuousplayback: item ... Video(...)/Image(...)log lines for the old items, no newMediaManifest/PlaylistPushever arrives).Root cause
plan/shared/protocol.md:104is explicit:and
crates/server/src/playlists/handlers.rs:331(doc comment onpush_to_device) says the same: "on every playlist change a freshMediaManifest,PlaylistPushandTransferOffer...".But
replace_items(crates/server/src/playlists/handlers.rs:236), the only handler wired toPUT /playlists/{playlist_id}/items(crates/server/src/playlists/mod.rs:32-33), never callspush_to_deviceor any push at all — it only writes the new items viastore::replace_itemsand returns the detail view. The only two places that push to a live connection areassign_playlist(on a fresh assignment) andpush_current_assignment(on anAcceptedreconnect). Editing the content of a playlist that is already assigned to a connected device pushes nothing, so the device never finds out until its next reconnect (or never, for a device that stays connected).Repro
PUT /api/v1/playlists/{playlist_id}/itemswith a different item set, same playlist id.PlaylistPushframe is ever sent.Logs and the live repro stack are on the build host in
/home/astraea/repos/wt-GRI-1885(compose projectserver, client log under/tmp/mvp-smoke-test.oCVzze/client.log), left up for inspection. Full smoke-test log:/tmp/mvp-smoke-test-GRI-1885-run8.log.Fix
replace_itemsneeds to look up which device(s), if any, are currently assigned the edited playlist and call the same push (MediaManifest+PlaylistPush+TransferOffers) thatassign_playlistsends — per spec, on every change to the assigned playlist, not just on (re)assignment.This is a backend/protocol fix, outside Test Writer scope — not mine to make.
Fixed by #130, merged into dev at
eb0de5b. Astraea: rerun the smoke test on dev tip.