Release 0.1.0: digital signage MVP and campus production test #136

Open
vivy wants to merge 595 commits from dev into main
Owner

First release of the digital signage MVP ("MVP - Campus deploy" milestone): one server behind the product owner's reverse proxy, x86 Ubuntu Desktop clients on several campuses. Version 0.1.0. main holds only the initial commit, so this is the whole product so far (210 files).

Scope

Closed in the MVP milestone:

  • #8 MVP API and WebSocket contract (docs)
  • #9 Server core: axum skeleton, health route, config wiring, Postgres schema and migrations
  • #10 Login, first-user setup and sessions
  • #11 Trusted-proxy client IP from X-Forwarded-For (pure function)
  • #12 Enrolment: WebSocket handshake, admission and device token
  • #13 Devices and IP rules API: list, approve, block, rule CRUD
  • #14 Media upload and storage with checksum (image, video, web page URL)
  • #15 PDF to page images at upload (pdftoppm)
  • #16 Playlists: CRUD, assign to device, push to device
  • #17 Client reconnect backoff with jitter and cap (pure)
  • #18 Client media cache plan and streaming sha256 verify (pure)
  • #19 Client playlist cursor: what plays now and for how long (pure)
  • #20 Client sync: wss connection, enrolment, playlist and media download
  • #21 Client playback from cache through the renderer, offline
  • #22 Panel: login and first-user screen
  • #23 Panel: devices (pending, approve, block) and IP rules
  • #24 Panel: media upload and library
  • #25 Panel: playlists and assign to device
  • #26 Packaging: server systemd unit or container
  • #27 Packaging: client .deb with full-screen autostart on Ubuntu Desktop
  • #28 Deployment note: one server behind a reverse proxy, many campuses
  • #30 Decision: do the two named approvals before main apply here? (Q3)
  • #31 Decision: the product's commercial name (Q4)
  • #32 Decision: does the template LICENSE.md stay? (Q5)
  • #113 Panel: switch all five API modules from mock to the real server
  • #114 Server: serve the built panel from the server binary and the container image
  • #115 MVP smoke test: the real client against the real server, on the build host
  • #127 Server never sends TransferOffer: media download is unimplemented end to end

Closed in the Campus production test milestone (21 issues, 0 open):

  • #159 Campus as owner of media, playlists and devices
  • #172 Campus scope and permissions on media and playlists; #174 its acceptance tests
  • #44 Users and permissions per device group; #46 permission scoping tests; #52 panel: users, permissions and API tokens
  • #161 Settings, global and per-campus with fallback; #178 its acceptance tests
  • #160 Live rollout view; #183 its acceptance tests
  • #156 Playlist editor: which screens show a playlist, assign several at once
  • #157 Per-page time overrides on a whole-PDF item; #185 the editor for it; #175 its acceptance tests
  • #158 Media library: PDF pages grouped under their document
  • #155 Deleting a PDF used by a playlist: clear error
  • #33, #189 PowerPoint upload rendered to MP4 with animations (slide images as fallback)
  • #200 dev red on cargo deny advisories (fixed by #203 and #202)

Bugs found by the smoke test and fixed on the way: #123 (reconnect after approve), #129 (playlist edit not pushed), #131 (every PDF upload failed). Deployment note brought up to date in #135.

Still open in the MVP milestone: #29, the product owner's own test on a real mini PC. That is the test week, and is why this goes to main now.

Gates

  • dev tip b69a8d4: all required contexts green on this pull request's own run, including CI / CI (push and pull_request).
  • dev now requires seven contexts (fmt, clippy, test with Postgres, deny, deny advisories, frontend-web, repository boundary), and a branch must be up to date with dev before it merges.
  • cargo deny advisories is green and blocking. deny.toml accepts exactly three advisories, by the product owner's decision of 2026-11-14 (none is a vulnerability; our code does not call the unsound function): glib RUSTSEC-2024-0429, paste RUSTSEC-2024-0436, proc-macro-error RUSTSEC-2024-0370. All three come only through the GTK3 player. CI runs with -D advisory-not-detected, so an entry that stops matching fails the run and must be removed. #201 (move the player to GTK4) removes all three.
  • The bundled-SQLite vulnerability RUSTSEC-2026-0459 is gone: the client keeps its state in a JSON file (#203).
  • End-to-end: scripts/mvp-smoke-test.sh run 11 passed on b71fd85. That is before the Campus production test work. It must pass again on b69a8d4 before the Tests approval.

Migrations

crates/server/migrations/0001_initial_schema.sql, 0002_media_url_and_optional_checksum.sql, 0003_document_page_media_kind.sql. They run at server start (sqlx, embedded). This is a first install, so there is no existing data to migrate. 0003 carries its own rollback steps; 0001 and 0002 are rolled back by dropping the database.

Behaviour change on an existing install (0012, forge #277): 0012_playlist_default_duration_nullable.sql sets the default playtime of every existing playlist to inherit (campus default, else global). A value set on purpose could not be told apart from a copy of the old default. After the upgrade, re-set the own value on any playlist that must keep it (playlist Settings, "Override with a custom value").

Manual steps at deploy

All in plan/operations/deployment.md:

  • Reverse proxy: TLS, WebSocket upgrade, X-Forwarded-For; set the proxy address as trusted in the server config.
  • Server: container image (has poppler), or systemd with poppler-utils installed. Postgres location from config/env (bundled DB is an optional Compose profile).
  • First browser visit creates the admin account.
  • Each client: install the .deb, set the server URL; approve the device in the panel (or set an IP rule per campus).
  • Client self-update is not built (#50, Phase 4): a new version means installing the new .deb on each client.

Roll-back

Restore the backup. For a first install: stop the server and drop its database; uninstall the client .deb.

Look at first

  • Admission: trusted-proxy handling of X-Forwarded-For and the default "pending" for unknown devices (security).
  • PDF conversion: the real pdftoppm test is #[ignore] because CI has no poppler; it is covered by the smoke test only.

Approvals needed: Tests — Chief Technology Officer (@nexus-warden); Security — Security Checker (@aegis). Then the product owner merges.

First release of the digital signage MVP ("MVP - Campus deploy" milestone): one server behind the product owner's reverse proxy, x86 Ubuntu Desktop clients on several campuses. Version 0.1.0. `main` holds only the initial commit, so this is the whole product so far (210 files). ## Scope Closed in the MVP milestone: - #8 MVP API and WebSocket contract (docs) - #9 Server core: axum skeleton, health route, config wiring, Postgres schema and migrations - #10 Login, first-user setup and sessions - #11 Trusted-proxy client IP from X-Forwarded-For (pure function) - #12 Enrolment: WebSocket handshake, admission and device token - #13 Devices and IP rules API: list, approve, block, rule CRUD - #14 Media upload and storage with checksum (image, video, web page URL) - #15 PDF to page images at upload (pdftoppm) - #16 Playlists: CRUD, assign to device, push to device - #17 Client reconnect backoff with jitter and cap (pure) - #18 Client media cache plan and streaming sha256 verify (pure) - #19 Client playlist cursor: what plays now and for how long (pure) - #20 Client sync: wss connection, enrolment, playlist and media download - #21 Client playback from cache through the renderer, offline - #22 Panel: login and first-user screen - #23 Panel: devices (pending, approve, block) and IP rules - #24 Panel: media upload and library - #25 Panel: playlists and assign to device - #26 Packaging: server systemd unit or container - #27 Packaging: client .deb with full-screen autostart on Ubuntu Desktop - #28 Deployment note: one server behind a reverse proxy, many campuses - #30 Decision: do the two named approvals before main apply here? (Q3) - #31 Decision: the product's commercial name (Q4) - #32 Decision: does the template LICENSE.md stay? (Q5) - #113 Panel: switch all five API modules from mock to the real server - #114 Server: serve the built panel from the server binary and the container image - #115 MVP smoke test: the real client against the real server, on the build host - #127 Server never sends TransferOffer: media download is unimplemented end to end Closed in the **Campus production test** milestone (21 issues, 0 open): - #159 Campus as owner of media, playlists and devices - #172 Campus scope and permissions on media and playlists; #174 its acceptance tests - #44 Users and permissions per device group; #46 permission scoping tests; #52 panel: users, permissions and API tokens - #161 Settings, global and per-campus with fallback; #178 its acceptance tests - #160 Live rollout view; #183 its acceptance tests - #156 Playlist editor: which screens show a playlist, assign several at once - #157 Per-page time overrides on a whole-PDF item; #185 the editor for it; #175 its acceptance tests - #158 Media library: PDF pages grouped under their document - #155 Deleting a PDF used by a playlist: clear error - #33, #189 PowerPoint upload rendered to MP4 with animations (slide images as fallback) - #200 `dev` red on `cargo deny advisories` (fixed by #203 and #202) Bugs found by the smoke test and fixed on the way: #123 (reconnect after approve), #129 (playlist edit not pushed), #131 (every PDF upload failed). Deployment note brought up to date in #135. Still open in the MVP milestone: **#29**, the product owner's own test on a real mini PC. That is the test week, and is why this goes to `main` now. ## Gates - `dev` tip `b69a8d4`: all required contexts green on this pull request's own run, including `CI / CI` (push and pull_request). - `dev` now requires **seven** contexts (fmt, clippy, test with Postgres, deny, **deny advisories**, frontend-web, repository boundary), and a branch must be up to date with `dev` before it merges. - `cargo deny advisories` is green and blocking. `deny.toml` accepts exactly three advisories, by the product owner's decision of 2026-11-14 (none is a vulnerability; our code does not call the unsound function): `glib` RUSTSEC-2024-0429, `paste` RUSTSEC-2024-0436, `proc-macro-error` RUSTSEC-2024-0370. All three come only through the GTK3 player. CI runs with `-D advisory-not-detected`, so an entry that stops matching fails the run and must be removed. #201 (move the player to GTK4) removes all three. - The bundled-SQLite vulnerability RUSTSEC-2026-0459 is gone: the client keeps its state in a JSON file (#203). - End-to-end: `scripts/mvp-smoke-test.sh` run 11 passed on `b71fd85`. **That is before the Campus production test work.** It must pass again on `b69a8d4` before the Tests approval. ## Migrations `crates/server/migrations/0001_initial_schema.sql`, `0002_media_url_and_optional_checksum.sql`, `0003_document_page_media_kind.sql`. They run at server start (sqlx, embedded). This is a first install, so there is no existing data to migrate. 0003 carries its own rollback steps; 0001 and 0002 are rolled back by dropping the database. **Behaviour change on an existing install (0012, forge #277):** `0012_playlist_default_duration_nullable.sql` sets the default playtime of **every** existing playlist to *inherit* (campus default, else global). A value set on purpose could not be told apart from a copy of the old default. After the upgrade, re-set the own value on any playlist that must keep it (playlist Settings, "Override with a custom value"). ## Manual steps at deploy All in `plan/operations/deployment.md`: - Reverse proxy: TLS, WebSocket upgrade, `X-Forwarded-For`; set the proxy address as trusted in the server config. - Server: container image (has poppler), or systemd with `poppler-utils` installed. Postgres location from config/env (bundled DB is an optional Compose profile). - First browser visit creates the admin account. - Each client: install the `.deb`, set the server URL; approve the device in the panel (or set an IP rule per campus). - Client self-update is **not** built (#50, Phase 4): a new version means installing the new `.deb` on each client. ## Roll-back Restore the backup. For a first install: stop the server and drop its database; uninstall the client `.deb`. ## Look at first - Admission: trusted-proxy handling of `X-Forwarded-For` and the default "pending" for unknown devices (security). - PDF conversion: the real `pdftoppm` test is `#[ignore]` because CI has no poppler; it is covered by the smoke test only. Approvals needed: Tests — Chief Technology Officer (@nexus-warden); Security — Security Checker (@aegis). Then the product owner merges.
vivy added 166 commits 2026-11-11 11:35:04 +00:00
GRI-155. Turns the template repository into a working project.

Workspace: crates/shared, crates/server, crates/client, with the pinned
toolchain, one workspace dependency table, and a release profile that keeps
unwinding because the update hand-over and the server's job isolation both
need it.

shared carries the parts the specification pins hardest: the frozen handshake
with a test that fixes its wire format, server-assigned identifiers as
distinct types, the content model, and the permission and audit enums.

server loads config.toml with SIGNAGE_* overrides, refuses an unknown key and
accepts only true/false for a boolean. client has the platform traits with a
Linux SystemInfo that reads /proc and /etc/os-release without an external
command, plus the local playlist cursor that makes it offline-first.

frontend-web is the panel shell on React, Vite and TypeScript.

Gates: fmt, clippy, tests, cargo-deny, and the panel's check and build, all
behind scripts/local-gates.sh and .github/workflows/ci.yml. A skipped gate is
not a pass. The tracked pre-push hook refuses a push to main or dev, and the
gate script fails while it is not installed.

plan/ holds the design from the specification: 12 ADRs for the decisions that
are closed, the area designs for the server, the client and the panel, the
process rules, and 5 open questions with the assumption each one is working
under.
GRI-155: set up the Rust workspace, the gates and the project plan (#1)
All checks were successful
CI / cargo fmt (push) Successful in 33s
CI / cargo clippy (push) Successful in 43s
CI / cargo test (push) Successful in 41s
CI / cargo deny (push) Successful in 2m37s
CI / cargo deny advisories (push) Successful in 2m24s
CI / frontend-web (push) Successful in 2m54s
CI / CI (push) Successful in 1m25s
df49733eb4
GRI-155: set up the Rust workspace, the gates and the project plan
GRI-174: renderer spike - image, video and web page in one GTK window
Some checks failed
CI / cargo fmt (pull_request) Successful in 23s
CI / cargo clippy (pull_request) Successful in 1m7s
CI / cargo test (pull_request) Successful in 1m11s
CI / frontend-web (pull_request) Successful in 4m29s
CI / cargo deny advisories (pull_request) Failing after 4m41s
CI / cargo deny (pull_request) Successful in 4m43s
CI / CI (pull_request) Successful in 5s
fc606dcd2d
Validates the ADR 0007 stack (GTK3 + GStreamer/gtksink + WebKitGTK via
wry) behind an ItemRenderer trait with one backend per item kind. The
gtk-renderer feature keeps the GTK/GStreamer/WebKit dependencies out of
the default workspace build, since the CI runner has none of their
system libraries installed.
GRI-365: name the two approvals by role, not by member
All checks were successful
CI / cargo fmt (pull_request) Successful in 37s
CI / cargo clippy (pull_request) Successful in 58s
CI / cargo test (pull_request) Successful in 1m12s
CI / cargo deny (pull_request) Successful in 1m40s
CI / cargo deny advisories (pull_request) Successful in 2m52s
CI / frontend-web (pull_request) Successful in 2m26s
CI / CI (pull_request) Successful in 41s
065c5e5776
Merge pull request 'GRI-365: agent names with meaning, and role references instead of member names' (#1) from docs/GRI-365-agent-names into dev
All checks were successful
CI / cargo fmt (push) Successful in 37s
CI / cargo clippy (push) Successful in 57s
CI / cargo test (push) Successful in 1m20s
CI / cargo deny advisories (push) Successful in 2m29s
CI / cargo deny (push) Successful in 2m35s
CI / frontend-web (push) Successful in 3m28s
CI / CI (push) Successful in 56s
b7442cd5bb
Merge pull request 'GRI-174: Phase 0 renderer spike - image, video and web page in one GTK window' (#2) from feature/GRI-174-renderer-spike into dev
Some checks failed
CI / cargo fmt (push) Successful in 29s
CI / cargo test (push) Successful in 22s
CI / cargo deny (push) Successful in 51s
CI / cargo deny advisories (push) Failing after 43s
CI / frontend-web (push) Successful in 20s
CI / cargo clippy (push) Successful in 9m50s
CI / CI (push) Successful in 28s
5df4e3f4d0
GRI-581: the signage repository gets the same boundary, and names its two duplicated process documents
Some checks failed
CI / cargo fmt (pull_request) Has been cancelled
CI / cargo clippy (pull_request) Has been cancelled
CI / cargo test (pull_request) Has been cancelled
CI / cargo deny (pull_request) Has been cancelled
CI / cargo deny advisories (pull_request) Has been cancelled
CI / frontend-web (pull_request) Has been cancelled
CI / repository boundary (pull_request) Has been cancelled
CI / CI (pull_request) Has been cancelled
789394fe0c
The product owner's rule counts for all repositories, so this one carries a
.repo-boundary manifest too, and CI runs repo-boundary from agent-tools against
it on every pull request. Exit 2 -- the check could not be made -- fails the
job, because a boundary that was not checked must not read like one that is
clean (GRI-143).

It also writes down what the check found. Two documents here are copies of
documents in grimoire-of-helpdesk, and both have drifted:
plan/process/agent-git-identity.md is 79 lines against 183, and
plan/process/branching-and-release.md is 179 against 943. Three homes for two
documents, none of them in step -- which is the same defect as the two block
generators of GRI-654, at document scale.

They are named as exceptions rather than deleted, because deleting a document
an agent is instructed to read before the replacement is in place breaks the
reader. GRI-715 moves both to agent-tools once and repoints every reader.
GRI-581: the boundary step needs the org token, not the job token
Some checks failed
CI / cargo fmt (pull_request) Successful in 16s
CI / cargo deny (pull_request) Successful in 53s
CI / cargo deny advisories (pull_request) Failing after 43s
CI / cargo clippy (pull_request) Successful in 9m51s
CI / repository boundary (pull_request) Successful in 11s
CI / cargo test (pull_request) Successful in 9m39s
CI / frontend-web (pull_request) Successful in 9m41s
CI / CI (pull_request) Successful in 12s
74275843bd
GRI-582: the hook reads the branch name it was already printing
Some checks failed
CI / the pre-push hook (pull_request) Has been cancelled
CI / cargo fmt (pull_request) Has been cancelled
CI / cargo clippy (pull_request) Has been cancelled
CI / cargo test (pull_request) Has been cancelled
CI / cargo deny (pull_request) Has been cancelled
CI / cargo deny advisories (pull_request) Has been cancelled
CI / frontend-web (pull_request) Has been cancelled
CI / CI (pull_request) Has been cancelled
1b8e6bfe44
This repository's pre-push hook refused a push to main or dev, printed
'feature/GRI-nn-...' in its own help text as the shape a branch has — and then
accepted any name at all. Rule 10 was a paragraph the hook had never read.

It also had no test. Nothing anywhere executed it: it is the one piece of
prevention the branch rules have, local-gates.sh fails when it is not
installed, and no suite drove it. That is the GRI-424 shape, where Merge guard
was red on 38 of 38 runs because it could only ever run in CI.

What changes:

- .githooks/pre-push refuses a branch whose name carries no GRI-<digits> key,
  case-sensitively, and warns on a kind that is off the list rather than
  refusing it. Deleting an unprotected branch stays allowed — that is how a
  finished branch leaves, and the sweep needs it.
- scripts/tests/pre-push-test.sh drives every branch of it the way git does,
  one ref line per push: 30 assertions, 30 passing. Both scripts/local-gates.sh
  and CI run it, the CI job needs no toolchain, and it is in the CI roll-up's
  needs so a skipped run is not a pass.
- Rules 10 and 11 are in plan/process/branching-and-release.md, with the sweep
  that detects what the hook cannot prevent: no open issue AND no patch dev is
  missing, both in the same pass, archive tag before deletion.

Three statements in those documents were out of date and are corrected, not
left for the next reader to believe:

- The hook claimed branch protection needs a paid GitHub plan (ADR 0002), so
  nothing on the server could refuse a bad push. GitHub is gone since
  2026-10-17 and this forge applies protection on dev and main here, for
  repository admins too. ADR 0002 now says its premise expired and why its
  controls are kept anyway — rule 10 has no server-side half on any forge,
  because DISABLE_GIT_HOOKS correctly keeps per-repository git hooks off.
- The hook pointed at a branch-guard.yml this repository does not have.
- 'Pushing is enough to hand the work over' is the sentence that let 22 issues
  reach done with their work not in dev, 16 with no pull request at all. A push
  is not the finish line; done means the work is an ancestor of dev.

The new CI job adds no required status context, so it cannot freeze merges:
dev requires the five named gate contexts and not an aggregate.
Merge pull request 'GRI-581: the same repository boundary here, and the two duplicated process documents named' (#3) from chore/GRI-581-repo-boundary into dev
Some checks failed
CI / cargo fmt (push) Successful in 10s
CI / cargo deny (push) Successful in 43s
CI / cargo deny advisories (push) Failing after 45s
CI / repository boundary (push) Successful in 6s
CI / cargo clippy (push) Successful in 9m48s
CI / cargo test (push) Successful in 9m39s
CI / frontend-web (push) Successful in 9m40s
CI / CI (push) Successful in 7s
4b649c028a
The conflict was two branches appending to the same `needs:` list: dev added
`boundary` (GRI-581), this branch added `hooks`. The resolution is the union,
and the roll-up's echo block already names both.

Without dev's `boundary` job in this branch's workflow, the required context
`CI / repository boundary` could never be reported on this head, so the merge
was frozen by a check nobody would produce (the GRI-683 shape).

`repo-boundary --repo .` passes: this branch's edit to
plan/process/branching-and-release.md is a named GRI-715 exception.
GRI-582: the forge runner is not a clean machine
Some checks failed
CI / the pre-push hook (pull_request) Successful in 6s
CI / cargo fmt (pull_request) Successful in 5s
CI / cargo deny (pull_request) Successful in 39s
CI / cargo deny advisories (pull_request) Failing after 39s
CI / cargo clippy (pull_request) Successful in 9m40s
CI / repository boundary (pull_request) Successful in 6s
CI / cargo test (pull_request) Successful in 9m51s
CI / frontend-web (pull_request) Successful in 9m38s
CI / CI (pull_request) Successful in 4s
d71a8d424c
Same correction as rule 5 in the branching document on this branch: the
pull-request gates run in a fresh container isolated from the working tree,
on this same build host. Calling it a clean machine has already been read as
"an independent measurement", which it is not.
Merge pull request 'GRI-582: the hook reads the branch name it was already printing' (#4) from feature/GRI-582-pre-push-issue-key into dev
Some checks failed
CI / the pre-push hook (push) Successful in 5s
CI / cargo fmt (push) Successful in 8s
CI / cargo deny (push) Successful in 44s
CI / cargo clippy (push) Successful in 9m50s
CI / cargo test (push) Successful in 9m46s
CI / cargo deny advisories (push) Failing after 43s
CI / repository boundary (push) Successful in 18s
CI / frontend-web (push) Successful in 9m50s
CI / CI (push) Successful in 5s
3480af4c91
GRI-1766: wake the pull request's author when a gate fails
Some checks failed
CI / the pre-push hook (pull_request) Successful in 10s
CI / cargo fmt (pull_request) Successful in 10s
CI / cargo deny advisories (pull_request) Failing after 1m2s
CI / repository boundary (pull_request) Successful in 7s
CI / cargo clippy (pull_request) Successful in 9m37s
CI / cargo test (pull_request) Successful in 9m45s
CI / frontend-web (pull_request) Successful in 9m37s
CI / cargo deny (pull_request) Failing after 15m8s
CI / CI (pull_request) Has been cancelled
CI / Notify gate failed (pull_request) Has been cancelled
92ff177ddf
GRI-1766: re-run CI, cargo deny hit its 15 min timeout
Some checks failed
CI / cargo fmt (pull_request) Successful in 8s
CI / the pre-push hook (pull_request) Successful in 10s
CI / cargo deny (pull_request) Successful in 59s
CI / cargo deny advisories (pull_request) Failing after 59s
CI / repository boundary (pull_request) Successful in 10s
CI / cargo clippy (pull_request) Successful in 9m42s
CI / cargo test (pull_request) Successful in 9m40s
CI / frontend-web (pull_request) Successful in 9m39s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 4s
fb75bbe5b7
Merge pull request 'GRI-1766: wake the pull request's author when a gate fails' (#6) from feature/GRI-1766-gate-failed-wake into dev
Some checks failed
CI / cargo fmt (push) Successful in 8s
CI / the pre-push hook (push) Successful in 9s
CI / cargo deny advisories (push) Failing after 59s
CI / cargo deny (push) Successful in 1m1s
CI / repository boundary (push) Successful in 7s
CI / cargo clippy (push) Successful in 9m41s
CI / cargo test (push) Successful in 9m40s
CI / frontend-web (push) Successful in 9m39s
CI / Notify gate failed (push) Has been skipped
CI / CI (push) Successful in 3s
bddd627f96
GRI-1808: decide the enrolment of one address from the lists
Some checks failed
CI / the pre-push hook (pull_request) Successful in 10s
CI / cargo fmt (pull_request) Successful in 15s
CI / cargo deny advisories (pull_request) Failing after 1m0s
CI / cargo deny (pull_request) Successful in 1m5s
CI / repository boundary (pull_request) Successful in 6s
CI / cargo clippy (pull_request) Successful in 9m43s
CI / cargo test (pull_request) Successful in 9m46s
CI / frontend-web (pull_request) Successful in 9m38s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 3s
76dd3855b7
Merge pull request 'GRI-1808: IP admission rules' (#7) from feature/GRI-1808-ip-admission into dev
Some checks failed
CI / the pre-push hook (push) Successful in 8s
CI / cargo fmt (push) Successful in 9s
CI / cargo deny advisories (push) Failing after 1m5s
CI / cargo deny (push) Successful in 1m5s
CI / repository boundary (push) Successful in 7s
CI / cargo clippy (push) Successful in 9m38s
CI / cargo test (push) Successful in 9m41s
CI / frontend-web (push) Successful in 9m36s
CI / Notify gate failed (push) Has been skipped
CI / CI (push) Successful in 3s
7d91fde9bd
GRI-1818: name the product Scryglass (Q4 answered)
Some checks failed
CI / the pre-push hook (pull_request) Successful in 8s
CI / cargo fmt (pull_request) Successful in 8s
CI / cargo deny advisories (pull_request) Failing after 56s
CI / cargo deny (pull_request) Successful in 58s
CI / repository boundary (pull_request) Successful in 5s
CI / cargo clippy (pull_request) Successful in 9m35s
CI / cargo test (pull_request) Successful in 9m39s
CI / frontend-web (pull_request) Successful in 9m32s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 3s
409e181bb6
Merge pull request 'GRI-1818: name the product Scryglass' (#71) from docs/GRI-1818-name-scryglass into dev
Some checks failed
CI / cargo fmt (push) Successful in 7s
CI / the pre-push hook (push) Successful in 7s
CI / cargo deny (push) Successful in 1m1s
CI / cargo deny advisories (push) Failing after 59s
CI / repository boundary (push) Successful in 7s
CI / cargo clippy (push) Successful in 9m36s
CI / cargo test (push) Successful in 9m41s
CI / frontend-web (push) Successful in 9m44s
CI / CI (push) Successful in 3s
CI / Notify gate failed (push) Has been skipped
52fa6c7746
GRI-1819: record the product owner's answers to Q2, Q3 and Q5
Some checks failed
CI / the pre-push hook (pull_request) Successful in 11s
CI / cargo fmt (pull_request) Successful in 6s
CI / cargo deny (pull_request) Successful in 37s
CI / cargo clippy (pull_request) Successful in 9m37s
CI / cargo deny advisories (pull_request) Failing after 47s
CI / repository boundary (pull_request) Successful in 5s
CI / cargo test (pull_request) Successful in 9m36s
CI / frontend-web (pull_request) Successful in 9m42s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 4s
90905944fe
Merge pull request 'GRI-1819: record the product owner's answers to Q2, Q3 and Q5' (#72) from docs/GRI-1819-record-po-answers into dev
Some checks failed
CI / cargo fmt (push) Successful in 5s
CI / the pre-push hook (push) Successful in 7s
CI / cargo deny advisories (push) Failing after 1m0s
CI / cargo deny (push) Successful in 1m0s
CI / repository boundary (push) Successful in 7s
CI / cargo clippy (push) Successful in 9m36s
CI / cargo test (push) Successful in 9m40s
CI / frontend-web (push) Successful in 9m37s
CI / Notify gate failed (push) Has been skipped
CI / CI (push) Successful in 3s
f08a7adeff
GRI-1817: read the client IP behind the trusted proxy
Some checks failed
CI / the pre-push hook (pull_request) Successful in 7s
CI / cargo fmt (pull_request) Successful in 9s
CI / cargo deny (pull_request) Successful in 1m26s
CI / cargo deny advisories (pull_request) Failing after 1m24s
CI / repository boundary (pull_request) Successful in 5s
CI / cargo clippy (pull_request) Successful in 9m36s
CI / cargo test (pull_request) Successful in 9m44s
CI / frontend-web (pull_request) Successful in 9m34s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 2s
87997fa762
Merge pull request 'GRI-1817: read the client IP behind the trusted proxy' (#73) from feature/GRI-1817-client-ip into dev
Some checks failed
CI / cargo fmt (push) Successful in 7s
CI / the pre-push hook (push) Successful in 8s
CI / cargo deny (push) Successful in 1m3s
CI / cargo deny advisories (push) Failing after 1m1s
CI / repository boundary (push) Successful in 5s
CI / cargo clippy (push) Successful in 9m36s
CI / cargo test (push) Successful in 9m45s
CI / frontend-web (push) Successful in 9m34s
CI / Notify gate failed (push) Has been skipped
CI / CI (push) Successful in 2s
852e12ac13
GRI-1830: reconnect backoff with jitter
Some checks failed
CI / cargo fmt (pull_request) Successful in 7s
CI / the pre-push hook (pull_request) Successful in 8s
CI / cargo deny advisories (pull_request) Failing after 53s
CI / cargo deny (pull_request) Successful in 56s
CI / repository boundary (pull_request) Successful in 6s
CI / cargo clippy (pull_request) Successful in 9m39s
CI / cargo test (pull_request) Successful in 9m44s
CI / frontend-web (pull_request) Successful in 9m40s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 2s
1d5399280c
Merge pull request 'GRI-1830: reconnect backoff with jitter' (#74) from feature/GRI-1830-backoff into dev
Some checks failed
CI / the pre-push hook (push) Successful in 7s
CI / cargo fmt (push) Successful in 8s
CI / cargo deny advisories (push) Failing after 1m1s
CI / repository boundary (push) Successful in 5s
CI / cargo clippy (push) Successful in 9m31s
CI / cargo test (push) Successful in 9m40s
CI / frontend-web (push) Successful in 9m47s
CI / cargo deny (push) Failing after 15m19s
CI / CI (push) Has been cancelled
CI / Notify gate failed (push) Has been cancelled
36ae5c7229
GRI-1831: decide the media cache plan
Some checks failed
CI / the pre-push hook (pull_request) Successful in 6s
CI / cargo fmt (pull_request) Successful in 7s
CI / cargo deny advisories (pull_request) Failing after 59s
CI / cargo deny (pull_request) Successful in 59s
CI / repository boundary (pull_request) Successful in 7s
CI / cargo clippy (pull_request) Successful in 9m40s
CI / cargo test (pull_request) Successful in 9m44s
CI / frontend-web (pull_request) Successful in 9m33s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 4s
d1739a7dc1
Merge pull request 'GRI-1831: decide the media cache plan' (#75) from feature/GRI-1831-cache-plan into dev
Some checks failed
CI / cargo fmt (push) Successful in 8s
CI / the pre-push hook (push) Successful in 9s
CI / cargo deny (push) Successful in 59s
CI / cargo deny advisories (push) Failing after 57s
CI / repository boundary (push) Successful in 7s
CI / cargo clippy (push) Successful in 9m43s
CI / cargo test (push) Successful in 9m47s
CI / frontend-web (push) Successful in 9m35s
CI / Notify gate failed (push) Has been skipped
CI / CI (push) Successful in 2s
38fd11fe7a
GRI-1836: stream the sha256 check for cached media
Some checks failed
CI / the pre-push hook (pull_request) Successful in 7s
CI / cargo fmt (pull_request) Successful in 9s
CI / cargo deny (pull_request) Successful in 58s
CI / cargo deny advisories (pull_request) Failing after 57s
CI / repository boundary (pull_request) Successful in 6s
CI / cargo clippy (pull_request) Successful in 9m39s
CI / cargo test (pull_request) Successful in 9m43s
CI / frontend-web (pull_request) Successful in 9m36s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 3s
7cfd90bab8
Merge pull request 'GRI-1836: stream the sha256 check for cached media' (#77) from feature/GRI-1836-sha256-verify into dev
Some checks failed
CI / cargo fmt (push) Successful in 11s
CI / the pre-push hook (push) Successful in 13s
CI / cargo deny advisories (push) Failing after 57s
CI / repository boundary (push) Successful in 5s
CI / cargo clippy (push) Successful in 9m43s
CI / cargo test (push) Successful in 9m48s
CI / frontend-web (push) Successful in 9m34s
CI / cargo deny (push) Failing after 13m17s
CI / CI (push) Has been cancelled
CI / Notify gate failed (push) Has been cancelled
2b3df862b5
fix(client): skip zero-length playlist items instead of showing them
Some checks failed
CI / the pre-push hook (pull_request) Successful in 9s
CI / cargo fmt (pull_request) Successful in 10s
CI / cargo deny (pull_request) Successful in 59s
CI / cargo deny advisories (pull_request) Failing after 57s
CI / repository boundary (pull_request) Successful in 8s
CI / cargo clippy (pull_request) Successful in 9m37s
CI / cargo test (pull_request) Successful in 9m41s
CI / frontend-web (pull_request) Successful in 9m38s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 3s
4484493f26
Merge pull request 'GRI-1837: skip zero-length playlist items in the cursor' (#78) from feature/GRI-1837-cursor-zero into dev
Some checks failed
CI / the pre-push hook (push) Successful in 10s
CI / cargo fmt (push) Successful in 10s
CI / cargo deny advisories (push) Failing after 1m2s
CI / cargo deny (push) Successful in 1m2s
CI / repository boundary (push) Successful in 7s
CI / cargo clippy (push) Successful in 9m41s
CI / cargo test (push) Successful in 9m45s
CI / frontend-web (push) Successful in 9m35s
CI / Notify gate failed (push) Has been skipped
CI / CI (push) Successful in 3s
b4689395a0
GRI-1763: cut the API and WebSocket contract to the MVP
Some checks failed
CI / cargo fmt (pull_request) Successful in 17s
CI / the pre-push hook (pull_request) Successful in 18s
CI / cargo deny advisories (pull_request) Failing after 2m5s
CI / cargo deny (pull_request) Successful in 2m5s
CI / repository boundary (pull_request) Successful in 34s
CI / cargo clippy (pull_request) Successful in 9m48s
CI / cargo test (pull_request) Successful in 9m53s
CI / frontend-web (pull_request) Successful in 10m33s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 2s
d80f107a73
GRI-1856: MVP acceptance test plan from the GRI-1761 scope table
Some checks failed
CI / the pre-push hook (pull_request) Successful in 8s
CI / cargo fmt (pull_request) Successful in 10s
CI / cargo deny (pull_request) Successful in 46s
CI / cargo deny advisories (pull_request) Failing after 42s
CI / repository boundary (pull_request) Successful in 5s
CI / cargo clippy (pull_request) Successful in 9m42s
CI / cargo test (pull_request) Successful in 9m40s
CI / frontend-web (pull_request) Successful in 9m41s
CI / CI (pull_request) Successful in 2s
CI / Notify gate failed (pull_request) Has been skipped
80cdf98cbf
GRI-1855: package the client as a .deb with full-screen XDG autostart
Some checks failed
CI / the pre-push hook (pull_request) Successful in 15s
CI / cargo fmt (pull_request) Successful in 5s
CI / cargo deny (pull_request) Successful in 54s
CI / cargo deny advisories (pull_request) Failing after 43s
CI / repository boundary (pull_request) Successful in 5s
CI / cargo clippy (pull_request) Successful in 9m39s
CI / cargo test (pull_request) Successful in 9m43s
CI / frontend-web (pull_request) Successful in 9m42s
CI / CI (pull_request) Successful in 5s
CI / Notify gate failed (pull_request) Has been skipped
d0b8fd05e1
scripts/package-client-deb.sh builds the renderer_spike binary, computes
its runtime Depends with dpkg-shlibdeps against this build host instead of
a hand-typed guess, and assembles grimoirix-signage-client_<version>_<arch>.deb
with an /etc/xdg/autostart entry that starts it full screen at login.

The spike fullscreens its window by default now (opt out with
GRIMOIRIX_RENDERER_WINDOWED for the existing developer workflow), since it
is what the packaged .deb autostarts on a signage display.
GRI-1853: Postgres schema, migrations and the db module
Some checks failed
CI / the pre-push hook (pull_request) Successful in 5s
CI / cargo fmt (pull_request) Successful in 4s
CI / cargo deny (pull_request) Successful in 52s
CI / cargo test (pull_request) Failing after 6m14s
CI / cargo deny advisories (pull_request) Failing after 47s
CI / repository boundary (pull_request) Successful in 14s
CI / cargo clippy (pull_request) Successful in 9m45s
CI / frontend-web (pull_request) Successful in 9m42s
CI / CI (pull_request) Failing after 3s
CI / Notify gate failed (pull_request) Successful in 3s
c94447a7a3
Adds the MVP tables (users, sessions, devices, ip_rules, media,
playlists, playlist_items, device_playlist_assignments) as a single
embedded sqlx migration, plus a server::db module that opens the pool
and runs migrations, refusing a weak sslmode unless the admin opts in.

Not wired into main.rs: GRI-1838 (the axum skeleton) has not merged
yet, and the task names that file as off-limits until it does.

Co-Authored-By: Paperclip <noreply@paperclip.ing>
Merge pull request 'GRI-1763: Signage MVP API and WebSocket contract (docs)' (#79) from docs/GRI-1763-mvp-api-ws-contract into dev
Some checks failed
CI / the pre-push hook (push) Successful in 14s
CI / cargo fmt (push) Successful in 6s
CI / cargo deny (push) Successful in 45s
CI / cargo deny advisories (push) Failing after 40s
CI / repository boundary (push) Successful in 4s
CI / cargo clippy (push) Successful in 9m35s
CI / cargo test (push) Successful in 9m40s
CI / frontend-web (push) Successful in 9m37s
CI / CI (push) Successful in 3s
CI / Notify gate failed (push) Has been skipped
5805a9afc6
GRI-1838: serve the HTTP health endpoint and graceful shutdown
Some checks failed
CI / the pre-push hook (pull_request) Successful in 4s
CI / cargo fmt (pull_request) Successful in 4s
CI / cargo deny (pull_request) Successful in 45s
CI / cargo deny advisories (pull_request) Failing after 39s
CI / repository boundary (pull_request) Successful in 5s
CI / cargo clippy (pull_request) Successful in 9m39s
CI / cargo test (pull_request) Successful in 9m45s
CI / frontend-web (pull_request) Successful in 9m37s
CI / CI (pull_request) Successful in 3s
CI / Notify gate failed (pull_request) Has been skipped
52e65cf7db
GRI-1854: protocol envelope, registration and media transfer frames
Some checks failed
CI / the pre-push hook (pull_request) Successful in 4s
CI / cargo fmt (pull_request) Successful in 4s
CI / cargo deny (pull_request) Successful in 40s
CI / cargo deny advisories (pull_request) Failing after 41s
CI / repository boundary (pull_request) Successful in 5s
CI / cargo clippy (pull_request) Successful in 9m33s
CI / cargo test (pull_request) Successful in 9m37s
CI / frontend-web (pull_request) Successful in 9m51s
CI / CI (pull_request) Successful in 4s
CI / Notify gate failed (pull_request) Has been skipped
b5484cb073
ServerMessage/ServerControl/ClientMessage tag every frame after the
handshake, so PlaylistPush and MediaManifest can be told apart. Adds the
Registration report, the transfer offer/accept/complete messages, the
12-byte binary chunk header, the device WebSocket path and the heartbeat
interval. protocol.md describes the session in order.
GRI-1764: panel first-user setup and login screens
Some checks failed
CI / the pre-push hook (pull_request) Successful in 11s
CI / cargo fmt (pull_request) Successful in 4s
CI / cargo deny (pull_request) Successful in 52s
CI / cargo deny advisories (pull_request) Failing after 53s
CI / cargo clippy (pull_request) Successful in 9m45s
CI / repository boundary (pull_request) Successful in 15s
CI / cargo test (pull_request) Successful in 9m36s
CI / frontend-web (pull_request) Successful in 9m47s
CI / CI (pull_request) Successful in 3s
CI / Notify gate failed (pull_request) Has been skipped
16a6093b15
Mocks the setup/session API behind one switch (src/api/sessionApi.ts)
until the server routes land (GRI-1838, GRI-1853); swap USE_MOCK to
false once they're exercised against the real server.
GRI-1854: client sync over wss — enrolment, playlist, media cache, reconnect
Some checks failed
CI / the pre-push hook (pull_request) Has been cancelled
CI / cargo fmt (pull_request) Has been cancelled
CI / cargo clippy (pull_request) Has been cancelled
CI / cargo test (pull_request) Has been cancelled
CI / cargo deny (pull_request) Has been cancelled
CI / cargo deny advisories (pull_request) Has been cancelled
CI / frontend-web (pull_request) Has been cancelled
CI / repository boundary (pull_request) Has been cancelled
CI / CI (pull_request) Has been cancelled
CI / Notify gate failed (pull_request) Has been cancelled
a6bb13bf04
state.rs keeps the identity and the last playlist in state.json, written
by rename. cache.rs stores media by sha256, resumes from <sha>.part and
only renames a file into place once its hash is checked; a name that is
not a sha256 never becomes a path. session.rs is the protocol for one
connection with no network in it. sync.rs is the wss loop: hello
timeout, heartbeat and ping, dead-connection detection, backoff with
jitter, and a watch channel that playback reads, filled from disk before
the first connect. config.rs reads the server from the environment or
/etc/grimoirix-signage/client.toml. The integration test runs a fake
server, restarts it on the same port, and checks the client comes back
with its identity and picks up the changed playlist.
GRI-1854: state.json is readable by its owner only (it holds the token)
Some checks failed
CI / the pre-push hook (pull_request) Successful in 10s
CI / cargo fmt (pull_request) Successful in 7s
CI / cargo clippy (pull_request) Successful in 9m40s
CI / cargo deny (pull_request) Successful in 44s
CI / cargo deny advisories (pull_request) Failing after 38s
CI / cargo test (pull_request) Successful in 9m41s
CI / repository boundary (pull_request) Successful in 4s
CI / frontend-web (pull_request) Successful in 9m37s
CI / CI (pull_request) Has been cancelled
CI / Notify gate failed (pull_request) Has been cancelled
52110c7f35
GRI-1764: panel devices and IP rules screens
Some checks failed
CI / the pre-push hook (pull_request) Successful in 4s
CI / cargo fmt (pull_request) Successful in 5s
CI / cargo deny (pull_request) Successful in 39s
CI / cargo deny advisories (pull_request) Failing after 38s
CI / repository boundary (pull_request) Successful in 10s
CI / cargo clippy (pull_request) Successful in 9m38s
CI / cargo test (pull_request) Successful in 9m41s
CI / frontend-web (pull_request) Successful in 9m56s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 11s
31a84b5706
Devices: pending list with approve/block, approved list with inline
rename, last-seen and assigned playlist. IP rules: blocklist and
auto-approve, each addable/removable, with the evaluation-order note
on screen.

Adds a tiny History API router (no library yet, per
plan/frontend/stack.md) now that there is more than one screen behind
login. Mocked behind devicesApi.ts/ipRulesApi.ts the same way as the
session API, until the server routes land.
GRI-1764: panel media library screen
Some checks failed
CI / the pre-push hook (pull_request) Successful in 4s
CI / cargo fmt (pull_request) Successful in 4s
CI / cargo deny (pull_request) Successful in 48s
CI / cargo deny advisories (pull_request) Failing after 48s
CI / cargo clippy (pull_request) Successful in 9m41s
CI / repository boundary (pull_request) Successful in 11s
CI / cargo test (pull_request) Successful in 9m36s
CI / frontend-web (pull_request) Successful in 9m59s
CI / CI (pull_request) Successful in 3s
CI / Notify gate failed (pull_request) Has been skipped
8993db2cec
Upload image/video/PDF, add a web-page URL, list and delete. A PDF
upload is split into one item per page at upload time, per
plan/server/media-pipeline.md. Mocked behind mediaApi.ts the same way
as the other screens, until the server routes land.
GRI-1854: playback from the cache, offline — grimoirix-signage-client
Some checks failed
CI / the pre-push hook (pull_request) Successful in 9s
CI / cargo fmt (pull_request) Successful in 6s
CI / cargo deny (pull_request) Successful in 49s
CI / cargo deny advisories (pull_request) Failing after 43s
CI / repository boundary (pull_request) Successful in 6s
CI / cargo clippy (pull_request) Successful in 9m46s
CI / cargo test (pull_request) Successful in 9m48s
CI / frontend-web (pull_request) Successful in 9m38s
CI / CI (pull_request) Has been cancelled
CI / Notify gate failed (pull_request) Has been cancelled
8f7a43943d
player.rs turns the cursor plus the cache into the next step: a web
page plays at once, an image, PDF page or video plays once its verified
file is on disk and is skipped until then. Nothing playable is
CannotLoad, nothing valid is NothingScheduled. Only http(s) URLs reach
the web view. The grimoirix-signage-client binary runs the sync on its
own thread and the GTK window on the main thread, joined by two watch
channels. The playlist from disk is played before any connection.
Images are scaled to the window, so a PDF page fills the screen.
GRI-1764: panel playlists screen
Some checks failed
CI / the pre-push hook (pull_request) Successful in 5s
CI / cargo fmt (pull_request) Successful in 4s
CI / cargo deny (pull_request) Successful in 40s
CI / cargo deny advisories (pull_request) Failing after 38s
CI / repository boundary (pull_request) Successful in 5s
CI / cargo clippy (pull_request) Successful in 9m34s
CI / cargo test (pull_request) Successful in 9m39s
CI / frontend-web (pull_request) Successful in 9m46s
CI / CI (pull_request) Successful in 3s
CI / Notify gate failed (pull_request) Has been skipped
13e2492383
Create a playlist, add items from the media library, reorder and set
a per-item duration, save, and assign to an approved device. Closes
the last MVP screen group.

Mocked behind playlistsApi.ts the same way as the other screens.
Assignment writes the approved device's assignedPlaylist in the mock
devices store, so the devices screen reflects it.
Merge pull request 'GRI-1856: MVP acceptance test plan' (#80) from docs/GRI-1856-mvp-acceptance-test-plan into dev
Some checks failed
CI / the pre-push hook (push) Successful in 4s
CI / cargo fmt (push) Successful in 4s
CI / cargo deny (push) Successful in 37s
CI / cargo deny advisories (push) Failing after 35s
CI / repository boundary (push) Successful in 5s
CI / cargo clippy (push) Successful in 9m30s
CI / cargo test (push) Successful in 9m36s
CI / frontend-web (push) Successful in 9m44s
CI / CI (push) Successful in 3s
CI / Notify gate failed (push) Has been skipped
6203258982
Merge pull request 'GRI-1838: serve the HTTP health endpoint and graceful shutdown' (#83) from feature/GRI-1838-http-skeleton into dev
Some checks failed
CI / the pre-push hook (push) Successful in 4s
CI / cargo fmt (push) Successful in 6s
CI / cargo deny (push) Successful in 48s
CI / cargo deny advisories (push) Failing after 40s
CI / repository boundary (push) Successful in 7s
CI / cargo clippy (push) Successful in 9m43s
CI / cargo test (push) Successful in 9m40s
CI / frontend-web (push) Successful in 9m41s
CI / CI (push) Successful in 2s
CI / Notify gate failed (push) Has been skipped
1f8076b2eb
Merge pull request 'GRI-1855: client .deb with full-screen XDG autostart' (#81) from feature/GRI-1855-client-deb-autostart into dev
Some checks failed
CI / the pre-push hook (push) Successful in 11s
CI / cargo fmt (push) Successful in 5s
CI / cargo deny (push) Successful in 42s
CI / cargo deny advisories (push) Failing after 42s
CI / repository boundary (push) Successful in 5s
CI / cargo clippy (push) Successful in 9m34s
CI / cargo test (push) Successful in 9m45s
CI / frontend-web (push) Successful in 9m35s
CI / CI (push) Successful in 3s
CI / Notify gate failed (push) Has been skipped
67f559dd26
GRI-1855: server Docker/Compose image and systemd unit packaging (#26)
Some checks failed
CI / the pre-push hook (pull_request) Successful in 6s
CI / cargo fmt (pull_request) Successful in 6s
CI / cargo deny (pull_request) Successful in 44s
CI / cargo deny advisories (pull_request) Failing after 40s
CI / repository boundary (pull_request) Successful in 5s
CI / cargo clippy (pull_request) Successful in 10m2s
CI / cargo test (pull_request) Successful in 10m0s
CI / frontend-web (pull_request) Successful in 9m35s
CI / CI (pull_request) Successful in 3s
CI / Notify gate failed (pull_request) Has been skipped
54139441a1
GRI-1856: real-TCP integration harness for the server's HTTP surface
Some checks failed
CI / the pre-push hook (pull_request) Successful in 24s
CI / cargo fmt (pull_request) Successful in 21s
CI / cargo deny (pull_request) Successful in 47s
CI / cargo deny advisories (pull_request) Failing after 1m1s
CI / repository boundary (pull_request) Successful in 18s
CI / cargo clippy (pull_request) Successful in 10m3s
CI / cargo test (pull_request) Successful in 10m8s
CI / frontend-web (pull_request) Successful in 9m45s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 6s
79e9503fd9
Adds crates/server/tests/support/mod.rs (binds server::http::router() on
127.0.0.1:0, drives it with axum::serve + graceful shutdown the way main.rs
does, and a minimal raw HTTP/1.1 client over a real TcpStream) and
crates/server/tests/http_integration.rs with the first tests built on it:
the /health route over a real socket, graceful shutdown finishing a request
already in flight, and the matching unhappy-path case for an unknown route.

This is the base every later route's integration test reuses as routes land.
Merge pull request 'GRI-1854: protocol envelope, registration and media transfer frames' (#84) from feature/GRI-1854-protocol-envelope into dev
Some checks failed
CI / the pre-push hook (push) Successful in 5s
CI / cargo fmt (push) Successful in 5s
CI / cargo deny (push) Successful in 46s
CI / cargo deny advisories (push) Failing after 52s
CI / repository boundary (push) Successful in 6s
CI / cargo clippy (push) Successful in 9m41s
CI / cargo test (push) Successful in 9m41s
CI / frontend-web (push) Successful in 9m42s
CI / Notify gate failed (push) Has been skipped
CI / CI (push) Successful in 6s
b22fcf163b
Merge remote-tracking branch 'origin/dev' into feature/GRI-1854-client-sync
Some checks failed
CI / the pre-push hook (pull_request) Successful in 6s
CI / cargo fmt (pull_request) Successful in 5s
CI / cargo deny (pull_request) Successful in 42s
CI / cargo deny advisories (pull_request) Failing after 44s
CI / repository boundary (pull_request) Successful in 5s
CI / cargo clippy (pull_request) Successful in 9m39s
CI / cargo test (pull_request) Successful in 9m49s
CI / frontend-web (pull_request) Successful in 9m37s
CI / CI (pull_request) Successful in 4s
CI / Notify gate failed (pull_request) Has been skipped
3cc319998f
# Conflicts:
#	Cargo.lock
Merge branch 'feature/GRI-1854-client-sync' into feature/GRI-1854-offline-playback
Some checks failed
CI / the pre-push hook (pull_request) Successful in 4s
CI / cargo fmt (pull_request) Successful in 4s
CI / cargo deny (pull_request) Successful in 42s
CI / cargo deny advisories (pull_request) Failing after 43s
CI / repository boundary (pull_request) Successful in 5s
CI / cargo clippy (pull_request) Successful in 9m42s
CI / cargo test (pull_request) Successful in 9m49s
CI / frontend-web (pull_request) Successful in 9m42s
CI / CI (pull_request) Successful in 6s
CI / Notify gate failed (pull_request) Has been skipped
68ebd4311a
Merge pull request 'GRI-1855: server Docker/Compose image and systemd unit packaging (#26)' (#91) from feature/GRI-1855-server-packaging into dev
Some checks failed
CI / the pre-push hook (push) Successful in 5s
CI / cargo fmt (push) Successful in 6s
CI / cargo deny (push) Successful in 37s
CI / cargo deny advisories (push) Failing after 38s
CI / repository boundary (push) Successful in 6s
CI / cargo clippy (push) Successful in 9m41s
CI / cargo test (push) Successful in 9m38s
CI / frontend-web (push) Successful in 9m39s
CI / CI (push) Successful in 5s
CI / Notify gate failed (push) Has been skipped
e17d343a55
Merge pull request 'GRI-1764: panel first-user setup and login screens' (#85) from feature/GRI-1764-panel-login into dev
Some checks failed
CI / the pre-push hook (push) Successful in 6s
CI / cargo fmt (push) Successful in 5s
CI / cargo deny (push) Successful in 38s
CI / cargo deny advisories (push) Failing after 39s
CI / repository boundary (push) Successful in 15s
CI / cargo clippy (push) Successful in 9m41s
CI / cargo test (push) Successful in 9m41s
CI / frontend-web (push) Successful in 9m52s
CI / CI (push) Successful in 3s
CI / Notify gate failed (push) Has been skipped
e000a0527b
Merge pull request 'GRI-1764: panel devices and IP rules screens' (#87) from feature/GRI-1764-panel-devices into dev
Some checks failed
CI / the pre-push hook (push) Successful in 10s
CI / cargo fmt (push) Successful in 6s
CI / cargo deny (push) Successful in 37s
CI / cargo deny advisories (push) Failing after 38s
CI / repository boundary (push) Successful in 5s
CI / cargo clippy (push) Successful in 9m38s
CI / cargo test (push) Successful in 9m41s
CI / frontend-web (push) Successful in 9m42s
CI / CI (push) Successful in 3s
CI / Notify gate failed (push) Has been skipped
436be41894
Merge pull request 'GRI-1764: panel media library screen' (#88) from feature/GRI-1764-panel-media into dev
Some checks failed
CI / the pre-push hook (push) Successful in 5s
CI / cargo fmt (push) Successful in 5s
CI / cargo deny (push) Successful in 43s
CI / cargo clippy (push) Successful in 9m46s
CI / cargo test (push) Successful in 9m46s
CI / repository boundary (push) Successful in 14s
CI / frontend-web (push) Successful in 9m43s
CI / CI (push) Successful in 3s
CI / Notify gate failed (push) Has been skipped
CI / cargo deny advisories (push) Failing after 10m54s
c31b340260
Merge pull request 'GRI-1764: panel playlists screen' (#90) from feature/GRI-1764-panel-playlists into dev
Some checks failed
CI / cargo fmt (push) Successful in 7s
CI / the pre-push hook (push) Successful in 9s
CI / cargo clippy (push) Successful in 9m49s
CI / cargo test (push) Successful in 9m59s
CI / cargo deny (push) Successful in 1m9s
CI / cargo deny advisories (push) Failing after 59s
CI / repository boundary (push) Successful in 10s
CI / frontend-web (push) Successful in 9m44s
CI / Notify gate failed (push) Has been skipped
CI / CI (push) Successful in 5s
7cecb8f32c
Merge pull request 'GRI-1856: real-TCP integration harness for server HTTP tests' (#92) from test/GRI-1856-server-integration-harness into dev
Some checks failed
CI / the pre-push hook (push) Successful in 8s
CI / cargo fmt (push) Successful in 7s
CI / cargo deny (push) Successful in 58s
CI / cargo deny advisories (push) Failing after 55s
CI / repository boundary (push) Successful in 5s
CI / cargo clippy (push) Successful in 9m39s
CI / cargo test (push) Successful in 9m45s
CI / frontend-web (push) Successful in 9m47s
CI / Notify gate failed (push) Has been skipped
CI / CI (push) Failing after 10m24s
1d48aa0edb
Merge pull request 'GRI-1854: client sync over wss — enrolment, playlist, media cache, reconnect' (#86) from feature/GRI-1854-client-sync into dev
Some checks failed
CI / the pre-push hook (push) Successful in 4s
CI / cargo fmt (push) Successful in 5s
CI / cargo deny (push) Successful in 44s
CI / cargo deny advisories (push) Failing after 52s
CI / repository boundary (push) Successful in 6s
CI / cargo clippy (push) Successful in 9m48s
CI / cargo test (push) Successful in 9m57s
CI / frontend-web (push) Successful in 9m43s
CI / CI (push) Successful in 4s
CI / Notify gate failed (push) Has been skipped
4fcfc0a76c
# Conflicts:
#	Cargo.lock
#	Cargo.toml
#	crates/server/Cargo.toml
#	crates/server/src/lib.rs
Merge pull request 'GRI-1854: playback from the cache, offline — grimoirix-signage-client' (#89) from feature/GRI-1854-offline-playback into dev
Some checks failed
CI / the pre-push hook (push) Successful in 4s
CI / cargo fmt (push) Successful in 5s
CI / cargo deny (push) Successful in 40s
CI / cargo deny advisories (push) Failing after 41s
CI / repository boundary (push) Successful in 15s
CI / cargo clippy (push) Successful in 9m40s
CI / cargo test (push) Successful in 9m45s
CI / frontend-web (push) Successful in 9m51s
CI / CI (push) Successful in 3s
CI / Notify gate failed (push) Has been skipped
2a5ab13b62
# Conflicts:
#	Cargo.lock
#	crates/server/Cargo.toml
Merge remote-tracking branch 'origin/dev' into feature/GRI-1853-signage-db-schema
Some checks failed
CI / the pre-push hook (pull_request) Successful in 6s
CI / cargo fmt (pull_request) Successful in 7s
CI / cargo test (pull_request) Failing after 5m56s
CI / cargo deny (pull_request) Successful in 58s
CI / cargo deny advisories (pull_request) Failing after 58s
CI / repository boundary (pull_request) Successful in 10s
CI / cargo clippy (pull_request) Successful in 9m54s
CI / frontend-web (pull_request) Successful in 9m50s
CI / Notify gate failed (pull_request) Successful in 5s
CI / CI (pull_request) Failing after 5s
5b098857a0
GRI-1853: fix CI test-database wiring and per-test isolation
Some checks failed
CI / cargo fmt (pull_request) Successful in 7s
CI / the pre-push hook (pull_request) Successful in 8s
CI / cargo deny advisories (pull_request) Failing after 1m11s
CI / cargo deny (pull_request) Successful in 1m11s
CI / repository boundary (pull_request) Successful in 6s
CI / cargo clippy (pull_request) Successful in 9m49s
CI / cargo test (pull_request) Successful in 10m14s
CI / frontend-web (pull_request) Successful in 9m40s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 3s
6ed8cd3b37
Point SIGNAGE_TEST_DATABASE_URL at the postgres service by hostname
instead of localhost with job.services.postgres.ports, which is empty
inside the Forgejo runner's job container. Give each db_integration
test its own database instead of sharing one and racing
DROP SCHEMA public CASCADE across parallel test threads.
Merge pull request 'GRI-1853: Postgres schema, migrations and the db module (signage #9b)' (#82) from feature/GRI-1853-signage-db-schema into dev
Some checks failed
CI / the pre-push hook (push) Successful in 9s
CI / cargo fmt (push) Successful in 9s
CI / cargo deny (push) Successful in 1m35s
CI / cargo deny advisories (push) Failing after 1m35s
CI / repository boundary (push) Successful in 9s
CI / cargo clippy (push) Successful in 10m16s
CI / cargo test (push) Successful in 10m41s
CI / frontend-web (push) Successful in 9m49s
CI / CI (push) Successful in 3s
CI / Notify gate failed (push) Has been skipped
536d9e0346
GRI-1853: cargo fmt
Some checks failed
CI / the pre-push hook (pull_request) Successful in 8s
CI / cargo fmt (pull_request) Successful in 13s
CI / cargo deny (pull_request) Successful in 46s
CI / cargo deny advisories (pull_request) Failing after 40s
CI / repository boundary (pull_request) Successful in 5s
CI / cargo clippy (pull_request) Successful in 10m8s
CI / cargo test (pull_request) Successful in 10m23s
CI / frontend-web (pull_request) Successful in 9m43s
CI / CI (pull_request) Successful in 3s
CI / Notify gate failed (pull_request) Has been skipped
6c709ad428
GRI-1873: enrolment over WebSocket (signage #12)
Some checks failed
CI / the pre-push hook (pull_request) Successful in 6s
CI / cargo fmt (pull_request) Successful in 17s
CI / cargo deny (pull_request) Successful in 1m5s
CI / cargo deny advisories (pull_request) Failing after 1m14s
CI / repository boundary (pull_request) Successful in 6s
CI / cargo clippy (pull_request) Successful in 10m9s
CI / cargo test (pull_request) Successful in 10m25s
CI / frontend-web (pull_request) Successful in 10m20s
CI / CI (pull_request) Successful in 4s
CI / Notify gate failed (pull_request) Has been skipped
553cd9741a
Device WebSocket route: the frozen handshake, the admission decision
(blocklist / auto-approve / pending, per plan/server/enrolment.md), and
the per-device token hand-off. The blocklist is checked against the bare
peer address before the WebSocket upgrade is accepted when it binds
registered devices (the default), so a blocked host gets a plain HTTP 403
and no frames are ever parsed.

Adds the device repository (devices.rs), token generation/hashing
(tokens.rs), and a minimal ed25519 key load-or-generate (signing.rs) for
the signing_public_key field the handshake requires (ADR 0006); actual
update signing/delivery stays out of scope, per protocol.md.

Admin approval has no REST route yet (signage #13, the second PR); the
pending-to-approved transition is exercised directly against the device
repository in ws_integration.rs the way that route will call it.
Merge pull request 'GRI-1853: login, first-user setup and sessions (signage #10)' (#93) from feature/GRI-1853-signage-auth-sessions into dev
Some checks failed
CI / the pre-push hook (push) Successful in 7s
CI / cargo fmt (push) Successful in 10s
CI / cargo deny (push) Successful in 1m12s
CI / cargo deny advisories (push) Failing after 52s
CI / cargo clippy (push) Successful in 10m14s
CI / repository boundary (push) Successful in 9s
CI / cargo test (push) Successful in 10m20s
CI / frontend-web (push) Successful in 10m2s
CI / Notify gate failed (push) Has been skipped
CI / CI (push) Successful in 6s
7856035f4a
GRI-1873: merge origin/dev (#93 login/sessions), wire both extension layers
Some checks failed
CI / cargo fmt (pull_request) Successful in 8s
CI / the pre-push hook (pull_request) Successful in 8s
CI / cargo deny (pull_request) Failing after 2m25s
CI / cargo deny advisories (pull_request) Failing after 2m26s
CI / repository boundary (pull_request) Successful in 6s
CI / cargo clippy (pull_request) Successful in 10m28s
CI / cargo test (pull_request) Successful in 10m54s
CI / frontend-web (pull_request) Successful in 11m10s
CI / CI (pull_request) Failing after 4s
CI / Notify gate failed (pull_request) Successful in 4s
21487d9a1d
GRI-1874: media upload and storage (signage #14)
Some checks failed
CI / the pre-push hook (pull_request) Successful in 6s
CI / cargo fmt (pull_request) Successful in 12s
CI / cargo deny (pull_request) Successful in 2m25s
CI / cargo deny advisories (pull_request) Failing after 1m59s
CI / repository boundary (pull_request) Successful in 5s
CI / cargo clippy (pull_request) Successful in 10m19s
CI / cargo test (pull_request) Successful in 11m2s
CI / frontend-web (pull_request) Successful in 10m30s
CI / CI (pull_request) Successful in 11s
CI / Notify gate failed (pull_request) Has been skipped
4f4fe7ef3a
Images and videos upload with a sha256, stored once on disk by content
hash; web page URLs are added with no upload. Both list through
GET /media, behind the session extractor from #10.

PDF upload is refused with a clear error for now: the page converter is
GRI-1868 (#15a), and wiring it in is #15b.

Also drops the UNIQUE constraint on media.sha256, which contradicted the
comment on MediaId in shared::ids (two uploads of the same bytes are two
catalog entries; only the file on disk is deduplicated) -- a mistake in
my own earlier schema from #9b.
GRI-1856: setup/session integration tests (AC-1-02..AC-1-06)
Some checks failed
CI / the pre-push hook (pull_request) Successful in 6s
CI / cargo fmt (pull_request) Successful in 9s
CI / cargo deny advisories (pull_request) Failing after 1m24s
CI / cargo deny (pull_request) Successful in 1m26s
CI / repository boundary (pull_request) Successful in 11s
CI / cargo clippy (pull_request) Successful in 9m49s
CI / cargo test (pull_request) Successful in 10m15s
CI / frontend-web (pull_request) Successful in 9m56s
CI / CI (pull_request) Successful in 3s
CI / Notify gate failed (pull_request) Has been skipped
790c4c3a4b
Extends the real-TCP harness in tests/support/mod.rs with a generic
send() helper for arbitrary methods/headers/bodies, and adds
setup_session_integration.rs covering first-user setup validation,
single-admin enforcement, and login success/failure paths.

One case (empty username accepted by POST /setup) is #[ignore]d with
the exact reason: a real validation gap against AC-1-02, not a test bug.

Co-Authored-By: Paperclip <noreply@paperclip.ing>
feat(server): render PDF pages to images via pdftoppm
Some checks failed
CI / the pre-push hook (pull_request) Successful in 5s
CI / cargo fmt (pull_request) Successful in 9s
CI / cargo deny (pull_request) Successful in 37s
CI / cargo deny advisories (pull_request) Failing after 42s
CI / repository boundary (pull_request) Successful in 11s
CI / cargo clippy (pull_request) Successful in 9m41s
CI / cargo test (pull_request) Successful in 9m42s
CI / frontend-web (pull_request) Successful in 9m57s
CI / CI (pull_request) Successful in 3s
CI / Notify gate failed (pull_request) Has been skipped
b1f4836f00
Merge pull request 'GRI-1874: media upload and storage (signage #14)' (#95) from feature/GRI-1874-signage-media-upload-storage into dev
Some checks failed
CI / the pre-push hook (push) Successful in 9s
CI / cargo fmt (push) Successful in 9s
CI / cargo deny (push) Successful in 1m8s
CI / cargo deny advisories (push) Failing after 54s
CI / repository boundary (push) Successful in 13s
CI / cargo clippy (push) Successful in 10m9s
CI / cargo test (push) Successful in 10m36s
CI / frontend-web (push) Successful in 9m49s
CI / CI (push) Successful in 3s
CI / Notify gate failed (push) Has been skipped
0eb1b00c9a
Merge pull request 'GRI-1856: setup/session integration tests' (#96) from test/GRI-1856-setup-session-integration into dev
Some checks failed
CI / the pre-push hook (push) Successful in 6s
CI / cargo fmt (push) Successful in 5s
CI / cargo deny (push) Successful in 45s
CI / cargo deny advisories (push) Failing after 46s
CI / repository boundary (push) Successful in 5s
CI / cargo clippy (push) Successful in 9m54s
CI / cargo test (push) Successful in 10m32s
CI / frontend-web (push) Successful in 9m51s
CI / CI (push) Successful in 3s
CI / Notify gate failed (push) Has been skipped
cd69e54a2d
Merge remote-tracking branch 'origin/dev' into feature/GRI-1873-enrolment-websocket
Some checks failed
CI / the pre-push hook (pull_request) Successful in 5s
CI / cargo fmt (pull_request) Successful in 5s
CI / cargo deny (pull_request) Failing after 2m29s
CI / cargo deny advisories (pull_request) Failing after 2m3s
CI / repository boundary (pull_request) Successful in 6s
CI / cargo clippy (pull_request) Successful in 10m18s
CI / cargo test (pull_request) Successful in 11m6s
CI / CI (pull_request) Has been cancelled
CI / Notify gate failed (pull_request) Has been cancelled
CI / frontend-web (pull_request) Has been cancelled
83d68560ef
# Conflicts:
#	crates/server/Cargo.toml
#	crates/server/src/http.rs
#	crates/server/src/lib.rs
#	crates/server/src/main.rs
GRI-1856: fix setup/session tests to use the real email field
Some checks failed
CI / the pre-push hook (pull_request) Successful in 5s
CI / cargo fmt (pull_request) Successful in 6s
CI / cargo deny (pull_request) Successful in 58s
CI / cargo deny advisories (pull_request) Failing after 1m42s
CI / repository boundary (pull_request) Successful in 8s
CI / cargo clippy (pull_request) Successful in 10m12s
CI / cargo test (pull_request) Successful in 11m3s
CI / frontend-web (pull_request) Successful in 10m1s
CI / CI (pull_request) Successful in 4s
CI / Notify gate failed (pull_request) Has been skipped
f6df9a0b89
GRI-1874: playlists CRUD, item assignment, device push stub (#16)
Some checks failed
CI / the pre-push hook (pull_request) Successful in 8s
CI / cargo fmt (pull_request) Successful in 13s
CI / cargo deny (pull_request) Successful in 1m21s
CI / cargo deny advisories (pull_request) Failing after 1m38s
CI / repository boundary (pull_request) Successful in 6s
CI / cargo test (pull_request) Failing after 5m46s
CI / cargo clippy (pull_request) Successful in 10m18s
CI / CI (pull_request) Has been cancelled
CI / Notify gate failed (pull_request) Has been cancelled
CI / frontend-web (pull_request) Has been cancelled
d9bd8ced32
GRI-1856: media acceptance tests (AC-3-01..AC-3-07)
Some checks failed
CI / the pre-push hook (pull_request) Successful in 5s
CI / cargo fmt (pull_request) Successful in 5s
CI / cargo deny (pull_request) Successful in 51s
CI / cargo deny advisories (pull_request) Failing after 43s
CI / repository boundary (pull_request) Successful in 7s
CI / cargo clippy (pull_request) Successful in 9m52s
CI / cargo test (pull_request) Successful in 10m35s
CI / frontend-web (pull_request) Successful in 9m42s
CI / CI (pull_request) Successful in 2s
CI / Notify gate failed (pull_request) Has been skipped
b601d9db00
Merge pull request 'GRI-1856: fix setup/session tests to use the real email field' (#98) from fix/GRI-1856-setup-session-email-field into dev
Some checks failed
CI / the pre-push hook (push) Successful in 11s
CI / cargo fmt (push) Successful in 7s
CI / cargo deny (push) Successful in 55s
CI / cargo deny advisories (push) Failing after 46s
CI / repository boundary (push) Successful in 5s
CI / cargo clippy (push) Successful in 9m58s
CI / cargo test (push) Successful in 10m23s
CI / frontend-web (push) Successful in 9m51s
CI / CI (push) Successful in 3s
CI / Notify gate failed (push) Has been skipped
9e984a729c
GRI-1874: fix ambiguous created_at in playlists list query
Some checks failed
CI / the pre-push hook (pull_request) Successful in 4s
CI / cargo fmt (pull_request) Successful in 4s
CI / cargo deny (pull_request) Successful in 45s
CI / cargo deny advisories (pull_request) Failing after 56s
CI / repository boundary (pull_request) Successful in 9s
CI / cargo clippy (pull_request) Successful in 9m58s
CI / cargo test (pull_request) Successful in 10m37s
CI / frontend-web (pull_request) Successful in 9m47s
CI / CI (pull_request) Successful in 5s
CI / Notify gate failed (pull_request) Has been skipped
6608c71d2a
GET /playlists joined playlist_items for the item count, and the
LEFT JOIN made the unqualified created_at/updated_at columns from
PLAYLIST_COLUMNS ambiguous (playlist_items also has created_at).
Qualify every selected column with the playlists alias.
GRI-1868: merge origin/dev into the PDF converter branch
Some checks failed
CI / the pre-push hook (pull_request) Successful in 10s
CI / cargo fmt (pull_request) Successful in 5s
CI / cargo deny (pull_request) Successful in 1m33s
CI / cargo deny advisories (pull_request) Failing after 58s
CI / repository boundary (pull_request) Successful in 5s
CI / cargo clippy (pull_request) Successful in 9m57s
CI / cargo test (pull_request) Successful in 10m33s
CI / frontend-web (pull_request) Successful in 9m46s
CI / CI (pull_request) Successful in 9s
CI / Notify gate failed (pull_request) Has been skipped
67759b8791
GRI-1873: pin server's tokio-tungstenite dev-dependency to 0.28 (match client)
Some checks failed
CI / the pre-push hook (pull_request) Successful in 4s
CI / cargo fmt (pull_request) Successful in 4s
CI / cargo deny (pull_request) Successful in 52s
CI / cargo deny advisories (pull_request) Failing after 44s
CI / repository boundary (pull_request) Successful in 5s
CI / cargo clippy (pull_request) Successful in 9m52s
CI / cargo test (pull_request) Successful in 10m29s
CI / frontend-web (pull_request) Successful in 9m46s
CI / CI (pull_request) Successful in 3s
CI / Notify gate failed (pull_request) Has been skipped
ff70a27b02
Merge pull request 'GRI-1856: media acceptance tests (AC-3-01..AC-3-07)' (#100) from test/GRI-1856-media-acceptance-tests into dev
Some checks failed
CI / the pre-push hook (push) Successful in 5s
CI / cargo fmt (push) Successful in 5s
CI / cargo deny (push) Successful in 1m21s
CI / cargo deny advisories (push) Failing after 1m29s
CI / repository boundary (push) Successful in 11s
CI / cargo clippy (push) Successful in 10m25s
CI / cargo test (push) Successful in 10m52s
CI / frontend-web (push) Successful in 10m25s
CI / CI (push) Successful in 4s
CI / Notify gate failed (push) Has been skipped
7b3727cd4f
Merge pull request 'GRI-1868: PDF to page images via pdftoppm' (#97) from feature/GRI-1868-pdf-pages into dev
Some checks failed
CI / the pre-push hook (push) Successful in 6s
CI / cargo fmt (push) Successful in 10s
CI / cargo deny (push) Failing after 2m27s
CI / cargo deny advisories (push) Failing after 1m38s
CI / repository boundary (push) Successful in 7s
CI / cargo clippy (push) Successful in 10m24s
CI / cargo test (push) Successful in 10m48s
CI / frontend-web (push) Successful in 10m29s
CI / CI (push) Failing after 7s
CI / Notify gate failed (push) Has been skipped
8c5c32f4bd
Merge origin/dev (#97 PDF) into feature/GRI-1873-enrolment-websocket
Some checks failed
CI / the pre-push hook (pull_request) Successful in 6s
CI / cargo fmt (pull_request) Successful in 6s
CI / cargo deny (pull_request) Successful in 48s
CI / cargo deny advisories (pull_request) Failing after 53s
CI / repository boundary (pull_request) Successful in 13s
CI / cargo clippy (pull_request) Successful in 10m7s
CI / cargo test (pull_request) Successful in 10m31s
CI / frontend-web (pull_request) Successful in 9m54s
CI / CI (pull_request) Successful in 4s
CI / Notify gate failed (pull_request) Has been skipped
af2318952a
Merge remote-tracking branch 'origin/dev' into feature/GRI-1874-signage-playlists
Some checks failed
CI / the pre-push hook (pull_request) Successful in 5s
CI / cargo fmt (pull_request) Successful in 5s
CI / cargo deny (pull_request) Successful in 54s
CI / cargo deny advisories (pull_request) Failing after 54s
CI / repository boundary (pull_request) Successful in 19s
CI / cargo clippy (pull_request) Successful in 10m7s
CI / cargo test (pull_request) Successful in 10m39s
CI / frontend-web (pull_request) Successful in 9m46s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 3s
a96ae90aab
# Conflicts:
#	crates/server/Cargo.toml
#	crates/server/src/lib.rs
Merge pull request 'GRI-1874: signage playlists (#16)' (#99) from feature/GRI-1874-signage-playlists into dev
Some checks failed
CI / cargo fmt (push) Successful in 7s
CI / the pre-push hook (push) Successful in 8s
CI / cargo deny (push) Successful in 1m15s
CI / cargo deny advisories (push) Failing after 1m15s
CI / repository boundary (push) Successful in 7s
CI / cargo clippy (push) Successful in 10m12s
CI / cargo test (push) Successful in 10m51s
CI / frontend-web (push) Successful in 9m57s
CI / CI (push) Successful in 3s
CI / Notify gate failed (push) Has been skipped
270975b29c
GRI-1873: merge dev (playlists #99) into enrolment
Some checks failed
CI / the pre-push hook (pull_request) Successful in 15s
CI / cargo fmt (pull_request) Successful in 5s
CI / cargo test (pull_request) Has been cancelled
CI / cargo deny (pull_request) Has been cancelled
CI / cargo deny advisories (pull_request) Has been cancelled
CI / frontend-web (pull_request) Has been cancelled
CI / repository boundary (pull_request) Has been cancelled
CI / CI (pull_request) Has been cancelled
CI / Notify gate failed (pull_request) Has been cancelled
CI / cargo clippy (pull_request) Has been cancelled
10dd2445ca
GRI-1873: register ws connections in DeviceConnections on admission
Some checks failed
CI / the pre-push hook (pull_request) Successful in 13s
CI / cargo fmt (pull_request) Successful in 6s
CI / cargo deny (pull_request) Successful in 1m0s
CI / cargo deny advisories (pull_request) Failing after 1m21s
CI / repository boundary (pull_request) Successful in 6s
CI / cargo clippy (pull_request) Successful in 10m7s
CI / cargo test (pull_request) Successful in 10m55s
CI / frontend-web (pull_request) Successful in 9m57s
CI / CI (pull_request) Successful in 4s
CI / Notify gate failed (pull_request) Has been skipped
59ab7e80e7
The device WebSocket handler now registers each Admission::Registered
device's sender in DeviceConnections and forwards pushed ServerControl
messages for the lifetime of the connection, unregistering on close.
Closes the gap connections.rs's own module doc called out: until now
playlists::handlers::assign_playlist's push always found nobody
listening.
GRI-1856: cargo fmt
Some checks failed
CI / the pre-push hook (pull_request) Successful in 11s
CI / cargo fmt (pull_request) Successful in 11s
CI / cargo deny (pull_request) Successful in 1m44s
CI / cargo deny advisories (pull_request) Failing after 1m24s
CI / repository boundary (pull_request) Successful in 7s
CI / cargo clippy (pull_request) Successful in 10m18s
CI / cargo test (pull_request) Successful in 10m56s
CI / frontend-web (pull_request) Successful in 10m19s
CI / CI (pull_request) Successful in 5s
CI / Notify gate failed (pull_request) Has been skipped
4a1f648198
Merge pull request 'GRI-1873: enrolment over WebSocket (signage #12)' (#94) from feature/GRI-1873-enrolment-websocket into dev
Some checks failed
CI / the pre-push hook (push) Successful in 5s
CI / cargo fmt (push) Successful in 5s
CI / cargo deny (push) Failing after 2m34s
CI / cargo deny advisories (push) Failing after 1m31s
CI / repository boundary (push) Successful in 6s
CI / cargo clippy (push) Successful in 10m32s
CI / cargo test (push) Successful in 11m10s
CI / frontend-web (push) Successful in 10m16s
CI / CI (push) Failing after 3s
CI / Notify gate failed (push) Has been skipped
879eda38b5
Merge pull request 'GRI-1856: independent acceptance tests for playlist routes' (#101) from test/GRI-1856-playlist-acceptance-tests into dev
Some checks failed
CI / the pre-push hook (push) Successful in 12s
CI / cargo fmt (push) Successful in 18s
CI / cargo deny (push) Successful in 49s
CI / cargo deny advisories (push) Failing after 47s
CI / repository boundary (push) Successful in 6s
CI / cargo clippy (push) Successful in 10m2s
CI / cargo test (push) Successful in 11m0s
CI / frontend-web (push) Successful in 9m38s
CI / CI (push) Successful in 3s
CI / Notify gate failed (push) Has been skipped
1e8c190e4f
GRI-1856: independent acceptance tests for enrolment over WebSocket
Some checks failed
CI / the pre-push hook (pull_request) Successful in 5s
CI / cargo fmt (pull_request) Successful in 5s
CI / cargo deny (pull_request) Successful in 54s
CI / cargo deny advisories (pull_request) Failing after 49s
CI / repository boundary (pull_request) Successful in 5s
CI / cargo clippy (pull_request) Successful in 9m47s
CI / cargo test (pull_request) Successful in 10m52s
CI / frontend-web (pull_request) Successful in 9m45s
CI / CI (pull_request) Successful in 4s
CI / Notify gate failed (pull_request) Has been skipped
8ad3840700
GRI-1873: devices and IP rules API (signage #13)
Some checks failed
CI / the pre-push hook (pull_request) Successful in 4s
CI / cargo fmt (pull_request) Successful in 5s
CI / cargo deny (pull_request) Successful in 45s
CI / cargo deny advisories (pull_request) Failing after 45s
CI / cargo test (pull_request) Failing after 5m49s
CI / repository boundary (pull_request) Successful in 5s
CI / cargo clippy (pull_request) Successful in 9m55s
CI / frontend-web (pull_request) Successful in 9m41s
CI / CI (pull_request) Failing after 5s
CI / Notify gate failed (pull_request) Successful in 5s
c072a3a04f
Merge remote-tracking branch 'origin/dev' into feature/GRI-1873-devices-ip-rules-api
Some checks failed
CI / cargo fmt (pull_request) Successful in 7s
CI / the pre-push hook (pull_request) Successful in 8s
CI / cargo test (pull_request) Failing after 5m50s
CI / cargo deny advisories (pull_request) Failing after 2m18s
CI / repository boundary (pull_request) Successful in 6s
CI / cargo deny (pull_request) Failing after 2m34s
CI / cargo clippy (pull_request) Successful in 10m7s
CI / frontend-web (pull_request) Successful in 9m49s
CI / CI (pull_request) Failing after 4s
CI / Notify gate failed (pull_request) Successful in 6s
b5a63ab0fd
Merge pull request 'GRI-1856: independent acceptance tests for enrolment over WebSocket' (#102) from test/GRI-1856-enrolment-acceptance-tests into dev
Some checks failed
CI / cargo fmt (push) Successful in 8s
CI / the pre-push hook (push) Successful in 8s
CI / cargo deny (push) Successful in 1m30s
CI / cargo deny advisories (push) Failing after 1m9s
CI / repository boundary (push) Successful in 6s
CI / cargo clippy (push) Successful in 10m12s
CI / cargo test (push) Successful in 11m19s
CI / frontend-web (push) Successful in 9m51s
CI / CI (push) Successful in 4s
CI / Notify gate failed (push) Has been skipped
CI / the pre-push hook (pull_request) Successful in 15s
CI / cargo fmt (pull_request) Successful in 14s
CI / cargo deny (pull_request) Failing after 2m19s
CI / cargo deny advisories (pull_request) Failing after 2m26s
CI / repository boundary (pull_request) Successful in 6s
CI / cargo clippy (pull_request) Successful in 10m23s
CI / cargo test (pull_request) Successful in 10m59s
CI / CI (pull_request) Has been cancelled
CI / Notify gate failed (pull_request) Has been cancelled
CI / frontend-web (pull_request) Has been cancelled
a0ee4fac0b
ip_address::text rendered an inet as CIDR (e.g. 203.0.113.5/32), which
IpAddr::from_str rejects, so row_to_device always read ip_address as
None and the blocklist insert on block_device was silently skipped.
Merge origin/dev into feature/GRI-1873-devices-ip-rules-api
Some checks failed
CI / cargo fmt (pull_request) Successful in 8s
CI / the pre-push hook (pull_request) Successful in 8s
CI / cargo deny advisories (pull_request) Failing after 1m12s
CI / cargo deny (pull_request) Successful in 1m15s
CI / repository boundary (pull_request) Successful in 6s
CI / cargo clippy (pull_request) Successful in 10m7s
CI / frontend-web (pull_request) Successful in 9m43s
CI / cargo test (pull_request) Successful in 11m22s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 3s
585ca9ff34
Merge pull request 'GRI-1873: devices and IP rules API (signage #13)' (#103) from feature/GRI-1873-devices-ip-rules-api into dev
Some checks failed
CI / cargo fmt (push) Successful in 11s
CI / the pre-push hook (push) Successful in 11s
CI / cargo deny advisories (push) Failing after 2m20s
CI / cargo deny (push) Successful in 3m8s
CI / repository boundary (push) Successful in 6s
CI / cargo clippy (push) Successful in 10m14s
CI / cargo test (push) Successful in 11m19s
CI / frontend-web (push) Successful in 10m18s
CI / CI (push) Successful in 7s
CI / Notify gate failed (push) Has been skipped
6ff9c3f6eb
GRI-1877: wire PDF upload to the page converter (signage #15b)
Some checks failed
CI / the pre-push hook (pull_request) Successful in 8s
CI / cargo fmt (pull_request) Successful in 8s
CI / cargo deny (pull_request) Successful in 44s
CI / cargo deny advisories (pull_request) Failing after 45s
CI / repository boundary (pull_request) Successful in 5s
CI / cargo clippy (pull_request) Successful in 10m17s
CI / cargo test (pull_request) Successful in 11m3s
CI / frontend-web (pull_request) Successful in 9m43s
CI / CI (pull_request) Successful in 3s
CI / Notify gate failed (pull_request) Has been skipped
dfd75a4e5a
GRI-1876: deployment note, one server behind a reverse proxy, many campuses
Some checks failed
CI / the pre-push hook (pull_request) Successful in 5s
CI / cargo fmt (pull_request) Successful in 5s
CI / cargo deny (pull_request) Successful in 44s
CI / cargo deny advisories (pull_request) Failing after 44s
CI / repository boundary (pull_request) Successful in 6s
CI / cargo clippy (pull_request) Successful in 9m50s
CI / cargo test (pull_request) Successful in 11m1s
CI / frontend-web (pull_request) Successful in 9m44s
CI / CI (pull_request) Successful in 3s
CI / Notify gate failed (pull_request) Has been skipped
f45b8a13d0
GRI-1856: independent acceptance test for pending-device list surface (AC-2-11)
Some checks failed
CI / the pre-push hook (pull_request) Successful in 5s
CI / cargo fmt (pull_request) Successful in 5s
CI / cargo deny (pull_request) Successful in 42s
CI / cargo deny advisories (pull_request) Failing after 55s
CI / repository boundary (pull_request) Successful in 6s
CI / cargo clippy (pull_request) Successful in 9m56s
CI / cargo test (pull_request) Successful in 11m23s
CI / frontend-web (pull_request) Successful in 10m2s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 4s
dc545e688a
Merge pull request 'GRI-1876: deployment note, one server behind a reverse proxy, many campuses' (#105) from docs/GRI-1876-deployment-note into dev
Some checks failed
CI / cargo fmt (push) Successful in 11s
CI / the pre-push hook (push) Successful in 11s
CI / cargo deny (push) Successful in 49s
CI / cargo deny advisories (push) Failing after 45s
CI / cargo clippy (push) Successful in 10m21s
CI / repository boundary (push) Successful in 10s
CI / cargo test (push) Successful in 11m14s
CI / frontend-web (push) Successful in 9m43s
CI / CI (push) Successful in 3s
CI / Notify gate failed (push) Has been skipped
2cfb83a0a0
Merge pull request 'GRI-1877: wire PDF upload to the page converter (signage #15b)' (#106) from feature/GRI-1877-pdf-upload-wiring into dev
Some checks failed
CI / the pre-push hook (push) Successful in 8s
CI / cargo fmt (push) Successful in 7s
CI / cargo deny (push) Successful in 1m23s
CI / cargo deny advisories (push) Failing after 2m34s
CI / repository boundary (push) Successful in 6s
CI / cargo clippy (push) Successful in 10m9s
CI / cargo test (push) Successful in 11m4s
CI / frontend-web (push) Successful in 10m5s
CI / CI (push) Successful in 3s
CI / Notify gate failed (push) Has been skipped
9141699c2a
Merge pull request 'GRI-1856: independent acceptance test for pending-device list surface (AC-2-11)' (#107) from test/GRI-1856-devices-pending-acceptance into dev
Some checks failed
CI / the pre-push hook (push) Successful in 6s
CI / cargo fmt (push) Successful in 5s
CI / cargo deny advisories (push) Failing after 1m27s
CI / cargo deny (push) Successful in 2m31s
CI / cargo clippy (push) Successful in 10m21s
CI / repository boundary (push) Successful in 6s
CI / cargo test (push) Successful in 11m1s
CI / frontend-web (push) Successful in 10m3s
CI / CI (push) Successful in 3s
CI / Notify gate failed (push) Has been skipped
5daa329cb8
GRI-1856: correct AC-3-03 ignore reason to missing poppler-utils
Some checks failed
CI / the pre-push hook (pull_request) Successful in 5s
CI / cargo fmt (pull_request) Successful in 7s
CI / cargo deny (pull_request) Successful in 48s
CI / cargo deny advisories (pull_request) Failing after 53s
CI / repository boundary (pull_request) Successful in 5s
CI / cargo clippy (pull_request) Successful in 10m1s
CI / cargo test (pull_request) Successful in 11m5s
CI / frontend-web (pull_request) Successful in 9m50s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 3s
e1e75d2e04
PDF upload is now wired to the page converter (GRI-1877/signage #15b landed).
The test still can't run, but for a different reason: pdftoppm (poppler-utils)
isn't on this host/CI image, so render_pages fails before the page-splitting
logic under test ever runs. Production's Dockerfile already installs it.
Merge pull request 'GRI-1856: correct AC-3-03 ignore reason to missing poppler-utils' (#108) from test/GRI-1856-pdf-page-acceptance into dev
Some checks failed
CI / cargo fmt (push) Successful in 11s
CI / the pre-push hook (push) Successful in 15s
CI / cargo deny advisories (push) Failing after 1m24s
CI / cargo deny (push) Successful in 1m47s
CI / repository boundary (push) Successful in 6s
CI / cargo clippy (push) Successful in 10m28s
CI / cargo test (push) Successful in 11m19s
CI / frontend-web (push) Successful in 11m0s
CI / Notify gate failed (push) Has been skipped
CI / CI (push) Successful in 3s
e7c82bd755
GRI-1856: independent acceptance test for AC-5-06 (UpdateRequired on unsupported protocol version)
Some checks failed
CI / the pre-push hook (pull_request) Successful in 9s
CI / cargo fmt (pull_request) Successful in 10s
CI / cargo deny (pull_request) Successful in 2m24s
CI / cargo deny advisories (pull_request) Failing after 2m44s
CI / cargo clippy (pull_request) Successful in 10m16s
CI / repository boundary (pull_request) Successful in 11s
CI / cargo test (pull_request) Successful in 11m29s
CI / frontend-web (pull_request) Successful in 10m2s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 4s
7d0ffabdbe
Merge pull request 'GRI-1856: independent acceptance test for AC-5-06 (UpdateRequired)' (#109) from test/GRI-1856-handshake-protocol-version-acceptance into dev
Some checks failed
CI / cargo fmt (push) Successful in 8s
CI / the pre-push hook (push) Successful in 16s
CI / cargo deny (push) Successful in 54s
CI / cargo deny advisories (push) Failing after 51s
CI / cargo clippy (push) Successful in 10m1s
CI / repository boundary (push) Successful in 10s
CI / cargo test (push) Successful in 11m11s
CI / frontend-web (push) Successful in 11m19s
CI / Notify gate failed (push) Has been skipped
CI / CI (push) Successful in 4s
afc5d956c0
GRI-1856: defer AC-2-12, AC-3-02, AC-5-07 past the MVP
Some checks failed
CI / the pre-push hook (pull_request) Successful in 7s
CI / cargo fmt (pull_request) Successful in 7s
CI / cargo clippy (pull_request) Successful in 10m18s
CI / cargo deny (pull_request) Successful in 42s
CI / cargo test (pull_request) Successful in 11m14s
CI / cargo deny advisories (pull_request) Failing after 52s
CI / repository boundary (pull_request) Successful in 7s
CI / frontend-web (pull_request) Successful in 10m1s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 3s
c834073c94
GRI-1880: apply blocklist_applies_to_registered in the pre-upgrade blocklist check
Some checks failed
CI / the pre-push hook (pull_request) Successful in 6s
CI / cargo fmt (pull_request) Successful in 6s
CI / cargo clippy (pull_request) Successful in 10m4s
CI / cargo test (pull_request) Successful in 11m6s
CI / repository boundary (pull_request) Successful in 5s
CI / cargo deny advisories (pull_request) Failing after 2m30s
CI / cargo deny (pull_request) Failing after 2m30s
CI / frontend-web (pull_request) Successful in 10m5s
CI / CI (pull_request) Failing after 5s
CI / Notify gate failed (pull_request) Successful in 4s
2238883fd2
ws::upgrade dropped a blocklisted registered device with 403 before the
upgrade even when the server setting was off, because its rules came from
load_admission_rules, which hardcodes blocklist_applies_to_registered: true.
handle_socket already applied the real setting after the upgrade, but by
then the connection was never reached. Apply the setting at the pre-upgrade
check too, as it already is after the upgrade.
GRI-1880: retrigger CI (cargo deny showed a transient failure unrelated to this change)
Some checks failed
CI / the pre-push hook (pull_request) Successful in 6s
CI / cargo deny (pull_request) Successful in 46s
CI / cargo deny advisories (pull_request) Failing after 40s
CI / repository boundary (pull_request) Successful in 8s
CI / cargo clippy (pull_request) Successful in 9m55s
CI / cargo fmt (pull_request) Failing after 10m44s
CI / frontend-web (pull_request) Successful in 9m51s
CI / cargo test (pull_request) Successful in 11m6s
CI / Notify gate failed (pull_request) Successful in 3s
CI / CI (pull_request) Failing after 4s
42115fea5b
GRI-1880: retrigger CI (cargo fmt failed after 10m44s, consistent with runner contention, not a real fmt diff)
Some checks failed
CI / the pre-push hook (pull_request) Successful in 6s
CI / cargo fmt (pull_request) Successful in 7s
CI / cargo clippy (pull_request) Successful in 10m1s
CI / cargo deny (pull_request) Successful in 40s
CI / cargo test (pull_request) Successful in 11m17s
CI / cargo deny advisories (pull_request) Failing after 43s
CI / repository boundary (pull_request) Successful in 14s
CI / frontend-web (pull_request) Successful in 9m51s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 3s
d0fec86236
Merge pull request 'GRI-1880: fix pre-upgrade blocklist check ignoring blocklist_applies_to_registered setting' (#112) from fix/GRI-1880-blocklist-off-ignored-pre-upgrade into dev
Some checks failed
CI / the pre-push hook (push) Successful in 7s
CI / cargo fmt (push) Successful in 8s
CI / cargo deny advisories (push) Failing after 1m7s
CI / cargo deny (push) Successful in 1m9s
CI / repository boundary (push) Successful in 14s
CI / cargo clippy (push) Successful in 10m2s
CI / frontend-web (push) Successful in 9m52s
CI / cargo test (push) Successful in 11m14s
CI / Notify gate failed (push) Has been skipped
CI / CI (push) Successful in 6s
6554d98e53
Merge pull request 'GRI-1856: defer AC-2-12, AC-3-02, AC-5-07 past the MVP' (#111) from docs/GRI-1856-defer-post-mvp-acceptance-criteria into dev
Some checks failed
CI / the pre-push hook (push) Successful in 7s
CI / cargo fmt (push) Successful in 11s
CI / cargo deny (push) Successful in 2m2s
CI / cargo deny advisories (push) Failing after 2m34s
CI / repository boundary (push) Successful in 10s
CI / cargo clippy (push) Successful in 10m14s
CI / cargo test (push) Successful in 11m26s
CI / frontend-web (push) Successful in 9m48s
CI / Notify gate failed (push) Has been skipped
CI / CI (push) Successful in 4s
cd02e964a0
GRI-1886: serve the built panel from the server binary and the image
Some checks failed
CI / cargo fmt (pull_request) Successful in 9s
CI / the pre-push hook (pull_request) Successful in 11s
CI / cargo deny (pull_request) Successful in 1m42s
CI / cargo deny advisories (pull_request) Failing after 1m48s
CI / repository boundary (pull_request) Successful in 14s
CI / CI (pull_request) Has been cancelled
CI / Notify gate failed (pull_request) Has been cancelled
CI / frontend-web (pull_request) Has been cancelled
CI / cargo clippy (pull_request) Successful in 10m40s
CI / cargo test (pull_request) Successful in 11m57s
b04640cbef
crates/server now serves frontend-web's build at /, with an SPA fallback
to index.html for any path router() does not otherwise match. The panel
directory is configurable (SIGNAGE_PANEL_DIRECTORY, default
/usr/local/share/grimoire-signage/panel) and kept out of the admin's
persistent volume since it is build output, not state.

packaging/server/Dockerfile gains a node build stage for frontend-web and
bakes dist/ into the image; scripts/package-server-image.sh reads
NODE_VERSION from .nvmrc the same way it already reads RUST_VERSION from
rust-toolchain.toml. deployment.md documents both the Docker and systemd
paths.
GRI-1885: write the MVP smoke-test checklist and automation script
Some checks failed
CI / the pre-push hook (pull_request) Successful in 6s
CI / cargo fmt (pull_request) Successful in 5s
CI / cargo clippy (pull_request) Successful in 10m25s
CI / cargo deny (pull_request) Failing after 3m0s
CI / repository boundary (pull_request) Successful in 7s
CI / cargo deny advisories (pull_request) Failing after 2m47s
CI / cargo test (pull_request) Successful in 11m42s
CI / frontend-web (pull_request) Successful in 9m49s
CI / CI (pull_request) Failing after 8s
CI / Notify gate failed (pull_request) Successful in 7s
f22b38e4a4
Forge #115. Writes the 5-step checklist (docs/mvp-smoke-test.md) and the
companion script (scripts/mvp-smoke-test.sh) that automates everything in
it that does not need a human eye on a browser: build and start the
packaged server, create the first user and log in by API, build and run
the real grimoirix-signage-client under Xvfb, approve it once pending,
generate one small real .mp4 with gst-launch-1.0 plus a test image, upload
both, build and assign a playlist, and confirm playback and a live
playlist change from the client's own log.

Not run end to end yet: the panel half of step 2 needs #113/#114, and this
build host's agent accounts have no docker group access to build or start
the container.
GRI-1886: make the Compose database a config choice, not a file edit
Some checks failed
CI / the pre-push hook (pull_request) Successful in 5s
CI / cargo fmt (pull_request) Successful in 5s
CI / cargo deny (pull_request) Failing after 2m46s
CI / cargo deny advisories (pull_request) Failing after 2m46s
CI / repository boundary (pull_request) Successful in 7s
CI / cargo clippy (pull_request) Successful in 10m41s
CI / cargo test (pull_request) Successful in 11m57s
CI / frontend-web (pull_request) Successful in 10m15s
CI / CI (pull_request) Failing after 3s
CI / Notify gate failed (pull_request) Successful in 3s
8d4ff87039
db sits behind the bundled-db profile, on by default via .env.example;
server's depends_on is required: false so it runs without it.
SIGNAGE_DATABASE_URL defaults to the bundled form when unset, letting
an external url override it without touching docker-compose.yml.
GRI-1887: wire the panel's five API modules to the real server
Some checks failed
CI / the pre-push hook (pull_request) Successful in 7s
CI / cargo fmt (pull_request) Successful in 9s
CI / cargo deny advisories (pull_request) Has been cancelled
CI / frontend-web (pull_request) Has been cancelled
CI / repository boundary (pull_request) Has been cancelled
CI / CI (pull_request) Has been cancelled
CI / Notify gate failed (pull_request) Has been cancelled
CI / cargo deny (pull_request) Successful in 4m8s
CI / cargo clippy (pull_request) Successful in 10m52s
CI / cargo test (pull_request) Successful in 11m40s
9365bbdfea
Flip USE_MOCK to false in sessionApi, devicesApi, ipRulesApi, mediaApi and
playlistsApi (the switch now resolves to the mock only under vitest, via
import.meta.env.MODE, so the QA suite keeps exercising the mock without a
hardcoded flag). The http* implementations guessed the server's wire shape
against a draft plan doc before the real routes existed; adjust them to the
merged server contract instead, which uses snake_case fields and a narrower
Device/MediaItem/PlaylistItem shape than the mock's. Device drops
lastSeenAt/assignedPlaylist (the server exposes neither); MediaItem's PDF
page numbers are now derived from a single upload response's row order,
the only place that order is ever available; PlaylistItem's human-readable
name and wire `kind` are resolved against the media library, since the
playlist item itself carries only media_id.

Remove the stale "not wired yet" section of deployment.md (PR #103 merged
this).

Known gaps, left for follow-up rather than guessed at here:
- The server's setup/login routes require email+name (its users table has
  no username column at all), but the panel's Setup/Login screens and
  App.test.tsx model a username-only account — matching the plan doc's own
  "username and password" line, which the server never implemented. Wiring
  sessionApi fully needs that resolved first; left unflipped in practice
  until then (getSetupStatus's needs_setup/firstUserExists inversion is
  fixed, since that needs no shape decision).
- PDF upload fails server-side: convert_pdf_upload removes its render
  directory before reading the rendered page bytes out of it, so every
  upload 500s after rendering successfully. Reproduced by hand.
GRI-1887: replace USE_MOCK with a VITE_API_MODE env flag
Some checks failed
CI / the pre-push hook (pull_request) Successful in 10s
CI / cargo fmt (pull_request) Successful in 8s
CI / cargo deny (pull_request) Successful in 1m44s
CI / cargo deny advisories (pull_request) Failing after 2m22s
CI / repository boundary (pull_request) Successful in 13s
CI / cargo clippy (pull_request) Successful in 10m4s
CI / cargo test (pull_request) Successful in 11m28s
CI / frontend-web (pull_request) Successful in 10m57s
CI / CI (pull_request) Successful in 10s
CI / Notify gate failed (pull_request) Has been skipped
8efced905f
Scope change from the product owner: no hard-coded mock switch. All five
API modules now read apiMode from src/api/mode.ts, which resolves to
'mock' under vitest (MODE === 'test', unconditionally) or when
VITE_API_MODE=mock is set, and to 'http' otherwise. Confirmed by building
both ways and grepping dist/ for mock-only fixture strings (mock-admin,
lobby-screen, cafe-south): present in a --mode mock build, absent from a
default production build — Rollup's cross-module constant folding drops
the mock import entirely once apiMode is statically known.

vite.config.ts proxies /api to VITE_DEV_API_TARGET when that env var is
set, so a dev panel can talk to a real server while keeping requests
same-origin (the session cookie needs that). package.json gets a
dev:mock script (vite --mode mock, loading .env.mock) alongside the
existing dev. .env.example documents both variables for
.env.development.local.
GRI-1885: retrigger CI (cargo deny / cargo deny advisories failed with no dependency change on this branch; dev's own tip is green)
Some checks failed
CI / the pre-push hook (pull_request) Successful in 8s
CI / cargo fmt (pull_request) Successful in 8s
CI / cargo deny (pull_request) Successful in 1m12s
CI / cargo deny advisories (pull_request) Failing after 4m34s
CI / repository boundary (pull_request) Successful in 19s
CI / frontend-web (pull_request) Successful in 9m55s
CI / cargo clippy (pull_request) Successful in 11m39s
CI / cargo test (pull_request) Successful in 11m42s
CI / CI (pull_request) Successful in 2s
CI / Notify gate failed (pull_request) Has been skipped
7685dfa10e
GRI-1886: retrigger CI (cargo deny passes locally; investigating CI-only failure)
Some checks failed
CI / the pre-push hook (pull_request) Successful in 11s
CI / cargo fmt (pull_request) Successful in 11s
CI / cargo deny advisories (pull_request) Failing after 2m29s
CI / cargo deny (pull_request) Failing after 2m34s
CI / repository boundary (pull_request) Successful in 6s
CI / cargo clippy (pull_request) Successful in 11m1s
CI / cargo test (pull_request) Successful in 12m4s
CI / frontend-web (pull_request) Successful in 11m7s
CI / Notify gate failed (pull_request) Successful in 4s
CI / CI (pull_request) Failing after 4s
c1c8fb9d17
Merge pull request 'GRI-1887: wire the panel's five API modules to the real server' (#118) from feature/GRI-1887-panel-live-api into dev
Some checks failed
CI / the pre-push hook (push) Successful in 7s
CI / cargo fmt (push) Successful in 5s
CI / cargo deny (push) Failing after 2m41s
CI / cargo clippy (push) Successful in 10m56s
CI / repository boundary (push) Successful in 6s
CI / cargo deny advisories (push) Failing after 2m48s
CI / cargo test (push) Successful in 12m7s
CI / frontend-web (push) Successful in 11m2s
CI / CI (push) Failing after 3s
CI / Notify gate failed (push) Has been skipped
21c3747fc4
Merge pull request 'GRI-1885: write the MVP smoke-test checklist and script' (#117) from test/GRI-1885-mvp-smoke-test into dev
Some checks failed
CI / the pre-push hook (push) Successful in 7s
CI / cargo fmt (push) Successful in 6s
CI / cargo deny (push) Failing after 2m24s
CI / cargo deny advisories (push) Failing after 2m55s
CI / repository boundary (push) Successful in 6s
CI / cargo clippy (push) Successful in 11m26s
CI / cargo test (push) Successful in 12m28s
CI / frontend-web (push) Successful in 11m2s
CI / Notify gate failed (push) Has been skipped
CI / CI (push) Failing after 3s
0d7a7eaf8d
GRI-1761: run cargo deny on the action image's Rust, not a 109 MB toolchain download
Some checks failed
CI / the pre-push hook (pull_request) Successful in 6s
CI / cargo fmt (pull_request) Successful in 7s
CI / cargo deny advisories (pull_request) Failing after 1m5s
CI / cargo deny (pull_request) Successful in 1m58s
CI / repository boundary (pull_request) Successful in 5s
CI / frontend-web (pull_request) Successful in 9m50s
CI / cargo clippy (pull_request) Successful in 12m3s
CI / cargo test (pull_request) Successful in 13m6s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 3s
536cf57cf3
The action's entrypoint installs the toolchain from rust-toolchain.toml
before it runs. On a slow link that download times out after ~2.5 minutes
and both deny jobs go red with no code change, as on every commit since
18:44 UTC on 2026-11-10. cargo-deny only needs cargo metadata, which the
image's own Rust 1.85.0 provides. Reproduced and verified with the action's
Dockerfile on this host.
Merge pull request 'GRI-1761: run cargo deny without downloading the pinned toolchain' (#119) from fix/GRI-1761-deny-without-toolchain-download into dev
Some checks failed
CI / cargo fmt (push) Successful in 11s
CI / cargo deny (push) Successful in 53s
CI / cargo deny advisories (push) Failing after 49s
CI / repository boundary (push) Successful in 6s
CI / cargo clippy (push) Successful in 10m43s
CI / frontend-web (push) Successful in 10m0s
CI / cargo test (push) Successful in 11m59s
CI / the pre-push hook (push) Failing after 14m48s
CI / CI (push) Has been cancelled
CI / Notify gate failed (push) Has been cancelled
d323b98d7e
Merge branch 'dev' into feature/GRI-1886-serve-panel-from-server
Some checks failed
CI / the pre-push hook (pull_request) Successful in 5s
CI / cargo fmt (pull_request) Successful in 5s
CI / cargo deny (pull_request) Successful in 29s
CI / cargo clippy (pull_request) Successful in 11m8s
CI / cargo deny advisories (pull_request) Failing after 1m51s
CI / repository boundary (pull_request) Successful in 7s
CI / frontend-web (pull_request) Successful in 10m28s
CI / cargo test (pull_request) Successful in 11m42s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 3s
3fd26f127f
Merge pull request 'GRI-1886: serve the built panel from the server binary and the image' (#116) from feature/GRI-1886-serve-panel-from-server into dev
Some checks failed
CI / the pre-push hook (push) Successful in 11s
CI / cargo fmt (push) Successful in 12s
CI / cargo deny (push) Successful in 1m15s
CI / cargo deny advisories (push) Failing after 1m16s
CI / repository boundary (push) Successful in 6s
CI / cargo clippy (push) Successful in 10m32s
CI / frontend-web (push) Successful in 10m29s
CI / cargo test (push) Successful in 12m4s
CI / Notify gate failed (push) Has been skipped
CI / CI (push) Successful in 3s
4734441106
GRI-1885: drop stale #113/#114-pending and docker-group wording
Some checks failed
CI / the pre-push hook (pull_request) Successful in 16s
CI / cargo fmt (pull_request) Successful in 16s
CI / cargo deny advisories (pull_request) Failing after 1m7s
CI / cargo deny (pull_request) Successful in 1m8s
CI / repository boundary (pull_request) Successful in 7s
CI / cargo clippy (pull_request) Successful in 10m14s
CI / cargo test (pull_request) Successful in 12m3s
CI / frontend-web (pull_request) Successful in 15m2s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 4s
455c218336
Both landed in dev. The docker-group check also no longer matches the
rootless-docker path GRI-1904 is provisioning instead.
GRI-1906: invalidate the dummy-build cache for shared and client before the real sources land
Some checks failed
CI / the pre-push hook (pull_request) Successful in 10s
CI / cargo fmt (pull_request) Successful in 10s
CI / cargo deny (pull_request) Successful in 27s
CI / cargo deny advisories (pull_request) Failing after 35s
CI / repository boundary (pull_request) Successful in 7s
CI / cargo clippy (pull_request) Successful in 10m3s
CI / frontend-web (pull_request) Successful in 10m2s
CI / cargo test (pull_request) Successful in 11m26s
CI / CI (pull_request) Successful in 3s
CI / Notify gate failed (pull_request) Has been skipped
409474ddf1
Merge pull request 'GRI-1885: drop stale #113/#114-pending and docker-group wording' (#120) from docs/GRI-1885-unblock-deps-note into dev
Some checks failed
CI / the pre-push hook (push) Successful in 13s
CI / cargo fmt (push) Successful in 5s
CI / cargo deny (push) Successful in 31s
CI / cargo deny advisories (push) Failing after 49s
CI / repository boundary (push) Successful in 14s
CI / cargo clippy (push) Successful in 10m2s
CI / cargo test (push) Successful in 11m16s
CI / frontend-web (push) Successful in 10m6s
CI / Notify gate failed (push) Has been skipped
CI / CI (push) Successful in 3s
457c26bc6b
Merge pull request 'GRI-1906: invalidate dummy-build cargo cache for shared/client in server Dockerfile' (#121) from fix/GRI-1906-docker-shared-cache into dev
Some checks failed
CI / the pre-push hook (push) Successful in 9s
CI / cargo fmt (push) Successful in 9s
CI / cargo deny (push) Successful in 1m22s
CI / cargo deny advisories (push) Failing after 1m21s
CI / repository boundary (push) Successful in 29s
CI / cargo clippy (push) Successful in 10m9s
CI / cargo test (push) Successful in 11m31s
CI / frontend-web (push) Successful in 10m17s
CI / Notify gate failed (push) Has been skipped
CI / CI (push) Successful in 3s
bb58677f94
GRI-1907: the README is for users — Docker and native install for server and client; contributor material moves to CONTRIBUTING.md
Some checks failed
CI / the pre-push hook (pull_request) Successful in 11s
CI / cargo fmt (pull_request) Successful in 10s
CI / cargo deny (pull_request) Successful in 59s
CI / cargo deny advisories (pull_request) Failing after 58s
CI / cargo clippy (pull_request) Successful in 10m9s
CI / repository boundary (pull_request) Successful in 11s
CI / cargo test (pull_request) Successful in 12m8s
CI / frontend-web (pull_request) Successful in 10m5s
CI / CI (pull_request) Successful in 7s
CI / Notify gate failed (pull_request) Has been skipped
42ce0f141a
Merge pull request 'GRI-1907: the README is for users; Docker and native install; contributor material moves to CONTRIBUTING.md' (#122) from docs/GRI-1907-readme-app-only into dev
Some checks failed
CI / the pre-push hook (push) Successful in 5s
CI / cargo fmt (push) Successful in 5s
CI / cargo deny (push) Successful in 50s
CI / cargo clippy (push) Successful in 10m16s
CI / cargo deny advisories (push) Failing after 49s
CI / repository boundary (push) Successful in 16s
CI / cargo test (push) Successful in 12m10s
CI / frontend-web (push) Successful in 9m55s
CI / Notify gate failed (push) Has been skipped
CI / CI (push) Successful in 3s
2a8a3dedd0
GRI-1885: strip home-dir ACL from config.toml before the bind mount
Some checks failed
CI / the pre-push hook (pull_request) Successful in 13s
CI / cargo fmt (pull_request) Successful in 13s
CI / cargo deny advisories (pull_request) Failing after 58s
CI / cargo deny (pull_request) Successful in 58s
CI / repository boundary (pull_request) Successful in 10s
CI / cargo clippy (pull_request) Successful in 10m27s
CI / frontend-web (pull_request) Successful in 9m58s
CI / cargo test (pull_request) Successful in 11m46s
CI / CI (pull_request) Successful in 4s
CI / Notify gate failed (pull_request) Has been skipped
8af8ddc1b5
config.toml was created 0660 under the home directory's default ACL
(grimoire-infra#321), so the container's uid could not read it over the
bind mount and the server restart-looped on Permission denied.
GRI-1912: close the WebSocket gracefully on approve/pend/reject
Some checks failed
CI / the pre-push hook (pull_request) Successful in 7s
CI / cargo fmt (pull_request) Successful in 6s
CI / cargo deny (pull_request) Successful in 34s
CI / cargo deny advisories (pull_request) Failing after 33s
CI / repository boundary (pull_request) Successful in 7s
CI / cargo clippy (pull_request) Successful in 9m59s
CI / cargo test (pull_request) Successful in 11m23s
CI / frontend-web (pull_request) Successful in 10m5s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 4s
e7a052614c
approve(), pend() and reject() wrote their final frame and then let
the socket drop with no WebSocket close handshake. Linux answers
close() with unread bytes still in the receive buffer with a TCP RST
instead of a FIN, and a reset can discard data the peer already
received but had not yet read off its socket buffer -- including the
just-sent Approved frame and one-shot token.

Add close_gracefully(), which sends an explicit Close frame and drains
incoming frames until EOF or a 5s timeout, and call it at the end of
each of the three replies.
Merge pull request 'GRI-1912: close the WebSocket gracefully on approve/pend/reject' (#125) from fix/GRI-1912-ws-graceful-close into dev
Some checks failed
CI / the pre-push hook (push) Successful in 11s
CI / cargo fmt (push) Successful in 11s
CI / cargo deny (push) Successful in 1m3s
CI / cargo deny advisories (push) Failing after 1m2s
CI / repository boundary (push) Successful in 14s
CI / cargo clippy (push) Successful in 10m6s
CI / frontend-web (push) Successful in 9m48s
CI / cargo test (push) Successful in 11m50s
CI / CI (push) Successful in 5s
CI / Notify gate failed (push) Has been skipped
b16f02bf5f
Merge pull request 'GRI-1885: fix smoke-test db profile and config.toml permission' (#124) from fix/GRI-1885-env-compose-profile into dev
Some checks failed
CI / the pre-push hook (push) Successful in 8s
CI / cargo fmt (push) Successful in 8s
CI / cargo deny (push) Successful in 45s
CI / cargo clippy (push) Successful in 10m18s
CI / repository boundary (push) Successful in 27s
CI / cargo deny advisories (push) Failing after 53s
CI / cargo test (push) Successful in 11m31s
CI / frontend-web (push) Successful in 10m23s
CI / Notify gate failed (push) Has been skipped
CI / CI (push) Successful in 4s
54ea3eaaaf
GRI-1912: approve route leaves the token for the device to collect
Some checks failed
CI / cargo fmt (pull_request) Successful in 17s
CI / the pre-push hook (pull_request) Successful in 18s
CI / cargo deny advisories (pull_request) Failing after 1m0s
CI / cargo deny (pull_request) Successful in 1m0s
CI / repository boundary (pull_request) Successful in 10s
CI / frontend-web (pull_request) Failing after 5m15s
CI / cargo clippy (pull_request) Successful in 10m11s
CI / cargo test (pull_request) Successful in 11m51s
CI / CI (pull_request) Failing after 6s
CI / Notify gate failed (pull_request) Successful in 7s
e3874da8de
The REST approve route called issue_token itself and returned the token
in the admin's HTTP response. The row issues one token only, so the
device's next reconnect with its temporary id always found it taken and
was refused as 'already enrolled on another connection' (signage #123).
The device now collects its token on that reconnect, as ws.rs expects.
GRI-1912: prettier format of approveDevice
Some checks failed
CI / the pre-push hook (pull_request) Successful in 15s
CI / cargo fmt (pull_request) Successful in 15s
CI / cargo deny advisories (pull_request) Failing after 1m10s
CI / repository boundary (pull_request) Successful in 6s
CI / cargo clippy (pull_request) Successful in 10m30s
CI / frontend-web (pull_request) Successful in 10m1s
CI / cargo test (pull_request) Successful in 11m47s
CI / cargo deny (pull_request) Failing after 15m38s
CI / CI (pull_request) Has been cancelled
CI / Notify gate failed (pull_request) Has been cancelled
1d088c3c5a
GRI-1912: re-run CI (cargo deny job hit its 15-minute timeout)
Some checks failed
CI / cargo fmt (pull_request) Successful in 17s
CI / the pre-push hook (pull_request) Successful in 20s
CI / cargo deny (pull_request) Successful in 1m15s
CI / cargo deny advisories (pull_request) Failing after 1m12s
CI / repository boundary (pull_request) Successful in 16s
CI / cargo clippy (pull_request) Successful in 10m7s
CI / frontend-web (pull_request) Successful in 9m53s
CI / cargo test (pull_request) Successful in 11m51s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 4s
1666f36ffd
Merge pull request 'GRI-1912: approve route leaves the token for the device to collect' (#126) from fix/GRI-1912-approve-leaves-token-to-device into dev
Some checks failed
CI / cargo fmt (push) Successful in 11s
CI / the pre-push hook (push) Successful in 11s
CI / cargo clippy (push) Successful in 10m3s
CI / cargo deny (push) Successful in 1m18s
CI / cargo deny advisories (push) Failing after 1m18s
CI / repository boundary (push) Successful in 6s
CI / cargo test (push) Successful in 11m52s
CI / frontend-web (push) Successful in 9m52s
CI / Notify gate failed (push) Has been skipped
CI / CI (push) Successful in 4s
c789d2be85
GRI-1916: server-side media transfer (TransferOffer/Accept/chunk streaming)
Some checks failed
CI / the pre-push hook (pull_request) Successful in 9s
CI / cargo fmt (pull_request) Failing after 9s
CI / frontend-web (pull_request) Has been cancelled
CI / repository boundary (pull_request) Has been cancelled
CI / CI (pull_request) Has been cancelled
CI / Notify gate failed (pull_request) Has been cancelled
CI / cargo clippy (pull_request) Has been cancelled
CI / cargo deny advisories (pull_request) Has been cancelled
CI / cargo deny (pull_request) Has been cancelled
CI / cargo test (pull_request) Successful in 12m10s
0e291db8d8
The server built MediaManifest and PlaylistPush but never offered the
files themselves, so a device could enrol and get a playlist but never
download anything to play. push_to_device now sends one TransferOffer
per manifest entry, and the device connection streams the file in
MAX_CHUNK_BYTES chunks on TransferAccept, honouring resume_from_offset,
behind a shared concurrency and bandwidth limiter (crate::transfers).
GRI-1916: cargo fmt
Some checks failed
CI / the pre-push hook (pull_request) Successful in 13s
CI / cargo fmt (pull_request) Successful in 6s
CI / cargo deny (pull_request) Successful in 50s
CI / cargo deny advisories (pull_request) Failing after 52s
CI / repository boundary (pull_request) Has been cancelled
CI / CI (pull_request) Has been cancelled
CI / Notify gate failed (pull_request) Has been cancelled
CI / cargo clippy (pull_request) Successful in 10m3s
CI / frontend-web (pull_request) Successful in 10m2s
CI / cargo test (pull_request) Successful in 12m17s
d59b5dbf74
GRI-1916: resend the current assignment on an Accepted reconnect
Some checks failed
CI / the pre-push hook (pull_request) Successful in 8s
CI / cargo fmt (pull_request) Successful in 8s
CI / cargo deny (pull_request) Successful in 1m0s
CI / cargo deny advisories (pull_request) Failing after 1m13s
CI / repository boundary (pull_request) Successful in 17s
CI / cargo clippy (pull_request) Successful in 10m11s
CI / cargo test (pull_request) Successful in 12m3s
CI / frontend-web (pull_request) Successful in 10m27s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 5s
3eeb86bcff
A device reconnecting with a valid token received no further push until
some later change to its assignment happened to occur while it stayed
connected. A device that reboots, or was offline when it was assigned,
never saw its playlist at all. Resend MediaManifest/PlaylistPush and one
TransferOffer per file on every Admission::Registered reconnect, per
protocol.md step 3.
Merge pull request 'GRI-1916: server-side media transfer (TransferOffer, chunk streaming)' (#128) from fix/GRI-1916-server-media-transfer into dev
Some checks failed
CI / cargo fmt (push) Successful in 9s
CI / the pre-push hook (push) Successful in 13s
CI / cargo deny advisories (push) Failing after 1m24s
CI / cargo deny (push) Successful in 1m24s
CI / repository boundary (push) Successful in 22s
CI / cargo clippy (push) Successful in 10m7s
CI / frontend-web (push) Successful in 10m3s
CI / cargo test (push) Successful in 12m8s
CI / Notify gate failed (push) Has been skipped
CI / CI (push) Successful in 6s
91e72c4446
GRI-1917: push playlist content edits to assigned devices
Some checks failed
CI / the pre-push hook (pull_request) Successful in 11s
CI / cargo fmt (pull_request) Successful in 11s
CI / cargo deny advisories (pull_request) Failing after 1m42s
CI / cargo deny (pull_request) Successful in 1m46s
CI / cargo clippy (pull_request) Successful in 10m15s
CI / repository boundary (pull_request) Successful in 9s
CI / frontend-web (pull_request) Successful in 10m1s
CI / cargo test (pull_request) Successful in 12m25s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 4s
b57a3baf61
replace_items now looks up devices currently assigned the edited
playlist and pushes MediaManifest/PlaylistPush/TransferOffer to each,
same as assign_playlist does on a fresh assignment, per
plan/shared/protocol.md:104 (push on every change to the assigned
playlist, not only on assignment).
Merge pull request 'GRI-1917: push playlist content edits to assigned devices' (#130) from fix/GRI-1917-push-on-playlist-edit into dev
Some checks failed
CI / cargo fmt (push) Successful in 13s
CI / the pre-push hook (push) Successful in 14s
CI / cargo clippy (push) Successful in 10m30s
CI / cargo test (push) Successful in 12m38s
CI / cargo deny (push) Successful in 2m6s
CI / repository boundary (push) Successful in 7s
CI / frontend-web (push) Successful in 11m33s
CI / Notify gate failed (push) Has been skipped
CI / CI (push) Successful in 7s
CI / cargo deny advisories (push) Failing after 16m32s
eb0de5bf7a
Run9 of scripts/mvp-smoke-test.sh is the first full end-to-end pass:
enrollment, approval, upload, playlist assignment, playback, and a
live playlist edit all follow through with the real client against
the real server. Note the one manual step, drop the stale
no-container-runtime caveat now that rootless Docker is live, and
list the three real bugs (#126, #128, #130) this checklist found
and that are already fixed in dev.
GRI-1919: read PDF pages into memory before removing the render directory
Some checks failed
CI / cargo fmt (pull_request) Successful in 15s
CI / cargo deny (pull_request) Successful in 46s
CI / cargo deny advisories (pull_request) Failing after 43s
CI / repository boundary (pull_request) Successful in 7s
CI / cargo clippy (pull_request) Successful in 10m3s
CI / frontend-web (pull_request) Successful in 9m55s
CI / cargo test (pull_request) Successful in 12m11s
CI / the pre-push hook (pull_request) Failing after 13m50s
CI / CI (pull_request) Has been cancelled
CI / Notify gate failed (pull_request) Has been cancelled
cd416e7756
Fix the race where convert_pdf_upload removed render_dir immediately
after render_pdf_pages returned, then tried to read each page file
from inside it, failing every PDF upload with ENOENT.
GRI-1919: retrigger CI (transient pre-push-hook job timeout)
Some checks failed
CI / cargo fmt (pull_request) Successful in 14s
CI / the pre-push hook (pull_request) Successful in 14s
CI / cargo deny advisories (pull_request) Failing after 54s
CI / cargo deny (pull_request) Successful in 54s
CI / repository boundary (pull_request) Successful in 8s
CI / cargo clippy (pull_request) Successful in 10m19s
CI / frontend-web (pull_request) Successful in 9m43s
CI / cargo test (pull_request) Successful in 12m23s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 7s
7e3721bb94
GRI-1907: README opens with the one-line install for server and client
Some checks failed
CI / cargo fmt (pull_request) Successful in 11s
CI / the pre-push hook (pull_request) Successful in 12s
CI / cargo deny advisories (pull_request) Failing after 1m4s
CI / cargo deny (pull_request) Successful in 1m5s
CI / repository boundary (pull_request) Successful in 19s
CI / cargo clippy (pull_request) Successful in 10m5s
CI / cargo test (pull_request) Successful in 12m20s
CI / frontend-web (pull_request) Successful in 15m2s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 3s
5190a8bb9a
Merge pull request 'GRI-1919: read PDF pages into memory before removing the render directory' (#132) from fix/GRI-1919-pdf-render-dir-deleted-early into dev
Some checks failed
CI / the pre-push hook (push) Successful in 8s
CI / cargo fmt (push) Successful in 12s
CI / cargo deny (push) Successful in 1m55s
CI / cargo deny advisories (push) Failing after 1m51s
CI / repository boundary (push) Successful in 35s
CI / cargo clippy (push) Successful in 10m45s
CI / cargo test (push) Successful in 12m24s
CI / frontend-web (push) Successful in 14m54s
CI / Notify gate failed (push) Has been skipped
CI / CI (push) Successful in 4s
b71fd85368
GRI-1885: smoke test extends to PDF pages and a web page URL, full pass on dev
Some checks failed
CI / cargo fmt (pull_request) Successful in 13s
CI / the pre-push hook (pull_request) Successful in 13s
CI / cargo deny (pull_request) Successful in 52s
CI / cargo deny advisories (pull_request) Failing after 51s
CI / repository boundary (pull_request) Successful in 12s
CI / cargo clippy (pull_request) Successful in 10m6s
CI / frontend-web (pull_request) Successful in 9m46s
CI / cargo test (pull_request) Successful in 12m14s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 8s
db2c0298e9
Run11 is a full end-to-end pass of scripts/mvp-smoke-test.sh against the
real server and real client: enroll, approve, upload of an image, a video,
a two-page PDF, and a web page URL, playlist assignment, and playback of
all four item kinds, plus a live playlist-edit follow-through with no
client restart.

Extends the script with the two must-have item kinds for the test week
(#29): a PDF (paged into document_page rows) and a web page URL item. Ten
prior runs each found one real bug by getting further than the last; all
ten are fixed in dev and none recur in this run.
Merge pull request 'GRI-1907: one-command install script for server and client' (#134) from feature/GRI-1907-install-script into dev
Some checks failed
CI / cargo fmt (push) Successful in 15s
CI / the pre-push hook (push) Successful in 18s
CI / cargo deny advisories (push) Failing after 55s
CI / repository boundary (push) Successful in 7s
CI / cargo clippy (push) Successful in 10m29s
CI / cargo test (push) Successful in 11m55s
CI / cargo deny (push) Failing after 15m28s
CI / frontend-web (push) Successful in 15m10s
CI / CI (push) Failing after 3s
CI / Notify gate failed (push) Has been skipped
ceb734ae96
Merge pull request 'GRI-1885: smoke test extends to PDF pages and a web page URL, full pass on dev' (#133) from docs/GRI-1885-smoke-test-pass into dev
Some checks failed
CI / the pre-push hook (push) Successful in 10s
CI / cargo fmt (push) Successful in 6s
CI / cargo deny (push) Successful in 30s
CI / cargo clippy (push) Successful in 10m20s
CI / cargo deny advisories (push) Failing after 30s
CI / repository boundary (push) Successful in 15s
CI / cargo test (push) Successful in 12m39s
CI / frontend-web (push) Successful in 14m1s
CI / Notify gate failed (push) Has been skipped
CI / CI (push) Successful in 3s
3ef69ada4d
GRI-1761: deployment note matches dev: PDF upload works, poppler on plain hosts, no client self-update yet, git not agit
Some checks failed
CI / the pre-push hook (pull_request) Successful in 10s
CI / cargo fmt (pull_request) Successful in 6s
CI / cargo clippy (pull_request) Successful in 10m31s
CI / cargo deny (pull_request) Successful in 1m3s
CI / cargo deny advisories (pull_request) Failing after 49s
CI / repository boundary (pull_request) Successful in 14s
CI / cargo test (pull_request) Successful in 12m40s
CI / frontend-web (pull_request) Successful in 15m2s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 4s
6d47c7e9f8
Merge pull request 'GRI-1761: deployment note matches dev (PDF works, poppler, no self-update yet)' (#135) from docs/GRI-1761-deploy-note-pdf into dev
Some checks failed
CI / cargo fmt (push) Successful in 11s
CI / the pre-push hook (push) Successful in 15s
CI / cargo deny (push) Successful in 30s
CI / cargo deny advisories (push) Failing after 54s
CI / repository boundary (push) Successful in 6s
CI / the pre-push hook (pull_request) Successful in 6s
CI / cargo fmt (pull_request) Successful in 11s
CI / cargo clippy (push) Successful in 10m33s
CI / cargo clippy (pull_request) Successful in 9m59s
CI / cargo test (push) Successful in 12m27s
CI / cargo deny (pull_request) Successful in 48s
CI / cargo deny advisories (pull_request) Failing after 55s
CI / repository boundary (pull_request) Successful in 17s
CI / frontend-web (push) Failing after 15m5s
CI / Notify gate failed (push) Has been skipped
CI / CI (push) Failing after 5s
CI / cargo test (pull_request) Successful in 11m56s
CI / frontend-web (pull_request) Failing after 15m2s
CI / CI (pull_request) Failing after 6s
CI / Notify gate failed (pull_request) Successful in 6s
3430fabf2b
aegis requested changes 2026-11-11 11:43:17 +00:00
Dismissed
aegis left a comment

Security review of this first release (dev → main), scoped to the five areas named on the task plus whatever else "the whole product is in scope" turned up along the way. Reviewed with a fresh clone at the PR's head.

Blocking: no throttling or lockout on login, despite being specified for this release

plan/server/users-and-permissions.md, "Login" lists Throttling ("Failed attempts are slowed, per account and per source IP") and Lockout ("After a configurable number of failures") as controls for this release — they are not in that document's "Later" table, unlike 2FA/OIDC/LDAP. plan/operations/security.md's own review checklist separately lists "Rate limits | Login, blocked-IP events, pending registrations per IP" as something a branch touching auth must have.

None of it exists. crates/server/src/auth/handlers.rs::login runs exactly one Argon2id verification per request (well-designed for timing-safety — see "What's solid" below) and returns 401 on failure, with nothing counting or slowing repeated failures from one IP or against one account. grep -rn "rate.limit\|rate_limit\|RateLimit\|lockout\|throttl" crates/ across the whole workspace finds nothing. There is no reverse-proxy config shipped either (correctly left to the operator per security.md), so nothing upstream covers it.

Attack: POST /api/v1/session is reachable pre-auth. An attacker can try passwords against the one admin account at whatever rate Argon2id's ~tens-of-milliseconds cost and their own connection concurrency allow, with no lockout ever kicking in. The password policy is only an 8-character minimum (validate_password), so a weak-but-policy-valid password is realistically guessable this way.

Blast radius: this one account is the entire admin surface for every campus this server runs — devices, playlists, IP rules, media (including arbitrary url-type playlist items). Takeover means arbitrary content, including arbitrary web pages, pushed to every physical screen.

Fix: implement what users-and-permissions.md already specifies — a failed-attempt counter keyed by account and by source IP, slowing or locking out after a configurable threshold, with the CLI-based reset the doc itself calls for ("recoverable without the database"). The same gap applies to pending-device-registration floods (devices::create_pending, crates/server/src/devices.rs:134 — no per-IP cap on an unauthenticated WebSocket connecting and immediately registering a pending row) and to blocked-IP events, both named in the same checklist; lower severity than the login case but same root cause.

Regression test to specify for QA: N consecutive failed POST /api/v1/session attempts for one account/IP must return a throttled/locked response (429/423) before the (N+1)th attempt ever reaches PasswordHasher::verify — assert on a counter or a mock hasher never being called past the threshold, not just on the HTTP status, so the test fails if throttling is bypassed internally while still answering 401.

Non-blocking, flag for follow-up

  • Audit log is specified but unbuilt. plan/server/audit-log.md describes an audit log "enabled by default" covering authentication, device lifecycle, IP-rule changes, etc. Only the category/outcome enums exist (crates/shared/src/audit.rs); there is no table, no write path, nothing recording a login failure anywhere in crates/server. This compounds the throttling gap above: if someone does brute-force the login, there's no record to notice it happened.
  • Upload content-type is taken on faith. crates/server/src/media/handlers.rs::classify trusts the multipart field's client-supplied Content-Type with no magic-byte check. Today the only trust boundary is "authenticated admin," and the bytes are only ever played by the client-side renderer (not parsed as HTML in a browser), so this isn't exploitable yet — but it's worth hardening (sniff actual bytes, e.g. via the file's magic number) before any lower-trust upload path or multi-user role model is added.

What's solid (reviewed, no issues)

  • X-Forwarded-For / trusted-proxy handling (crates/server/src/client_ip.rs): client IP is read from the real TCP peer (axum::extract::ConnectInfo), never trusted from a header unless the peer itself is in an operator-configured, empty-by-default trusted-proxy list; the forwarded chain is walked right-to-left and stops at the first untrusted entry. Well covered by tests, including forged headers from an untrusted peer and IPv4-mapped-IPv6 entries.
  • Default admission for unknown devices (crates/server/src/admission.rs): fixed order — blocklist, then valid token, then auto-approve, then Pending — and AdmissionRules::default() is empty lists, i.e. fail-closed to Pending. The blocklist is checked (blocklist_only_drop) before any WebSocket frame is parsed.
  • Login/session mechanics apart from throttling: Argon2id at OWASP's current minimum params, with a fixed dummy hash so an unknown email costs the same real hash as a wrong password (crates/server/src/auth/password.rs); 256-bit random session tokens stored only as a SHA-256 hash, HttpOnly/Secure/SameSite=Strict, fixed 12 h expiry checked in SQL; first-user creation is race-safe via a Postgres advisory lock.
  • PDF upload via pdftoppm (crates/server/src/pdf.rs): invoked through tokio::process::Command with a fixed argv, never a shell — no command injection surface; 120 s timeout with kill_on_drop; stderr capped at 2048 bytes; the render scratch directory is always removed, including on failure.
  • No hard-coded endpoints or secrets (GRI-1884): DB URL, trusted-proxy ranges, media/panel directories, update-signing key path and HTTP bind address are all SIGNAGE_*-env-var/config-file driven (crates/server/src/config.rs), defaulting closed (allow_plaintext_connections defaults false); the client's server address is user/config-supplied (crates/client/src/config.rs), never compiled in; the update-signing private key is written 0600, outside the database.

Requesting changes for the login-throttling gap. Everything else named on the task reviewed clean.

Security review of this first release (`dev` → `main`), scoped to the five areas named on the task plus whatever else "the whole product is in scope" turned up along the way. Reviewed with a fresh clone at the PR's head. ## Blocking: no throttling or lockout on login, despite being specified for this release `plan/server/users-and-permissions.md`, "Login" lists `Throttling` ("Failed attempts are slowed, per account and per source IP") and `Lockout` ("After a configurable number of failures") as controls for this release — they are **not** in that document's "Later" table, unlike 2FA/OIDC/LDAP. `plan/operations/security.md`'s own review checklist separately lists "Rate limits | Login, blocked-IP events, pending registrations per IP" as something a branch touching auth must have. None of it exists. `crates/server/src/auth/handlers.rs::login` runs exactly one Argon2id verification per request (well-designed for timing-safety — see "What's solid" below) and returns `401` on failure, with nothing counting or slowing repeated failures from one IP or against one account. `grep -rn "rate.limit\|rate_limit\|RateLimit\|lockout\|throttl" crates/` across the whole workspace finds nothing. There is no reverse-proxy config shipped either (correctly left to the operator per `security.md`), so nothing upstream covers it. **Attack:** `POST /api/v1/session` is reachable pre-auth. An attacker can try passwords against the one admin account at whatever rate Argon2id's ~tens-of-milliseconds cost and their own connection concurrency allow, with no lockout ever kicking in. The password policy is only an 8-character minimum (`validate_password`), so a weak-but-policy-valid password is realistically guessable this way. **Blast radius:** this one account is the entire admin surface for every campus this server runs — devices, playlists, IP rules, media (including arbitrary `url`-type playlist items). Takeover means arbitrary content, including arbitrary web pages, pushed to every physical screen. **Fix:** implement what `users-and-permissions.md` already specifies — a failed-attempt counter keyed by account and by source IP, slowing or locking out after a configurable threshold, with the CLI-based reset the doc itself calls for ("recoverable without the database"). The same gap applies to pending-device-registration floods (`devices::create_pending`, `crates/server/src/devices.rs:134` — no per-IP cap on an unauthenticated WebSocket connecting and immediately registering a `pending` row) and to blocked-IP events, both named in the same checklist; lower severity than the login case but same root cause. **Regression test to specify for QA:** N consecutive failed `POST /api/v1/session` attempts for one account/IP must return a throttled/locked response (`429`/`423`) before the (N+1)th attempt ever reaches `PasswordHasher::verify` — assert on a counter or a mock hasher never being called past the threshold, not just on the HTTP status, so the test fails if throttling is bypassed internally while still answering 401. ## Non-blocking, flag for follow-up - **Audit log is specified but unbuilt.** `plan/server/audit-log.md` describes an audit log "enabled by default" covering authentication, device lifecycle, IP-rule changes, etc. Only the category/outcome enums exist (`crates/shared/src/audit.rs`); there is no table, no write path, nothing recording a login failure anywhere in `crates/server`. This compounds the throttling gap above: if someone does brute-force the login, there's no record to notice it happened. - **Upload content-type is taken on faith.** `crates/server/src/media/handlers.rs::classify` trusts the multipart field's client-supplied `Content-Type` with no magic-byte check. Today the only trust boundary is "authenticated admin," and the bytes are only ever played by the client-side renderer (not parsed as HTML in a browser), so this isn't exploitable yet — but it's worth hardening (sniff actual bytes, e.g. via the file's magic number) before any lower-trust upload path or multi-user role model is added. ## What's solid (reviewed, no issues) - **X-Forwarded-For / trusted-proxy handling** (`crates/server/src/client_ip.rs`): client IP is read from the real TCP peer (`axum::extract::ConnectInfo`), never trusted from a header unless the peer itself is in an operator-configured, empty-by-default trusted-proxy list; the forwarded chain is walked right-to-left and stops at the first untrusted entry. Well covered by tests, including forged headers from an untrusted peer and IPv4-mapped-IPv6 entries. - **Default admission for unknown devices** (`crates/server/src/admission.rs`): fixed order — blocklist, then valid token, then auto-approve, then `Pending` — and `AdmissionRules::default()` is empty lists, i.e. fail-closed to `Pending`. The blocklist is checked (`blocklist_only_drop`) before any WebSocket frame is parsed. - **Login/session mechanics apart from throttling**: Argon2id at OWASP's current minimum params, with a fixed dummy hash so an unknown email costs the same real hash as a wrong password (`crates/server/src/auth/password.rs`); 256-bit random session tokens stored only as a SHA-256 hash, `HttpOnly`/`Secure`/`SameSite=Strict`, fixed 12 h expiry checked in SQL; first-user creation is race-safe via a Postgres advisory lock. - **PDF upload via `pdftoppm`** (`crates/server/src/pdf.rs`): invoked through `tokio::process::Command` with a fixed argv, never a shell — no command injection surface; 120 s timeout with `kill_on_drop`; stderr capped at 2048 bytes; the render scratch directory is always removed, including on failure. - **No hard-coded endpoints or secrets (GRI-1884)**: DB URL, trusted-proxy ranges, media/panel directories, update-signing key path and HTTP bind address are all `SIGNAGE_*`-env-var/config-file driven (`crates/server/src/config.rs`), defaulting closed (`allow_plaintext_connections` defaults `false`); the client's server address is user/config-supplied (`crates/client/src/config.rs`), never compiled in; the update-signing private key is written `0600`, outside the database. Requesting changes for the login-throttling gap. Everything else named on the task reviewed clean.
GRI-1761: raise frontend-web CI timeout from 15 to 30 minutes
Some checks failed
CI / the pre-push hook (pull_request) Successful in 10s
CI / cargo fmt (pull_request) Successful in 10s
CI / cargo deny (pull_request) Successful in 35s
CI / cargo deny advisories (pull_request) Failing after 29s
CI / repository boundary (pull_request) Successful in 33s
CI / cargo clippy (pull_request) Successful in 10m6s
CI / cargo test (pull_request) Successful in 12m31s
CI / frontend-web (pull_request) Successful in 29m23s
CI / CI (pull_request) Successful in 14s
CI / Notify gate failed (pull_request) Has been skipped
9a14cf4833
Merge pull request 'GRI-1761: raise frontend-web CI timeout to 30 minutes' (#137) from fix/GRI-1761-frontend-ci-timeout into dev
Some checks failed
CI / the pre-push hook (push) Successful in 25s
CI / cargo fmt (push) Successful in 24s
CI / cargo deny (push) Successful in 52s
CI / cargo deny advisories (push) Failing after 47s
CI / cargo clippy (push) Successful in 10m25s
CI / cargo test (push) Successful in 12m29s
CI / frontend-web (push) Failing after 30m3s
CI / the pre-push hook (pull_request) Successful in 15s
CI / repository boundary (push) Successful in 19s
CI / cargo fmt (pull_request) Successful in 11s
CI / cargo clippy (pull_request) Successful in 2m9s
CI / cargo deny advisories (pull_request) Failing after 2m5s
CI / cargo deny (pull_request) Successful in 2m16s
CI / repository boundary (pull_request) Successful in 38s
CI / frontend-web (pull_request) Successful in 1m44s
CI / cargo test (pull_request) Successful in 6m11s
CI / CI (push) Failing after 20s
CI / Notify gate failed (push) Has been skipped
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 31s
98562a0fc4
GRI-1922: throttle login attempts per account and per IP
Some checks failed
CI / the pre-push hook (pull_request) Successful in 7s
CI / cargo fmt (pull_request) Successful in 6s
CI / cargo deny (pull_request) Successful in 51s
CI / cargo deny advisories (pull_request) Failing after 1m16s
CI / repository boundary (pull_request) Successful in 33s
CI / cargo clippy (pull_request) Successful in 10m32s
CI / cargo test (pull_request) Successful in 12m9s
CI / CI (pull_request) Has been cancelled
CI / Notify gate failed (pull_request) Has been cancelled
CI / frontend-web (pull_request) Failing after 15m6s
1fb1a3c112
429 + Retry-After before PasswordHasher::verify once a threshold is
crossed; thresholds and window configurable via config.toml /
SIGNAGE_LOGIN_THROTTLE_* (GRI-1884). In-memory fixed-window counters,
reset on successful login. Reuses enrolment's TrustedProxies for
client IP instead of a second trusted-proxy list.
GRI-1922: make login-throttle check atomic, not check-then-record
Some checks failed
CI / the pre-push hook (pull_request) Successful in 26s
CI / cargo fmt (pull_request) Successful in 38s
CI / cargo clippy (pull_request) Successful in 1m59s
CI / cargo deny (pull_request) Successful in 1m24s
CI / repository boundary (pull_request) Successful in 27s
CI / cargo deny advisories (pull_request) Failing after 1m27s
CI / frontend-web (pull_request) Successful in 1m55s
CI / cargo test (pull_request) Successful in 4m22s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 3s
c8544ba55e
check() now reserves the attempt's slot under the same lock as the
threshold test, so concurrent requests can no longer all pass the
check before any of them is counted. A success releases the IP's
reserved slot (so it still never counts against the IP budget) and
resets the account counter; a failure leaves the reservation in
place. record_failure is gone — the reservation itself is the count.

Also prunes expired entries on every reservation so the maps do not
grow without bound.
Merge pull request 'GRI-1922: throttle login attempts per account and per IP' (#139) from feature/GRI-1922-login-throttling into dev
Some checks failed
CI / cargo fmt (push) Successful in 24s
CI / the pre-push hook (push) Successful in 26s
CI / cargo deny (push) Successful in 1m57s
CI / cargo clippy (push) Successful in 2m24s
CI / cargo deny advisories (push) Failing after 1m14s
CI / repository boundary (push) Successful in 27s
CI / frontend-web (push) Successful in 2m13s
CI / the pre-push hook (pull_request) Successful in 28s
CI / cargo fmt (pull_request) Successful in 16s
CI / cargo test (push) Successful in 4m31s
CI / cargo deny (pull_request) Successful in 2m23s
CI / cargo clippy (pull_request) Successful in 2m45s
CI / cargo deny advisories (pull_request) Failing after 1m44s
CI / repository boundary (pull_request) Successful in 28s
CI / Notify gate failed (push) Has been skipped
CI / frontend-web (pull_request) Successful in 1m30s
CI / cargo test (pull_request) Successful in 5m5s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 8s
CI / CI (push) Failing after 11m24s
7831bde481
aegis approved these changes 2026-11-11 14:43:02 +00:00
Dismissed
aegis left a comment

Re-review after GRI-1922 (#139, merged into dev at c8544ba, carried by this PR at 7831bde): the blocking finding is fixed.

crates/server/src/auth/throttle.rs adds per-account and per-client-IP fixed-window counters, checked in handlers::login before the DB lookup or password hash runs (so a throttled attempt never pays the timing cost of either, and the correct password still gets 429 while over threshold -- proven directly in auth_integration.rs). Test-and-count is one atomic locked step (Bucket::reserve), with a concurrency test confirming exactly max_attempts reservations succeed under 50 racing threads -- this closes the TOCTOU gap a naive check-then-increment would have. 429 responses carry Retry-After. A success resets the account counter and releases one IP slot (shared-IP fairness). Client IP reuses the existing TrustedProxies extractor already reviewed clean, not a second implementation. Thresholds and window are configurable via TOML and SIGNAGE_LOGIN_THROTTLE_* env vars (GRI-1884), defaulting to 5/account and 20/IP per 15 minutes.

Lockout is in-memory and window-based; a restart clears it, which is the documented recovery path for the single-server MVP (plan/server/users-and-permissions.md). No separate CLI unlock exists, and none is needed at this scale -- noted as the one piece of residual risk to revisit if a second server is added.

Secondary, non-blocking items from the first pass still stand and are not release blockers: the audit log described in plan/server/audit-log.md has only its enum types built, and media upload classify() trusts client-supplied Content-Type with no magic-byte check. Worth their own follow-up issues with the back-end engineer, not blockers for 0.1.0.

Everything else from the first pass (X-Forwarded-For/trusted-proxy handling, default-pending device admission, session/login cryptography, PDF-via-pdftoppm, no hard-coded endpoints or secrets) was already reviewed clean and is unchanged by this PR.

Security approval given. Does not cover merge authority -- only the product owner merges to main.

Re-review after GRI-1922 (#139, merged into dev at c8544ba, carried by this PR at 7831bde): the blocking finding is fixed. `crates/server/src/auth/throttle.rs` adds per-account and per-client-IP fixed-window counters, checked in `handlers::login` before the DB lookup or password hash runs (so a throttled attempt never pays the timing cost of either, and the correct password still gets 429 while over threshold -- proven directly in `auth_integration.rs`). Test-and-count is one atomic locked step (`Bucket::reserve`), with a concurrency test confirming exactly `max_attempts` reservations succeed under 50 racing threads -- this closes the TOCTOU gap a naive check-then-increment would have. 429 responses carry `Retry-After`. A success resets the account counter and releases one IP slot (shared-IP fairness). Client IP reuses the existing `TrustedProxies` extractor already reviewed clean, not a second implementation. Thresholds and window are configurable via TOML and `SIGNAGE_LOGIN_THROTTLE_*` env vars (GRI-1884), defaulting to 5/account and 20/IP per 15 minutes. Lockout is in-memory and window-based; a restart clears it, which is the documented recovery path for the single-server MVP (`plan/server/users-and-permissions.md`). No separate CLI unlock exists, and none is needed at this scale -- noted as the one piece of residual risk to revisit if a second server is added. Secondary, non-blocking items from the first pass still stand and are not release blockers: the audit log described in `plan/server/audit-log.md` has only its enum types built, and media upload `classify()` trusts client-supplied Content-Type with no magic-byte check. Worth their own follow-up issues with the back-end engineer, not blockers for 0.1.0. Everything else from the first pass (X-Forwarded-For/trusted-proxy handling, default-pending device admission, session/login cryptography, PDF-via-pdftoppm, no hard-coded endpoints or secrets) was already reviewed clean and is unchanged by this PR. Security approval given. Does not cover merge authority -- only the product owner merges to main.
GRI-1896: device groups claim devices by a name rule (starts with, ends with, contains, regex)
Some checks failed
CI / the pre-push hook (pull_request) Successful in 7s
CI / cargo fmt (pull_request) Successful in 14s
CI / cargo deny (pull_request) Successful in 31s
CI / cargo deny advisories (pull_request) Failing after 34s
CI / cargo clippy (pull_request) Successful in 10m13s
CI / repository boundary (pull_request) Successful in 11s
CI / cargo test (pull_request) Successful in 12m43s
CI / frontend-web (pull_request) Failing after 15m6s
CI / CI (pull_request) Failing after 13s
CI / Notify gate failed (pull_request) Successful in 6s
0b32f78dbb
Merge remote-tracking branch 'origin/dev' into feature/GRI-1896-device-groups
Some checks failed
CI / the pre-push hook (pull_request) Successful in 32s
CI / cargo fmt (pull_request) Successful in 45s
CI / cargo clippy (pull_request) Successful in 2m14s
CI / cargo deny (pull_request) Successful in 2m15s
CI / cargo deny advisories (pull_request) Failing after 1m22s
CI / repository boundary (pull_request) Successful in 46s
CI / frontend-web (pull_request) Successful in 2m6s
CI / cargo test (pull_request) Successful in 5m41s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Failing after 10m58s
caa9f163c0
Merge pull request 'GRI-1896: device groups claim devices by a name rule' (#140) from feature/GRI-1896-device-groups into dev
Some checks failed
CI / cargo fmt (push) Successful in 11s
CI / the pre-push hook (push) Successful in 16s
CI / cargo deny (push) Successful in 3m3s
CI / cargo deny advisories (push) Failing after 3m1s
CI / cargo clippy (push) Successful in 3m20s
CI / the pre-push hook (pull_request) Successful in 30s
CI / repository boundary (push) Successful in 47s
CI / cargo fmt (pull_request) Successful in 37s
CI / frontend-web (push) Successful in 1m31s
CI / cargo deny (pull_request) Successful in 2m10s
CI / cargo clippy (pull_request) Successful in 3m20s
CI / cargo test (push) Successful in 7m53s
CI / repository boundary (pull_request) Successful in 42s
CI / cargo deny advisories (pull_request) Failing after 1m35s
CI / Notify gate failed (push) Has been skipped
CI / CI (push) Successful in 20s
CI / frontend-web (pull_request) Successful in 1m50s
CI / cargo test (pull_request) Successful in 5m11s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 4s
112d945cc4
vivy dismissed aegis's review 2026-11-11 15:04:11 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

aegis approved these changes 2026-11-11 19:20:30 +00:00
Dismissed
aegis left a comment

Re-review after dev advanced from 7831bde to 112d945c (PR #140, GRI-1896: device groups claim devices by a name rule), dismissing review 438.

Delta reviewed: agit diff 7831bde..112d945c touches only 5 files (204 lines, all additions) — Cargo.toml/Cargo.lock (new regex = "1" workspace dependency), crates/server/Cargo.toml, crates/server/src/lib.rs (new pub mod groups; + re-exports), and the new crates/server/src/groups.rs.

groups.rs is a self-contained data/matching module: NameRuleKind (StartsWith/EndsWith/Contains/Regex), NameRule::matches(), NameRule::is_valid(), DeviceGroup::claims(). Findings:

  • No new attack surface yet. Confirmed via agit diff --stat and a search of the diff: no new HTTP route, handler, or DB migration is wired to this module in this PR. It is exported from lib.rs but not yet reachable from any endpoint, so there is nothing here an unauthenticated or lower-privileged caller can reach today.
  • Regex DoS: the regex crate (not fancy-regex/PCRE) guarantees linear-time matching with no catastrophic backtracking, so an admin-supplied pattern cannot be used for a ReDoS even once this is wired to an endpoint. Appropriate choice for user-supplied patterns.
  • No panics: Regex::new(...) is handled with .is_ok_and(...) in matches() (invalid regex just fails to match, fail-closed) and checked explicitly in is_valid(). No .unwrap()/.expect() on attacker/admin-influenced input.
  • Confirmed the throttling fix from #139 (my prior blocking finding, GRI-1922) is untouched by this delta — crates/server/src/auth/throttle.rs and the login handler have no changes between 7831bde and 112d945c.

No blocking issues in this delta. Re-approving as APPROVED (official review) on PR #136. Still not merging — that remains the product owner's call on main.

Prior non-blocking items stand (unimplemented audit log, no magic-byte check on upload Content-Type) and are unaffected by this delta.

Re-review after dev advanced from 7831bde to 112d945c (PR #140, GRI-1896: device groups claim devices by a name rule), dismissing review 438. Delta reviewed: `agit diff 7831bde..112d945c` touches only 5 files (204 lines, all additions) — `Cargo.toml`/`Cargo.lock` (new `regex = "1"` workspace dependency), `crates/server/Cargo.toml`, `crates/server/src/lib.rs` (new `pub mod groups;` + re-exports), and the new `crates/server/src/groups.rs`. `groups.rs` is a self-contained data/matching module: `NameRuleKind` (StartsWith/EndsWith/Contains/Regex), `NameRule::matches()`, `NameRule::is_valid()`, `DeviceGroup::claims()`. Findings: - **No new attack surface yet.** Confirmed via `agit diff --stat` and a search of the diff: no new HTTP route, handler, or DB migration is wired to this module in this PR. It is exported from `lib.rs` but not yet reachable from any endpoint, so there is nothing here an unauthenticated or lower-privileged caller can reach today. - **Regex DoS:** the `regex` crate (not `fancy-regex`/PCRE) guarantees linear-time matching with no catastrophic backtracking, so an admin-supplied pattern cannot be used for a ReDoS even once this is wired to an endpoint. Appropriate choice for user-supplied patterns. - **No panics:** `Regex::new(...)` is handled with `.is_ok_and(...)` in `matches()` (invalid regex just fails to match, fail-closed) and checked explicitly in `is_valid()`. No `.unwrap()`/`.expect()` on attacker/admin-influenced input. - Confirmed the throttling fix from #139 (my prior blocking finding, GRI-1922) is untouched by this delta — `crates/server/src/auth/throttle.rs` and the login handler have no changes between 7831bde and 112d945c. No blocking issues in this delta. Re-approving as **APPROVED** (official review) on PR #136. Still not merging — that remains the product owner's call on `main`. Prior non-blocking items stand (unimplemented audit log, no magic-byte check on upload Content-Type) and are unaffected by this delta.
GRI-1936: install.sh uninstall and reinstall, keeping the data unless --purge
Some checks failed
CI / the pre-push hook (pull_request) Successful in 14s
CI / cargo fmt (pull_request) Successful in 15s
CI / cargo deny advisories (pull_request) Failing after 2m30s
CI / cargo deny (pull_request) Successful in 2m30s
CI / cargo clippy (pull_request) Successful in 2m56s
CI / repository boundary (pull_request) Successful in 18s
CI / frontend-web (pull_request) Successful in 1m14s
CI / cargo test (pull_request) Successful in 5m12s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 2s
e8c1bb2a14
Merge pull request 'GRI-1936: install.sh installs PostgreSQL on request, and gains uninstall and reinstall' (#141) from feature/GRI-1936-install-postgres into dev
Some checks failed
CI / the pre-push hook (push) Successful in 10s
CI / cargo fmt (push) Successful in 9s
CI / cargo clippy (push) Successful in 3m5s
CI / cargo deny advisories (push) Failing after 1m45s
CI / cargo deny (push) Successful in 1m47s
CI / frontend-web (push) Successful in 2m15s
CI / cargo test (push) Successful in 5m30s
CI / repository boundary (push) Successful in 37s
CI / cargo fmt (pull_request) Successful in 18s
CI / the pre-push hook (pull_request) Successful in 18s
CI / cargo deny (pull_request) Successful in 1m45s
CI / cargo deny advisories (pull_request) Failing after 1m46s
CI / cargo clippy (pull_request) Successful in 2m8s
CI / repository boundary (pull_request) Successful in 25s
CI / CI (push) Successful in 14s
CI / Notify gate failed (push) Has been skipped
CI / frontend-web (pull_request) Successful in 1m24s
CI / cargo test (pull_request) Successful in 4m39s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 3s
824f4a65c6
vivy dismissed aegis's review 2026-11-12 12:01:23 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

GRI-1937: the panel sends the server's account fields — email, name and password
Some checks failed
CI / cargo fmt (pull_request) Successful in 12s
CI / the pre-push hook (pull_request) Successful in 13s
CI / cargo deny advisories (pull_request) Failing after 2m3s
CI / cargo deny (pull_request) Successful in 2m5s
CI / cargo clippy (pull_request) Successful in 2m32s
CI / repository boundary (pull_request) Successful in 32s
CI / frontend-web (pull_request) Successful in 1m20s
CI / cargo test (pull_request) Successful in 7m58s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 9s
926cf4f543
The setup and login screens were written against the mock and sent
{username, password}; the server takes {email, name, password} for setup
and {email, password} for login, so a fresh install answered 422 to the
first account. The panel now uses the server's fields and UserView shape.

Two faults the same drift hid: GET /session with no cookie answers code
'unauthorized', and the panel only recognised 'not_authenticated', so a
returning visitor saw 'Could not reach the server' instead of the login
screen; and a plain-text framework rejection (a 4xx from axum's Json
extractor) broke the panel's JSON parse instead of showing the reason.

A test now pins the real client's wire format, which the mock cannot.
Merge pull request 'GRI-1937: panel sends email, name and password to setup and login' (#142) from fix/GRI-1937-panel-setup-email into dev
Some checks failed
CI / the pre-push hook (push) Successful in 15s
CI / cargo fmt (push) Successful in 16s
CI / cargo deny (push) Successful in 49s
CI / cargo deny advisories (push) Failing after 1m27s
CI / cargo clippy (push) Successful in 1m59s
CI / repository boundary (push) Successful in 33s
CI / the pre-push hook (pull_request) Successful in 27s
CI / cargo fmt (pull_request) Successful in 27s
CI / frontend-web (push) Successful in 1m57s
CI / cargo clippy (pull_request) Successful in 1m59s
CI / cargo deny (pull_request) Successful in 1m34s
CI / cargo deny advisories (pull_request) Failing after 1m32s
CI / cargo test (push) Successful in 6m4s
CI / frontend-web (pull_request) Successful in 1m45s
CI / CI (push) Successful in 18s
CI / Notify gate failed (push) Has been skipped
CI / repository boundary (pull_request) Successful in 31s
CI / cargo test (pull_request) Successful in 5m50s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 3s
57b52932f0
GRI-1937: install.sh gains upgrade, purge finds data after a plain uninstall, questions time out
Some checks failed
CI / cargo fmt (pull_request) Successful in 15s
CI / the pre-push hook (pull_request) Successful in 16s
CI / cargo clippy (pull_request) Successful in 1m49s
CI / cargo deny (pull_request) Successful in 1m41s
CI / cargo deny advisories (pull_request) Failing after 1m39s
CI / repository boundary (pull_request) Successful in 19s
CI / frontend-web (pull_request) Successful in 1m17s
CI / cargo test (pull_request) Successful in 3m52s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 4s
4e988c9e4a
Merge pull request 'GRI-1937: install.sh upgrade, purge after a plain uninstall, questions time out' (#143) from feature/GRI-1937-install-upgrade into dev
Some checks failed
CI / cargo fmt (push) Successful in 9s
CI / the pre-push hook (push) Successful in 14s
CI / cargo deny (push) Successful in 1m55s
CI / cargo clippy (push) Successful in 2m16s
CI / cargo deny advisories (push) Failing after 2m5s
CI / repository boundary (push) Successful in 37s
CI / the pre-push hook (pull_request) Successful in 40s
CI / cargo fmt (pull_request) Successful in 32s
CI / frontend-web (push) Successful in 1m49s
CI / cargo clippy (pull_request) Successful in 1m43s
CI / cargo test (push) Successful in 5m14s
CI / cargo deny (pull_request) Successful in 1m20s
CI / repository boundary (pull_request) Successful in 40s
CI / cargo deny advisories (pull_request) Failing after 1m18s
CI / frontend-web (pull_request) Successful in 1m22s
CI / cargo test (pull_request) Successful in 6m51s
CI / Notify gate failed (push) Has been skipped
CI / CI (push) Successful in 23s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 26s
9fcc0604c0
GRI-1937: session.secure_cookie setting — Secure stays the default, plain HTTP is an explicit choice
Some checks failed
CI / the pre-push hook (pull_request) Successful in 30s
CI / cargo fmt (pull_request) Successful in 34s
CI / cargo deny (pull_request) Successful in 1m22s
CI / cargo clippy (pull_request) Successful in 1m57s
CI / cargo deny advisories (pull_request) Failing after 1m47s
CI / frontend-web (pull_request) Successful in 2m11s
CI / repository boundary (pull_request) Successful in 54s
CI / cargo test (pull_request) Successful in 5m55s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 3s
75b063017f
Merge pull request 'GRI-1937: session.secure_cookie setting' (#144) from feature/GRI-1937-secure-cookie-setting into dev
Some checks failed
CI / cargo fmt (push) Successful in 12s
CI / the pre-push hook (push) Successful in 13s
CI / cargo deny advisories (push) Failing after 1m30s
CI / cargo clippy (push) Successful in 1m44s
CI / cargo deny (push) Successful in 1m32s
CI / the pre-push hook (pull_request) Successful in 37s
CI / repository boundary (push) Successful in 38s
CI / frontend-web (push) Successful in 1m21s
CI / cargo fmt (pull_request) Successful in 42s
CI / cargo clippy (pull_request) Successful in 1m52s
CI / cargo deny (pull_request) Successful in 1m18s
CI / cargo test (push) Successful in 5m19s
CI / cargo deny advisories (pull_request) Failing after 1m23s
CI / repository boundary (pull_request) Successful in 25s
CI / Notify gate failed (push) Has been skipped
CI / CI (push) Successful in 24s
CI / frontend-web (pull_request) Successful in 1m59s
CI / cargo test (pull_request) Successful in 5m33s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 4s
5adcbe9366
The server starts without a database and serves only the panel and the
setup routes. The panel writes its own settings file in the state
directory, between config.toml and the environment. A change applies
on restart, which the server does in place by exec of /proc/self/exe.
Step 1 asks whether a TLS reverse proxy is in front: with one, its
address (or trust all, with a warning) and the HTTPS-only cookie on as
an opt-out; without one, the cookie off as an opt-in, a public address
and the port. Step 2 asks for the database only in setup mode, shows
how to create it and tests it. Step 3 is the admin account. Settings
shows the same values, locks what the environment sets, and restarts
the server to apply a change.
GRI-1937: the setup status now says whether a database is configured
Some checks failed
CI / cargo fmt (pull_request) Successful in 11s
CI / the pre-push hook (pull_request) Successful in 12s
CI / cargo deny advisories (pull_request) Failing after 2m11s
CI / cargo deny (pull_request) Successful in 2m12s
CI / cargo clippy (pull_request) Successful in 2m49s
CI / repository boundary (pull_request) Successful in 48s
CI / frontend-web (pull_request) Successful in 1m44s
CI / cargo test (pull_request) Successful in 5m38s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 4s
fa1f208dcc
Merge pull request 'GRI-1937: setup wizard, setup mode and Settings screen' (#145) from feature/GRI-1937-setup-wizard into dev
Some checks failed
CI / the pre-push hook (push) Successful in 15s
CI / cargo fmt (push) Successful in 16s
CI / cargo deny advisories (push) Failing after 1m47s
CI / cargo deny (push) Successful in 1m49s
CI / cargo clippy (push) Successful in 2m53s
CI / repository boundary (push) Successful in 48s
CI / the pre-push hook (pull_request) Successful in 40s
CI / frontend-web (push) Successful in 1m30s
CI / cargo fmt (pull_request) Successful in 41s
CI / cargo deny (pull_request) Successful in 1m4s
CI / cargo clippy (pull_request) Successful in 1m34s
CI / cargo test (pull_request) Failing after 1m33s
CI / repository boundary (pull_request) Successful in 1m2s
CI / cargo test (push) Successful in 6m20s
CI / cargo deny advisories (pull_request) Failing after 2m5s
CI / frontend-web (pull_request) Successful in 1m48s
CI / Notify gate failed (push) Has been skipped
CI / CI (push) Successful in 28s
CI / CI (pull_request) Failing after 20s
CI / Notify gate failed (pull_request) Successful in 16s
4f07342750
GRI-1937: upgrade paths per install type, and the setup wizard in the deployment guide
Some checks failed
CI / the pre-push hook (pull_request) Successful in 37s
CI / cargo fmt (pull_request) Successful in 30s
CI / cargo deny (pull_request) Successful in 2m2s
CI / cargo deny advisories (pull_request) Failing after 1m58s
CI / cargo clippy (pull_request) Successful in 2m32s
CI / repository boundary (pull_request) Successful in 45s
CI / frontend-web (pull_request) Successful in 1m33s
CI / cargo test (pull_request) Successful in 5m44s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 6s
e431c54eb6
Merge pull request 'GRI-1937: upgrade paths per install type, and the setup wizard in the deployment guide' (#146) from docs/GRI-1937-upgrade-paths into dev
Some checks failed
CI / the pre-push hook (push) Successful in 16s
CI / cargo fmt (push) Successful in 16s
CI / cargo deny advisories (push) Failing after 2m0s
CI / cargo deny (push) Successful in 2m7s
CI / cargo clippy (push) Successful in 2m40s
CI / repository boundary (push) Successful in 1m18s
CI / frontend-web (push) Successful in 2m10s
CI / cargo test (push) Successful in 10m33s
CI / Notify gate failed (push) Has been skipped
CI / CI (push) Successful in 15s
CI / cargo fmt (pull_request) Successful in 11s
CI / the pre-push hook (pull_request) Successful in 12s
CI / cargo deny (pull_request) Successful in 1m45s
CI / cargo deny advisories (pull_request) Failing after 1m52s
CI / cargo clippy (pull_request) Successful in 2m11s
CI / repository boundary (pull_request) Successful in 31s
CI / frontend-web (pull_request) Successful in 1m33s
CI / cargo test (pull_request) Successful in 4m45s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 10s
bc13b82a0e
aegis approved these changes 2026-11-12 18:45:13 +00:00
Dismissed
aegis left a comment

Re-reviewed after dev advanced to bc13b82 (PRs #141-#146, GRI-1937/GRI-1936: install.sh PostgreSQL automation + upgrade/uninstall/purge, the panel setup wizard, Settings screen, session.secure_cookie, panel-writable settings file). Delta reviewed: 112d945c..bc13b82 (36 files, +3323/-195).

Checked in detail:

  • Session cookie (auth/session.rs, config.rs): CookieSecurity defaults to Secure: true; a router that forgets to layer it fails closed, not open (cookie_security() unwraps to CookieSecurity::default()). session.secure_cookie = false is only reachable through an explicit operator choice (config, env, or the wizard's "no reverse proxy" branch), never a silent default. Tests cover both states.
  • Panel-writable settings (settings.rs, new): SetupOrSignedIn extractor correctly gates /settings, /server/restart, /setup/database* — open only pre-database or pre-first-user, a signed-in session required after. No user-deletion feature exists in this release, so that window cannot be reopened once an admin exists. Settings file written via temp-file+rename at mode 0600 (can hold the DB password). database_url/database_allow_plaintext never exposed back through GET /settings (only a boolean). Environment variables still win over the panel (environment_pins locks those fields in the UI, and put_settings/save_database both refuse a locked key server-side, not just in the UI).
  • test_database/save_database SSRF surface: save_database and the real DB connection are correctly restricted to setup_mode_only (no pool yet) — the code even comments on why ("otherwise this is a way to make the server open connections to any host and port somebody names"). Non-blocking residual risk: while in that pre-setup window, test_database/save_database do let an unauthenticated LAN client make the server open TCP connections to arbitrary host:port combinations it names, with distinguishable timeout/refused/connected responses — a blind internal-network-reachability probe. This is the same trust window already accepted for POST /api/v1/setup (anybody reaches the wizard first), not a new trust boundary, and is required for the wizard's "test this database" UX. No action needed for this release; worth a line in the deployment doc that the panel should not be exposed to an untrusted network before setup completes (it's partially already implied).
  • install.sh: PostgreSQL automation (install/uninstall/purge/upgrade/reinstall) reviewed for injection and destructive-path risk. deletable_path() rejects anything that isn't a two-level absolute path before any rm -rf. drop_local_database validates the db/user names extracted from database.env against ^[A-Za-z0-9_]+$ before interpolating into psql — the one place a stored value reaches SQL. Random Postgres password via openssl rand -hex 24. --purge always asks for confirmation (or requires --yes with no terminal); Docker volume removal is scoped by compose labels so another project's same-named volume is never touched.
  • GRI-1884 (no hardcoding): database URL, settings-file path (SIGNAGE_SETTINGS_FILE), trusted proxies, secure-cookie policy, HTTP bind/port/public URL are all config/env/panel-settable with no secret or endpoint baked into source; config.toml.example ships a commented-out placeholder, not a live default.
  • Frontend (NetworkFields.tsx, SetupWizard.tsx): "Trust every address" and "send cookie over plain HTTP" both default to off/secure and carry explicit inline warnings when turned on; neither is a silent default.

Nothing here touches the GRI-1922 login-throttling fix, which is unaffected by this delta.

Did not merge — that stays the product owner's call on main.

Re-reviewed after dev advanced to bc13b82 (PRs #141-#146, GRI-1937/GRI-1936: install.sh PostgreSQL automation + upgrade/uninstall/purge, the panel setup wizard, Settings screen, session.secure_cookie, panel-writable settings file). Delta reviewed: 112d945c..bc13b82 (36 files, +3323/-195). Checked in detail: - **Session cookie (`auth/session.rs`, `config.rs`)**: `CookieSecurity` defaults to `Secure: true`; a router that forgets to layer it fails closed, not open (`cookie_security()` unwraps to `CookieSecurity::default()`). `session.secure_cookie = false` is only reachable through an explicit operator choice (config, env, or the wizard's "no reverse proxy" branch), never a silent default. Tests cover both states. - **Panel-writable settings (`settings.rs`, new)**: `SetupOrSignedIn` extractor correctly gates `/settings`, `/server/restart`, `/setup/database*` — open only pre-database or pre-first-user, a signed-in session required after. No user-deletion feature exists in this release, so that window cannot be reopened once an admin exists. Settings file written via temp-file+rename at mode `0600` (can hold the DB password). `database_url`/`database_allow_plaintext` never exposed back through `GET /settings` (only a boolean). Environment variables still win over the panel (`environment_pins` locks those fields in the UI, and `put_settings`/`save_database` both refuse a locked key server-side, not just in the UI). - **`test_database`/`save_database` SSRF surface**: `save_database` and the real DB connection are correctly restricted to `setup_mode_only` (no pool yet) — the code even comments on why ("otherwise this is a way to make the server open connections to any host and port somebody names"). Non-blocking residual risk: while in that pre-setup window, `test_database`/`save_database` do let an unauthenticated LAN client make the server open TCP connections to arbitrary host:port combinations it names, with distinguishable timeout/refused/connected responses — a blind internal-network-reachability probe. This is the same trust window already accepted for `POST /api/v1/setup` (anybody reaches the wizard first), not a new trust boundary, and is required for the wizard's "test this database" UX. No action needed for this release; worth a line in the deployment doc that the panel should not be exposed to an untrusted network before setup completes (it's partially already implied). - **`install.sh`**: PostgreSQL automation (install/uninstall/purge/upgrade/reinstall) reviewed for injection and destructive-path risk. `deletable_path()` rejects anything that isn't a two-level absolute path before any `rm -rf`. `drop_local_database` validates the db/user names extracted from `database.env` against `^[A-Za-z0-9_]+$` before interpolating into `psql` — the one place a stored value reaches SQL. Random Postgres password via `openssl rand -hex 24`. `--purge` always asks for confirmation (or requires `--yes` with no terminal); Docker volume removal is scoped by compose labels so another project's same-named volume is never touched. - **GRI-1884 (no hardcoding)**: database URL, settings-file path (`SIGNAGE_SETTINGS_FILE`), trusted proxies, secure-cookie policy, HTTP bind/port/public URL are all config/env/panel-settable with no secret or endpoint baked into source; `config.toml.example` ships a commented-out placeholder, not a live default. - **Frontend (`NetworkFields.tsx`, `SetupWizard.tsx`)**: "Trust every address" and "send cookie over plain HTTP" both default to off/secure and carry explicit inline warnings when turned on; neither is a silent default. Nothing here touches the GRI-1922 login-throttling fix, which is unaffected by this delta. Did not merge — that stays the product owner's call on `main`.
GRI-1941: add the Grimoirix design system, colour scheme and example page
Some checks failed
CI / the pre-push hook (pull_request) Successful in 7s
CI / cargo fmt (pull_request) Successful in 7s
CI / cargo clippy (pull_request) Successful in 1m47s
CI / cargo deny advisories (pull_request) Failing after 2m15s
CI / cargo deny (pull_request) Successful in 2m20s
CI / frontend-web (pull_request) Failing after 1m55s
CI / repository boundary (pull_request) Successful in 35s
CI / CI (pull_request) Has been cancelled
CI / Notify gate failed (pull_request) Has been cancelled
CI / cargo test (pull_request) Has been cancelled
403011b805
GRI-1941: one set of design token names, and self-hosted fonts (template 425cb03)
Some checks failed
CI / the pre-push hook (pull_request) Successful in 22s
CI / cargo fmt (pull_request) Successful in 30s
CI / cargo deny (pull_request) Successful in 1m40s
CI / cargo clippy (pull_request) Successful in 2m10s
CI / frontend-web (pull_request) Failing after 1m17s
CI / cargo deny advisories (pull_request) Failing after 1m18s
CI / repository boundary (pull_request) Successful in 47s
CI / cargo test (pull_request) Successful in 5m47s
CI / CI (pull_request) Failing after 10s
CI / Notify gate failed (pull_request) Successful in 18s
207aeb9fc1
GRI-1941: design template v0.1.0 — SCSS source, compiled CSS, gx- components and the theme switch (TS)
Some checks failed
CI / the pre-push hook (pull_request) Successful in 15s
CI / cargo fmt (pull_request) Successful in 18s
CI / cargo deny (pull_request) Successful in 1m43s
CI / cargo deny advisories (pull_request) Failing after 1m39s
CI / cargo clippy (pull_request) Successful in 2m0s
CI / repository boundary (pull_request) Successful in 30s
CI / frontend-web (pull_request) Successful in 1m53s
CI / cargo test (pull_request) Successful in 4m48s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 16s
04a14d6ec8
Merge pull request 'GRI-1941: add the Grimoirix design system, colour scheme and example page' (#147) from docs/GRI-1941-grimoirix-design into dev
Some checks failed
CI / the pre-push hook (push) Successful in 29s
CI / cargo fmt (push) Successful in 24s
CI / cargo clippy (push) Successful in 1m39s
CI / cargo deny (push) Successful in 1m13s
CI / cargo deny advisories (push) Failing after 1m7s
CI / frontend-web (push) Successful in 1m12s
CI / repository boundary (push) Successful in 24s
CI / the pre-push hook (pull_request) Successful in 26s
CI / cargo fmt (pull_request) Successful in 43s
CI / cargo test (push) Successful in 7m14s
CI / cargo clippy (pull_request) Successful in 2m21s
CI / cargo deny (pull_request) Successful in 1m0s
CI / cargo deny advisories (pull_request) Failing after 1m4s
CI / repository boundary (pull_request) Successful in 18s
CI / CI (push) Successful in 5s
CI / Notify gate failed (push) Has been skipped
CI / frontend-web (pull_request) Successful in 1m46s
CI / cargo test (pull_request) Failing after 15m0s
CI / CI (pull_request) Has been cancelled
CI / Notify gate failed (pull_request) Has been cancelled
03d3bda8e6
vivy dismissed aegis's review 2026-11-12 22:41:08 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

GRI-1946: apply the Grimoirix design system to frontend-web
Some checks failed
CI / cargo fmt (pull_request) Successful in 28s
CI / the pre-push hook (pull_request) Successful in 34s
CI / cargo clippy (pull_request) Successful in 2m6s
CI / cargo deny (pull_request) Successful in 1m47s
CI / cargo deny advisories (pull_request) Failing after 1m48s
CI / repository boundary (pull_request) Successful in 29s
CI / frontend-web (pull_request) Successful in 1m27s
CI / cargo test (pull_request) Successful in 4m23s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 9s
1298da5299
Load the template's compiled tokens, fonts and gx- components into the
global stylesheet, wire a dark/light toggle that remembers the choice
(dark by default), and restyle every screen's buttons, inputs, cards,
notes and tags with the gx- classes instead of unstyled elements.
Merge pull request 'GRI-1946: apply the Grimoirix design system to the web front end' (#149) from feature/GRI-1946-grimoirix-design-system into dev
Some checks failed
CI / the pre-push hook (push) Successful in 45s
CI / cargo fmt (push) Successful in 24s
CI / cargo clippy (push) Successful in 1m26s
CI / cargo deny (push) Successful in 1m40s
CI / cargo deny advisories (push) Failing after 58s
CI / frontend-web (push) Successful in 1m58s
CI / repository boundary (push) Successful in 31s
CI / cargo test (push) Successful in 7m24s
CI / cargo fmt (pull_request) Successful in 58s
CI / the pre-push hook (pull_request) Successful in 59s
CI / cargo clippy (pull_request) Successful in 2m4s
CI / cargo deny (pull_request) Successful in 1m31s
CI / cargo deny advisories (pull_request) Failing after 1m39s
CI / frontend-web (pull_request) Successful in 1m33s
CI / repository boundary (pull_request) Successful in 25s
CI / CI (push) Successful in 15s
CI / Notify gate failed (push) Has been skipped
CI / cargo test (pull_request) Successful in 8m24s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 22s
20518cdab7
vivy requested review from aegis 2026-11-13 00:29:43 +00:00
aegis approved these changes 2026-11-13 00:30:59 +00:00
Dismissed
aegis left a comment

Re-reviewed after dev advanced to 20518cd (#147 design system docs/tokens, #149 apply design system to frontend-web), dismissing approval 442.

Delta bc13b82..20518cd (36 files, +2676/-261) is purely presentational: new SCSS/CSS design tokens and compiled stylesheet, static font files (OFL-licensed, self-hosted, no external font-loading calls), a standalone theme.ts/theme.global.js light/dark toggle, and the corresponding className/markup churn across the existing screens to adopt it.

Verified no logic changes rode along with the restyle: grepped the full diff for fetch(/credentials:/Authorization/FormData/method: and any added API call -- none. The only storage use is localStorage for the theme preference string ("dark"/"light"), not for any token/session data, and every access is try/catch-guarded so it fails closed to the in-memory default rather than breaking the page. No dangerouslySetInnerHTML/innerHTML/eval added. The two bare http:// / https:// strings in the diff are SettingsScreen UI copy describing the existing secure-cookie warning, not a hardcoded endpoint (GRI-1884) -- consistent with what was already reviewed at bc13b82.

All prior findings stand unchanged: login throttling (GRI-1922) fix untouched, device-groups matching (GRI-1896) untouched, install.sh/settings.rs (GRI-1937/1936) untouched. Posted APPROVED as an official review on PR #136, pinned to 20518cd. Did not merge -- that stays the product owner's call on main.

Re-reviewed after dev advanced to 20518cd (#147 design system docs/tokens, #149 apply design system to frontend-web), dismissing approval 442. Delta bc13b82..20518cd (36 files, +2676/-261) is purely presentational: new SCSS/CSS design tokens and compiled stylesheet, static font files (OFL-licensed, self-hosted, no external font-loading calls), a standalone theme.ts/theme.global.js light/dark toggle, and the corresponding className/markup churn across the existing screens to adopt it. Verified no logic changes rode along with the restyle: grepped the full diff for fetch(/credentials:/Authorization/FormData/method: and any added API call -- none. The only storage use is `localStorage` for the *theme preference string* ("dark"/"light"), not for any token/session data, and every access is try/catch-guarded so it fails closed to the in-memory default rather than breaking the page. No dangerouslySetInnerHTML/innerHTML/eval added. The two bare http:// / https:// strings in the diff are SettingsScreen UI copy describing the existing secure-cookie warning, not a hardcoded endpoint (GRI-1884) -- consistent with what was already reviewed at bc13b82. All prior findings stand unchanged: login throttling (GRI-1922) fix untouched, device-groups matching (GRI-1896) untouched, install.sh/settings.rs (GRI-1937/1936) untouched. Posted **APPROVED** as an official review on PR #136, pinned to 20518cd. Did not merge -- that stays the product owner's call on main.
test(client): add offline playback cache test
Some checks failed
CI / the pre-push hook (pull_request) Successful in 8s
CI / cargo fmt (pull_request) Successful in 8s
CI / cargo deny advisories (pull_request) Failing after 1m27s
CI / cargo deny (pull_request) Successful in 1m29s
CI / cargo clippy (pull_request) Successful in 1m37s
CI / repository boundary (pull_request) Successful in 24s
CI / frontend-web (pull_request) Successful in 1m7s
CI / cargo test (pull_request) Successful in 5m47s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 3s
3a43c05e30
A device unplugged for 24h keeps playing its playlist from the cache it
already holds, instead of falling back to the waiting screen.
Merge pull request 'GRI-1950: Test: a device offline for a day keeps playing' (#150) from test/GRI-1950-offline-playback into dev
Some checks failed
CI / cargo fmt (push) Successful in 7s
CI / the pre-push hook (push) Successful in 8s
CI / cargo deny advisories (push) Failing after 1m52s
CI / cargo deny (push) Successful in 1m54s
CI / cargo clippy (push) Successful in 2m13s
CI / repository boundary (push) Successful in 27s
CI / the pre-push hook (pull_request) Successful in 33s
CI / cargo fmt (pull_request) Successful in 20s
CI / frontend-web (push) Successful in 1m42s
CI / cargo clippy (pull_request) Successful in 2m0s
CI / cargo test (push) Successful in 5m26s
CI / cargo deny (pull_request) Successful in 1m52s
CI / cargo deny advisories (pull_request) Failing after 1m19s
CI / repository boundary (pull_request) Successful in 40s
CI / Notify gate failed (push) Has been skipped
CI / CI (push) Successful in 29s
CI / frontend-web (pull_request) Successful in 1m35s
CI / cargo test (pull_request) Successful in 6m3s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 13s
6bbc9fb847
voidgazer dismissed aegis's review 2026-11-13 02:48:10 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

GRI-1941: use the npm package @grimoirix/design instead of a copied design/ folder
Some checks failed
CI / the pre-push hook (pull_request) Successful in 5s
CI / cargo fmt (pull_request) Successful in 6s
CI / cargo clippy (pull_request) Successful in 1m30s
CI / cargo deny (pull_request) Successful in 1m6s
CI / cargo deny advisories (pull_request) Failing after 1m12s
CI / repository boundary (pull_request) Successful in 27s
CI / frontend-web (pull_request) Successful in 1m26s
CI / cargo test (pull_request) Successful in 5m25s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 9s
c1d7535290
Merge pull request 'GRI-1941: use the npm package @grimoirix/design instead of a copied design/ folder' (#151) from chore/GRI-1941-design-package into dev
Some checks failed
CI / the pre-push hook (push) Successful in 24s
CI / cargo fmt (push) Successful in 24s
CI / cargo clippy (push) Successful in 1m54s
CI / cargo deny (push) Successful in 1m32s
CI / cargo deny advisories (push) Failing after 1m32s
CI / the pre-push hook (pull_request) Successful in 33s
CI / repository boundary (push) Successful in 37s
CI / cargo fmt (pull_request) Successful in 35s
CI / frontend-web (push) Successful in 1m28s
CI / cargo clippy (pull_request) Successful in 2m7s
CI / cargo deny (pull_request) Successful in 1m30s
CI / cargo deny advisories (pull_request) Failing after 1m29s
CI / frontend-web (pull_request) Successful in 1m50s
CI / repository boundary (pull_request) Successful in 49s
CI / cargo test (push) Successful in 7m12s
CI / cargo test (pull_request) Successful in 7m41s
CI / CI (push) Successful in 38s
CI / Notify gate failed (push) Has been skipped
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 32s
2f15e1ed9c
GRI-1937: native server install also installs poppler-utils
Some checks failed
CI / the pre-push hook (pull_request) Successful in 11s
CI / cargo fmt (pull_request) Successful in 11s
CI / cargo deny advisories (pull_request) Failing after 1m41s
CI / cargo clippy (pull_request) Successful in 1m53s
CI / cargo deny (pull_request) Successful in 1m46s
CI / repository boundary (pull_request) Successful in 20s
CI / frontend-web (pull_request) Successful in 1m24s
CI / cargo test (pull_request) Successful in 4m13s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 22s
d36e62c338
The server shells out to pdftoppm for PDF uploads. The container image
installs poppler-utils; the native path (install, reinstall, upgrade) did
not, so a PDF upload failed with 'pdftoppm is not installed'.
Merge pull request 'GRI-1937: native server install also installs poppler-utils' (#152) from fix/GRI-1937-native-poppler into dev
Some checks failed
CI / the pre-push hook (push) Successful in 34s
CI / cargo fmt (push) Successful in 31s
CI / cargo clippy (push) Successful in 2m2s
CI / cargo deny (push) Successful in 1m56s
CI / repository boundary (push) Successful in 57s
CI / cargo deny advisories (push) Failing after 2m24s
CI / frontend-web (push) Successful in 1m47s
CI / cargo test (pull_request) Has been cancelled
CI / cargo deny (pull_request) Has been cancelled
CI / cargo deny advisories (pull_request) Has been cancelled
CI / frontend-web (pull_request) Has been cancelled
CI / repository boundary (pull_request) Has been cancelled
CI / CI (pull_request) Has been cancelled
CI / Notify gate failed (pull_request) Has been cancelled
CI / cargo clippy (pull_request) Has been cancelled
CI / cargo fmt (pull_request) Has been cancelled
CI / cargo test (push) Successful in 7m1s
CI / the pre-push hook (pull_request) Has been cancelled
CI / CI (push) Successful in 11s
CI / Notify gate failed (push) Has been skipped
f8f4d25652
GRI-1937: a whole PDF can be added to a playlist
Some checks failed
CI / the pre-push hook (pull_request) Successful in 10s
CI / cargo fmt (pull_request) Successful in 10s
CI / cargo deny (pull_request) Successful in 1m26s
CI / cargo deny advisories (pull_request) Failing after 1m39s
CI / cargo clippy (pull_request) Successful in 1m56s
CI / repository boundary (pull_request) Successful in 29s
CI / frontend-web (pull_request) Successful in 2m2s
CI / cargo test (pull_request) Successful in 5m26s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 28s
cc94fd19d2
The panel library lists an uploaded PDF as one 'document' entry, and saving
a playlist with it failed: 'item 0: "document" is not a known item kind'.
A page could not be saved either, because the panel sent no page number and
the server stored none for it.

- media: pages carry document_id and page (migration 0004, with a backfill
  for existing pages that links a PDF only when the page count matches);
  deleting a PDF deletes its pages and their files.
- playlists: kind 'document' expands into one document_page item per page,
  in page order; a document_page without page takes it from its media row.
- panel: sends 'document' for a whole PDF and the page number for a page;
  labels PDF entries 'all pages' / 'page N'.
Merge pull request 'GRI-1937: a whole PDF can be added to a playlist' (#153) from fix/GRI-1937-playlist-document into dev
Some checks failed
CI / the pre-push hook (push) Successful in 32s
CI / cargo fmt (push) Successful in 41s
CI / cargo clippy (push) Successful in 1m35s
CI / cargo test (push) Failing after 2m0s
CI / cargo deny (push) Successful in 1m29s
CI / repository boundary (push) Successful in 44s
CI / cargo deny advisories (push) Failing after 1m42s
CI / the pre-push hook (pull_request) Successful in 53s
CI / frontend-web (push) Successful in 1m39s
CI / cargo fmt (pull_request) Successful in 29s
CI / cargo clippy (pull_request) Successful in 2m13s
CI / cargo deny advisories (pull_request) Failing after 1m58s
CI / cargo deny (pull_request) Successful in 1m59s
CI / repository boundary (pull_request) Successful in 15s
CI / CI (push) Failing after 10s
CI / Notify gate failed (push) Has been skipped
CI / frontend-web (pull_request) Successful in 1m20s
CI / cargo test (pull_request) Successful in 5m12s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 15s
5fa3ecfa0e
Asks the desktop over the session D-Bus not to blank the screen or suspend:
GNOME session manager, else the XDG portal, else org.freedesktop.ScreenSaver.
On by default; keep_awake = false in client.toml or
GRIMOIRIX_SIGNAGE_KEEP_AWAKE=0 turns it off.
GRI-1937: document keep_awake in the client deployment section
Some checks failed
CI / the pre-push hook (pull_request) Successful in 34s
CI / cargo fmt (pull_request) Successful in 35s
CI / cargo clippy (pull_request) Successful in 1m54s
CI / cargo deny (pull_request) Successful in 1m30s
CI / repository boundary (pull_request) Successful in 33s
CI / cargo deny advisories (pull_request) Failing after 1m42s
CI / frontend-web (pull_request) Successful in 2m19s
CI / cargo test (pull_request) Successful in 7m5s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 14s
56a78995a6
Merge pull request 'GRI-1937: the client keeps the screen on while it runs' (#154) from feature/GRI-1937-client-no-sleep into dev
Some checks failed
CI / cargo fmt (push) Successful in 10s
CI / the pre-push hook (push) Successful in 12s
CI / cargo deny (push) Successful in 1m41s
CI / cargo deny advisories (push) Failing after 1m42s
CI / repository boundary (push) Successful in 33s
CI / cargo clippy (push) Successful in 2m39s
CI / the pre-push hook (pull_request) Successful in 31s
CI / cargo fmt (pull_request) Successful in 43s
CI / frontend-web (push) Successful in 1m34s
CI / cargo deny (pull_request) Successful in 1m17s
CI / cargo clippy (pull_request) Successful in 1m47s
CI / cargo test (pull_request) Failing after 1m27s
CI / repository boundary (pull_request) Successful in 58s
CI / cargo deny advisories (pull_request) Failing after 1m11s
CI / cargo test (push) Successful in 6m15s
CI / Notify gate failed (push) Has been skipped
CI / CI (push) Successful in 14s
CI / frontend-web (pull_request) Successful in 1m51s
CI / CI (pull_request) Failing after 5s
CI / Notify gate failed (pull_request) Successful in 4s
ab0cae51d5
GRI-1899: client state in SQLite through sqlx, state.json imported once
Some checks failed
CI / the pre-push hook (pull_request) Successful in 43s
CI / cargo fmt (pull_request) Successful in 48s
CI / cargo deny advisories (pull_request) Failing after 1m48s
CI / cargo deny (pull_request) Successful in 2m10s
CI / cargo clippy (pull_request) Successful in 3m22s
CI / repository boundary (pull_request) Successful in 1m1s
CI / frontend-web (pull_request) Successful in 1m58s
CI / cargo test (pull_request) Successful in 6m55s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 5s
99a2f328dc
The client kept identity, last playlist and last manifest in state.json.
ADR 0003 puts it in SQLite through sqlx: client.db, WAL, synchronous=FULL,
one transaction per change, mode 0600. An existing state.json is imported
into an empty database on first start and renamed to state.json.imported;
a corrupt one stops the start and is left alone.

The workspace sqlx entry now carries only shared features; the server adds
postgres, the client adds sqlite, so neither links the other's driver.
Merge pull request 'GRI-1899: client state in SQLite through sqlx' (#164) from feature/GRI-1899-client-sqlite-state into dev
Some checks failed
CI / the pre-push hook (push) Successful in 27s
CI / cargo fmt (push) Successful in 28s
CI / cargo deny advisories (push) Failing after 1m44s
CI / cargo deny (push) Successful in 1m45s
CI / cargo clippy (push) Successful in 2m34s
CI / the pre-push hook (pull_request) Successful in 43s
CI / repository boundary (push) Successful in 1m13s
CI / cargo fmt (pull_request) Successful in 35s
CI / frontend-web (push) Successful in 2m29s
CI / cargo clippy (pull_request) Successful in 1m54s
CI / cargo test (pull_request) Failing after 1m53s
CI / cargo deny (pull_request) Successful in 1m21s
CI / cargo deny advisories (pull_request) Failing after 1m20s
CI / repository boundary (pull_request) Successful in 59s
CI / cargo test (push) Successful in 7m43s
CI / frontend-web (pull_request) Successful in 1m55s
CI / Notify gate failed (push) Has been skipped
CI / Notify gate failed (pull_request) Successful in 24s
CI / CI (pull_request) Failing after 29s
CI / CI (push) Successful in 31s
c4e72cdabc
GRI-1962: name blocking playlists on media delete conflict and offer remove-and-delete
Some checks failed
CI / the pre-push hook (pull_request) Successful in 13s
CI / cargo fmt (pull_request) Successful in 16s
CI / cargo clippy (pull_request) Successful in 2m13s
CI / cargo deny advisories (pull_request) Failing after 2m3s
CI / cargo deny (pull_request) Successful in 2m6s
CI / repository boundary (pull_request) Successful in 46s
CI / frontend-web (pull_request) Successful in 1m25s
CI / cargo test (pull_request) Failing after 5m56s
CI / CI (pull_request) Failing after 32s
CI / Notify gate failed (pull_request) Successful in 25s
6aa9edc604
Media delete now answers 409 media_in_use with the playlists referencing the
document or its pages. The panel shows that list and offers removing the
item from those playlists before deleting, instead of a generic retry message.
Merge remote-tracking branch 'origin/dev' into fix/GRI-1962-media-delete-in-use-playlists
Some checks failed
CI / the pre-push hook (pull_request) Successful in 13s
CI / cargo fmt (pull_request) Successful in 12s
CI / cargo deny advisories (pull_request) Failing after 1m31s
CI / cargo deny (pull_request) Successful in 1m37s
CI / cargo clippy (pull_request) Successful in 2m14s
CI / repository boundary (pull_request) Successful in 57s
CI / frontend-web (pull_request) Successful in 1m47s
CI / cargo test (pull_request) Successful in 6m39s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 3s
d7a6c14ebd
Merge pull request 'GRI-1962: name blocking playlists on media delete conflict' (#163) from fix/GRI-1962-media-delete-in-use-playlists into dev
Some checks failed
CI / cargo fmt (push) Successful in 11s
CI / the pre-push hook (push) Successful in 12s
CI / cargo clippy (push) Successful in 2m18s
CI / cargo deny (push) Successful in 2m8s
CI / repository boundary (push) Successful in 24s
CI / the pre-push hook (pull_request) Successful in 29s
CI / cargo fmt (pull_request) Successful in 30s
CI / frontend-web (push) Successful in 1m47s
CI / cargo test (push) Successful in 5m22s
CI / cargo clippy (pull_request) Successful in 2m6s
CI / cargo deny (pull_request) Successful in 1m44s
CI / repository boundary (pull_request) Successful in 37s
CI / cargo deny advisories (pull_request) Failing after 1m43s
CI / frontend-web (pull_request) Successful in 2m5s
CI / cargo deny advisories (push) Failing after 12m12s
CI / Notify gate failed (push) Has been skipped
CI / CI (push) Successful in 59s
CI / cargo test (pull_request) Successful in 10m37s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 26s
ad79695e23
GRI-1964: campus as owner of media, playlists, devices and IP rules
Some checks failed
CI / cargo fmt (pull_request) Successful in 9s
CI / the pre-push hook (pull_request) Successful in 9s
CI / cargo deny advisories (pull_request) Failing after 1m53s
CI / cargo deny (pull_request) Successful in 1m54s
CI / cargo clippy (pull_request) Successful in 2m27s
CI / repository boundary (pull_request) Successful in 1m15s
CI / frontend-web (pull_request) Successful in 2m14s
CI / cargo test (pull_request) Successful in 7m14s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 3s
bdaf38a84c
Adds a campus table (AM, HE, JO, NO, seeded as data per GRI-1884) and a
nullable campus_id on media, playlists, devices and ip_rules, per the
product owner's decision on GRI-1960 (forge #159): an object belongs to
exactly one campus or to all (NULL), never two or three.

A playlist may only take media of its own campus or media shared across
every campus; the reverse holds too, so a shared playlist cannot take one
campus's exclusive media. A device auto-approved through a campus-scoped
IP rule inherits that rule's campus; an admin can assign one by hand
through PATCH /devices/{id}.

Caller-side scoping (listing only the campuses a user is granted, and the
404-not-403 rule for a direct id of another campus) depends on user scope,
which is #44 and not yet built — the data model here is what #44 wires
up to.
Merge remote-tracking branch 'origin/dev' into feature/GRI-1964-campus-ownership
Some checks failed
CI / the pre-push hook (pull_request) Successful in 51s
CI / cargo fmt (pull_request) Successful in 51s
CI / cargo deny (pull_request) Successful in 1m31s
CI / cargo clippy (pull_request) Successful in 2m30s
CI / cargo deny advisories (pull_request) Failing after 1m53s
CI / frontend-web (pull_request) Successful in 2m18s
CI / repository boundary (pull_request) Successful in 1m8s
CI / cargo test (pull_request) Successful in 10m50s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 4s
e48eff1af2
Merge pull request 'GRI-1964: campus as owner of media, playlists, devices and IP rules' (#162) from feature/GRI-1964-campus-ownership into dev
Some checks failed
CI / the pre-push hook (push) Successful in 35s
CI / cargo fmt (push) Successful in 1m7s
CI / cargo deny (push) Successful in 1m33s
CI / cargo clippy (push) Successful in 2m8s
CI / cargo deny advisories (push) Failing after 1m33s
CI / repository boundary (push) Successful in 49s
CI / the pre-push hook (pull_request) Successful in 39s
CI / cargo fmt (pull_request) Successful in 36s
CI / frontend-web (push) Successful in 1m42s
CI / cargo clippy (pull_request) Successful in 2m9s
CI / cargo deny (pull_request) Successful in 1m39s
CI / cargo deny advisories (pull_request) Failing after 1m18s
CI / frontend-web (pull_request) Successful in 1m18s
CI / repository boundary (pull_request) Successful in 50s
CI / cargo test (push) Successful in 7m49s
CI / Notify gate failed (push) Has been skipped
CI / CI (push) Successful in 4s
CI / cargo test (pull_request) Failing after 15m36s
CI / CI (pull_request) Has been cancelled
CI / Notify gate failed (pull_request) Has been cancelled
33253b270d
GRI-1898: per-device transcoding profiles
Some checks failed
CI / cargo fmt (pull_request) Successful in 19s
CI / the pre-push hook (pull_request) Successful in 28s
CI / cargo clippy (pull_request) Successful in 3m4s
CI / cargo deny (pull_request) Successful in 3m0s
CI / cargo deny advisories (pull_request) Failing after 2m58s
CI / repository boundary (pull_request) Successful in 43s
CI / frontend-web (pull_request) Successful in 1m41s
CI / cargo test (pull_request) Successful in 5m43s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 39s
9283f22df6
Merge pull request 'GRI-1898: per-device transcoding profiles' (#165) from feature/GRI-1898-per-device-transcoding-profiles into dev
Some checks failed
CI / cargo fmt (push) Successful in 12s
CI / the pre-push hook (push) Successful in 13s
CI / cargo deny advisories (push) Failing after 1m42s
CI / cargo deny (push) Successful in 1m48s
CI / cargo clippy (push) Successful in 2m25s
CI / repository boundary (push) Successful in 48s
CI / the pre-push hook (pull_request) Successful in 52s
CI / cargo fmt (pull_request) Successful in 49s
CI / frontend-web (push) Successful in 1m54s
CI / cargo deny (pull_request) Successful in 1m51s
CI / cargo test (pull_request) Failing after 2m2s
CI / cargo clippy (pull_request) Successful in 2m52s
CI / repository boundary (pull_request) Successful in 1m14s
CI / cargo deny advisories (pull_request) Failing after 1m49s
CI / frontend-web (pull_request) Successful in 2m21s
CI / cargo test (push) Successful in 8m58s
CI / Notify gate failed (push) Has been skipped
CI / Notify gate failed (pull_request) Successful in 1m0s
CI / CI (pull_request) Failing after 1m2s
CI / CI (push) Successful in 18s
afe0f41d69
GRI-1962: push the changed playlist to its devices on a media delete that detaches it
Some checks failed
CI / the pre-push hook (pull_request) Successful in 28s
CI / cargo fmt (pull_request) Failing after 28s
CI / cargo deny (pull_request) Successful in 1m46s
CI / cargo deny advisories (pull_request) Failing after 1m45s
CI / cargo clippy (pull_request) Successful in 2m32s
CI / repository boundary (pull_request) Successful in 1m16s
CI / frontend-web (pull_request) Successful in 2m2s
CI / cargo test (pull_request) Failing after 14m10s
CI / Notify gate failed (pull_request) Successful in 39s
CI / CI (pull_request) Failing after 39s
16cb9800e6
GRI-1962: run cargo fmt
Some checks failed
CI / the pre-push hook (pull_request) Successful in 1m43s
CI / cargo fmt (pull_request) Successful in 2m3s
CI / cargo clippy (pull_request) Successful in 2m51s
CI / cargo deny (pull_request) Successful in 3m2s
CI / cargo deny advisories (pull_request) Failing after 2m17s
CI / frontend-web (pull_request) Successful in 2m39s
CI / repository boundary (pull_request) Successful in 32s
CI / cargo test (pull_request) Successful in 8m28s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 23s
a1528ce201
Merge pull request 'GRI-1962: push the changed playlist to its devices on a media delete' (#167) from fix/GRI-1962-push-playlist-on-media-delete into dev
Some checks failed
CI / the pre-push hook (pull_request) Has been cancelled
CI / cargo fmt (pull_request) Has been cancelled
CI / cargo clippy (pull_request) Has been cancelled
CI / cargo test (pull_request) Has been cancelled
CI / cargo deny (pull_request) Has been cancelled
CI / cargo deny advisories (pull_request) Has been cancelled
CI / frontend-web (pull_request) Has been cancelled
CI / repository boundary (pull_request) Has been cancelled
CI / CI (pull_request) Has been cancelled
CI / Notify gate failed (pull_request) Has been cancelled
CI / the pre-push hook (push) Successful in 13s
CI / cargo fmt (push) Successful in 12s
CI / cargo deny (push) Successful in 1m52s
CI / cargo deny advisories (push) Failing after 1m51s
CI / cargo clippy (push) Successful in 2m11s
CI / repository boundary (push) Successful in 52s
CI / frontend-web (push) Successful in 1m38s
CI / cargo test (push) Successful in 8m41s
CI / Notify gate failed (push) Has been skipped
CI / CI (push) Successful in 41s
8b987ab896
GRI-1971: acceptance tests for permission scoping on reads
Some checks failed
CI / the pre-push hook (pull_request) Successful in 49s
CI / cargo fmt (pull_request) Successful in 48s
CI / cargo clippy (pull_request) Successful in 3m16s
CI / cargo deny advisories (pull_request) Failing after 2m26s
CI / cargo deny (pull_request) Successful in 2m28s
CI / repository boundary (pull_request) Successful in 58s
CI / frontend-web (pull_request) Successful in 2m8s
CI / cargo test (pull_request) Successful in 9m32s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 13s
da928b4bb6
Fail-first against today's unscoped handlers: a campus-scoped
non-admin currently sees every campus's devices, fetches another
campus's device by direct id with 200 instead of 404, and reads the
IP rules with 200 instead of 403. Three paired happy-path tests
(admin sees everything, admin reads IP rules, an editor reads their
own campus's device) confirm the harness and fixtures are sound.

No role or campus assignment exists on users yet (#44 is not
implemented); the file adds both to its own per-test database only,
mirroring the existing nullable campus_id convention, as a stand-in
documented in the file header for the real migration #44 lands with.
Merge pull request 'GRI-1971: acceptance tests for permission scoping on reads' (#166) from test/GRI-1971-permission-scoping-reads into dev
Some checks failed
CI / the pre-push hook (push) Successful in 57s
CI / cargo fmt (push) Successful in 45s
CI / cargo clippy (push) Successful in 2m13s
CI / cargo deny (push) Successful in 1m40s
CI / cargo test (push) Failing after 2m4s
CI / repository boundary (push) Successful in 49s
CI / cargo deny advisories (push) Failing after 1m41s
CI / frontend-web (push) Successful in 2m29s
CI / the pre-push hook (pull_request) Successful in 2m2s
CI / cargo fmt (pull_request) Successful in 1m37s
CI / cargo deny advisories (pull_request) Failing after 2m11s
CI / cargo deny (pull_request) Successful in 2m18s
CI / cargo clippy (pull_request) Successful in 4m0s
CI / repository boundary (pull_request) Successful in 1m3s
CI / frontend-web (pull_request) Successful in 2m28s
CI / CI (push) Failing after 38s
CI / Notify gate failed (push) Has been skipped
CI / cargo test (pull_request) Successful in 12m33s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 24s
8a2491f94c
GRI-1965: run the CI test Postgres on tmpfs, with a health start period
Some checks failed
CI / the pre-push hook (pull_request) Successful in 42s
CI / cargo fmt (pull_request) Successful in 38s
CI / cargo deny (pull_request) Successful in 3m26s
CI / cargo clippy (pull_request) Successful in 5m5s
CI / cargo deny advisories (pull_request) Failing after 2m7s
CI / cargo test (pull_request) Successful in 6m17s
CI / repository boundary (pull_request) Successful in 38s
CI / frontend-web (pull_request) Successful in 1m54s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 41s
6450b3cd8d
The cargo test gate went red on a loaded host with no change to the code.
The job logs show two shapes, both the service Postgres losing on fsync
against the shared SSD: the service never became healthy and the job died
before its first step, or it came up too slowly and the per-test
CREATE DATABASE hit PoolTimedOut. The database is thrown away with the job,
so its data directory goes on tmpfs.
Merge pull request 'GRI-1965: run the CI test Postgres on tmpfs, with a health start period' (#170) from fix/GRI-1965-ci-postgres-tmpfs into dev
Some checks failed
CI / the pre-push hook (pull_request) Has been cancelled
CI / cargo fmt (pull_request) Has been cancelled
CI / cargo clippy (pull_request) Has been cancelled
CI / cargo test (pull_request) Has been cancelled
CI / cargo deny (pull_request) Has been cancelled
CI / cargo deny advisories (pull_request) Has been cancelled
CI / frontend-web (pull_request) Has been cancelled
CI / repository boundary (pull_request) Has been cancelled
CI / CI (pull_request) Has been cancelled
CI / Notify gate failed (pull_request) Has been cancelled
CI / the pre-push hook (push) Successful in 17s
CI / cargo fmt (push) Successful in 16s
CI / cargo deny (push) Successful in 2m11s
CI / cargo clippy (push) Successful in 2m44s
CI / cargo test (push) Successful in 3m30s
CI / cargo deny advisories (push) Failing after 1m19s
CI / repository boundary (push) Successful in 29s
CI / frontend-web (push) Successful in 1m57s
CI / Notify gate failed (push) Has been skipped
CI / CI (push) Successful in 38s
1bcd4acbf7
GRI-1972: show which screens a playlist is assigned to, and assign several at once
Some checks failed
CI / the pre-push hook (pull_request) Successful in 46s
CI / cargo fmt (pull_request) Successful in 51s
CI / cargo deny advisories (pull_request) Failing after 2m57s
CI / cargo deny (pull_request) Successful in 3m18s
CI / cargo clippy (pull_request) Successful in 4m29s
CI / repository boundary (pull_request) Successful in 54s
CI / frontend-web (pull_request) Successful in 2m7s
CI / cargo test (pull_request) Successful in 11m24s
CI / CI (pull_request) Successful in 26s
CI / Notify gate failed (pull_request) Has been skipped
b5576e2515
Backend: GET /playlists/{id} now returns assigned_devices; new
GET /device-playlist-assignments endpoint.
Frontend: multi-select assign checkboxes in the playlist editor, a
'Shown on' list, and a playlist column on the devices screen.
# Conflicts:
#	crates/server/src/playlists/handlers.rs
GRI-1972: fix merge fallout — push_to_assigned_devices used the renamed store function
Some checks failed
CI / the pre-push hook (pull_request) Successful in 10s
CI / cargo fmt (pull_request) Successful in 12s
CI / cargo deny (pull_request) Successful in 1m26s
CI / cargo clippy (pull_request) Successful in 2m55s
CI / cargo deny advisories (pull_request) Failing after 1m38s
CI / repository boundary (pull_request) Successful in 49s
CI / frontend-web (pull_request) Successful in 2m28s
CI / cargo test (pull_request) Successful in 10m49s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 31s
3472cc1ec4
Merge pull request 'GRI-1972: playlist editor shows assigned screens, assigns several at once' (#169) from feature/GRI-1972-playlist-editor-assign-multi into dev
Some checks failed
CI / the pre-push hook (push) Successful in 29s
CI / cargo fmt (push) Successful in 30s
CI / cargo clippy (push) Successful in 2m1s
CI / cargo deny (push) Successful in 1m46s
CI / cargo deny advisories (push) Failing after 1m50s
CI / repository boundary (push) Successful in 39s
CI / frontend-web (push) Successful in 2m4s
CI / the pre-push hook (pull_request) Successful in 33s
CI / cargo test (push) Successful in 4m12s
CI / cargo fmt (pull_request) Successful in 36s
CI / cargo deny (pull_request) Successful in 1m36s
CI / cargo deny advisories (pull_request) Failing after 1m44s
CI / cargo clippy (pull_request) Successful in 2m39s
CI / repository boundary (pull_request) Successful in 56s
CI / cargo test (pull_request) Successful in 3m34s
CI / frontend-web (pull_request) Successful in 1m58s
CI / Notify gate failed (push) Has been skipped
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (push) Successful in 38s
CI / CI (pull_request) Successful in 42s
90052c834c
GRI-1975: remove the campus seed, add campus CRUD
Some checks failed
CI / the pre-push hook (pull_request) Successful in 44s
CI / cargo fmt (pull_request) Successful in 1m6s
CI / cargo clippy (pull_request) Successful in 2m47s
CI / cargo deny (pull_request) Successful in 1m44s
CI / repository boundary (pull_request) Successful in 1m18s
CI / cargo deny advisories (pull_request) Failing after 1m53s
CI / frontend-web (pull_request) Successful in 1m56s
CI / cargo test (pull_request) Failing after 6m54s
CI / CI (pull_request) Failing after 31s
CI / Notify gate failed (pull_request) Successful in 32s
4b4019cfdb
Remove the AM/HE/JO/NO insert from 0005_campus.sql so a fresh install
lists no campuses; add admin POST/PATCH/DELETE /api/v1/campuses
(duplicate code -> 409, delete of a campus still referenced by media,
playlists, devices or IP rules -> 409); fix test fixtures across the
server crate to create the campuses they need instead of relying on
the seed.
GRI-1975: merge dev — pick up CI Postgres fix (#170)
Some checks failed
CI / the pre-push hook (pull_request) Successful in 56s
CI / cargo fmt (pull_request) Successful in 43s
CI / cargo clippy (pull_request) Successful in 2m22s
CI / cargo deny (pull_request) Successful in 2m15s
CI / repository boundary (pull_request) Successful in 43s
CI / cargo test (pull_request) Successful in 3m6s
CI / frontend-web (pull_request) Successful in 1m33s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 21s
CI / cargo deny advisories (pull_request) Failing after 13m35s
b173df7726
Merge pull request 'GRI-1975: remove the campus seed, add campus CRUD' (#171) from feature/GRI-1975-campus-crud into dev
Some checks failed
CI / cargo fmt (push) Successful in 43s
CI / the pre-push hook (push) Successful in 44s
CI / cargo clippy (push) Successful in 2m29s
CI / cargo deny (push) Successful in 2m27s
CI / cargo deny advisories (push) Failing after 2m27s
CI / cargo test (push) Successful in 3m38s
CI / repository boundary (push) Successful in 52s
CI / frontend-web (push) Successful in 1m36s
CI / the pre-push hook (pull_request) Successful in 57s
CI / cargo fmt (pull_request) Successful in 56s
CI / cargo deny advisories (pull_request) Failing after 1m24s
CI / cargo deny (pull_request) Successful in 1m50s
CI / cargo clippy (pull_request) Successful in 2m46s
CI / repository boundary (pull_request) Successful in 1m7s
CI / Notify gate failed (push) Has been skipped
CI / CI (push) Successful in 44s
CI / frontend-web (pull_request) Successful in 2m6s
CI / cargo test (pull_request) Successful in 4m8s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 22s
0c1b78b03e
GRI-1970: cargo fmt
Some checks failed
CI / the pre-push hook (pull_request) Successful in 1m7s
CI / cargo fmt (pull_request) Successful in 1m16s
CI / cargo clippy (pull_request) Successful in 4m9s
CI / cargo deny (pull_request) Successful in 3m8s
CI / cargo deny advisories (pull_request) Failing after 4m13s
CI / repository boundary (pull_request) Successful in 1m19s
CI / cargo test (pull_request) Failing after 10m12s
CI / frontend-web (pull_request) Failing after 18m30s
CI / CI (pull_request) Has been cancelled
CI / Notify gate failed (pull_request) Has been cancelled
f13a4462b0
GRI-1971's permission_scoping_acceptance_integration.rs assumed a
users.role stand-in column; the real #44 migration uses
user_groups/group_permissions/user_group_members instead. Updates
insert_scoped_user and the lookup helper only, per the file's own
documented extension point -- no assertion changed.
GRI-1970: require admin for campus create/update/delete
Some checks failed
CI / the pre-push hook (pull_request) Successful in 49s
CI / cargo fmt (pull_request) Successful in 46s
CI / cargo deny advisories (pull_request) Failing after 1m47s
CI / cargo deny (pull_request) Successful in 1m52s
CI / cargo clippy (pull_request) Successful in 2m34s
CI / cargo test (pull_request) Failing after 2m53s
CI / repository boundary (pull_request) Successful in 52s
CI / frontend-web (pull_request) Successful in 1m35s
CI / CI (pull_request) Failing after 27s
CI / Notify gate failed (pull_request) Successful in 29s
76ce85d287
GRI-1970: permissions_integration.rs must create its own campuses
Some checks failed
CI / cargo fmt (pull_request) Successful in 48s
CI / the pre-push hook (pull_request) Successful in 49s
CI / cargo deny (pull_request) Successful in 1m30s
CI / cargo deny advisories (pull_request) Failing after 1m30s
CI / cargo clippy (pull_request) Successful in 2m47s
CI / repository boundary (pull_request) Successful in 1m26s
CI / cargo test (pull_request) Successful in 4m3s
CI / frontend-web (pull_request) Successful in 2m25s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 33s
d44cd3a7f7
Migration 0005 seeds no campus rows (GRI-1884: the campus list is data,
not code). The test file read campuses 'AM'/'HE' through the admin
session but never created them, so three tests panicked with
'campus AM is seeded' in CI. Create each one through POST
/api/v1/campuses first, the same way every other integration test file
in this crate already does.
Merge pull request 'GRI-1970: users, roles and campus-scoped permissions' (#168) from feature/GRI-1970-campus-permissions into dev
Some checks failed
CI / cargo fmt (push) Successful in 10s
CI / the pre-push hook (push) Successful in 10s
CI / cargo deny (push) Successful in 1m24s
CI / cargo deny advisories (push) Failing after 1m23s
CI / cargo clippy (push) Successful in 2m18s
CI / repository boundary (push) Successful in 56s
CI / the pre-push hook (pull_request) Successful in 49s
CI / cargo test (push) Successful in 3m34s
CI / cargo fmt (pull_request) Successful in 1m2s
CI / frontend-web (push) Successful in 2m1s
CI / cargo clippy (pull_request) Successful in 2m22s
CI / cargo deny (pull_request) Successful in 2m13s
CI / cargo deny advisories (pull_request) Failing after 2m30s
CI / repository boundary (pull_request) Successful in 59s
CI / CI (push) Successful in 42s
CI / Notify gate failed (push) Has been skipped
CI / cargo test (pull_request) Successful in 3m24s
CI / frontend-web (pull_request) Successful in 1m30s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 14s
f7328b6422
GRI-1978: panel user and role management, permission-gated nav
Some checks failed
CI / cargo fmt (pull_request) Successful in 9s
CI / the pre-push hook (pull_request) Successful in 10s
CI / cargo deny advisories (pull_request) Failing after 1m50s
CI / cargo deny (pull_request) Successful in 1m52s
CI / repository boundary (pull_request) Successful in 44s
CI / cargo clippy (pull_request) Successful in 2m49s
CI / frontend-web (pull_request) Successful in 1m43s
CI / cargo test (pull_request) Successful in 3m48s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 10s
d7208c7a99
Users screen (list, create, edit, delete) for admins, with a fixed
role (Admin, Campus Editor) and a campus assigned per user, against
the server contract from GRI-1970 (PR #168). The Devices/IP rules/
Settings/Users tabs and routes are now gated by the signed-in user's
permissions, so IP rules and Settings disappear for a Campus Editor
and a typed-in URL does not reach them either. API tokens are left
for later, per the chief of staff's release note on forge issue #52.
Merge pull request 'GRI-1978: panel users, roles and permission-gated nav (campus test scope)' (#173) from feature/GRI-1978-panel-users-permissions into dev
Some checks failed
CI / cargo fmt (push) Successful in 13s
CI / the pre-push hook (push) Successful in 13s
CI / cargo deny (push) Successful in 1m53s
CI / cargo deny advisories (push) Failing after 2m2s
CI / cargo clippy (push) Successful in 2m24s
CI / repository boundary (push) Successful in 23s
CI / the pre-push hook (pull_request) Successful in 18s
CI / cargo fmt (pull_request) Successful in 37s
CI / cargo test (push) Successful in 3m29s
CI / frontend-web (push) Successful in 2m4s
CI / cargo clippy (pull_request) Successful in 2m47s
CI / cargo deny (pull_request) Successful in 2m33s
CI / cargo deny advisories (pull_request) Failing after 1m53s
CI / CI (push) Successful in 42s
CI / Notify gate failed (push) Has been skipped
CI / repository boundary (pull_request) Successful in 50s
CI / cargo test (pull_request) Successful in 3m53s
CI / frontend-web (pull_request) Successful in 2m21s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 21s
441951bde6
GRI-1981: media library groups a PDF's pages under its document
Some checks failed
CI / cargo fmt (pull_request) Successful in 1m2s
CI / the pre-push hook (pull_request) Successful in 1m2s
CI / cargo deny (pull_request) Successful in 1m32s
CI / cargo clippy (pull_request) Successful in 2m34s
CI / cargo deny advisories (pull_request) Failing after 1m31s
CI / repository boundary (pull_request) Successful in 34s
CI / cargo test (pull_request) Successful in 3m29s
CI / frontend-web (pull_request) Successful in 1m31s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 37s
b73fbfb27a
Media list now groups a document's `document_page` rows under the
document, with a page count and an expand control, instead of listing
every page as its own top-level item (field feedback on GRI-1960). The
playlist editor's add-from-library picker does the same: the document
is the selectable option, its pages nested under it in an optgroup.
Merge pull request 'GRI-1981: media library groups a PDF's pages under its document' (#176) from feature/GRI-1981-media-pdf-grouping into dev
Some checks failed
CI / cargo fmt (push) Successful in 13s
CI / the pre-push hook (push) Successful in 14s
CI / cargo deny (push) Successful in 2m5s
CI / cargo deny advisories (push) Failing after 2m5s
CI / cargo clippy (push) Successful in 2m37s
CI / repository boundary (push) Successful in 1m0s
CI / the pre-push hook (pull_request) Successful in 48s
CI / cargo test (push) Successful in 3m39s
CI / cargo fmt (pull_request) Successful in 46s
CI / frontend-web (push) Successful in 1m51s
CI / cargo clippy (pull_request) Successful in 2m25s
CI / cargo deny advisories (pull_request) Failing after 2m2s
CI / cargo deny (pull_request) Successful in 2m21s
CI / CI (pull_request) Has been cancelled
CI / Notify gate failed (pull_request) Has been cancelled
CI / frontend-web (pull_request) Has been cancelled
CI / repository boundary (pull_request) Successful in 1m29s
CI / Notify gate failed (push) Has been skipped
CI / CI (push) Successful in 1m22s
CI / cargo test (pull_request) Successful in 4m27s
aa297c4ec1
GRI-1980: acceptance tests for campus scope and permissions on media and playlists
Some checks failed
CI / the pre-push hook (pull_request) Successful in 16s
CI / cargo fmt (pull_request) Successful in 24s
CI / cargo deny advisories (pull_request) Failing after 1m46s
CI / cargo deny (pull_request) Successful in 1m55s
CI / cargo clippy (pull_request) Successful in 3m12s
CI / repository boundary (pull_request) Successful in 1m25s
CI / cargo test (pull_request) Successful in 4m21s
CI / frontend-web (pull_request) Successful in 2m10s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 21s
475b247fc5
Merge pull request 'GRI-1980: acceptance tests for campus scope and permissions on media and playlists' (#177) from test/GRI-1980-media-playlist-permission-scoping into dev
Some checks failed
CI / the pre-push hook (push) Successful in 1m5s
CI / cargo fmt (push) Successful in 1m32s
CI / cargo clippy (push) Successful in 2m51s
CI / cargo deny advisories (push) Failing after 1m58s
CI / cargo deny (push) Successful in 2m43s
CI / repository boundary (push) Successful in 30s
CI / the pre-push hook (pull_request) Successful in 18s
CI / frontend-web (push) Successful in 1m53s
CI / cargo fmt (pull_request) Successful in 1m2s
CI / cargo test (push) Successful in 5m11s
CI / cargo clippy (pull_request) Successful in 2m47s
CI / cargo deny advisories (pull_request) Failing after 2m30s
CI / cargo deny (pull_request) Successful in 3m14s
CI / repository boundary (pull_request) Successful in 1m14s
CI / Notify gate failed (push) Has been skipped
CI / frontend-web (pull_request) Successful in 2m39s
CI / cargo test (pull_request) Successful in 4m40s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (push) Successful in 1m23s
CI / CI (pull_request) Successful in 26s
fc9d38fe94
Filters media/playlist lists by current.may_access; cross-campus
get/update/delete now reads 404 not 403, same as devices. Create
(upload, url, playlist) forces a campus-scoped caller's own campus_id
via campus::validate_for_create rather than accepting a different
campus or every campus. Adds ContentUpload checks on upload_media,
add_url_media and create_playlist; ContentAssign checks on
update_playlist, replace_items and assign_playlist. assign_playlist
404s when the device or the playlist is outside the caller's campus.
media_in_use_error filters playlists_referencing by may_access so the
409 conflict never names a playlist in another campus.
The acceptance suite's fresh_pool created a database per test and never
dropped it (GRI-1984: 2,512 had piled up and filled the shared Postgres's
/dev/shm). Wraps the pool in a guard whose Drop runs DROP DATABASE ...
WITH (FORCE) on a dedicated thread, so it fires on panic too and does not
need a nested Tokio runtime.
GRI-1977: drop #[ignore] from campus scoping acceptance tests so CI runs them
Some checks failed
CI / the pre-push hook (pull_request) Successful in 11s
CI / cargo fmt (pull_request) Successful in 11s
CI / cargo deny advisories (pull_request) Failing after 1m53s
CI / cargo clippy (pull_request) Successful in 2m14s
CI / cargo deny (pull_request) Successful in 2m7s
CI / repository boundary (pull_request) Successful in 1m5s
CI / cargo test (pull_request) Successful in 4m8s
CI / frontend-web (pull_request) Successful in 2m52s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 41s
3a3974ffe6
Merge pull request 'GRI-1977: campus scope and permissions on media and playlists' (#180) from feature/GRI-1977-campus-media-playlist-permissions into dev
Some checks failed
CI / cargo deny (push) Successful in 2m57s
CI / cargo deny advisories (push) Failing after 2m57s
CI / repository boundary (push) Successful in 48s
CI / cargo clippy (push) Successful in 4m6s
CI / frontend-web (push) Successful in 1m54s
CI / cargo test (push) Successful in 5m19s
CI / Notify gate failed (push) Has been skipped
CI / CI (push) Successful in 20s
CI / the pre-push hook (pull_request) Has been cancelled
CI / cargo fmt (pull_request) Has been cancelled
CI / cargo clippy (pull_request) Has been cancelled
CI / cargo test (pull_request) Has been cancelled
CI / cargo deny (pull_request) Has been cancelled
CI / cargo deny advisories (pull_request) Has been cancelled
CI / frontend-web (pull_request) Has been cancelled
CI / repository boundary (pull_request) Has been cancelled
CI / CI (pull_request) Has been cancelled
CI / Notify gate failed (pull_request) Has been cancelled
CI / the pre-push hook (push) Successful in 8s
CI / cargo fmt (push) Successful in 9s
3b630d6647
GRI-1997: acceptance tests for global and per-campus playback settings, with fallback
Some checks failed
CI / the pre-push hook (pull_request) Successful in 13s
CI / cargo fmt (pull_request) Successful in 13s
CI / cargo deny advisories (pull_request) Failing after 2m5s
CI / cargo deny (pull_request) Successful in 2m6s
CI / cargo clippy (pull_request) Successful in 3m4s
CI / repository boundary (pull_request) Successful in 59s
CI / cargo test (pull_request) Successful in 4m17s
CI / frontend-web (pull_request) Successful in 1m57s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 14s
581b5d99c1
Merge pull request 'GRI-1997: acceptance tests for global and per-campus playback settings, with fallback' (#179) from test/GRI-1997-settings-acceptance-tests into dev
Some checks failed
CI / the pre-push hook (push) Successful in 1m16s
CI / cargo fmt (push) Successful in 1m4s
CI / cargo deny advisories (push) Failing after 1m47s
CI / cargo clippy (push) Successful in 2m8s
CI / cargo deny (push) Successful in 2m33s
CI / repository boundary (push) Successful in 1m1s
CI / the pre-push hook (pull_request) Successful in 37s
CI / cargo fmt (pull_request) Successful in 39s
CI / frontend-web (push) Successful in 2m42s
CI / cargo test (push) Successful in 5m48s
CI / cargo clippy (pull_request) Successful in 3m1s
CI / cargo deny (pull_request) Successful in 1m42s
CI / repository boundary (pull_request) Successful in 42s
CI / cargo deny advisories (pull_request) Failing after 1m19s
CI / frontend-web (pull_request) Successful in 1m40s
CI / cargo test (pull_request) Successful in 4m20s
CI / CI (push) Successful in 23s
CI / Notify gate failed (push) Has been skipped
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 21s
7caf3240dc
Keeps kind=document as one stored row with sparse page_overrides
(JSON, page number -> seconds|skip), trimmed to the document's current
pages on write. Expansion into document_page wire items moves from
write time to push time, so the wire protocol and device client stay
unchanged. Adds GET /media/{id}/file for page thumbnails.
GRI-1982: store+API acceptance tests for per-page overrides on a document item
Some checks failed
CI / the pre-push hook (pull_request) Has been cancelled
CI / cargo fmt (pull_request) Has been cancelled
CI / cargo clippy (pull_request) Has been cancelled
CI / cargo test (pull_request) Has been cancelled
CI / cargo deny (pull_request) Has been cancelled
CI / cargo deny advisories (pull_request) Has been cancelled
CI / frontend-web (pull_request) Has been cancelled
CI / repository boundary (pull_request) Has been cancelled
CI / CI (pull_request) Has been cancelled
CI / Notify gate failed (pull_request) Has been cancelled
20b5f31803
Covers the design in nyssa's #157 comment: a document item stores sparse
page_overrides as one row, expansion to per-page wire items happens at
push time (not in the PUT response), overrides for pages a shrunk PDF no
longer has are trimmed silently, and structurally invalid overrides
(page 0, negative time) are refused. Also rewrites the GRI-1937 test that
asserted write-time expansion, which this design replaces.
GRI-1961: merge dev
Some checks failed
CI / the pre-push hook (pull_request) Successful in 48s
CI / cargo fmt (pull_request) Successful in 49s
CI / cargo deny advisories (pull_request) Failing after 1m43s
CI / cargo deny (pull_request) Successful in 1m45s
CI / repository boundary (pull_request) Successful in 49s
CI / cargo clippy (pull_request) Successful in 2m49s
CI / cargo test (pull_request) Failing after 2m47s
CI / frontend-web (pull_request) Successful in 1m44s
CI / Notify gate failed (pull_request) Successful in 36s
CI / CI (pull_request) Failing after 37s
b2332440e4
# Conflicts:
#	crates/server/src/playlists/handlers.rs
GRI-1961: renumber migration to 0007, clear of dev's 0005/0006
Some checks failed
CI / cargo fmt (pull_request) Successful in 8s
CI / the pre-push hook (pull_request) Successful in 9s
CI / cargo deny (pull_request) Successful in 1m37s
CI / cargo deny advisories (pull_request) Failing after 1m43s
CI / cargo clippy (pull_request) Successful in 2m25s
CI / repository boundary (pull_request) Successful in 40s
CI / frontend-web (pull_request) Successful in 1m29s
CI / cargo test (pull_request) Successful in 3m18s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 14s
b3386e2256
0005 collided with dev's 0005_campus.sql (landed concurrently via #176/#177),
causing a duplicate _sqlx_migrations primary key at test time.
Merge pull request '[DO NOT MERGE until the sh block at the top of this PR's body exits 0] GRI-1961: per-page time overrides on a whole-PDF playlist item' (#182) from feature/GRI-1961-pdf-page-overrides into dev
Some checks failed
CI / the pre-push hook (push) Successful in 36s
CI / cargo fmt (push) Successful in 36s
CI / cargo deny advisories (push) Failing after 1m35s
CI / cargo deny (push) Successful in 1m35s
CI / cargo clippy (push) Successful in 2m11s
CI / the pre-push hook (pull_request) Successful in 42s
CI / repository boundary (push) Successful in 47s
CI / cargo fmt (pull_request) Successful in 33s
CI / frontend-web (push) Successful in 2m20s
CI / cargo test (push) Successful in 4m35s
CI / cargo clippy (pull_request) Successful in 1m56s
CI / cargo deny advisories (pull_request) Failing after 1m44s
CI / cargo deny (pull_request) Successful in 1m57s
CI / repository boundary (pull_request) Successful in 23s
CI / CI (push) Successful in 21s
CI / Notify gate failed (push) Has been skipped
CI / frontend-web (pull_request) Successful in 2m34s
CI / cargo test (pull_request) Successful in 4m5s
CI / CI (pull_request) Successful in 2s
CI / Notify gate failed (pull_request) Has been skipped
a7b05dac8c
Migration 0007 adds playback_settings (one global row, one per campus,
with fallback). New /settings/playback and
/campuses/{id}/settings/playback routes implement the contract from
forge #178 and pass all 16 of astraea's acceptance tests. Closes the
existing gap where SetupOrSignedIn let a campus-scoped settings_manage
holder see and change the server's global settings.
GRI-1992: panel for global and per-campus playback defaults
Some checks failed
CI / the pre-push hook (pull_request) Successful in 8s
CI / cargo fmt (pull_request) Successful in 8s
CI / cargo deny advisories (pull_request) Failing after 1m23s
CI / cargo deny (pull_request) Successful in 1m35s
CI / cargo clippy (pull_request) Successful in 1m59s
CI / repository boundary (pull_request) Successful in 36s
CI / cargo test (pull_request) Successful in 3m0s
CI / frontend-web (pull_request) Successful in 2m5s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 3s
344f2be5a5
SettingsScreen gets a global playback-default field, visible only to
an unscoped settings_manage holder (the server now 403s a
campus-scoped one). A new CampusSettingsScreen shows the effective
value and whether it is the campus's own override or the global
default, with a way to set or clear the override; the dashboard
routes a campus-scoped settings_manage holder there instead of the
server's global screen.
GRI-1992: drop #[ignore] from playback settings acceptance tests so CI runs them
Some checks failed
CI / the pre-push hook (pull_request) Successful in 5s
CI / cargo fmt (pull_request) Successful in 6s
CI / cargo clippy (pull_request) Successful in 2m3s
CI / cargo deny (pull_request) Successful in 53s
CI / cargo test (pull_request) Successful in 3m20s
CI / cargo deny advisories (pull_request) Failing after 1m23s
CI / repository boundary (pull_request) Successful in 27s
CI / frontend-web (pull_request) Successful in 1m35s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 11s
7efed70611
Merge pull request 'GRI-1992: global and per-campus playback settings, with fallback' (#181) from feature/GRI-1992-campus-playback-settings into dev
Some checks failed
CI / Notify gate failed (push) Has been skipped
CI / CI (push) Failing after 15s
CI / the pre-push hook (pull_request) Has been cancelled
CI / cargo fmt (pull_request) Has been cancelled
CI / cargo clippy (pull_request) Has been cancelled
CI / cargo test (pull_request) Has been cancelled
CI / cargo deny (pull_request) Has been cancelled
CI / cargo deny advisories (pull_request) Has been cancelled
CI / frontend-web (pull_request) Has been cancelled
CI / repository boundary (pull_request) Has been cancelled
CI / CI (pull_request) Has been cancelled
CI / Notify gate failed (pull_request) Has been cancelled
CI / the pre-push hook (push) Successful in 9s
CI / cargo fmt (push) Successful in 10s
CI / cargo deny (push) Successful in 1m33s
CI / cargo deny advisories (push) Failing after 1m32s
CI / cargo clippy (push) Successful in 2m27s
CI / repository boundary (push) Successful in 43s
CI / cargo test (push) Failing after 2m37s
CI / frontend-web (push) Successful in 1m54s
d417a14357
GRI-2009: fail-first acceptance tests for live rollout status (#160)
Some checks failed
CI / cargo fmt (pull_request) Successful in 8s
CI / the pre-push hook (pull_request) Successful in 9s
CI / cargo deny (pull_request) Successful in 1m28s
CI / cargo deny advisories (pull_request) Failing after 1m41s
CI / cargo clippy (pull_request) Successful in 1m50s
CI / repository boundary (pull_request) Successful in 34s
CI / frontend-web (pull_request) Successful in 1m34s
CI / cargo test (pull_request) Successful in 3m14s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 15s
3c3cf9c89a
Merge pull request 'GRI-2009: fail-first acceptance tests for live rollout status (#160)' (#184) from test/GRI-2009-rollout-status-acceptance into dev
Some checks failed
CI / Notify gate failed (push) Has been skipped
CI / CI (push) Failing after 10s
CI / the pre-push hook (pull_request) Has been cancelled
CI / cargo fmt (pull_request) Has been cancelled
CI / cargo clippy (pull_request) Has been cancelled
CI / cargo test (pull_request) Has been cancelled
CI / cargo deny (pull_request) Has been cancelled
CI / cargo deny advisories (pull_request) Has been cancelled
CI / frontend-web (pull_request) Has been cancelled
CI / repository boundary (pull_request) Has been cancelled
CI / CI (pull_request) Has been cancelled
CI / Notify gate failed (pull_request) Has been cancelled
CI / the pre-push hook (push) Successful in 35s
CI / cargo fmt (push) Successful in 36s
CI / cargo clippy (push) Successful in 2m12s
CI / cargo deny (push) Successful in 2m4s
CI / cargo deny advisories (push) Failing after 1m46s
CI / cargo test (push) Failing after 2m51s
CI / repository boundary (push) Successful in 28s
CI / frontend-web (push) Successful in 1m46s
24e3c59b25
GRI-2010: playlist editor cogwheel and page list for document page overrides
Some checks failed
CI / the pre-push hook (pull_request) Successful in 8s
CI / cargo fmt (pull_request) Successful in 9s
CI / cargo deny advisories (pull_request) Failing after 1m17s
CI / cargo deny (pull_request) Successful in 1m17s
CI / cargo clippy (pull_request) Successful in 1m54s
CI / repository boundary (pull_request) Successful in 36s
CI / frontend-web (pull_request) Successful in 1m30s
CI / cargo test (pull_request) Successful in 3m5s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 3s
d34a757520
Adds a cogwheel on a document item in the playlist editor that opens its
page list, with thumbnails from GET /media/{id}/file. Per page: own time
in seconds or skip, empty meaning the item's default. Save sends
page_overrides on the item in PUT /playlists/{id}/items (signage#185,
follow-up to #157/#182).
Merge pull request 'GRI-2010: playlist editor cogwheel and page list for per-page overrides' (#186) from feature/GRI-2010-playlist-page-overrides-editor into dev
Some checks failed
CI / Notify gate failed (push) Has been skipped
CI / CI (push) Failing after 17s
CI / CI (pull_request) Failing after 39s
CI / Notify gate failed (pull_request) Successful in 33s
CI / the pre-push hook (push) Successful in 27s
CI / cargo fmt (push) Successful in 31s
CI / cargo clippy (push) Successful in 2m12s
CI / cargo deny (push) Successful in 2m5s
CI / repository boundary (push) Successful in 39s
CI / the pre-push hook (pull_request) Successful in 27s
CI / cargo deny advisories (push) Failing after 2m3s
CI / cargo test (push) Failing after 2m42s
CI / cargo fmt (pull_request) Successful in 26s
CI / frontend-web (push) Successful in 2m4s
CI / cargo deny (pull_request) Successful in 1m31s
CI / cargo clippy (pull_request) Successful in 1m59s
CI / cargo deny advisories (pull_request) Failing after 1m58s
CI / repository boundary (pull_request) Successful in 1m27s
CI / cargo test (pull_request) Failing after 3m26s
CI / frontend-web (pull_request) Successful in 2m17s
32e78a64e1
Author
Owner

Do not merge this release yet. dev (and so this PR head) holds two migrations numbered 0007 (#181 and #182 merged minutes apart), and a fresh database fails on the second one, so the server does not start. The fix is #187 (rename to 0008, CI green), waiting on nyssa's review (GRI-2012). This PR is safe to merge once #187 is in dev.

Do not merge this release yet. `dev` (and so this PR head) holds two migrations numbered 0007 (#181 and #182 merged minutes apart), and a fresh database fails on the second one, so the server does not start. The fix is #187 (rename to 0008, CI green), waiting on nyssa's review (GRI-2012). This PR is safe to merge once #187 is in dev.
GRI-1960: renumber playback settings migration to 0008
Some checks failed
CI / the pre-push hook (pull_request) Successful in 29s
CI / cargo fmt (pull_request) Successful in 21s
CI / cargo deny advisories (pull_request) Failing after 1m18s
CI / cargo deny (pull_request) Successful in 1m38s
CI / cargo clippy (pull_request) Successful in 2m16s
CI / repository boundary (pull_request) Successful in 28s
CI / frontend-web (pull_request) Successful in 1m43s
CI / cargo test (pull_request) Successful in 3m20s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 16s
cefebf9d37
#181 and #182 both landed a migration numbered 0007. sqlx keys
migrations by version, so a fresh database applies one 0007 and
then fails on the duplicate version. Neither is deployed yet; the
later merge (#181, playback settings) moves to 0008.
Merge pull request 'GRI-1960: renumber playback settings migration to 0008' (#187) from fix/GRI-1960-migration-0008 into dev
Some checks failed
CI / the pre-push hook (push) Successful in 11s
CI / cargo fmt (push) Successful in 11s
CI / cargo deny (push) Successful in 1m32s
CI / the pre-push hook (pull_request) Successful in 45s
CI / cargo deny advisories (push) Failing after 1m36s
CI / cargo clippy (push) Successful in 2m13s
CI / repository boundary (push) Successful in 47s
CI / cargo fmt (pull_request) Successful in 30s
CI / frontend-web (push) Successful in 2m15s
CI / cargo test (push) Successful in 4m8s
CI / cargo clippy (pull_request) Successful in 2m14s
CI / cargo deny (pull_request) Successful in 1m35s
CI / cargo deny advisories (pull_request) Failing after 1m49s
CI / repository boundary (pull_request) Successful in 45s
CI / frontend-web (pull_request) Successful in 2m7s
CI / cargo test (pull_request) Successful in 4m23s
CI / Notify gate failed (push) Has been skipped
CI / CI (push) Successful in 16s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 12s
438748d174
Author
Owner

Update 08:0xZ: #187 is merged into dev (head cefebf9d, verified ancestor). dev now has 0007_document_page_overrides.sql and 0008_playback_settings.sql, so the duplicate-0007 fault is fixed. This release PR follows dev, so the warning from 07:2xZ no longer applies once CI on the new head is green.

Update 08:0xZ: #187 is merged into `dev` (head `cefebf9d`, verified ancestor). `dev` now has `0007_document_page_overrides.sql` and `0008_playback_settings.sql`, so the duplicate-0007 fault is fixed. This release PR follows `dev`, so the warning from 07:2xZ no longer applies once CI on the new head is green.
GRI-1968: live rollout status (applied/downloading/offline) over SSE
Some checks failed
CI / the pre-push hook (pull_request) Successful in 46s
CI / cargo fmt (pull_request) Successful in 52s
CI / cargo deny (pull_request) Successful in 1m59s
CI / cargo clippy (pull_request) Successful in 2m54s
CI / cargo deny advisories (pull_request) Failing after 2m47s
CI / repository boundary (pull_request) Successful in 55s
CI / frontend-web (pull_request) Successful in 2m20s
CI / cargo test (pull_request) Successful in 4m32s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 3s
5b3e1cfc47
Track each connected device's playing_item and transfer progress in
DeviceConnections, compute rollout status against the device's current
assignment, and push it to the panel over a new SSE stream
(/api/v1/devices/rollout-status/stream) recomputed on connect,
heartbeat, transfer start/complete, disconnect, and every assignment
push. Removes the #[ignore] marks from the pinned acceptance tests.
Merge pull request 'GRI-1968: live rollout view (applied/downloading/offline) over SSE' (#188) from feature/GRI-1968-rollout-status-view into dev
Some checks failed
CI / cargo fmt (push) Successful in 9s
CI / the pre-push hook (push) Successful in 10s
CI / cargo deny (push) Successful in 2m3s
CI / cargo deny advisories (push) Failing after 2m3s
CI / cargo clippy (push) Successful in 2m24s
CI / repository boundary (push) Successful in 42s
CI / the pre-push hook (pull_request) Successful in 39s
CI / frontend-web (push) Successful in 1m41s
CI / cargo fmt (pull_request) Successful in 1m0s
CI / cargo test (push) Successful in 4m25s
CI / cargo clippy (pull_request) Successful in 2m1s
CI / cargo deny advisories (pull_request) Failing after 2m10s
CI / CI (push) Successful in 15s
CI / Notify gate failed (push) Has been skipped
CI / cargo deny (pull_request) Successful in 2m37s
CI / repository boundary (pull_request) Successful in 21s
CI / frontend-web (pull_request) Successful in 2m2s
CI / cargo test (pull_request) Successful in 4m2s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 3s
dfd16387c0
GRI-2014: render .pptx uploads to MP4 (Xvfb + ffmpeg), slide images as fallback
Some checks failed
CI / the pre-push hook (pull_request) Successful in 33s
CI / cargo fmt (pull_request) Successful in 33s
CI / cargo deny advisories (pull_request) Failing after 1m26s
CI / cargo deny (pull_request) Successful in 1m29s
CI / cargo clippy (pull_request) Successful in 2m50s
CI / repository boundary (pull_request) Successful in 48s
CI / cargo test (pull_request) Failing after 3m50s
CI / frontend-web (pull_request) Successful in 2m7s
CI / CI (pull_request) Failing after 31s
CI / Notify gate failed (pull_request) Successful in 33s
8e790aa6bc
Adds crate::pptx_video: LibreOffice Impress plays the deck on a virtual
display using its own slide timing, ffmpeg records it to H.264 MP4. A
deck with only click-triggered steps never finishes on its own and is
bounded by a configurable timeout, falling back to one PNG per slide
(forge #33's shape) via gs, so a failed or timed-out render never leaves
a half item. Every binary, the resolution and the timeout are config
(PptxVideoConfig), not hard-coded.

Wires the fallback into media::handlers::upload_media alongside the
existing PDF path. Acceptance tests exercise the real fallback
conversion (soffice + gs) and the all-or-nothing guarantee with no
#[ignore]; the render success path is proven at the HTTP contract level
with injected fake tools, since this build host's Xvfb render of a real
Impress slideshow is a separate, documented open finding.
GRI-2014: use fake soffice/gs in the fallback acceptance test
Some checks failed
CI / the pre-push hook (pull_request) Successful in 16s
CI / cargo fmt (pull_request) Successful in 17s
CI / cargo deny (pull_request) Successful in 1m10s
CI / cargo clippy (pull_request) Successful in 2m11s
CI / cargo deny advisories (pull_request) Failing after 1m16s
CI / repository boundary (pull_request) Successful in 39s
CI / cargo test (pull_request) Successful in 3m14s
CI / frontend-web (pull_request) Successful in 1m37s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 3s
c466099285
The CI runner image has neither binary, so
a_pptx_render_that_fails_falls_back_to_one_page_image_per_slide failed
there even though it passes on this build host, which does have them.
GRI-2014: detect blank/frozen renders and fall back; accept .pptx in upload
Some checks failed
CI / the pre-push hook (pull_request) Successful in 29s
CI / cargo fmt (pull_request) Successful in 33s
CI / cargo clippy (pull_request) Failing after 2m35s
CI / cargo deny (pull_request) Successful in 2m7s
CI / repository boundary (pull_request) Successful in 26s
CI / cargo test (pull_request) Successful in 3m44s
CI / frontend-web (pull_request) Successful in 1m22s
CI / CI (pull_request) Failing after 13s
CI / Notify gate failed (pull_request) Successful in 13s
CI / cargo deny advisories (pull_request) Failing after 12m17s
57f9eca707
GRI-2014: avoid expect_used in soffice wait-result handling
Some checks failed
CI / the pre-push hook (pull_request) Successful in 11s
CI / cargo fmt (pull_request) Successful in 11s
CI / cargo deny (pull_request) Successful in 2m0s
CI / cargo deny advisories (pull_request) Failing after 2m0s
CI / cargo clippy (pull_request) Successful in 2m36s
CI / repository boundary (pull_request) Successful in 1m27s
CI / frontend-web (pull_request) Successful in 2m33s
CI / cargo test (pull_request) Successful in 4m54s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 23s
afa63c6849
Merge pull request 'GRI-2014: render .pptx uploads to MP4, slide images as fallback' (#190) from feature/GRI-2014-pptx-video-render into dev
Some checks failed
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 22s
CI / the pre-push hook (push) Successful in 38s
CI / cargo fmt (push) Successful in 39s
CI / cargo deny (push) Successful in 2m13s
CI / cargo deny advisories (push) Failing after 2m13s
CI / cargo clippy (push) Successful in 3m38s
CI / repository boundary (push) Successful in 1m51s
CI / the pre-push hook (pull_request) Successful in 1m13s
CI / cargo test (push) Successful in 5m34s
CI / cargo fmt (pull_request) Successful in 58s
CI / frontend-web (push) Successful in 2m46s
CI / cargo deny (pull_request) Successful in 2m55s
CI / cargo deny advisories (pull_request) Failing after 3m0s
CI / cargo clippy (pull_request) Successful in 4m3s
CI / CI (push) Successful in 58s
CI / Notify gate failed (push) Has been skipped
CI / repository boundary (pull_request) Successful in 2m11s
CI / frontend-web (pull_request) Successful in 2m38s
CI / cargo test (pull_request) Successful in 6m6s
c117ea44a8
GRI-2014: render a real slideshow instead of a blank one
Some checks failed
CI / the pre-push hook (pull_request) Successful in 1m5s
CI / cargo fmt (pull_request) Successful in 1m9s
CI / cargo clippy (pull_request) Successful in 2m32s
CI / cargo deny (pull_request) Successful in 1m36s
CI / cargo deny advisories (pull_request) Failing after 1m56s
CI / repository boundary (pull_request) Successful in 1m17s
CI / frontend-web (pull_request) Successful in 2m18s
CI / cargo test (pull_request) Successful in 5m19s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 18s
8ea3b8c251
soffice --show left the slideshow permanently blank under this host's
Xvfb (no /dev/dri access): every real deck fell back to slide images,
with no way to tell a failing render from a working one. Loading the
document normally and sending a synthetic F5 over XTEST once it has
loaded, with OpenGL disabled, renders real content. Since soffice no
longer exits on its own when a show ends, a new pptx_video_presenter
binary drives the keypress and tracks the EWMH fullscreen hint to know
when the show starts and ends, in place of waiting on the process.
Merge pull request 'GRI-2014: render a real slideshow instead of a blank one' (#192) from fix/GRI-2014-pptx-slideshow-render into dev
Some checks failed
CI / the pre-push hook (push) Successful in 11s
CI / cargo fmt (push) Successful in 11s
CI / cargo deny (push) Successful in 1m56s
CI / cargo clippy (push) Successful in 2m16s
CI / cargo deny advisories (push) Failing after 2m2s
CI / repository boundary (push) Successful in 1m12s
CI / the pre-push hook (pull_request) Successful in 1m11s
CI / cargo fmt (pull_request) Successful in 41s
CI / frontend-web (push) Successful in 2m35s
CI / cargo clippy (pull_request) Successful in 2m16s
CI / cargo deny advisories (pull_request) Failing after 2m25s
CI / cargo test (push) Successful in 6m6s
CI / cargo deny (pull_request) Successful in 3m4s
CI / frontend-web (pull_request) Successful in 2m8s
CI / CI (push) Successful in 42s
CI / cargo test (pull_request) Successful in 5m18s
CI / Notify gate failed (push) Has been skipped
CI / repository boundary (pull_request) Successful in 50s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 20s
2a91fc3d59
GRI-2014: accept a non-blank timed-out render, trim its frozen tail, and end the wait early when idle
Some checks failed
CI / the pre-push hook (pull_request) Successful in 7s
CI / cargo fmt (pull_request) Successful in 7s
CI / cargo deny (pull_request) Successful in 1m12s
CI / cargo clippy (pull_request) Successful in 2m21s
CI / cargo deny advisories (pull_request) Failing after 1m18s
CI / repository boundary (pull_request) Successful in 20s
CI / frontend-web (pull_request) Successful in 1m29s
CI / cargo test (pull_request) Successful in 4m6s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 16s
322e0f57a7
GRI-2014: raise the idle bound to cover a slide's own auto-advance timing
Some checks failed
CI / the pre-push hook (pull_request) Successful in 40s
CI / cargo fmt (pull_request) Successful in 42s
CI / cargo deny (pull_request) Successful in 2m3s
CI / cargo deny advisories (pull_request) Failing after 2m1s
CI / cargo clippy (pull_request) Successful in 3m13s
CI / repository boundary (pull_request) Successful in 1m24s
CI / cargo test (pull_request) Successful in 4m19s
CI / frontend-web (pull_request) Successful in 2m13s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 19s
7fb17bba20
idle_end_seconds was a ceiling, not a floor: a slide held longer than the
10s default was cut off mid-hold, losing real content. Read the longest
advTm out of the .pptx's own ppt/slides/*.xml (it is a zip) and raise the
wait to cover it, plus a safety margin. A file that cannot be read as a
.pptx falls back to the full render_timeout_seconds instead of guessing.
Merge pull request 'GRI-2014: accept non-blank timed-out renders, trim the frozen tail, end idle waits early' (#193) from fix/GRI-2014-pptx-trim-idle-end into dev
Some checks failed
CI / the pre-push hook (push) Successful in 9s
CI / cargo fmt (push) Successful in 9s
CI / cargo deny (push) Successful in 1m4s
CI / cargo clippy (push) Successful in 2m26s
CI / cargo deny advisories (push) Failing after 3m32s
CI / the pre-push hook (pull_request) Successful in 11s
CI / frontend-web (push) Successful in 3m18s
CI / repository boundary (push) Successful in 57s
CI / cargo fmt (pull_request) Successful in 7s
CI / cargo deny (pull_request) Successful in 1m28s
CI / cargo clippy (pull_request) Successful in 1m52s
CI / cargo deny advisories (pull_request) Failing after 1m31s
CI / repository boundary (pull_request) Successful in 45s
CI / frontend-web (pull_request) Successful in 2m18s
CI / cargo test (pull_request) Successful in 4m21s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 47s
CI / cargo test (push) Failing after 17m18s
CI / CI (push) Has been cancelled
CI / Notify gate failed (push) Has been cancelled
7b862884d4
GRI-2014: cap the slide-xml read in longest_slide_advance_seconds
Some checks failed
CI / the pre-push hook (pull_request) Successful in 42s
CI / cargo fmt (pull_request) Successful in 48s
CI / cargo clippy (pull_request) Successful in 2m22s
CI / cargo deny (pull_request) Successful in 2m26s
CI / cargo deny advisories (pull_request) Failing after 2m36s
CI / repository boundary (pull_request) Successful in 1m9s
CI / frontend-web (pull_request) Successful in 2m8s
CI / cargo test (pull_request) Successful in 4m19s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 24s
e54ac1b811
Review follow-up on PR #193 (Vivy, non-blocking): read_to_string on a
ppt/slides/slideN.xml zip entry had no size limit, so a crafted .pptx
upload could decompress an arbitrarily large entry into memory. Bound
it to 8 MiB; past that the file is treated as unreadable, same as any
other corrupt .pptx, falling back to render_timeout_seconds.
Merge pull request 'GRI-2014: cap the slide-xml read in longest_slide_advance_seconds' (#194) from fix/GRI-2014-pptx-slide-xml-read-cap into dev
Some checks failed
CI / cargo fmt (push) Successful in 1m13s
CI / the pre-push hook (push) Successful in 1m31s
CI / cargo clippy (push) Successful in 1m57s
CI / cargo deny (push) Successful in 1m52s
CI / cargo deny advisories (push) Failing after 1m37s
CI / repository boundary (push) Successful in 48s
CI / the pre-push hook (pull_request) Successful in 47s
CI / frontend-web (push) Successful in 2m10s
CI / cargo fmt (pull_request) Successful in 32s
CI / cargo deny (pull_request) Successful in 2m40s
CI / cargo clippy (pull_request) Successful in 4m57s
CI / cargo deny advisories (pull_request) Failing after 1m51s
CI / cargo test (push) Successful in 9m49s
CI / Notify gate failed (push) Has been skipped
CI / cargo test (pull_request) Successful in 6m39s
CI / frontend-web (pull_request) Successful in 2m9s
CI / repository boundary (pull_request) Successful in 1m39s
CI / CI (push) Successful in 45s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 31s
a20cd7030d
GRI-2014: keep the reserved display number below x11rb's TCP-port overflow
Some checks failed
CI / the pre-push hook (pull_request) Successful in 13s
CI / cargo fmt (pull_request) Successful in 14s
CI / cargo deny (pull_request) Successful in 58s
CI / cargo clippy (pull_request) Successful in 2m13s
CI / cargo deny advisories (pull_request) Failing after 1m43s
CI / cargo test (pull_request) Successful in 3m40s
CI / repository boundary (pull_request) Successful in 1m6s
CI / frontend-web (pull_request) Successful in 2m8s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 11s
4a45b0c18c
Merge pull request 'GRI-2014: keep the reserved display number below x11rb's TCP-port overflow' (#195) from fix/GRI-2014-pptx-display-overflow into dev
Some checks failed
CI / cargo fmt (push) Successful in 34s
CI / the pre-push hook (push) Successful in 35s
CI / cargo deny advisories (push) Failing after 1m41s
CI / cargo clippy (push) Successful in 2m42s
CI / cargo deny (push) Successful in 2m7s
CI / the pre-push hook (pull_request) Successful in 1m1s
CI / repository boundary (push) Successful in 1m4s
CI / cargo fmt (pull_request) Successful in 45s
CI / frontend-web (push) Successful in 2m45s
CI / cargo test (push) Successful in 5m26s
CI / cargo clippy (pull_request) Successful in 1m50s
CI / cargo deny advisories (pull_request) Failing after 2m21s
CI / frontend-web (pull_request) Successful in 2m30s
CI / cargo deny (pull_request) Successful in 2m54s
CI / repository boundary (pull_request) Successful in 40s
CI / Notify gate failed (push) Has been skipped
CI / CI (push) Successful in 26s
CI / cargo test (pull_request) Successful in 5m18s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 8s
cb1377c604
GRI-2014: gate the .pptx MP4 render behind config, default off, and fix the presenter/idle race
Some checks failed
CI / the pre-push hook (pull_request) Successful in 7s
CI / cargo fmt (pull_request) Successful in 7s
CI / cargo clippy (pull_request) Successful in 2m5s
CI / cargo deny (pull_request) Successful in 2m9s
CI / cargo deny advisories (pull_request) Failing after 2m18s
CI / repository boundary (pull_request) Successful in 36s
CI / cargo test (pull_request) Failing after 3m46s
CI / frontend-web (pull_request) Successful in 1m41s
CI / Notify gate failed (pull_request) Successful in 20s
CI / CI (pull_request) Failing after 21s
02e8b12843
PptxVideoConfig.mp4_enabled (default false, SIGNAGE_PPTX_VIDEO_MP4_ENABLED)
keeps every upload on the slide-image fallback until it is switched on.

Separately: pptx_video_presenter now reports fullscreen over stdout as it
happens, and watch_for_idle_screen waits for that signal before it will
ever declare the screen idle — closing the race where a presenter stuck
on its loading screen read as a successful idle render well before its
own, much slower, deadline-bound failure could surface.
GRI-2014: fix the fallback tools used by the mp4-off acceptance test
Some checks failed
CI / the pre-push hook (pull_request) Successful in 11s
CI / cargo fmt (pull_request) Successful in 13s
CI / cargo deny (pull_request) Successful in 1m42s
CI / cargo deny advisories (pull_request) Failing after 1m43s
CI / cargo clippy (pull_request) Successful in 1m56s
CI / repository boundary (pull_request) Successful in 55s
CI / frontend-web (pull_request) Successful in 1m47s
CI / cargo test (pull_request) Successful in 3m49s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 13s
66a83bcf3a
mp4_is_off_by_default_the_upload_still_falls_back_to_pages took its
soffice_path/rasterizer_path from fake_successful_render_opts, whose
fake soffice is a no-op daemon for the MP4 path and never writes a
PDF. With mp4_enabled off, the upload takes the fallback-conversion
path instead, so it needs the soffice/gs pair that actually produces
one -- the same pair fallback_only_opts already builds.
Merge pull request 'GRI-2014: gate the .pptx MP4 render behind config, default off, and fix the presenter/idle race' (#196) from fix/GRI-2014-pptx-mp4-flag-fallback into dev
Some checks failed
CI / cargo fmt (push) Successful in 11s
CI / the pre-push hook (push) Successful in 12s
CI / cargo deny advisories (push) Failing after 2m28s
CI / the pre-push hook (pull_request) Successful in 58s
CI / cargo clippy (push) Successful in 2m59s
CI / repository boundary (push) Successful in 1m7s
CI / cargo fmt (pull_request) Successful in 44s
CI / frontend-web (push) Successful in 2m11s
CI / cargo test (push) Successful in 4m54s
CI / cargo deny (pull_request) Successful in 2m21s
CI / cargo deny advisories (pull_request) Failing after 2m29s
CI / cargo clippy (pull_request) Successful in 2m51s
CI / repository boundary (pull_request) Successful in 1m51s
CI / frontend-web (pull_request) Successful in 4m10s
CI / cargo test (pull_request) Successful in 7m55s
CI / cargo deny (push) Failing after 16m7s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 15s
CI / CI (push) Has been cancelled
CI / Notify gate failed (push) Has been cancelled
422683ae96
GRI-2014: build .pptx video from slide images and xfade, not a recorded slideshow
Some checks failed
CI / the pre-push hook (pull_request) Successful in 8s
CI / cargo fmt (pull_request) Successful in 9s
CI / cargo deny (pull_request) Successful in 1m43s
CI / cargo deny advisories (pull_request) Failing after 1m43s
CI / cargo clippy (pull_request) Successful in 2m5s
CI / repository boundary (pull_request) Successful in 49s
CI / frontend-web (pull_request) Successful in 1m47s
CI / cargo test (pull_request) Successful in 3m44s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 16s
7e5a777f9c
Replaces the Xvfb-recorded render (PRs #190-#196), which could not be made
reliable against soffice's Tip-of-the-Day focus race. Reads each slide's
transition and advTm straight out of the .pptx XML, maps it to the closest
ffmpeg xfade effect, and joins the same slide images the fallback already
renders -- no display server, deterministic, and testable in CI without
soffice or ffmpeg installed. mp4_enabled now defaults on.
Merge pull request 'GRI-2014: build .pptx video from slide images and ffmpeg xfade' (#199) from feature/GRI-2014-pptx-xfade-video into dev
Some checks failed
CI / cargo deny advisories (pull_request) Failing after 2m55s
CI / repository boundary (pull_request) Successful in 1m54s
CI / the pre-push hook (push) Successful in 12s
CI / cargo fmt (push) Successful in 12s
CI / frontend-web (pull_request) Successful in 2m47s
CI / cargo test (pull_request) Successful in 6m23s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 42s
CI / cargo deny (push) Failing after 14m0s
CI / cargo deny advisories (push) Failing after 2m25s
CI / cargo clippy (push) Successful in 2m52s
CI / repository boundary (push) Successful in 1m6s
CI / the pre-push hook (pull_request) Successful in 1m12s
CI / frontend-web (push) Successful in 2m10s
CI / cargo test (push) Successful in 4m53s
CI / cargo fmt (pull_request) Successful in 56s
CI / cargo deny (pull_request) Successful in 2m46s
CI / cargo clippy (pull_request) Successful in 2m59s
CI / CI (push) Has been cancelled
CI / Notify gate failed (push) Has been cancelled
6b0d3fc1c6
GRI-2052: drop SQLite from the client to clear RUSTSEC-2026-0459
Some checks failed
CI / the pre-push hook (pull_request) Successful in 1m4s
CI / cargo fmt (pull_request) Successful in 1m4s
CI / cargo clippy (pull_request) Successful in 1m59s
CI / cargo deny (pull_request) Successful in 2m9s
CI / cargo deny advisories (pull_request) Failing after 1m58s
CI / repository boundary (pull_request) Successful in 51s
CI / cargo test (pull_request) Successful in 5m5s
CI / frontend-web (pull_request) Successful in 1m55s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 36s
ef5b73a38c
The client's device state is a plain JSON file (written through a
temporary file and renamed into place) instead of sqlx's sqlite
feature. No sqlx release takes libsqlite3-sys >= 0.39, and rusqlite
cannot coexist with the server's sqlx dependency in the same
Cargo.lock: libsqlite3-sys links = "sqlite3" allows only one version,
and sqlx's weak feature edges to sqlx-sqlite pin a version below the
fix regardless of whether sqlite is ever turned on.

gtk-renderer and the advisories-blocking decision are out of scope
here; both stay as they are on dev pending the product owner's call
on GRI-2051.
Merge pull request 'GRI-2052: drop SQLite from the client to clear RUSTSEC-2026-0459' (#203) from fix/GRI-2052-client-state-json into dev
Some checks failed
CI / cargo fmt (push) Successful in 34s
CI / the pre-push hook (push) Successful in 52s
CI / cargo clippy (push) Successful in 1m53s
CI / cargo deny advisories (push) Failing after 2m20s
CI / cargo deny (push) Successful in 2m38s
CI / the pre-push hook (pull_request) Successful in 47s
CI / repository boundary (push) Successful in 52s
CI / frontend-web (push) Successful in 2m15s
CI / cargo test (push) Successful in 4m35s
CI / cargo fmt (pull_request) Successful in 49s
CI / cargo clippy (pull_request) Successful in 2m31s
CI / cargo deny (pull_request) Successful in 2m55s
CI / cargo deny advisories (pull_request) Failing after 2m54s
CI / repository boundary (pull_request) Successful in 53s
CI / Notify gate failed (push) Has been skipped
CI / CI (push) Successful in 38s
CI / frontend-web (pull_request) Successful in 2m10s
CI / cargo test (pull_request) Successful in 4m50s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 14s
c8fccc2be7
GRI-2052: clear the four cargo-deny advisories blocking dev
All checks were successful
CI / the pre-push hook (pull_request) Successful in 15s
CI / cargo fmt (pull_request) Successful in 20s
CI / cargo deny advisories (pull_request) Successful in 1m55s
CI / cargo deny (pull_request) Successful in 2m1s
CI / repository boundary (pull_request) Successful in 57s
CI / cargo clippy (pull_request) Successful in 3m14s
CI / frontend-web (pull_request) Successful in 2m25s
CI / cargo test (pull_request) Successful in 5m8s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 15s
a63fd1dcb5
RUSTSEC-2026-0459 (bundled SQLite CVE) cannot be cleared by swapping sqlx's
sqlite feature for rusqlite: rusqlite and sqlx's optional sqlx-sqlite
dependency can never share a libsqlite3-sys version in the same workspace
Cargo.lock, even with sqlx's sqlite feature never turned on, because several
of the server's sqlx features (migrate, chrono, uuid, json) hold a weak
feature edge back to sqlx-sqlite. So the client's state is a plain JSON
file for this release instead, written through a temporary file and
renamed into place for an atomic replace.

RUSTSEC-2024-0429/0436/0370 (glib unsoundness and two unmaintained crates,
all reached only through gtk-renderer) are cleared by taking gtk-renderer
and its dependencies out of the workspace for this release; nothing else
reaches glib or gstreamer. The removed code is archived at
refs/archive/2026-11-14/gtk-renderer-removal-GRI-2052 and forge issue #201
tracks bringing it back.

cargo deny check advisories now blocks CI and local-gates.sh instead of
being continue-on-error, per the product owner's rule that a vulnerability
or unsound advisory is never ignored.
GRI-2052: keep gtk-renderer, accept the three advisories with a dated reason
All checks were successful
CI / the pre-push hook (pull_request) Successful in 11s
CI / cargo fmt (pull_request) Successful in 11s
CI / cargo deny (pull_request) Successful in 1m49s
CI / cargo deny advisories (pull_request) Successful in 1m56s
CI / cargo clippy (pull_request) Successful in 2m22s
CI / repository boundary (pull_request) Successful in 47s
CI / frontend-web (pull_request) Successful in 1m39s
CI / cargo test (pull_request) Successful in 3m50s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 16s
ec8c3956aa
The product owner's rule on GRI-2051 (23:15 UTC): our code does not call the
unsound glib path RUSTSEC-2024-0429 reaches, so it is accepted alongside the
two unmaintained crates underneath gtk-renderer (RUSTSEC-2024-0436, -0370),
each dated and with the removal condition on forge issue #201. The bundled
SQLite advisory stays cleared the way #203 already merged it -- a plain JSON
state file, no sqlx sqlite feature.

Restores gtk-renderer, its five crates and the two binaries
(grimoirix_signage_client, renderer_spike) from dev, where they were never
removed; only this branch had taken them out. package-client-deb.sh and
mvp-smoke-test.sh build the real player again.

cargo deny check advisories now runs with -D advisory-not-detected, in CI
and in local-gates.sh, so an ignore entry that stops matching a reported
advisory fails the gate the day a fix is available. Proved locally: a fake
ignore entry turns the gate red with error[advisory-not-detected]; removed
after confirming.
Merge pull request 'GRI-2052: keep gtk-renderer, accept the three advisories with a dated reason' (#202) from security/GRI-2052-cargo-deny-advisories into dev
All checks were successful
CI / cargo fmt (push) Successful in 8s
CI / the pre-push hook (push) Successful in 9s
CI / cargo clippy (push) Successful in 2m1s
CI / cargo deny advisories (push) Successful in 1m58s
CI / cargo deny (push) Successful in 1m59s
CI / repository boundary (push) Successful in 1m3s
CI / the pre-push hook (pull_request) Successful in 1m5s
CI / cargo test (push) Successful in 3m23s
CI / cargo fmt (pull_request) Successful in 1m0s
CI / frontend-web (push) Successful in 2m23s
CI / cargo clippy (pull_request) Successful in 2m5s
CI / cargo deny (pull_request) Successful in 1m54s
CI / cargo deny advisories (pull_request) Successful in 2m13s
CI / repository boundary (pull_request) Successful in 55s
CI / Notify gate failed (push) Has been skipped
CI / CI (push) Successful in 30s
CI / frontend-web (pull_request) Successful in 2m5s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 11s
CI / cargo test (pull_request) Successful in 4m11s
b69a8d4556
aegis approved these changes 2026-11-15 00:17:54 +00:00
Dismissed
aegis left a comment

Re-reviewed after dev advanced 20518cd → b69a8d45. Note for the record: the delta is far larger than the handoff comment described ("includes #202 cargo-deny exceptions") — it's 101 commits / ~56k lines, not just the advisory fix: campus/user/permission scoping (GRI-1964/1970/1977/1978), playback settings (GRI-1992), a new PDF→MP4 video pipeline that shells out to LibreOffice/ffmpeg/gs (GRI-2014), live rollout-status SSE (GRI-1968), SQLite removal from the client, and gtk-renderer restoration with three accepted advisories (GRI-2052). Reviewed the actual diff rather than the summary.

Process surface (GRI-2052, cargo-deny): deny.toml's three new ignore entries (RUSTSEC-2024-0429/0436/0370) are dated, each names forge issue #201 as the removal condition, and match the product owner's GRI-2051 decision (2026-11-14 23:15 UTC) verbatim. cargo deny check advisories -D advisory-not-detected now blocks CI and local-gates.sh, so an entry that stops matching a real advisory fails the gate the day a fix exists — proved in the commit message and matches a gate I'd have asked for. gtk-renderer is a non-default Cargo feature; CI's default --workspace build never links glib, but package-client-deb.sh's real client binary does require it, so the shipped client does carry RUSTSEC-2024-0429's dependency — consistent with what the product owner knowingly accepted, not a surprise introduced by this PR.

New PDF→MP4 pipeline (crates/server/src/pptx_video.rs, GRI-2014): every external tool (soffice, the rasterizer, ffmpeg) runs via Command::new + .arg()/.args() — argv only, no shell, so no injection even through a crafted filename. Zip parts are read through read_zip_part's take(MAX_PART_BYTES + 1) (8 MiB cap), closing the zip-bomb/unbounded-decompression risk explicitly called out in its own doc comment. The whole conversion is wrapped in tokio::time::timeout(opts.render_timeout_seconds, ...). All work happens in a tempfile::tempdir(). No shell, no unbounded read, no missing timeout.

Campus/user/permission model (GRI-1964/1970/1977/1978): Permission is a fixed Rust enum with no run-time-created permissions; user_groups.rs exposes only a GET (list_groups) — there is no endpoint to create a group or edit group_permissions, so the only two groups are the ones the migration seeds (Admin: every permission; Campus Editor: everything except users_manage/devices_approve/settings_manage). That closes the privilege-escalation path I went looking for first: users.rs's create_user/update_user gate only on current.may(Permission::UsersManage) with no separate admin check, which would be a vertical-privilege-escalation bug (a UsersManage holder promoting themselves or anyone else into the Admin group) if UsersManage could ever be granted to a non-admin group — it can't, by construction, and the migration's own comment calls out exactly this reasoning (user_groups.is_admin is deliberately not derived from a permission a UsersManage holder could edit). campus::validate_for_create fails closed: a campus-scoped caller's own campus always wins, a different campus is refused outright, and "every campus" is silently narrowed rather than honoured. Device/media/playlist/IP-rule handlers consistently gate on current.may_access(resource.campus_id) before a permission check, with cross-campus reads returning 404 not 403 (confirmed in devices/handlers.rs).

Rollout-status SSE (GRI-1968): rollout_status_stream filters every event through current.may_access(device.campus_id) per-device before it reaches the client (visible_sse_event), so a campus-scoped panel session never receives another campus's device events over the stream — same complete-mediation pattern as the REST handlers, correctly applied to a push channel.

One non-blocking finding: playback_settings.rs's get_campus (GET /campuses/{id}/settings/playback) only checks campus_in_scope (campus membership via may_access), not require_settings_manage — unlike put_campus, which checks both. Any authenticated user scoped to (or admin over) that campus can read its effective playback-default duration without holding settings_manage. Low severity: it's a non-secret integer (slide duration), already campus-scoped, read-only, and not a cross-tenant leak. Worth a one-line fix (add require_settings_manage to get_campus) but not a release blocker.

Prior findings (login throttling GRI-1922, device groups GRI-1896, install.sh/settings.rs GRI-1937/1936, design-system restyle GRI-1941/1946) are untouched by this delta — none of those files appear in the 20518cd..b69a8d45 diff.

Posted APPROVED, pinned to b69a8d45. Did not merge — that stays the product owner's call on main.

Re-reviewed after dev advanced `20518cd` → `b69a8d45`. Note for the record: the delta is far larger than the handoff comment described ("includes #202 cargo-deny exceptions") — it's 101 commits / ~56k lines, not just the advisory fix: campus/user/permission scoping (GRI-1964/1970/1977/1978), playback settings (GRI-1992), a new PDF→MP4 video pipeline that shells out to LibreOffice/ffmpeg/gs (GRI-2014), live rollout-status SSE (GRI-1968), SQLite removal from the client, and gtk-renderer restoration with three accepted advisories (GRI-2052). Reviewed the actual diff rather than the summary. **Process surface (GRI-2052, cargo-deny):** `deny.toml`'s three new `ignore` entries (RUSTSEC-2024-0429/0436/0370) are dated, each names forge issue #201 as the removal condition, and match the product owner's GRI-2051 decision (2026-11-14 23:15 UTC) verbatim. `cargo deny check advisories -D advisory-not-detected` now blocks CI and `local-gates.sh`, so an entry that stops matching a real advisory fails the gate the day a fix exists — proved in the commit message and matches a gate I'd have asked for. `gtk-renderer` is a non-default Cargo feature; CI's default `--workspace` build never links `glib`, but `package-client-deb.sh`'s real client binary does require it, so the shipped client does carry RUSTSEC-2024-0429's dependency — consistent with what the product owner knowingly accepted, not a surprise introduced by this PR. **New PDF→MP4 pipeline (`crates/server/src/pptx_video.rs`, GRI-2014):** every external tool (`soffice`, the rasterizer, `ffmpeg`) runs via `Command::new` + `.arg()`/`.args()` — argv only, no shell, so no injection even through a crafted filename. Zip parts are read through `read_zip_part`'s `take(MAX_PART_BYTES + 1)` (8 MiB cap), closing the zip-bomb/unbounded-decompression risk explicitly called out in its own doc comment. The whole conversion is wrapped in `tokio::time::timeout(opts.render_timeout_seconds, ...)`. All work happens in a `tempfile::tempdir()`. No shell, no unbounded read, no missing timeout. **Campus/user/permission model (GRI-1964/1970/1977/1978):** `Permission` is a fixed Rust enum with no run-time-created permissions; `user_groups.rs` exposes only a `GET` (`list_groups`) — there is no endpoint to create a group or edit `group_permissions`, so the only two groups are the ones the migration seeds (`Admin`: every permission; `Campus Editor`: everything except `users_manage`/`devices_approve`/`settings_manage`). That closes the privilege-escalation path I went looking for first: `users.rs`'s `create_user`/`update_user` gate only on `current.may(Permission::UsersManage)` with no separate admin check, which would be a vertical-privilege-escalation bug (a `UsersManage` holder promoting themselves or anyone else into the Admin group) if `UsersManage` could ever be granted to a non-admin group — it can't, by construction, and the migration's own comment calls out exactly this reasoning (`user_groups.is_admin` is deliberately not derived from a permission a `UsersManage` holder could edit). `campus::validate_for_create` fails closed: a campus-scoped caller's own campus always wins, a different campus is refused outright, and "every campus" is silently narrowed rather than honoured. Device/media/playlist/IP-rule handlers consistently gate on `current.may_access(resource.campus_id)` before a permission check, with cross-campus reads returning 404 not 403 (confirmed in `devices/handlers.rs`). **Rollout-status SSE (GRI-1968):** `rollout_status_stream` filters every event through `current.may_access(device.campus_id)` per-device before it reaches the client (`visible_sse_event`), so a campus-scoped panel session never receives another campus's device events over the stream — same complete-mediation pattern as the REST handlers, correctly applied to a push channel. **One non-blocking finding:** `playback_settings.rs`'s `get_campus` (`GET /campuses/{id}/settings/playback`) only checks `campus_in_scope` (campus membership via `may_access`), not `require_settings_manage` — unlike `put_campus`, which checks both. Any authenticated user scoped to (or admin over) that campus can read its effective playback-default duration without holding `settings_manage`. Low severity: it's a non-secret integer (slide duration), already campus-scoped, read-only, and not a cross-tenant leak. Worth a one-line fix (add `require_settings_manage` to `get_campus`) but not a release blocker. Prior findings (login throttling GRI-1922, device groups GRI-1896, install.sh/settings.rs GRI-1937/1936, design-system restyle GRI-1941/1946) are untouched by this delta — none of those files appear in the 20518cd..b69a8d45 diff. Posted **APPROVED**, pinned to `b69a8d45`. Did not merge — that stays the product owner's call on `main`.
vivy changed title from Release 0.1.0: digital signage MVP (campus deploy) to Release 0.1.0: digital signage MVP and campus production test 2026-11-15 00:47:29 +00:00
GRI-1909: decide the specificity rule for overlapping schedule rules
Some checks failed
CI / cargo fmt (pull_request) Successful in 8s
CI / the pre-push hook (pull_request) Successful in 9s
CI / cargo clippy (pull_request) Successful in 1m27s
CI / cargo test (pull_request) Successful in 1m27s
CI / cargo deny advisories (pull_request) Failing after 1m22s
CI / cargo deny (pull_request) Successful in 1m24s
CI / repository boundary (pull_request) Successful in 8s
CI / frontend-web (pull_request) Successful in 47s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 4s
1e033a62fc
Merge remote-tracking branch 'origin/dev' into feature/GRI-1909-schedule-overlap
Some checks failed
CI / cargo fmt (pull_request) Successful in 9s
CI / the pre-push hook (pull_request) Successful in 10s
CI / cargo deny advisories (pull_request) Failing after 1m51s
CI / cargo deny (pull_request) Successful in 1m59s
CI / cargo clippy (pull_request) Successful in 2m10s
CI / cargo test (pull_request) Failing after 2m38s
CI / repository boundary (pull_request) Successful in 32s
CI / frontend-web (pull_request) Successful in 1m34s
CI / CI (pull_request) Failing after 19s
CI / Notify gate failed (pull_request) Successful in 22s
b1897839ba
Merge remote-tracking branch 'origin/dev' into feature/GRI-1909-schedule-overlap
All checks were successful
CI / cargo fmt (pull_request) Successful in 8s
CI / the pre-push hook (pull_request) Successful in 9s
CI / cargo deny advisories (pull_request) Successful in 1m32s
CI / cargo deny (pull_request) Successful in 1m32s
CI / cargo clippy (pull_request) Successful in 2m12s
CI / repository boundary (pull_request) Successful in 42s
CI / frontend-web (pull_request) Successful in 1m35s
CI / cargo test (pull_request) Successful in 3m25s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 3s
dfcb480c1f
Merge pull request 'GRI-1909: decide the specificity rule for overlapping schedule rules' (#204) from feature/GRI-1909-schedule-overlap into dev
All checks were successful
CI / cargo fmt (push) Successful in 12s
CI / the pre-push hook (push) Successful in 12s
CI / cargo deny (push) Successful in 1m29s
CI / cargo deny advisories (push) Successful in 1m43s
CI / cargo clippy (push) Successful in 2m22s
CI / repository boundary (push) Successful in 41s
CI / the pre-push hook (pull_request) Successful in 18s
CI / cargo fmt (pull_request) Successful in 26s
CI / frontend-web (push) Successful in 2m18s
CI / cargo test (push) Successful in 4m2s
CI / cargo clippy (pull_request) Successful in 2m16s
CI / cargo deny (pull_request) Successful in 1m38s
CI / cargo deny advisories (pull_request) Successful in 1m47s
CI / repository boundary (pull_request) Successful in 24s
CI / Notify gate failed (push) Has been skipped
CI / CI (push) Successful in 19s
CI / frontend-web (pull_request) Successful in 1m47s
CI / cargo test (pull_request) Successful in 3m47s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 9s
71a482fb8a
voidgazer dismissed aegis's review 2026-11-15 01:43:30 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

aegis approved these changes 2026-11-15 06:14:18 +00:00
Dismissed
aegis left a comment

Re-reviewed after dev advanced b69a8d45 -> 71a482fb (PR #204, GRI-1909: scheduling-overlap specificity decision). Delta is exactly 5 files under plan/, all documentation: a new ADR (0013, i18n library: rust-i18n), its README index entry, the open-questions.md entry closing Q6, the scheduling.md section recording "more specific rule wins" for same-priority overlapping rules, and internationalisation.md's status flip from Draft to Accepted reflecting the same ADR. No crates/, no frontend-web/, no migrations, no CI config — confirmed by diff stat and full diff read. No new attack surface, no behavior change, nothing bearing on any prior finding (login throttling GRI-1922, device groups GRI-1896, install.sh/settings.rs GRI-1937/1936, campus/permission scoping, pptx_video.rs, accepted RUSTSEC advisories).

Posted APPROVED, pinned to 71a482fb. Did not merge — product owner's call on main.

Re-reviewed after dev advanced b69a8d45 -> 71a482fb (PR #204, GRI-1909: scheduling-overlap specificity decision). Delta is exactly 5 files under plan/, all documentation: a new ADR (0013, i18n library: rust-i18n), its README index entry, the open-questions.md entry closing Q6, the scheduling.md section recording "more specific rule wins" for same-priority overlapping rules, and internationalisation.md's status flip from Draft to Accepted reflecting the same ADR. No crates/, no frontend-web/, no migrations, no CI config — confirmed by diff stat and full diff read. No new attack surface, no behavior change, nothing bearing on any prior finding (login throttling GRI-1922, device groups GRI-1896, install.sh/settings.rs GRI-1937/1936, campus/permission scoping, pptx_video.rs, accepted RUSTSEC advisories). Posted APPROVED, pinned to 71a482fb. Did not merge — product owner's call on main.
GRI-2082: set Cache-Control on panel index.html and hashed assets
All checks were successful
CI / the pre-push hook (pull_request) Successful in 32s
CI / cargo fmt (pull_request) Successful in 42s
CI / cargo deny (pull_request) Successful in 2m2s
CI / cargo deny advisories (pull_request) Successful in 1m52s
CI / cargo clippy (pull_request) Successful in 3m14s
CI / repository boundary (pull_request) Successful in 47s
CI / frontend-web (pull_request) Successful in 1m47s
CI / cargo test (pull_request) Successful in 4m59s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 46s
24038b459b
Merge pull request 'GRI-2082: set Cache-Control on panel index.html and hashed assets' (#215) from feature/GRI-2082-panel-cache-control into dev
Some checks failed
CI / the pre-push hook (push) Successful in 14s
CI / cargo deny (push) Successful in 1m54s
CI / cargo clippy (push) Successful in 2m54s
CI / cargo deny advisories (push) Successful in 2m32s
CI / repository boundary (push) Successful in 1m29s
CI / frontend-web (push) Successful in 2m36s
CI / the pre-push hook (pull_request) Successful in 1m18s
CI / cargo test (push) Successful in 5m21s
CI / cargo fmt (pull_request) Successful in 55s
CI / cargo deny (pull_request) Successful in 1m41s
CI / cargo deny advisories (pull_request) Successful in 1m46s
CI / cargo clippy (pull_request) Successful in 2m40s
CI / repository boundary (pull_request) Successful in 41s
CI / frontend-web (pull_request) Successful in 2m8s
CI / cargo test (pull_request) Successful in 4m22s
CI / cargo fmt (push) Failing after 10m28s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 29s
CI / CI (push) Has been cancelled
CI / Notify gate failed (push) Has been cancelled
712dc6c5c6
vivy dismissed aegis's review 2026-11-15 10:29:40 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

GRI-2071: show Scryglass as the product name in the top bar
All checks were successful
CI / cargo fmt (pull_request) Successful in 26s
CI / the pre-push hook (pull_request) Successful in 29s
CI / cargo clippy (pull_request) Successful in 2m24s
CI / cargo deny advisories (pull_request) Successful in 2m0s
CI / cargo deny (pull_request) Successful in 2m2s
CI / repository boundary (pull_request) Successful in 7s
CI / frontend-web (pull_request) Successful in 1m0s
CI / cargo test (pull_request) Successful in 3m26s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 4s
824bcd037b
Merge branch 'dev' into feature/GRI-2071-scryglass-top-bar
All checks were successful
CI / the pre-push hook (pull_request) Successful in 28s
CI / cargo fmt (pull_request) Successful in 23s
CI / cargo clippy (pull_request) Successful in 1m35s
CI / cargo deny (pull_request) Successful in 1m50s
CI / cargo deny advisories (pull_request) Successful in 1m44s
CI / repository boundary (pull_request) Successful in 27s
CI / frontend-web (pull_request) Successful in 2m0s
CI / cargo test (pull_request) Successful in 5m20s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 59s
13e7362c37
Merge pull request 'GRI-2071: show Scryglass as the product name in the top bar' (#212) from feature/GRI-2071-scryglass-top-bar into dev
All checks were successful
CI / cargo fmt (push) Successful in 10s
CI / the pre-push hook (push) Successful in 12s
CI / cargo deny advisories (push) Successful in 1m42s
CI / cargo deny (push) Successful in 1m49s
CI / cargo clippy (push) Successful in 2m17s
CI / repository boundary (push) Successful in 49s
CI / the pre-push hook (pull_request) Successful in 30s
CI / cargo fmt (pull_request) Successful in 40s
CI / frontend-web (push) Successful in 1m50s
CI / cargo test (push) Successful in 3m34s
CI / cargo clippy (pull_request) Successful in 2m14s
CI / cargo deny (pull_request) Successful in 2m32s
CI / cargo deny advisories (pull_request) Successful in 2m32s
CI / repository boundary (pull_request) Successful in 34s
CI / frontend-web (pull_request) Successful in 2m11s
CI / cargo test (pull_request) Successful in 4m21s
CI / Notify gate failed (push) Has been skipped
CI / CI (push) Successful in 29s
CI / CI (pull_request) Successful in 47s
CI / Notify gate failed (pull_request) Has been skipped
e7b55c21fa
GRI-2072: give every section a left sub-menu, and playlist tabs for Media/Devices/Settings
All checks were successful
CI / the pre-push hook (pull_request) Successful in 1m3s
CI / cargo fmt (pull_request) Successful in 49s
CI / cargo deny (pull_request) Successful in 1m59s
CI / cargo deny advisories (pull_request) Successful in 1m58s
CI / cargo clippy (pull_request) Successful in 2m52s
CI / repository boundary (pull_request) Successful in 1m15s
CI / frontend-web (pull_request) Successful in 3m22s
CI / cargo test (pull_request) Successful in 5m46s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 37s
6301f8fad6
Settings used to mix network config, playback defaults and the "restart
now" controls on one page, with IP rules as a separate top-level tab;
Playlists mixed items, device assignment and creation on one page too.

Each section now gets a left sub-menu of its own pages, each with its own
URL: Settings splits into Playback defaults / Campuses / Network (merging
in the old IP rules page) / IP rules, and a playlist's editor splits into
Media (default) / Devices / Settings (name, campus, delete). Creating a
playlist moved from an inline form on the list page to a small dialog
(name, campus for a global admin), landing straight on the new playlist's
Media tab. The top bar gains a Dashboard tab and drops the standalone IP
rules tab; an old /ip-rules link redirects into Settings.
Merge branch 'dev' into feature/GRI-2072-panel-left-submenu-nav
All checks were successful
CI / the pre-push hook (pull_request) Successful in 34s
CI / cargo fmt (pull_request) Successful in 30s
CI / cargo deny (pull_request) Successful in 2m5s
CI / cargo clippy (pull_request) Successful in 2m48s
CI / cargo deny advisories (pull_request) Successful in 1m48s
CI / repository boundary (pull_request) Successful in 44s
CI / frontend-web (pull_request) Successful in 1m46s
CI / cargo test (pull_request) Successful in 4m23s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 55s
498e7d5ae8
Fixed the review's regression: a campus user with settings_manage and
devices_approve hit the early CampusSettingsScreen return and lost IP
rules entirely, and a campus devices_approve holder with no settings
permission hit an empty Settings menu gated on isGlobal. Both now get a
menu (Playback defaults if settings_manage, IP rules if devices_approve),
and the network-config fields stay global-only.
Merge remote-tracking branch 'origin/feature/GRI-2072-panel-left-submenu-nav' into feature/GRI-2072-panel-left-submenu-nav
All checks were successful
CI / the pre-push hook (pull_request) Successful in 1m11s
CI / cargo fmt (pull_request) Successful in 1m11s
CI / cargo clippy (pull_request) Successful in 2m0s
CI / cargo deny advisories (pull_request) Successful in 2m26s
CI / cargo deny (pull_request) Successful in 2m28s
CI / repository boundary (pull_request) Successful in 54s
CI / frontend-web (pull_request) Successful in 3m15s
CI / cargo test (pull_request) Successful in 4m33s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 22s
350247fe05
Merge pull request 'GRI-2072: left sub-menu per section; playlist tabs for Media/Devices/Settings' (#218) from feature/GRI-2072-panel-left-submenu-nav into dev
Some checks failed
CI / the pre-push hook (push) Successful in 36s
CI / cargo fmt (push) Successful in 35s
CI / cargo clippy (push) Successful in 2m10s
CI / cargo deny (push) Successful in 2m30s
CI / cargo deny advisories (push) Successful in 2m29s
CI / the pre-push hook (pull_request) Successful in 2m3s
CI / repository boundary (push) Successful in 2m4s
CI / frontend-web (push) Successful in 2m38s
CI / cargo fmt (pull_request) Successful in 1m31s
CI / cargo test (push) Successful in 6m8s
CI / cargo clippy (pull_request) Successful in 1m59s
CI / cargo deny advisories (pull_request) Successful in 2m3s
CI / frontend-web (pull_request) Successful in 2m53s
CI / repository boundary (pull_request) Successful in 1m20s
CI / cargo test (pull_request) Successful in 5m40s
CI / Notify gate failed (push) Has been skipped
CI / CI (push) Successful in 37s
CI / cargo deny (pull_request) Failing after 12m9s
CI / CI (pull_request) Has been cancelled
CI / Notify gate failed (pull_request) Has been cancelled
f4a0709fc1
GRI-2073: unassign a device from a playlist
All checks were successful
CI / cargo fmt (pull_request) Successful in 29s
CI / the pre-push hook (pull_request) Successful in 44s
CI / cargo clippy (pull_request) Successful in 2m7s
CI / cargo deny advisories (pull_request) Successful in 1m58s
CI / cargo deny (pull_request) Successful in 2m14s
CI / repository boundary (pull_request) Successful in 40s
CI / frontend-web (pull_request) Successful in 1m41s
CI / cargo test (pull_request) Successful in 3m53s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 5s
5f3512eebf
DELETE /api/v1/devices/{device_id}/playlist removes the assignment and
pushes PlaylistCleared to the device's live connection, idempotently.
The client drops to its existing idle screen on receipt, per ADR 0014.
GRI-2073: push PlaylistCleared on reconnect after an offline unassignment
Some checks failed
CI / the pre-push hook (pull_request) Successful in 44s
CI / cargo fmt (pull_request) Successful in 30s
CI / cargo deny (pull_request) Successful in 1m50s
CI / cargo clippy (pull_request) Successful in 2m57s
CI / cargo deny advisories (pull_request) Successful in 2m37s
CI / repository boundary (pull_request) Successful in 28s
CI / cargo test (pull_request) Failing after 3m33s
CI / frontend-web (pull_request) Successful in 2m30s
CI / CI (pull_request) Failing after 46s
CI / Notify gate failed (pull_request) Successful in 12s
57016c9e1f
push_current_assignment returned Ok(()) when a reconnecting device had
no assignment, so a device that went offline before being unassigned
kept its last playlist forever. Push PlaylistCleared in that case too.
push_current_assignment was pushing PlaylistCleared on any reconnect
with no current assignment, including a device that connects before
ever being assigned - breaking existing ws_integration tests that
rely on that ordinary sequence. Track the debt explicitly instead:
unassign_playlist marks pending-clear only when its own push found no
live connection, and push_current_assignment consumes that mark to
decide whether to resend PlaylistCleared on reconnect.
GRI-2073: cargo fmt
All checks were successful
CI / cargo fmt (pull_request) Successful in 1m3s
CI / the pre-push hook (pull_request) Successful in 1m19s
CI / cargo clippy (pull_request) Successful in 3m44s
CI / cargo deny advisories (pull_request) Successful in 2m32s
CI / cargo deny (pull_request) Successful in 2m55s
CI / repository boundary (pull_request) Successful in 47s
CI / cargo test (pull_request) Successful in 4m33s
CI / frontend-web (pull_request) Successful in 1m50s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 20s
cf5a74e9df
Merge pull request 'GRI-2073: unassign a device from a playlist' (#214) from feature/GRI-2073-unassign-device-playlist into dev
All checks were successful
CI / the pre-push hook (push) Successful in 14s
CI / cargo fmt (push) Successful in 13s
CI / cargo clippy (push) Successful in 2m20s
CI / cargo deny advisories (push) Successful in 2m15s
CI / cargo deny (push) Successful in 2m16s
CI / repository boundary (push) Successful in 1m3s
CI / cargo test (push) Successful in 3m52s
CI / the pre-push hook (pull_request) Successful in 1m36s
CI / frontend-web (push) Successful in 2m20s
CI / cargo fmt (pull_request) Successful in 1m34s
CI / cargo deny advisories (pull_request) Successful in 2m30s
CI / cargo deny (pull_request) Successful in 2m59s
CI / cargo clippy (pull_request) Successful in 3m46s
CI / cargo test (pull_request) Successful in 4m18s
CI / Notify gate failed (push) Has been skipped
CI / CI (push) Successful in 45s
CI / repository boundary (pull_request) Successful in 53s
CI / frontend-web (pull_request) Successful in 2m9s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 27s
46a980cf99
GRI-2080: acceptance tests for campus CRUD counts and in-use delete details
Some checks failed
CI / the pre-push hook (pull_request) Successful in 27s
CI / cargo fmt (pull_request) Successful in 26s
CI / cargo clippy (pull_request) Successful in 2m16s
CI / cargo deny (pull_request) Successful in 1m55s
CI / cargo test (pull_request) Failing after 2m54s
CI / repository boundary (pull_request) Successful in 46s
CI / cargo deny advisories (pull_request) Successful in 2m12s
CI / frontend-web (pull_request) Successful in 1m48s
CI / CI (pull_request) Failing after 59s
CI / Notify gate failed (pull_request) Successful in 1m3s
b0cf7dd331
Server: GET /campuses now returns device/playlist counts per campus,
and DELETE returns a structured 409 campus_in_use naming what still
uses it. Panel: new Settings -> Campuses screen (list, add, rename,
delete with the server's in-use message surfaced) that opens into the
existing CampusSettingsScreen for a global admin.
GRI-2075: fix clippy expect_used in join_english
Some checks failed
CI / the pre-push hook (pull_request) Successful in 37s
CI / cargo fmt (pull_request) Successful in 38s
CI / cargo clippy (pull_request) Successful in 3m0s
CI / cargo deny (pull_request) Successful in 2m45s
CI / cargo deny advisories (pull_request) Successful in 2m37s
CI / cargo test (pull_request) Failing after 3m29s
CI / repository boundary (pull_request) Successful in 45s
CI / frontend-web (pull_request) Successful in 1m54s
CI / CI (pull_request) Failing after 40s
CI / Notify gate failed (pull_request) Successful in 40s
ab5e047a81
Settings is now a left-menu section (SettingsSectionScreen/CampusesTab,
NetworkSettingsTab, PlaybackSettingsTab) rather than one SettingsScreen.
Campus CRUD moves into CampusesTab, and opening one campus from that list
renders CampusSettingsScreen with a back link while the left menu stays on
Campuses.
GRI-2075: prettier parens on ternary in SettingsSectionScreen
Some checks failed
CI / the pre-push hook (pull_request) Successful in 12s
CI / cargo deny (pull_request) Successful in 1m11s
CI / cargo clippy (pull_request) Successful in 2m6s
CI / cargo deny advisories (pull_request) Successful in 1m35s
CI / repository boundary (pull_request) Successful in 1m3s
CI / frontend-web (pull_request) Successful in 1m50s
CI / cargo test (pull_request) Successful in 3m58s
CI / cargo fmt (pull_request) Failing after 14m19s
CI / CI (pull_request) Has been cancelled
CI / Notify gate failed (pull_request) Has been cancelled
061d2b1ccd
GRI-2075: retrigger CI (cargo fmt job hit its 10m timeout after 14m19s on 061d2b1, a hang not a formatting diff; cargo fmt --all --check passes locally on that commit)
All checks were successful
CI / the pre-push hook (pull_request) Successful in 12s
CI / cargo fmt (pull_request) Successful in 12s
CI / cargo deny (pull_request) Successful in 1m39s
CI / cargo deny advisories (pull_request) Successful in 1m39s
CI / cargo clippy (pull_request) Successful in 2m12s
CI / repository boundary (pull_request) Successful in 44s
CI / frontend-web (pull_request) Successful in 1m55s
CI / cargo test (pull_request) Successful in 3m53s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 19s
50d9a680d5
Merge remote-tracking branch 'origin/dev' into feature/GRI-2075-panel-campus-admin
All checks were successful
CI / the pre-push hook (pull_request) Successful in 10s
CI / cargo fmt (pull_request) Successful in 10s
CI / cargo deny advisories (pull_request) Successful in 1m35s
CI / cargo deny (pull_request) Successful in 1m36s
CI / cargo clippy (pull_request) Successful in 2m29s
CI / repository boundary (pull_request) Successful in 56s
CI / frontend-web (pull_request) Successful in 2m5s
CI / cargo test (pull_request) Successful in 4m7s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 17s
f182f89043
Merge pull request 'GRI-2075: let a global admin manage campuses from Settings' (#219) from feature/GRI-2075-panel-campus-admin into dev
All checks were successful
CI / the pre-push hook (push) Successful in 1m29s
CI / cargo fmt (push) Successful in 1m28s
CI / cargo clippy (push) Successful in 3m2s
CI / cargo deny advisories (push) Successful in 2m10s
CI / cargo deny (push) Successful in 2m12s
CI / repository boundary (push) Successful in 57s
CI / the pre-push hook (pull_request) Successful in 58s
CI / cargo test (push) Successful in 4m50s
CI / cargo fmt (pull_request) Successful in 1m37s
CI / frontend-web (push) Successful in 2m52s
CI / cargo clippy (pull_request) Successful in 3m11s
CI / cargo deny (pull_request) Successful in 2m6s
CI / cargo deny advisories (pull_request) Successful in 2m6s
CI / repository boundary (pull_request) Successful in 1m13s
CI / frontend-web (pull_request) Successful in 2m29s
CI / cargo test (pull_request) Successful in 6m1s
CI / Notify gate failed (push) Has been skipped
CI / CI (push) Successful in 59s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 25s
91606c788d
GRI-2088: write fake_program script via child sh instead of in-process fd
Some checks failed
CI / the pre-push hook (pull_request) Successful in 7s
CI / cargo fmt (pull_request) Successful in 7s
CI / cargo deny (pull_request) Successful in 1m10s
CI / cargo clippy (pull_request) Successful in 2m15s
CI / cargo deny advisories (pull_request) Successful in 1m32s
CI / CI (pull_request) Has been cancelled
CI / Notify gate failed (pull_request) Has been cancelled
CI / cargo test (pull_request) Has been cancelled
CI / repository boundary (pull_request) Has been cancelled
CI / frontend-web (pull_request) Successful in 2m40s
9dd501d193
Removes the ETXTBSY race: a concurrent fork() from another test thread
could inherit a writable fd on the fake program before exec, causing
Linux to refuse exec with Text file busy. Writing via 'sh -c cat > ... && chmod'
means this process never holds that fd.
Merge branch 'dev' into fix/GRI-2088-fake-program-etxtbsy
All checks were successful
CI / the pre-push hook (pull_request) Successful in 1m15s
CI / cargo fmt (pull_request) Successful in 1m17s
CI / cargo clippy (pull_request) Successful in 2m12s
CI / cargo deny (pull_request) Successful in 2m45s
CI / cargo deny advisories (pull_request) Successful in 2m8s
CI / frontend-web (pull_request) Successful in 2m37s
CI / repository boundary (pull_request) Successful in 59s
CI / cargo test (pull_request) Successful in 5m30s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 36s
3c4f93288c
Merge pull request 'GRI-2088: fix ETXTBSY race in pptx_video fake_program test helper' (#221) from fix/GRI-2088-fake-program-etxtbsy into dev
All checks were successful
CI / the pre-push hook (push) Successful in 21s
CI / cargo fmt (push) Successful in 32s
CI / cargo deny advisories (push) Successful in 2m9s
CI / cargo deny (push) Successful in 2m42s
CI / cargo clippy (push) Successful in 4m41s
CI / repository boundary (push) Successful in 3m17s
CI / frontend-web (push) Successful in 4m27s
CI / the pre-push hook (pull_request) Successful in 3m10s
CI / cargo fmt (pull_request) Successful in 2m23s
CI / cargo test (push) Successful in 8m46s
CI / cargo deny (pull_request) Successful in 2m4s
CI / cargo deny advisories (pull_request) Successful in 3m39s
CI / cargo clippy (pull_request) Successful in 5m18s
CI / frontend-web (pull_request) Successful in 4m48s
CI / repository boundary (pull_request) Successful in 3m22s
CI / cargo test (pull_request) Successful in 9m11s
CI / Notify gate failed (push) Has been skipped
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (push) Successful in 1m4s
CI / CI (pull_request) Successful in 1m10s
2d72019113
GRI-2081: install.sh client upgrade installs the new build and restarts the player
Some checks failed
CI / the pre-push hook (pull_request) Successful in 49s
CI / cargo fmt (pull_request) Successful in 37s
CI / install.sh client upgrade (pull_request) Failing after 2m25s
CI / cargo deny (pull_request) Successful in 2m1s
CI / cargo clippy (pull_request) Successful in 2m30s
CI / repository boundary (pull_request) Successful in 56s
CI / cargo deny advisories (pull_request) Successful in 1m59s
CI / frontend-web (pull_request) Successful in 2m44s
CI / cargo test (pull_request) Successful in 4m56s
CI / CI (pull_request) Failing after 54s
CI / Notify gate failed (pull_request) Successful in 1m21s
7613c53572
Every client build was packaged as 0.1.0, and apt-get install skips a .deb
whose version is already installed, with exit 0 and its output in /dev/null.
install.sh upgrade client printed "installed" and left the old binary.

- package-client-deb.sh: each build is <version>+git<UTC commit time>.<sha>
  (SIGNAGE_DEB_VERSION overrides it).
- install.sh: apt-get install --reinstall --allow-downgrades, installs the
  file the package script names, then checks the dpkg version and the
  binary's sha256 against the .deb and stops on a mismatch; prints the
  installed version. A player still running the replaced binary is stopped
  and started again in its own session (user, environment, cwd, arguments).
- scripts/tests/install-client-upgrade-test.sh: real apt-get and dpkg against
  a private dpkg database; in local-gates.sh and as a CI job.
Merge branch 'dev' into fix/GRI-2081-client-upgrade-reinstall
Some checks failed
CI / the pre-push hook (pull_request) Successful in 23s
CI / cargo fmt (pull_request) Successful in 27s
CI / install.sh client upgrade (pull_request) Failing after 1m36s
CI / cargo clippy (pull_request) Successful in 2m10s
CI / cargo deny (pull_request) Successful in 1m52s
CI / cargo deny advisories (pull_request) Successful in 1m35s
CI / repository boundary (pull_request) Successful in 29s
CI / frontend-web (pull_request) Successful in 2m36s
CI / cargo test (pull_request) Successful in 5m0s
CI / Notify gate failed (pull_request) Successful in 1m9s
CI / CI (pull_request) Failing after 1m11s
d281986a43
Merge remote-tracking branch 'origin/dev' into fix/GRI-2081-client-upgrade-reinstall
Some checks failed
CI / the pre-push hook (pull_request) Successful in 54s
CI / cargo fmt (pull_request) Successful in 1m5s
CI / install.sh client upgrade (pull_request) Successful in 2m36s
CI / cargo clippy (pull_request) Successful in 2m53s
CI / cargo deny (pull_request) Successful in 1m47s
CI / cargo deny advisories (pull_request) Successful in 2m4s
CI / cargo test (pull_request) Failing after 3m55s
CI / repository boundary (pull_request) Successful in 1m56s
CI / frontend-web (pull_request) Successful in 2m29s
CI / Notify gate failed (pull_request) Successful in 27s
CI / CI (pull_request) Failing after 29s
c523957592
Merge remote-tracking branch 'origin/dev' into fix/GRI-2081-client-upgrade-reinstall
Some checks failed
CI / cargo fmt (pull_request) Successful in 45s
CI / the pre-push hook (pull_request) Successful in 53s
CI / install.sh client upgrade (pull_request) Successful in 1m0s
CI / cargo clippy (pull_request) Successful in 2m14s
CI / cargo deny advisories (pull_request) Successful in 1m53s
CI / cargo deny (pull_request) Successful in 2m1s
CI / cargo test (pull_request) Failing after 2m22s
CI / repository boundary (pull_request) Successful in 27s
CI / frontend-web (pull_request) Successful in 1m50s
CI / CI (pull_request) Failing after 25s
CI / Notify gate failed (pull_request) Successful in 27s
2ee3f441b8
Merge remote-tracking branch 'origin/dev' into HEAD
All checks were successful
CI / the pre-push hook (pull_request) Successful in 3m23s
CI / cargo fmt (pull_request) Successful in 1m11s
CI / install.sh client upgrade (pull_request) Successful in 2m51s
CI / cargo deny (pull_request) Successful in 1m45s
CI / cargo clippy (pull_request) Successful in 3m46s
CI / repository boundary (pull_request) Successful in 1m56s
CI / cargo deny advisories (pull_request) Successful in 3m6s
CI / frontend-web (pull_request) Successful in 3m28s
CI / cargo test (pull_request) Successful in 6m5s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 11s
b86baba332
Merge pull request 'GRI-2081: install.sh client upgrade installs the new build and restarts the player' (#217) from fix/GRI-2081-client-upgrade-reinstall into dev
All checks were successful
CI / the pre-push hook (push) Successful in 3s
CI / install.sh client upgrade (push) Successful in 7s
CI / cargo fmt (push) Successful in 4s
CI / cargo clippy (push) Successful in 1m15s
CI / cargo deny (push) Successful in 24s
CI / cargo deny advisories (push) Successful in 24s
CI / repository boundary (push) Successful in 4s
CI / the pre-push hook (pull_request) Successful in 4s
CI / cargo fmt (pull_request) Successful in 5s
CI / install.sh client upgrade (pull_request) Successful in 11s
CI / cargo test (push) Successful in 2m30s
CI / frontend-web (push) Successful in 1m1s
CI / cargo deny (pull_request) Successful in 23s
CI / cargo deny advisories (pull_request) Successful in 20s
CI / cargo clippy (pull_request) Successful in 1m15s
CI / repository boundary (pull_request) Successful in 4s
CI / CI (push) Successful in 2s
CI / Notify gate failed (push) Has been skipped
CI / frontend-web (pull_request) Successful in 1m1s
CI / cargo test (pull_request) Successful in 2m25s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 2s
2ae146b6cd
GRI-2074: split add-from-library into pick-file then pick-pages, with a page range
All checks were successful
CI / the pre-push hook (pull_request) Successful in 3s
CI / cargo fmt (pull_request) Successful in 4s
CI / install.sh client upgrade (pull_request) Successful in 7s
CI / cargo deny advisories (pull_request) Successful in 22s
CI / cargo deny (pull_request) Successful in 24s
CI / repository boundary (pull_request) Successful in 5s
CI / cargo clippy (pull_request) Successful in 1m22s
CI / frontend-web (pull_request) Successful in 1m4s
CI / cargo test (pull_request) Successful in 2m22s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 2s
b8f4b14c55
GRI-2074: add whole-document option, lazy page images, disable Add on invalid range
All checks were successful
CI / the pre-push hook (pull_request) Successful in 4s
CI / cargo fmt (pull_request) Successful in 3s
CI / install.sh client upgrade (pull_request) Successful in 6s
CI / cargo deny (pull_request) Successful in 19s
CI / cargo deny advisories (pull_request) Successful in 21s
CI / repository boundary (pull_request) Successful in 7s
CI / cargo clippy (pull_request) Successful in 1m28s
CI / frontend-web (pull_request) Successful in 1m11s
CI / cargo test (pull_request) Successful in 2m50s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 1s
78a4e8ffa9
Review feedback on PR #222: the two-step picker could no longer add a
multi-page document as itself, so new items never got the page-overrides
cogwheel or Skip this page. Add an explicit 'Add whole document' button
in the pages step. Also disable Add while the typed range is invalid,
and lazy-load page thumbnail images.
Merge pull request 'GRI-2074: playlist add-from-library in two steps (file, then pages) with a page range' (#222) from feature/GRI-2074-playlist-add-from-library-pages into dev
All checks were successful
CI / the pre-push hook (push) Successful in 4s
CI / cargo fmt (push) Successful in 3s
CI / install.sh client upgrade (push) Successful in 7s
CI / cargo deny (push) Successful in 14s
CI / cargo deny advisories (push) Successful in 24s
CI / repository boundary (push) Successful in 5s
CI / the pre-push hook (pull_request) Successful in 6s
CI / install.sh client upgrade (pull_request) Successful in 13s
CI / cargo fmt (pull_request) Successful in 6s
CI / cargo clippy (push) Successful in 1m21s
CI / frontend-web (push) Successful in 1m9s
CI / cargo deny (pull_request) Successful in 28s
CI / cargo clippy (pull_request) Successful in 1m33s
CI / cargo deny advisories (pull_request) Successful in 37s
CI / repository boundary (pull_request) Successful in 5s
CI / cargo test (push) Successful in 3m18s
CI / Notify gate failed (push) Has been skipped
CI / CI (push) Successful in 2s
CI / frontend-web (pull_request) Successful in 1m8s
CI / cargo test (pull_request) Successful in 2m50s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 2s
8ed0ea17fb
GRI-2101: red buttons only for danger, not every secondary action
All checks were successful
CI / the pre-push hook (pull_request) Successful in 3s
CI / cargo fmt (pull_request) Successful in 3s
CI / install.sh client upgrade (pull_request) Successful in 7s
CI / cargo deny (pull_request) Successful in 18s
CI / cargo deny advisories (pull_request) Successful in 21s
CI / repository boundary (pull_request) Successful in 5s
CI / cargo clippy (pull_request) Successful in 1m23s
CI / frontend-web (pull_request) Successful in 1m9s
CI / cargo test (pull_request) Successful in 2m37s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 2s
c6e41ea435
Expand, Edit, Open, Rename, Cancel, Back, Log out, Move up/down and
similar used gx-btn--secondary, this design system's red/danger
button class, even though none of them is destructive or urgent.

Add a gx-btn--neutral class (the shared @grimoirix/design package
only ships primary and secondary) and move every non-danger action
onto it, keeping gx-btn--secondary for Delete, Block, Remove and
Restart now. A vitest check scans every .tsx file and fails when a
gx-btn--secondary element's label does not read as a danger action.
Merge pull request 'GRI-2101: red buttons only for danger, not every secondary action' (#235) from fix/GRI-2101-neutral-secondary-buttons into dev
All checks were successful
CI / the pre-push hook (push) Successful in 5s
CI / cargo fmt (push) Successful in 4s
CI / install.sh client upgrade (push) Successful in 7s
CI / cargo deny (push) Successful in 18s
CI / cargo deny advisories (push) Successful in 26s
CI / repository boundary (push) Successful in 5s
CI / the pre-push hook (pull_request) Successful in 6s
CI / install.sh client upgrade (pull_request) Successful in 12s
CI / cargo fmt (pull_request) Successful in 6s
CI / cargo clippy (push) Successful in 1m25s
CI / frontend-web (push) Successful in 1m9s
CI / cargo deny (pull_request) Successful in 22s
CI / cargo deny advisories (pull_request) Successful in 24s
CI / cargo clippy (pull_request) Successful in 1m23s
CI / repository boundary (pull_request) Successful in 4s
CI / cargo test (push) Successful in 3m20s
CI / frontend-web (pull_request) Successful in 1m9s
CI / cargo test (pull_request) Successful in 3m31s
CI / CI (push) Successful in 3s
CI / Notify gate failed (push) Has been skipped
CI / CI (pull_request) Successful in 2s
CI / Notify gate failed (pull_request) Has been skipped
21eb1be5c6
GRI-2106: let a global or campus admin assign a device to a campus
All checks were successful
CI / the pre-push hook (pull_request) Successful in 3s
CI / cargo fmt (pull_request) Successful in 3s
CI / install.sh client upgrade (pull_request) Successful in 7s
CI / cargo deny advisories (pull_request) Successful in 21s
CI / cargo deny (pull_request) Successful in 22s
CI / repository boundary (pull_request) Successful in 6s
CI / cargo clippy (pull_request) Successful in 1m24s
CI / frontend-web (pull_request) Successful in 1m6s
CI / cargo test (pull_request) Successful in 2m26s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 2s
ce03388d76
Merge branch 'dev' into feature/GRI-2106-device-campus-assignment
All checks were successful
CI / the pre-push hook (pull_request) Successful in 6s
CI / install.sh client upgrade (pull_request) Successful in 10s
CI / cargo fmt (pull_request) Successful in 7s
CI / cargo deny (pull_request) Successful in 21s
CI / cargo deny advisories (pull_request) Successful in 23s
CI / cargo clippy (pull_request) Successful in 1m30s
CI / repository boundary (pull_request) Successful in 4s
CI / frontend-web (pull_request) Successful in 1m5s
CI / cargo test (pull_request) Successful in 3m21s
CI / CI (pull_request) Successful in 2s
CI / Notify gate failed (pull_request) Has been skipped
e98e703c40
Merge pull request 'GRI-2106: let a global or campus admin assign a device to a campus' (#238) from feature/GRI-2106-device-campus-assignment into dev
All checks were successful
CI / the pre-push hook (push) Successful in 6s
CI / install.sh client upgrade (push) Successful in 10s
CI / cargo fmt (push) Successful in 5s
CI / cargo deny (push) Successful in 16s
CI / cargo deny advisories (push) Successful in 21s
CI / repository boundary (push) Successful in 6s
CI / the pre-push hook (pull_request) Successful in 6s
CI / install.sh client upgrade (pull_request) Successful in 14s
CI / cargo fmt (pull_request) Successful in 6s
CI / cargo clippy (push) Successful in 1m25s
CI / frontend-web (push) Successful in 1m17s
CI / cargo deny (pull_request) Successful in 30s
CI / cargo clippy (pull_request) Successful in 1m32s
CI / cargo deny advisories (pull_request) Successful in 26s
CI / repository boundary (pull_request) Successful in 6s
CI / frontend-web (pull_request) Successful in 1m30s
CI / cargo test (push) Successful in 4m22s
CI / cargo test (pull_request) Successful in 4m45s
CI / CI (push) Successful in 2s
CI / Notify gate failed (push) Has been skipped
CI / CI (pull_request) Successful in 2s
CI / Notify gate failed (pull_request) Has been skipped
30d507fd3e
GRI-2099: client install logs a screen account in at boot, so a screen shows the player after a reboot
All checks were successful
CI / the pre-push hook (pull_request) Successful in 4s
CI / cargo fmt (pull_request) Successful in 3s
CI / install.sh client upgrade (pull_request) Successful in 7s
CI / cargo deny (pull_request) Successful in 15s
CI / cargo deny advisories (pull_request) Successful in 15s
CI / repository boundary (pull_request) Successful in 6s
CI / cargo clippy (pull_request) Successful in 1m23s
CI / frontend-web (pull_request) Successful in 1m10s
CI / cargo test (pull_request) Successful in 2m36s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 2s
616ae9b5f6
install.sh client now makes a screen account (default scryglass, no admin
rights), removes its password (GRI-2051), sets GDM's AutomaticLoginEnable and
AutomaticLogin and nothing else, and gives that account a locked dconf profile
with no screen lock, blanking or idle suspend. It stops before the build when
sshd allows empty passwords, or when the named account has sudo or is a
system account. --kiosk-user, --kiosk-password-keep and --no-kiosk (and their
SCRYGLASS_* variables) are recorded in /etc/grimoirix-signage/install.toml,
so an upgrade keeps them; an upgrade never re-creates the account, never
touches an existing password, and keeps an auto-login set to something else.

scripts/tests/install-client-kiosk-test.sh measures the custom.conf edit
(keys set, other lines kept, a second run changes nothing), the plan and its
refusals, and the whole step twice on a private root. Run by CI and by
local-gates.sh.
Merge branch 'dev' into feature/GRI-2099-kiosk-autologin
All checks were successful
CI / the pre-push hook (pull_request) Successful in 4s
CI / install.sh client upgrade (pull_request) Successful in 11s
CI / cargo fmt (pull_request) Successful in 6s
CI / cargo deny (pull_request) Successful in 23s
CI / cargo deny advisories (pull_request) Successful in 23s
CI / cargo clippy (pull_request) Successful in 1m38s
CI / repository boundary (pull_request) Successful in 5s
CI / frontend-web (pull_request) Successful in 1m5s
CI / cargo test (pull_request) Successful in 3m37s
CI / CI (pull_request) Successful in 2s
CI / Notify gate failed (pull_request) Has been skipped
daa9f73aa3
Merge branch 'dev' into feature/GRI-2099-kiosk-autologin
All checks were successful
CI / the pre-push hook (pull_request) Successful in 5s
CI / install.sh client upgrade (pull_request) Successful in 14s
CI / cargo fmt (pull_request) Successful in 8s
CI / cargo deny (pull_request) Successful in 21s
CI / cargo clippy (pull_request) Successful in 1m33s
CI / cargo deny advisories (pull_request) Successful in 24s
CI / repository boundary (pull_request) Successful in 5s
CI / frontend-web (pull_request) Successful in 1m34s
CI / cargo test (pull_request) Successful in 4m34s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 2s
a07286e392
Merge pull request 'GRI-2099: client install logs a screen account in at boot (auto-login, no password)' (#234) from feature/GRI-2099-kiosk-autologin into dev
All checks were successful
CI / the pre-push hook (push) Successful in 4s
CI / cargo fmt (push) Successful in 4s
CI / install.sh client upgrade (push) Successful in 8s
CI / cargo deny (push) Successful in 13s
CI / cargo deny advisories (push) Successful in 15s
CI / repository boundary (push) Successful in 6s
CI / the pre-push hook (pull_request) Successful in 6s
CI / install.sh client upgrade (pull_request) Successful in 12s
CI / cargo fmt (pull_request) Successful in 6s
CI / cargo clippy (push) Successful in 1m17s
CI / frontend-web (push) Successful in 1m9s
CI / cargo deny (pull_request) Successful in 21s
CI / cargo clippy (pull_request) Successful in 1m16s
CI / cargo deny advisories (pull_request) Successful in 22s
CI / repository boundary (pull_request) Successful in 5s
CI / cargo test (push) Successful in 3m8s
CI / frontend-web (pull_request) Successful in 1m5s
CI / cargo test (pull_request) Successful in 3m17s
CI / CI (push) Successful in 1s
CI / Notify gate failed (push) Has been skipped
CI / CI (pull_request) Successful in 1s
CI / Notify gate failed (pull_request) Has been skipped
0cb7e82602
GRI-2109: return 409 device_assigned on playlist delete, with unassign_devices option
All checks were successful
CI / the pre-push hook (pull_request) Successful in 4s
CI / install.sh client upgrade (pull_request) Successful in 6s
CI / cargo fmt (pull_request) Successful in 4s
CI / cargo deny (pull_request) Successful in 15s
CI / cargo deny advisories (pull_request) Successful in 18s
CI / repository boundary (pull_request) Successful in 6s
CI / cargo clippy (pull_request) Successful in 1m21s
CI / frontend-web (pull_request) Successful in 1m5s
CI / cargo test (pull_request) Successful in 2m28s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 2s
5f17186348
Deleting a playlist that devices use failed with a bare 500 from the
foreign-key violation. DELETE /playlists/{id} now returns 409 with the
blocking devices named; ?unassign_devices=true unassigns them (pushing
PlaylistCleared, or marking pending-clear if offline) and deletes the
playlist in one transaction.
Merge remote-tracking branch 'origin/dev' into fix/GRI-2109-playlist-delete-device-conflict
All checks were successful
CI / the pre-push hook (pull_request) Successful in 5s
CI / install.sh client upgrade (pull_request) Successful in 12s
CI / cargo fmt (pull_request) Successful in 7s
CI / cargo deny (pull_request) Successful in 24s
CI / cargo deny advisories (pull_request) Successful in 27s
CI / cargo clippy (pull_request) Successful in 1m54s
CI / repository boundary (pull_request) Successful in 4s
CI / frontend-web (pull_request) Successful in 1m15s
CI / cargo test (pull_request) Successful in 3m15s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 2s
53b8eebd84
Merge branch 'dev' into fix/GRI-2109-playlist-delete-device-conflict
All checks were successful
CI / the pre-push hook (pull_request) Successful in 5s
CI / install.sh client upgrade (pull_request) Successful in 10s
CI / cargo fmt (pull_request) Successful in 5s
CI / cargo deny (pull_request) Successful in 19s
CI / cargo deny advisories (pull_request) Successful in 23s
CI / cargo clippy (pull_request) Successful in 1m27s
CI / repository boundary (pull_request) Successful in 4s
CI / frontend-web (pull_request) Successful in 57s
CI / cargo test (pull_request) Successful in 3m7s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 1s
ef87086025
Merge pull request 'GRI-2109: return 409 on playlist delete with devices assigned, offer unassign' (#246) from fix/GRI-2109-playlist-delete-device-conflict into dev
All checks were successful
CI / cargo fmt (push) Successful in 3s
CI / the pre-push hook (push) Successful in 4s
CI / install.sh client upgrade (push) Successful in 8s
CI / cargo deny (push) Successful in 16s
CI / cargo deny advisories (push) Successful in 17s
CI / repository boundary (push) Successful in 6s
CI / the pre-push hook (pull_request) Successful in 5s
CI / install.sh client upgrade (pull_request) Successful in 13s
CI / cargo fmt (pull_request) Successful in 6s
CI / cargo clippy (push) Successful in 1m32s
CI / frontend-web (push) Successful in 1m26s
CI / cargo deny (pull_request) Successful in 21s
CI / cargo clippy (pull_request) Successful in 1m27s
CI / cargo deny advisories (pull_request) Successful in 23s
CI / repository boundary (pull_request) Successful in 5s
CI / cargo test (push) Successful in 3m38s
CI / frontend-web (pull_request) Successful in 1m14s
CI / cargo test (pull_request) Successful in 3m47s
CI / CI (push) Successful in 2s
CI / Notify gate failed (push) Has been skipped
CI / CI (pull_request) Successful in 2s
CI / Notify gate failed (pull_request) Has been skipped
2973265f51
Add a shared DismissibleError component: a close button, a 10s
auto-dismiss timer that pauses while the pointer is on it, and
selectable text. Wire it into MediaScreen's upload and add-by-URL
errors, the ones named in the campus test report. Clearing on the
next action was already handled by the existing setError(null) calls
at the start of each handler; unmounting on navigation clears it too.
GRI-2108: adopt DismissibleError across the rest of the panel's transient error notes
All checks were successful
CI / the pre-push hook (pull_request) Successful in 5s
CI / install.sh client upgrade (pull_request) Successful in 11s
CI / cargo fmt (pull_request) Successful in 5s
CI / cargo deny (pull_request) Successful in 21s
CI / cargo deny advisories (pull_request) Successful in 23s
CI / cargo clippy (pull_request) Successful in 1m35s
CI / repository boundary (pull_request) Successful in 4s
CI / frontend-web (pull_request) Successful in 1m3s
CI / cargo test (pull_request) Successful in 2m44s
CI / CI (pull_request) Successful in 2s
CI / Notify gate failed (pull_request) Has been skipped
d1b91e134a
Every transient action/save/delete error note (not the full-page
load-failure states, which have no other controls to cover, and not
AddFromLibraryDialog's live range validation, which tracks the current
input) now closes by its button, its timer, or the next action, the
same as the media screen.
Merge remote-tracking branch 'origin/dev' into fix/GRI-2108-panel-error-dismiss
All checks were successful
CI / the pre-push hook (pull_request) Successful in 5s
CI / install.sh client upgrade (pull_request) Successful in 11s
CI / cargo fmt (pull_request) Successful in 6s
CI / cargo deny (pull_request) Successful in 20s
CI / cargo deny advisories (pull_request) Successful in 22s
CI / cargo clippy (pull_request) Successful in 1m40s
CI / repository boundary (pull_request) Successful in 5s
CI / frontend-web (pull_request) Successful in 1m20s
CI / cargo test (pull_request) Successful in 4m17s
CI / CI (pull_request) Successful in 1s
CI / Notify gate failed (pull_request) Has been skipped
9f48a718b7
# Conflicts:
#	frontend-web/src/screens/DevicesScreen.tsx
Merge branch 'dev' into fix/GRI-2108-panel-error-dismiss
All checks were successful
CI / the pre-push hook (pull_request) Successful in 6s
CI / cargo fmt (pull_request) Successful in 4s
CI / install.sh client upgrade (pull_request) Successful in 8s
CI / cargo deny (pull_request) Successful in 35s
CI / cargo deny advisories (pull_request) Successful in 38s
CI / repository boundary (pull_request) Successful in 6s
CI / cargo clippy (pull_request) Successful in 1m28s
CI / frontend-web (pull_request) Successful in 1m3s
CI / cargo test (pull_request) Successful in 2m31s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 1s
f61571415e
Merge pull request 'GRI-2108: dismissible, self-closing error notes in the panel' (#241) from fix/GRI-2108-panel-error-dismiss into dev
All checks were successful
CI / the pre-push hook (push) Successful in 5s
CI / install.sh client upgrade (push) Successful in 8s
CI / cargo fmt (push) Successful in 3s
CI / cargo deny advisories (push) Successful in 14s
CI / cargo deny (push) Successful in 17s
CI / repository boundary (push) Successful in 4s
CI / the pre-push hook (pull_request) Successful in 5s
CI / install.sh client upgrade (pull_request) Successful in 12s
CI / cargo fmt (pull_request) Successful in 5s
CI / cargo clippy (push) Successful in 1m21s
CI / frontend-web (push) Successful in 1m6s
CI / cargo deny (pull_request) Successful in 18s
CI / cargo deny advisories (pull_request) Successful in 25s
CI / cargo clippy (pull_request) Successful in 1m22s
CI / repository boundary (pull_request) Successful in 5s
CI / cargo test (push) Successful in 3m20s
CI / frontend-web (pull_request) Successful in 1m14s
CI / cargo test (pull_request) Successful in 3m21s
CI / Notify gate failed (push) Has been skipped
CI / CI (push) Successful in 1s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 2s
df90ccf66f
vivy added 10 commits 2026-11-15 20:49:23 +00:00
Devices tab checkbox is no longer disabled for an already-assigned
device; Save now diffs selection against the current assignment and
both assigns the newly-checked devices and unassigns the unchecked
ones (DELETE /devices/{id}/playlist, #209). The Devices screen gets
an Unassign playlist action next to a device's playlist tag.
GRI-2107: prettier formatting
Some checks failed
CI / the pre-push hook (pull_request) Successful in 4s
CI / cargo fmt (pull_request) Successful in 3s
CI / install.sh client upgrade (pull_request) Successful in 8s
CI / cargo deny (pull_request) Successful in 12s
CI / cargo deny advisories (pull_request) Successful in 24s
CI / cargo clippy (pull_request) Successful in 1m16s
CI / repository boundary (pull_request) Successful in 5s
CI / frontend-web (pull_request) Failing after 46s
CI / cargo test (pull_request) Successful in 2m36s
CI / CI (pull_request) Failing after 1s
CI / Notify gate failed (pull_request) Successful in 1s
3f974ece3a
GRI-2107: neutral Unassign button, re-seed selection on refetch
Some checks failed
CI / the pre-push hook (pull_request) Successful in 4s
CI / install.sh client upgrade (pull_request) Successful in 7s
CI / cargo fmt (pull_request) Successful in 4s
CI / cargo deny (pull_request) Successful in 15s
CI / cargo deny advisories (pull_request) Successful in 20s
CI / repository boundary (pull_request) Successful in 5s
CI / frontend-web (pull_request) Failing after 52s
CI / cargo clippy (pull_request) Successful in 1m16s
CI / cargo test (pull_request) Successful in 2m30s
CI / CI (pull_request) Failing after 1s
CI / Notify gate failed (pull_request) Successful in 2s
9180e20b1b
- Unassign playlist uses gx-btn--neutral (#235's danger-only red rule)
- AssignToDeviceForm remounts when the assignment set changes, so a
  refetched playlist re-seeds `selected` instead of diffing against
  a stale snapshot from first mount
GRI-2107: merge dev, resolve DevicesScreen campus/unassign prop conflict
Some checks failed
CI / the pre-push hook (pull_request) Successful in 7s
CI / cargo fmt (pull_request) Successful in 6s
CI / install.sh client upgrade (pull_request) Successful in 10s
CI / cargo deny (pull_request) Successful in 23s
CI / cargo deny advisories (pull_request) Successful in 33s
CI / repository boundary (pull_request) Successful in 7s
CI / frontend-web (pull_request) Failing after 1m11s
CI / cargo clippy (pull_request) Successful in 2m20s
CI / cargo test (pull_request) Successful in 4m51s
CI / CI (pull_request) Failing after 1s
CI / Notify gate failed (pull_request) Successful in 1s
609cb5933a
Merge remote-tracking branch 'origin/dev' into fix/GRI-2107-unassign-device-from-playlist
Some checks failed
CI / the pre-push hook (pull_request) Successful in 4s
CI / cargo fmt (pull_request) Successful in 3s
CI / install.sh client upgrade (pull_request) Successful in 8s
CI / cargo deny (pull_request) Successful in 22s
CI / cargo deny advisories (pull_request) Successful in 29s
CI / repository boundary (pull_request) Successful in 5s
CI / frontend-web (pull_request) Failing after 49s
CI / cargo test (pull_request) Failing after 1m20s
CI / cargo clippy (pull_request) Successful in 1m26s
CI / Notify gate failed (pull_request) Successful in 0s
CI / CI (pull_request) Failing after 2s
8053e7c590
Merge remote-tracking branch 'origin/dev' into fix/GRI-2107-unassign-device-from-playlist
Some checks failed
CI / the pre-push hook (pull_request) Successful in 4s
CI / install.sh client upgrade (pull_request) Successful in 10s
CI / cargo fmt (pull_request) Successful in 5s
CI / cargo deny (pull_request) Successful in 18s
CI / cargo deny advisories (pull_request) Successful in 26s
CI / repository boundary (pull_request) Successful in 3s
CI / cargo clippy (pull_request) Successful in 1m21s
CI / frontend-web (pull_request) Failing after 40s
CI / cargo test (pull_request) Successful in 2m23s
CI / CI (pull_request) Failing after 1s
CI / Notify gate failed (pull_request) Successful in 2s
deed537423
GRI-2107: update PlaylistsScreen tests for Save/Saved, enabled checkbox, and add uncheck-to-unassign test
All checks were successful
CI / the pre-push hook (pull_request) Successful in 4s
CI / cargo fmt (pull_request) Successful in 4s
CI / install.sh client upgrade (pull_request) Successful in 8s
CI / cargo deny (pull_request) Successful in 16s
CI / cargo deny advisories (pull_request) Successful in 26s
CI / repository boundary (pull_request) Successful in 5s
CI / cargo clippy (pull_request) Successful in 1m22s
CI / frontend-web (pull_request) Successful in 1m8s
CI / cargo test (pull_request) Successful in 2m30s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 1s
8c82b43956
Merge remote-tracking branch 'origin/dev' into fix/GRI-2107-unassign-device-from-playlist
All checks were successful
CI / the pre-push hook (pull_request) Successful in 5s
CI / install.sh client upgrade (pull_request) Successful in 9s
CI / cargo fmt (pull_request) Successful in 5s
CI / cargo deny (pull_request) Successful in 15s
CI / cargo deny advisories (pull_request) Successful in 25s
CI / repository boundary (pull_request) Successful in 5s
CI / cargo clippy (pull_request) Successful in 1m30s
CI / frontend-web (pull_request) Successful in 1m0s
CI / cargo test (pull_request) Successful in 2m38s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 1s
a876335f9e
Merge pull request 'GRI-2107: panel can unassign a device from a playlist' (#237) from fix/GRI-2107-unassign-device-from-playlist into dev
All checks were successful
CI / the pre-push hook (push) Successful in 4s
CI / cargo fmt (push) Successful in 4s
CI / install.sh client upgrade (push) Successful in 8s
CI / cargo deny (push) Successful in 14s
CI / cargo deny advisories (push) Successful in 15s
CI / repository boundary (push) Successful in 5s
CI / the pre-push hook (pull_request) Successful in 5s
CI / install.sh client upgrade (pull_request) Successful in 12s
CI / cargo fmt (pull_request) Successful in 5s
CI / cargo clippy (push) Successful in 1m18s
CI / frontend-web (push) Successful in 1m11s
CI / cargo deny (pull_request) Successful in 21s
CI / cargo deny advisories (pull_request) Successful in 24s
CI / cargo clippy (pull_request) Successful in 1m26s
CI / repository boundary (pull_request) Successful in 5s
CI / cargo test (push) Successful in 3m25s
CI / frontend-web (pull_request) Successful in 1m12s
CI / Notify gate failed (push) Has been skipped
CI / CI (push) Successful in 1s
CI / cargo test (pull_request) Successful in 3m8s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 1s
f6470407dd
GRI-2121: panel shows upload percentage while a file is sent
All checks were successful
CI / the pre-push hook (pull_request) Successful in 5s
CI / install.sh client upgrade (pull_request) Successful in 14s
CI / cargo fmt (pull_request) Successful in 7s
CI / cargo deny (pull_request) Successful in 19s
CI / cargo deny advisories (pull_request) Successful in 21s
CI / cargo clippy (pull_request) Successful in 1m35s
CI / repository boundary (pull_request) Successful in 5s
CI / frontend-web (pull_request) Successful in 1m35s
CI / cargo test (pull_request) Successful in 4m17s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 1s
324ec20bc6
Merge pull request 'GRI-2121: panel shows upload percentage while a file is sent' (#255) from feature/GRI-2121-upload-progress-percent into dev
All checks were successful
CI / the pre-push hook (push) Successful in 6s
CI / install.sh client upgrade (push) Successful in 10s
CI / cargo fmt (push) Successful in 6s
CI / cargo deny (push) Successful in 20s
CI / cargo deny advisories (push) Successful in 24s
CI / cargo clippy (push) Successful in 1m45s
CI / repository boundary (push) Successful in 5s
CI / the pre-push hook (pull_request) Successful in 5s
CI / cargo fmt (pull_request) Successful in 4s
CI / install.sh client upgrade (pull_request) Successful in 8s
CI / frontend-web (push) Successful in 1m7s
CI / cargo deny (pull_request) Successful in 19s
CI / cargo deny advisories (pull_request) Successful in 25s
CI / cargo clippy (pull_request) Successful in 2m15s
CI / repository boundary (pull_request) Successful in 5s
CI / frontend-web (pull_request) Successful in 1m23s
CI / cargo test (push) Successful in 4m26s
CI / CI (push) Successful in 2s
CI / Notify gate failed (push) Has been skipped
CI / cargo test (pull_request) Successful in 5m47s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 2s
cb06c667b0
GRI-2102: install soffice, gs and ffmpeg on every server path, warn when one is missing
Some checks failed
CI / the pre-push hook (pull_request) Successful in 4s
CI / install.sh client upgrade (pull_request) Successful in 8s
CI / cargo fmt (pull_request) Successful in 3s
CI / cargo deny (pull_request) Successful in 14s
CI / cargo deny advisories (pull_request) Successful in 17s
CI / repository boundary (pull_request) Successful in 6s
CI / cargo clippy (pull_request) Successful in 1m38s
CI / frontend-web (pull_request) Successful in 1m20s
CI / cargo test (pull_request) Failing after 2m25s
CI / CI (pull_request) Failing after 2s
CI / Notify gate failed (pull_request) Successful in 1s
05c0e69630
install.sh installed only poppler-utils, so every PowerPoint upload on a
native install failed with "soffice is not installed" (forge #229).

- install.sh: SERVER_CONVERTER_PACKAGES (poppler-utils, libreoffice-impress,
  ghostscript, ffmpeg), installed by server_native, which upgrade runs too.
- Dockerfile: the runtime image installs the same list.
- soffice gets its own profile in the work dir via -env:UserInstallation;
  under the shipped unit (DynamicUser, ProtectHome) it cannot create one in
  HOME and exits 77.
- The server logs one warning per missing converter at start-up.
- scripts/tests/install-server-converters-test.sh holds both install paths
  to the list; wired into local-gates.sh and CI.
GRI-2102: cargo fmt
All checks were successful
CI / the pre-push hook (pull_request) Successful in 5s
CI / cargo fmt (pull_request) Successful in 6s
CI / install.sh client upgrade (pull_request) Successful in 10s
CI / cargo deny (pull_request) Successful in 31s
CI / cargo deny advisories (pull_request) Successful in 38s
CI / repository boundary (pull_request) Successful in 5s
CI / cargo clippy (pull_request) Successful in 2m26s
CI / frontend-web (pull_request) Successful in 1m25s
CI / cargo test (pull_request) Successful in 4m0s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 2s
69462aa845
Merge remote-tracking branch 'origin/dev' into fix/GRI-2102-install-converters
Some checks failed
CI / the pre-push hook (pull_request) Successful in 7s
CI / cargo fmt (pull_request) Successful in 5s
CI / install.sh client upgrade (pull_request) Successful in 12s
CI / cargo deny (pull_request) Successful in 23s
CI / cargo deny advisories (pull_request) Successful in 24s
CI / repository boundary (pull_request) Successful in 7s
CI / CI (pull_request) Has been cancelled
CI / Notify gate failed (pull_request) Has been cancelled
CI / cargo test (pull_request) Has been cancelled
CI / cargo clippy (pull_request) Has been cancelled
CI / frontend-web (pull_request) Has been cancelled
a77be4e2b4
# Conflicts:
#	.github/workflows/ci.yml
#	scripts/local-gates.sh
Merge remote-tracking branch 'origin/dev' into fix/GRI-2102-install-converters
All checks were successful
CI / the pre-push hook (pull_request) Successful in 5s
CI / cargo fmt (pull_request) Successful in 5s
CI / install.sh client upgrade (pull_request) Successful in 10s
CI / cargo deny (pull_request) Successful in 18s
CI / cargo deny advisories (pull_request) Successful in 18s
CI / repository boundary (pull_request) Successful in 6s
CI / cargo clippy (pull_request) Successful in 1m34s
CI / frontend-web (pull_request) Successful in 1m16s
CI / cargo test (pull_request) Successful in 3m26s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 1s
9f5f1ca7c7
Merge pull request 'GRI-2102: install soffice, gs and ffmpeg on every server path, warn when one is missing' (#243) from fix/GRI-2102-install-converters into dev
All checks were successful
CI / the pre-push hook (push) Successful in 4s
CI / install.sh client upgrade (push) Successful in 9s
CI / cargo fmt (push) Successful in 3s
CI / cargo deny (push) Successful in 17s
CI / cargo deny advisories (push) Successful in 17s
CI / repository boundary (push) Successful in 6s
CI / the pre-push hook (pull_request) Successful in 5s
CI / install.sh client upgrade (pull_request) Successful in 14s
CI / cargo fmt (pull_request) Successful in 7s
CI / cargo clippy (push) Successful in 1m34s
CI / frontend-web (push) Successful in 1m23s
CI / cargo deny (pull_request) Successful in 18s
CI / cargo deny advisories (pull_request) Successful in 22s
CI / cargo clippy (pull_request) Successful in 1m31s
CI / repository boundary (pull_request) Successful in 5s
CI / frontend-web (pull_request) Successful in 1m37s
CI / cargo test (push) Successful in 4m32s
CI / cargo test (pull_request) Successful in 4m39s
CI / CI (push) Successful in 2s
CI / Notify gate failed (push) Has been skipped
CI / CI (pull_request) Successful in 3s
CI / Notify gate failed (pull_request) Has been skipped
0178b0c537
GRI-2104: add DELETE /devices/{id} to remove a device
All checks were successful
CI / the pre-push hook (pull_request) Successful in 4s
CI / cargo fmt (pull_request) Successful in 4s
CI / install.sh client upgrade (pull_request) Successful in 8s
CI / cargo deny (pull_request) Successful in 12s
CI / cargo deny advisories (pull_request) Successful in 16s
CI / repository boundary (pull_request) Successful in 5s
CI / cargo clippy (pull_request) Successful in 1m33s
CI / frontend-web (pull_request) Successful in 1m15s
CI / cargo test (pull_request) Successful in 2m59s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 1s
5578af32eb
Merge branch 'dev' into feature/GRI-2104-remove-device
Some checks failed
CI / the pre-push hook (pull_request) Successful in 5s
CI / cargo fmt (pull_request) Successful in 6s
CI / install.sh client upgrade (pull_request) Successful in 12s
CI / cargo deny (pull_request) Successful in 23s
CI / cargo deny advisories (pull_request) Successful in 24s
CI / frontend-web (pull_request) Failing after 1m28s
CI / repository boundary (pull_request) Successful in 7s
CI / cargo clippy (pull_request) Successful in 2m42s
CI / cargo test (pull_request) Successful in 5m3s
CI / CI (pull_request) Failing after 3s
CI / Notify gate failed (pull_request) Successful in 2s
8c675fc866
Merge branch 'dev' into feature/GRI-2104-remove-device
All checks were successful
CI / the pre-push hook (pull_request) Successful in 5s
CI / install.sh client upgrade (pull_request) Successful in 9s
CI / cargo fmt (pull_request) Successful in 5s
CI / cargo deny (pull_request) Successful in 18s
CI / cargo deny advisories (pull_request) Successful in 23s
CI / repository boundary (pull_request) Successful in 7s
CI / cargo clippy (pull_request) Successful in 2m0s
CI / frontend-web (pull_request) Successful in 1m28s
CI / cargo test (pull_request) Successful in 5m20s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 3s
d8d1e3d02f
Merge pull request 'GRI-2104: add DELETE /devices/{id} to remove a device' (#251) from feature/GRI-2104-remove-device into dev
All checks were successful
CI / the pre-push hook (push) Successful in 5s
CI / cargo fmt (push) Successful in 5s
CI / install.sh client upgrade (push) Successful in 12s
CI / cargo deny (push) Successful in 22s
CI / cargo deny advisories (push) Successful in 23s
CI / cargo clippy (push) Successful in 1m42s
CI / repository boundary (push) Successful in 5s
CI / the pre-push hook (pull_request) Successful in 5s
CI / cargo fmt (pull_request) Successful in 3s
CI / install.sh client upgrade (pull_request) Successful in 10s
CI / frontend-web (push) Successful in 1m12s
CI / cargo deny (pull_request) Successful in 22s
CI / cargo deny advisories (pull_request) Successful in 22s
CI / cargo clippy (pull_request) Successful in 1m38s
CI / repository boundary (pull_request) Successful in 5s
CI / cargo test (push) Successful in 3m53s
CI / frontend-web (pull_request) Successful in 1m17s
CI / CI (push) Successful in 1s
CI / Notify gate failed (push) Has been skipped
CI / cargo test (pull_request) Successful in 4m26s
CI / CI (pull_request) Successful in 2s
CI / Notify gate failed (pull_request) Has been skipped
88bee3b275
GRI-2105: let an admin set a new password for a user
All checks were successful
CI / the pre-push hook (pull_request) Successful in 4s
CI / cargo fmt (pull_request) Successful in 5s
CI / install.sh client upgrade (pull_request) Successful in 8s
CI / cargo deny (pull_request) Successful in 16s
CI / cargo deny advisories (pull_request) Successful in 24s
CI / repository boundary (pull_request) Successful in 5s
CI / cargo clippy (pull_request) Successful in 1m27s
CI / frontend-web (pull_request) Successful in 1m14s
CI / cargo test (pull_request) Successful in 4m28s
CI / CI (pull_request) Successful in 2s
CI / Notify gate failed (pull_request) Has been skipped
2b79c3c925
Merge branch 'dev' into fix/GRI-2105-admin-set-password
All checks were successful
CI / the pre-push hook (pull_request) Successful in 5s
CI / install.sh client upgrade (pull_request) Successful in 11s
CI / cargo fmt (pull_request) Successful in 4s
CI / cargo deny (pull_request) Successful in 23s
CI / cargo clippy (pull_request) Successful in 2m7s
CI / cargo deny advisories (pull_request) Successful in 26s
CI / repository boundary (pull_request) Successful in 6s
CI / frontend-web (pull_request) Successful in 1m25s
CI / cargo test (pull_request) Successful in 4m28s
CI / CI (pull_request) Successful in 2s
CI / Notify gate failed (pull_request) Has been skipped
e117bb0562
Merge branch 'dev' into fix/GRI-2105-admin-set-password
All checks were successful
CI / the pre-push hook (pull_request) Successful in 5s
CI / cargo fmt (pull_request) Successful in 5s
CI / install.sh client upgrade (pull_request) Successful in 11s
CI / cargo deny (pull_request) Successful in 23s
CI / cargo deny advisories (pull_request) Successful in 21s
CI / cargo clippy (pull_request) Successful in 2m0s
CI / repository boundary (pull_request) Successful in 7s
CI / frontend-web (pull_request) Successful in 1m23s
CI / cargo test (pull_request) Successful in 4m42s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 2s
dee5dfe45f
Merge pull request 'GRI-2105: let an admin set a new password for a user' (#256) from fix/GRI-2105-admin-set-password into dev
Some checks failed
CI / cargo fmt (push) Successful in 5s
CI / the pre-push hook (push) Successful in 6s
CI / install.sh client upgrade (push) Successful in 8s
CI / cargo deny (push) Successful in 14s
CI / cargo deny advisories (push) Successful in 19s
CI / repository boundary (push) Successful in 5s
CI / the pre-push hook (pull_request) Successful in 5s
CI / install.sh client upgrade (pull_request) Successful in 13s
CI / cargo fmt (pull_request) Successful in 6s
CI / cargo clippy (push) Successful in 1m25s
CI / frontend-web (push) Successful in 1m15s
CI / cargo deny (pull_request) Successful in 22s
CI / cargo deny advisories (pull_request) Successful in 24s
CI / cargo clippy (pull_request) Successful in 1m30s
CI / repository boundary (pull_request) Successful in 7s
CI / frontend-web (pull_request) Successful in 1m14s
CI / cargo test (push) Successful in 3m36s
CI / cargo test (pull_request) Failing after 3m22s
CI / Notify gate failed (pull_request) Successful in 1s
CI / CI (push) Successful in 1s
CI / Notify gate failed (push) Has been skipped
CI / CI (pull_request) Failing after 1s
4ccc194e49
GRI-2103: show playlist rollout status on the Devices screen (#228)
All checks were successful
CI / the pre-push hook (pull_request) Successful in 4s
CI / cargo fmt (pull_request) Successful in 5s
CI / install.sh client upgrade (pull_request) Successful in 10s
CI / cargo deny (pull_request) Successful in 2m16s
CI / cargo deny advisories (pull_request) Successful in 22s
CI / repository boundary (pull_request) Successful in 5s
CI / cargo clippy (pull_request) Successful in 3m33s
CI / frontend-web (pull_request) Successful in 1m13s
CI / cargo test (pull_request) Successful in 5m36s
CI / CI (pull_request) Successful in 2s
CI / Notify gate failed (pull_request) Has been skipped
94613e8f30
Merge branch 'dev' into feature/GRI-2103-device-rollout-status
Some checks failed
CI / the pre-push hook (pull_request) Successful in 4s
CI / install.sh client upgrade (pull_request) Successful in 20s
CI / cargo fmt (pull_request) Successful in 6s
CI / cargo deny (pull_request) Successful in 21s
CI / cargo deny advisories (pull_request) Successful in 24s
CI / cargo clippy (pull_request) Successful in 2m6s
CI / repository boundary (pull_request) Successful in 7s
CI / frontend-web (pull_request) Successful in 1m14s
CI / cargo test (pull_request) Failing after 4m8s
CI / CI (pull_request) Failing after 2s
CI / Notify gate failed (pull_request) Successful in 3s
af300ad895
Merge branch 'dev' into feature/GRI-2103-device-rollout-status
All checks were successful
CI / the pre-push hook (pull_request) Successful in 7s
CI / install.sh client upgrade (pull_request) Successful in 11s
CI / cargo fmt (pull_request) Successful in 7s
CI / cargo deny (pull_request) Successful in 20s
CI / cargo deny advisories (pull_request) Successful in 20s
CI / cargo clippy (pull_request) Successful in 1m33s
CI / repository boundary (pull_request) Successful in 5s
CI / frontend-web (pull_request) Successful in 1m0s
CI / cargo test (pull_request) Successful in 2m52s
CI / CI (pull_request) Successful in 1s
CI / Notify gate failed (pull_request) Has been skipped
ccbd8a0ea0
Merge pull request 'GRI-2103: Devices screen shows playlist rollout status, live (#228)' (#257) from feature/GRI-2103-device-rollout-status into dev
All checks were successful
CI / the pre-push hook (push) Successful in 4s
CI / cargo fmt (push) Successful in 3s
CI / install.sh client upgrade (push) Successful in 9s
CI / cargo deny (push) Successful in 13s
CI / cargo deny advisories (push) Successful in 23s
CI / repository boundary (push) Successful in 5s
CI / the pre-push hook (pull_request) Successful in 5s
CI / install.sh client upgrade (pull_request) Successful in 11s
CI / cargo fmt (pull_request) Successful in 5s
CI / cargo clippy (push) Successful in 1m16s
CI / frontend-web (push) Successful in 1m10s
CI / cargo deny (pull_request) Successful in 21s
CI / cargo deny advisories (pull_request) Successful in 26s
CI / cargo clippy (pull_request) Successful in 1m31s
CI / repository boundary (pull_request) Successful in 4s
CI / cargo test (push) Successful in 3m10s
CI / frontend-web (pull_request) Successful in 1m0s
CI / cargo test (pull_request) Successful in 3m27s
CI / Notify gate failed (push) Has been skipped
CI / CI (push) Successful in 2s
CI / CI (pull_request) Successful in 1s
CI / Notify gate failed (pull_request) Has been skipped
dd9b970a13
GRI-2105: Users > Edit can set a new password, typed twice
All checks were successful
CI / the pre-push hook (pull_request) Successful in 5s
CI / install.sh client upgrade (pull_request) Successful in 9s
CI / cargo fmt (pull_request) Successful in 6s
CI / cargo deny (pull_request) Successful in 20s
CI / cargo deny advisories (pull_request) Successful in 25s
CI / cargo clippy (pull_request) Successful in 1m37s
CI / repository boundary (pull_request) Successful in 5s
CI / frontend-web (pull_request) Successful in 1m9s
CI / cargo test (pull_request) Successful in 3m54s
CI / CI (pull_request) Successful in 2s
CI / Notify gate failed (pull_request) Has been skipped
9fc4978732
Merge branch 'dev' into feature/GRI-2105-set-password-ui
All checks were successful
CI / the pre-push hook (pull_request) Successful in 5s
CI / install.sh client upgrade (pull_request) Successful in 9s
CI / cargo fmt (pull_request) Successful in 5s
CI / cargo deny (pull_request) Successful in 20s
CI / cargo deny advisories (pull_request) Successful in 23s
CI / cargo clippy (pull_request) Successful in 1m35s
CI / repository boundary (pull_request) Successful in 5s
CI / frontend-web (pull_request) Successful in 1m7s
CI / cargo test (pull_request) Successful in 2m44s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 1s
0a8516c96e
Merge pull request 'GRI-2105: Users > Edit can set a new password (panel half of #226)' (#258) from feature/GRI-2105-set-password-ui into dev
All checks were successful
CI / the pre-push hook (push) Successful in 3s
CI / cargo fmt (push) Successful in 4s
CI / install.sh client upgrade (push) Successful in 8s
CI / cargo deny (push) Successful in 13s
CI / cargo deny advisories (push) Successful in 22s
CI / repository boundary (push) Successful in 4s
CI / cargo clippy (push) Successful in 1m25s
CI / the pre-push hook (pull_request) Successful in 5s
CI / cargo fmt (pull_request) Successful in 4s
CI / install.sh client upgrade (pull_request) Successful in 9s
CI / frontend-web (push) Successful in 1m5s
CI / cargo deny (pull_request) Successful in 21s
CI / cargo deny advisories (pull_request) Successful in 21s
CI / cargo clippy (pull_request) Successful in 1m36s
CI / repository boundary (pull_request) Successful in 5s
CI / cargo test (push) Successful in 3m21s
CI / frontend-web (pull_request) Successful in 1m3s
CI / cargo test (pull_request) Successful in 3m19s
CI / CI (push) Successful in 2s
CI / Notify gate failed (push) Has been skipped
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 1s
e0f6e21174
GRI-2112: hide the mouse pointer when it is not moving
All checks were successful
CI / the pre-push hook (pull_request) Successful in 4s
CI / cargo fmt (pull_request) Successful in 3s
CI / install.sh client upgrade (pull_request) Successful in 8s
CI / cargo deny (pull_request) Successful in 19s
CI / cargo deny advisories (pull_request) Successful in 29s
CI / repository boundary (pull_request) Successful in 6s
CI / cargo clippy (pull_request) Successful in 1m31s
CI / frontend-web (pull_request) Successful in 1m15s
CI / cargo test (pull_request) Successful in 3m59s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 1s
2ae65e51bc
Merge branch 'dev' into fix/GRI-2112-hide-idle-cursor
All checks were successful
CI / the pre-push hook (pull_request) Successful in 3s
CI / cargo fmt (pull_request) Successful in 4s
CI / install.sh client upgrade (pull_request) Successful in 8s
CI / cargo deny (pull_request) Successful in 22s
CI / cargo deny advisories (pull_request) Successful in 21s
CI / repository boundary (pull_request) Successful in 4s
CI / cargo clippy (pull_request) Successful in 1m37s
CI / frontend-web (pull_request) Successful in 1m6s
CI / cargo test (pull_request) Successful in 2m42s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 1s
8e6d761f8c
Merge pull request 'GRI-2112: hide the mouse pointer when it is not moving' (#259) from fix/GRI-2112-hide-idle-cursor into dev
Some checks failed
CI / the pre-push hook (push) Successful in 4s
CI / install.sh client upgrade (push) Successful in 8s
CI / cargo deny (push) Successful in 14s
CI / cargo deny advisories (push) Successful in 20s
CI / repository boundary (push) Successful in 3s
CI / the pre-push hook (pull_request) Successful in 4s
CI / cargo clippy (push) Successful in 1m9s
CI / cargo fmt (pull_request) Successful in 4s
CI / install.sh client upgrade (pull_request) Successful in 9s
CI / frontend-web (push) Successful in 1m2s
CI / cargo deny (pull_request) Successful in 22s
CI / cargo deny advisories (pull_request) Successful in 21s
CI / cargo clippy (pull_request) Successful in 1m32s
CI / repository boundary (pull_request) Successful in 3s
CI / cargo test (push) Successful in 2m57s
CI / frontend-web (pull_request) Successful in 1m5s
CI / cargo test (pull_request) Successful in 3m24s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 2s
CI / cargo fmt (push) Failing after 14m3s
CI / Notify gate failed (push) Has been cancelled
CI / CI (push) Has been cancelled
881596861b
Forge #248 contract: on subscribe, GET /devices/rollout-status/stream
sends one event per visible device with its current state before any
transition; last_seen_at (RFC 3339, nullable) is in GET /devices, set on
WebSocket disconnect and on each heartbeat/message while connected.

Written before the implementation (tonight's routing). Self-contained,
not sharing rollout_status_acceptance_integration.rs's helpers, for the
same reason that file gives: a WebSocket device client and a raw SSE
client neither existing helper set shares, plus a campus-scoped session
that file has no need for.
GRI-2122: rollout-status snapshot on subscribe, last_seen_at per device
Some checks failed
CI / the pre-push hook (pull_request) Successful in 6s
CI / install.sh client upgrade (pull_request) Successful in 15s
CI / cargo fmt (pull_request) Successful in 7s
CI / cargo deny (pull_request) Successful in 21s
CI / cargo deny advisories (pull_request) Successful in 25s
CI / cargo clippy (pull_request) Successful in 1m37s
CI / repository boundary (pull_request) Successful in 5s
CI / frontend-web (pull_request) Successful in 1m12s
CI / cargo test (pull_request) Failing after 2m42s
CI / CI (pull_request) Failing after 1s
CI / Notify gate failed (pull_request) Successful in 1s
39d3d1df60
Forge #248, server half of #228. Implements the decided contract:

- GET /devices/rollout-status/stream sends one event per device the
  caller may see, carrying its current computed status, before the
  live transitions (rollout_status::current_event, devices/handlers.rs
  initial_snapshot_events) -- a fresh subscriber no longer waits for a
  device's next transition, which could be hours away.
- devices.last_seen_at (nullable timestamptz, migration 0009), exposed
  on DeviceView. Set by devices::touch_last_seen on WebSocket disconnect
  and on every heartbeat/message while connected (ws::run_session,
  ws::handle_client_text).

cargo fmt, cargo clippy --all-targets clean. The new acceptance tests
(previous commit) pass; see the board issue for the known collision
this creates with 8 of rollout_status_acceptance_integration.rs's
existing GRI-2009 tests, which encode the old no-snapshot contract and
are not touched here.
Merge remote-tracking branch 'origin/dev' into feature/GRI-2122-rollout-snapshot-last-seen
All checks were successful
CI / the pre-push hook (pull_request) Successful in 9s
CI / cargo fmt (pull_request) Successful in 6s
CI / install.sh client upgrade (pull_request) Successful in 18s
CI / cargo deny (pull_request) Successful in 24s
CI / cargo deny advisories (pull_request) Successful in 25s
CI / cargo clippy (pull_request) Successful in 2m18s
CI / repository boundary (pull_request) Successful in 7s
CI / frontend-web (pull_request) Successful in 1m41s
CI / cargo test (pull_request) Successful in 4m49s
CI / CI (pull_request) Successful in 1s
CI / Notify gate failed (pull_request) Has been skipped
c6ad88e4b1
Merge branch 'dev' into feature/GRI-2122-rollout-snapshot-last-seen
All checks were successful
CI / the pre-push hook (pull_request) Successful in 5s
CI / cargo fmt (pull_request) Successful in 6s
CI / install.sh client upgrade (pull_request) Successful in 10s
CI / cargo deny (pull_request) Successful in 21s
CI / cargo deny advisories (pull_request) Successful in 25s
CI / cargo clippy (pull_request) Successful in 1m29s
CI / repository boundary (pull_request) Successful in 4s
CI / frontend-web (pull_request) Successful in 1m3s
CI / cargo test (pull_request) Successful in 2m47s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 1s
61413efe88
Merge pull request 'GRI-2122: rollout-status snapshot on subscribe, last_seen_at per device' (#260) from feature/GRI-2122-rollout-snapshot-last-seen into dev
All checks were successful
CI / the pre-push hook (push) Successful in 3s
CI / install.sh client upgrade (push) Successful in 7s
CI / cargo fmt (push) Successful in 3s
CI / cargo clippy (push) Successful in 1m27s
CI / cargo deny (push) Successful in 21s
CI / cargo deny advisories (push) Successful in 20s
CI / repository boundary (push) Successful in 5s
CI / the pre-push hook (pull_request) Successful in 5s
CI / frontend-web (push) Successful in 1m14s
CI / install.sh client upgrade (pull_request) Successful in 10s
CI / cargo fmt (pull_request) Successful in 4s
CI / cargo test (push) Successful in 3m43s
CI / cargo deny (pull_request) Successful in 17s
CI / cargo deny advisories (pull_request) Successful in 22s
CI / repository boundary (pull_request) Successful in 6s
CI / cargo clippy (pull_request) Successful in 1m15s
CI / frontend-web (pull_request) Successful in 1m6s
CI / CI (push) Successful in 2s
CI / Notify gate failed (push) Has been skipped
CI / cargo test (pull_request) Successful in 3m12s
CI / CI (pull_request) Successful in 2s
CI / Notify gate failed (pull_request) Has been skipped
f256e2fe10
GRI-2123: force-refresh a device or every connected device on a playlist
All checks were successful
CI / the pre-push hook (pull_request) Successful in 5s
CI / cargo fmt (pull_request) Successful in 5s
CI / install.sh client upgrade (pull_request) Successful in 12s
CI / cargo deny (pull_request) Successful in 21s
CI / cargo deny advisories (pull_request) Successful in 23s
CI / cargo clippy (pull_request) Successful in 1m46s
CI / repository boundary (pull_request) Successful in 6s
CI / frontend-web (pull_request) Successful in 1m29s
CI / cargo test (pull_request) Successful in 4m4s
CI / CI (pull_request) Successful in 2s
CI / Notify gate failed (pull_request) Has been skipped
0896f91943
Merge branch 'dev' into fix/GRI-2123-device-force-refresh
All checks were successful
CI / the pre-push hook (pull_request) Successful in 5s
CI / install.sh client upgrade (pull_request) Successful in 10s
CI / cargo fmt (pull_request) Successful in 5s
CI / cargo deny (pull_request) Successful in 24s
CI / cargo deny advisories (pull_request) Successful in 20s
CI / cargo clippy (pull_request) Successful in 1m30s
CI / repository boundary (pull_request) Successful in 5s
CI / frontend-web (pull_request) Successful in 1m2s
CI / cargo test (pull_request) Successful in 2m49s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 1s
6ec40fb874
Merge pull request 'GRI-2123: force-refresh a device or every connected device on a playlist' (#262) from fix/GRI-2123-device-force-refresh into dev
All checks were successful
CI / the pre-push hook (push) Successful in 5s
CI / cargo fmt (push) Successful in 4s
CI / install.sh client upgrade (push) Successful in 8s
CI / cargo deny (push) Successful in 22s
CI / cargo deny advisories (push) Successful in 22s
CI / repository boundary (push) Successful in 6s
CI / the pre-push hook (pull_request) Successful in 6s
CI / install.sh client upgrade (pull_request) Successful in 13s
CI / cargo fmt (pull_request) Successful in 6s
CI / cargo clippy (push) Successful in 1m29s
CI / frontend-web (push) Successful in 1m13s
CI / cargo deny (pull_request) Successful in 18s
CI / cargo deny advisories (pull_request) Successful in 21s
CI / cargo clippy (pull_request) Successful in 1m21s
CI / repository boundary (pull_request) Successful in 6s
CI / frontend-web (pull_request) Successful in 1m18s
CI / cargo test (push) Successful in 3m38s
CI / CI (push) Successful in 2s
CI / Notify gate failed (push) Has been skipped
CI / cargo test (pull_request) Successful in 3m41s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 1s
33a068698c
GRI-2115: acceptance tests for campus move for media (#242, backend #244)
Some checks failed
CI / the pre-push hook (pull_request) Successful in 8s
CI / cargo fmt (pull_request) Successful in 8s
CI / install.sh client upgrade (pull_request) Successful in 12s
CI / cargo deny (pull_request) Successful in 19s
CI / cargo deny advisories (pull_request) Successful in 15s
CI / repository boundary (pull_request) Successful in 5s
CI / cargo clippy (pull_request) Successful in 1m30s
CI / frontend-web (pull_request) Successful in 1m12s
CI / cargo test (pull_request) Failing after 3m38s
CI / CI (pull_request) Failing after 2s
CI / Notify gate failed (pull_request) Successful in 2s
557ae95ab9
It ran unignored against a real DB in CI (unlike the other 13 tests in
this PR, which carry the standard ignore), so it failed the cargo test
gate on a route that genuinely does not exist yet. The other acceptance
tests in this PR already follow GRI-1977/GRI-1992's pattern: ship
ignored, drop the ignore once the backend engineer implements the route.
Merge origin/dev into test/GRI-2115-campus-move-media-acceptance
Some checks failed
CI / the pre-push hook (pull_request) Successful in 4s
CI / install.sh client upgrade (pull_request) Successful in 10s
CI / cargo fmt (pull_request) Successful in 4s
CI / cargo deny (pull_request) Successful in 22s
CI / cargo deny advisories (pull_request) Successful in 26s
CI / cargo clippy (pull_request) Successful in 1m30s
CI / repository boundary (pull_request) Successful in 3s
CI / cargo test (pull_request) Failing after 1m29s
CI / frontend-web (pull_request) Successful in 1m1s
CI / CI (pull_request) Failing after 1s
CI / Notify gate failed (pull_request) Successful in 2s
b8c58cc319
GRI-2115: merge dev
All checks were successful
CI / the pre-push hook (pull_request) Successful in 4s
CI / install.sh client upgrade (pull_request) Successful in 13s
CI / cargo fmt (pull_request) Successful in 6s
CI / cargo deny (pull_request) Successful in 22s
CI / cargo deny advisories (pull_request) Successful in 27s
CI / cargo clippy (pull_request) Successful in 2m6s
CI / repository boundary (pull_request) Successful in 6s
CI / frontend-web (pull_request) Successful in 1m9s
CI / cargo test (pull_request) Successful in 3m38s
CI / CI (pull_request) Successful in 2s
CI / Notify gate failed (pull_request) Has been skipped
3ea0446062
GRI-2116: PATCH /api/v1/media/{id} to move a media item's campus
All checks were successful
CI / the pre-push hook (pull_request) Successful in 5s
CI / cargo fmt (pull_request) Successful in 5s
CI / install.sh client upgrade (pull_request) Successful in 8s
CI / cargo deny (pull_request) Successful in 22s
CI / cargo deny advisories (pull_request) Successful in 22s
CI / repository boundary (pull_request) Successful in 6s
CI / frontend-web (pull_request) Successful in 1m14s
CI / cargo clippy (pull_request) Successful in 1m44s
CI / cargo test (pull_request) Successful in 3m24s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 2s
fb1d1a3093
Global admin only; moves a whole document as one unit; refuses with
409 media_in_use_by_other_campus unless remove_from_playlists is set,
mirroring delete_media's 409 media_in_use shape (GRI-1962).

Drops the GRI-2115 ignore on the device-push acceptance test now that
the route exists.
GRI-2116: require campus_id on PATCH /media/{id}, run the acceptance tests
All checks were successful
CI / the pre-push hook (pull_request) Successful in 6s
CI / cargo fmt (pull_request) Successful in 6s
CI / install.sh client upgrade (pull_request) Successful in 14s
CI / cargo deny (pull_request) Successful in 25s
CI / cargo deny advisories (pull_request) Successful in 25s
CI / cargo clippy (pull_request) Successful in 2m17s
CI / repository boundary (pull_request) Successful in 8s
CI / frontend-web (pull_request) Successful in 1m34s
CI / cargo test (pull_request) Successful in 5m41s
CI / CI (pull_request) Successful in 3s
CI / Notify gate failed (pull_request) Has been skipped
1cc50b180a
Drop the #[ignore] guard from the 13 acceptance tests so CI runs them
(they already return early without SIGNAGE_TEST_DATABASE_URL set).

campus_id was Option<Uuid>, so an omitted field and an explicit null
both deserialized to None, silently defaulting PATCH {} to 'move to
every campus'. Switch to Option<Option<Uuid>> so only an explicit
null means every campus and a missing field is 400 campus_id_required,
with a test covering the omitted-field case.
Merge branch 'dev' into feature/GRI-2116-media-campus-move
All checks were successful
CI / the pre-push hook (pull_request) Successful in 4s
CI / install.sh client upgrade (pull_request) Successful in 10s
CI / cargo fmt (pull_request) Successful in 6s
CI / cargo deny (pull_request) Successful in 19s
CI / cargo clippy (pull_request) Successful in 1m22s
CI / cargo deny advisories (pull_request) Successful in 20s
CI / repository boundary (pull_request) Successful in 5s
CI / frontend-web (pull_request) Successful in 1m5s
CI / cargo test (pull_request) Successful in 2m45s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 2s
79edb8aea7
Merge pull request 'GRI-2116: PATCH /api/v1/media/{media_id} campus move' (#253) from feature/GRI-2116-media-campus-move into dev
All checks were successful
CI / the pre-push hook (push) Successful in 4s
CI / cargo fmt (push) Successful in 4s
CI / install.sh client upgrade (push) Successful in 7s
CI / cargo deny (push) Successful in 19s
CI / cargo deny advisories (push) Successful in 20s
CI / repository boundary (push) Successful in 5s
CI / the pre-push hook (pull_request) Successful in 5s
CI / install.sh client upgrade (pull_request) Successful in 16s
CI / cargo fmt (pull_request) Successful in 5s
CI / cargo clippy (push) Successful in 1m18s
CI / frontend-web (push) Successful in 1m6s
CI / cargo deny (pull_request) Successful in 31s
CI / cargo deny advisories (pull_request) Successful in 21s
CI / cargo clippy (pull_request) Successful in 1m53s
CI / repository boundary (pull_request) Successful in 5s
CI / frontend-web (pull_request) Successful in 1m13s
CI / cargo test (push) Successful in 3m46s
CI / cargo test (pull_request) Successful in 3m49s
CI / CI (push) Successful in 2s
CI / Notify gate failed (push) Has been skipped
CI / CI (pull_request) Successful in 2s
CI / Notify gate failed (pull_request) Has been skipped
409540ccb4
vivy added 10 commits 2026-11-16 00:16:22 +00:00
GRI-2114: add panel buttons to force-refresh a device or a playlist's devices (#48)
Some checks failed
CI / the pre-push hook (pull_request) Successful in 6s
CI / cargo fmt (pull_request) Successful in 5s
CI / install.sh client upgrade (pull_request) Successful in 13s
CI / cargo deny (pull_request) Successful in 21s
CI / cargo deny advisories (pull_request) Successful in 24s
CI / frontend-web (pull_request) Failing after 1m18s
CI / repository boundary (pull_request) Successful in 6s
CI / cargo clippy (pull_request) Successful in 2m23s
CI / cargo test (pull_request) Successful in 5m49s
CI / CI (pull_request) Failing after 3s
CI / Notify gate failed (pull_request) Successful in 2s
ae6f6a9ca2
GRI-2114: use neutral button style for device/playlist refresh actions
All checks were successful
CI / the pre-push hook (pull_request) Successful in 5s
CI / cargo fmt (pull_request) Successful in 4s
CI / install.sh client upgrade (pull_request) Successful in 8s
CI / cargo deny (pull_request) Successful in 21s
CI / cargo deny advisories (pull_request) Successful in 22s
CI / repository boundary (pull_request) Successful in 5s
CI / cargo clippy (pull_request) Successful in 1m18s
CI / frontend-web (pull_request) Successful in 1m4s
CI / cargo test (pull_request) Successful in 2m30s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 1s
9e36168646
GRI-2114: match device-refresh wire shape to nyssa's server (bool, not id lists)
All checks were successful
CI / the pre-push hook (pull_request) Successful in 4s
CI / install.sh client upgrade (pull_request) Successful in 7s
CI / cargo fmt (pull_request) Successful in 4s
CI / cargo deny (pull_request) Successful in 20s
CI / cargo deny advisories (pull_request) Successful in 18s
CI / cargo clippy (pull_request) Successful in 1m24s
CI / repository boundary (pull_request) Successful in 4s
CI / frontend-web (pull_request) Successful in 1m5s
CI / cargo test (pull_request) Successful in 3m6s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 3s
48762f72b4
GRI-2114: merge origin/dev (rollout status + remove device), resolve import conflict
All checks were successful
CI / the pre-push hook (pull_request) Successful in 4s
CI / cargo fmt (pull_request) Successful in 4s
CI / install.sh client upgrade (pull_request) Successful in 7s
CI / cargo deny advisories (pull_request) Successful in 31s
CI / cargo deny (pull_request) Successful in 51s
CI / repository boundary (pull_request) Successful in 5s
CI / cargo clippy (pull_request) Successful in 1m9s
CI / frontend-web (pull_request) Successful in 1m1s
CI / cargo test (pull_request) Successful in 2m40s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 1s
ddbea8e971
GRI-2114: say what the refresh result actually is, not a queue that doesn't exist
Some checks failed
CI / the pre-push hook (pull_request) Successful in 3s
CI / cargo fmt (pull_request) Successful in 4s
CI / install.sh client upgrade (pull_request) Successful in 7s
CI / frontend-web (pull_request) Has been cancelled
CI / repository boundary (pull_request) Has been cancelled
CI / CI (pull_request) Has been cancelled
CI / Notify gate failed (pull_request) Has been cancelled
CI / cargo test (pull_request) Has been cancelled
CI / cargo clippy (pull_request) Has been cancelled
CI / cargo deny (pull_request) Successful in 13s
CI / cargo deny advisories (pull_request) Successful in 16s
0dd04c6b6d
#262's server keeps no refresh for an offline device, so the panel's
'will refresh when online' notice promised something that never
happens. Say the device/devices were offline and not refreshed instead,
per review feedback on #261 (reviews 496, 500).
Merge remote-tracking branch 'origin/dev' into feature/GRI-2114-panel-force-refresh
All checks were successful
CI / the pre-push hook (pull_request) Successful in 3s
CI / cargo fmt (pull_request) Successful in 3s
CI / install.sh client upgrade (pull_request) Successful in 7s
CI / cargo deny (pull_request) Successful in 13s
CI / cargo deny advisories (pull_request) Successful in 18s
CI / repository boundary (pull_request) Successful in 5s
CI / cargo clippy (pull_request) Successful in 1m14s
CI / frontend-web (pull_request) Successful in 1m9s
CI / cargo test (pull_request) Successful in 2m26s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 1s
9cb17956dc
Merge remote-tracking branch 'origin/dev' into feature/GRI-2114-panel-force-refresh
All checks were successful
CI / the pre-push hook (pull_request) Successful in 3s
CI / install.sh client upgrade (pull_request) Successful in 7s
CI / cargo fmt (pull_request) Successful in 6s
CI / cargo deny (pull_request) Successful in 15s
CI / cargo deny advisories (pull_request) Successful in 20s
CI / cargo clippy (pull_request) Successful in 1m24s
CI / repository boundary (pull_request) Successful in 6s
CI / frontend-web (pull_request) Successful in 1m13s
CI / cargo test (pull_request) Successful in 3m12s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 1s
0fd626811d
Merge pull request 'GRI-2114: panel buttons to force-refresh a device or a playlist (#48)' (#261) from feature/GRI-2114-panel-force-refresh into dev
Some checks failed
CI / the pre-push hook (pull_request) Successful in 5s
CI / install.sh client upgrade (pull_request) Successful in 12s
CI / cargo fmt (pull_request) Successful in 6s
CI / cargo deny (pull_request) Successful in 19s
CI / cargo deny advisories (pull_request) Successful in 22s
CI / cargo clippy (pull_request) Successful in 1m29s
CI / repository boundary (pull_request) Successful in 4s
CI / the pre-push hook (push) Successful in 5s
CI / install.sh client upgrade (push) Successful in 12s
CI / cargo fmt (push) Successful in 5s
CI / frontend-web (pull_request) Successful in 1m10s
CI / cargo deny (push) Successful in 20s
CI / cargo deny advisories (push) Successful in 31s
CI / cargo clippy (push) Successful in 1m27s
CI / repository boundary (push) Successful in 4s
CI / cargo test (pull_request) Successful in 3m30s
CI / frontend-web (push) Successful in 1m4s
CI / cargo test (push) Failing after 2m51s
CI / CI (pull_request) Successful in 1s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (push) Failing after 1s
CI / Notify gate failed (push) Has been skipped
5924008454
vivy added 11 commits 2026-11-16 00:33:01 +00:00
playbin's set_state(Playing) only starts an asynchronous state change: a
missing demuxer plugin or a corrupt stream is reported later, as an Error
message on its bus, well after show() already returned Ok. Nobody read
that bus, so the item was never skipped and gtksink's widget kept showing
the previous item's last frame forever (an MPEG-1 program stream upload,
signage #239).

VideoRenderer::poll_error() drains that bus; the window polls it every
200ms while a video is on screen and, on an error, blanks to the fallback
kind before moving on to the next item, so a second failing video in a row
never has anything stale left to show either.
An uploaded video was stored and served exactly as given, with no check at
all: whatever codec or container it carried, every client had to be able
to decode it. An MPEG-1 program stream (signage #239) needs a demuxer
plugin GStreamer does not install by default, and the client had no way
to tell "cannot decode" from "fine, just not started yet" (fixed
separately, same issue) — so the one upload that should have been
rejected or converted instead went to every screen as-is.

crate::video probes an upload with ffprobe and, unless it is already
H.264 video / AAC-or-silent audio in an MP4 container, transcodes it with
ffmpeg before it is stored — the one thing every client's decoder set is
guaranteed to handle. A file neither tool can read is refused at upload
with its own error text, and nothing is written or recorded for it.

Two of the existing media upload tests now fail on this branch:
ac_3_02_uploading_a_video_stores_the_original_with_its_checksum
(media_acceptance_integration.rs, Astraea) and
an_uploaded_video_is_classified_and_stored (media_integration.rs,
Aetherforge) both upload literal placeholder bytes labelled video/mp4 and
assert they are accepted — exactly the behaviour this change removes.
Flagged to Astraea rather than edited here; see the issue comment.
The server's ffmpeg dependency (pptx_video.rs's slide-image join, and now
crate::video's upload normalisation) was never actually installed by
either the native install path or the Docker image — only poppler-utils
was. gstreamer1.0-plugins-bad carries the MPEG-1/2 program stream demuxer
(mpegpsdemux): the server now normalises new uploads so a client never
needs it for those, but it is the safety net for whatever is already in a
device's cache from before this landed, or a server still running an
older build.
Fixes the blocker nyssa raised on forge #239: two tests (ac_3_02 here and
media_integration's an_uploaded_video_is_classified_and_stored) uploaded
placeholder bytes labelled video/mp4 and asserted they were accepted,
which is exactly the pre-fix leniency the issue removes. Both now upload
a real 1-second 64x64 H.264/AAC MP4 fixture, which stays valid once the
server-side ffprobe/ffmpeg check lands.

Adds an_unreadable_video_upload_is_refused, covering the issue's own
done-when (a file labelled video/* that neither tool can read is
refused, library unchanged). Confirmed it fails first against dev at
30d507f: upload of garbage bytes labelled video/mp4 is accepted 201
instead of refused 400.
Merge remote-tracking branch 'origin/test/GRI-2117-video-upload-fixtures' into fix/GRI-2113-video-skip-on-decode-error
Some checks failed
CI / the pre-push hook (pull_request) Successful in 4s
CI / cargo fmt (pull_request) Successful in 4s
CI / install.sh client upgrade (pull_request) Successful in 7s
CI / cargo deny (pull_request) Successful in 13s
CI / cargo deny advisories (pull_request) Successful in 21s
CI / repository boundary (pull_request) Successful in 6s
CI / cargo clippy (pull_request) Successful in 1m21s
CI / cargo test (pull_request) Failing after 1m26s
CI / frontend-web (pull_request) Successful in 1m11s
CI / CI (pull_request) Failing after 1s
CI / Notify gate failed (pull_request) Successful in 1s
86c15046fe
GRI-2113: merge origin/dev, resolve converter-install conflicts
Some checks failed
CI / the pre-push hook (pull_request) Successful in 5s
CI / cargo fmt (pull_request) Successful in 5s
CI / install.sh client upgrade (pull_request) Successful in 12s
CI / cargo deny (pull_request) Successful in 18s
CI / cargo deny advisories (pull_request) Successful in 23s
CI / repository boundary (pull_request) Successful in 4s
CI / cargo clippy (pull_request) Successful in 1m30s
CI / cargo test (pull_request) Failing after 1m30s
CI / frontend-web (pull_request) Successful in 59s
CI / CI (pull_request) Failing after 2s
CI / Notify gate failed (pull_request) Successful in 2s
d9b4f6875f
dev consolidated the PDF/PPTX converter installs into install_converters()
and a single apt-get list (now including ffmpeg); drop this branch's
separate ffmpeg install in favour of that, in both install.sh and
packaging/server/Dockerfile.
GRI-2113: install ffmpeg in the cargo test CI job
All checks were successful
CI / the pre-push hook (pull_request) Successful in 3s
CI / cargo fmt (pull_request) Successful in 4s
CI / install.sh client upgrade (pull_request) Successful in 9s
CI / cargo deny (pull_request) Successful in 19s
CI / cargo deny advisories (pull_request) Successful in 20s
CI / cargo clippy (pull_request) Successful in 1m17s
CI / repository boundary (pull_request) Successful in 3s
CI / frontend-web (pull_request) Successful in 55s
CI / cargo test (pull_request) Successful in 4m23s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 1s
a8ca60d77f
video.rs's own tests build their fixtures with real ffmpeg/ffprobe and
were failing in CI with 'No such file or directory' — the test job never
installed the one converter GRI-2102 already puts on every server path.
GRI-2113: address review on #252 - odd frame size, 10-bit pixel format, explicit stream map, error-skip flicker, timeout=0, tool-missing status
All checks were successful
CI / the pre-push hook (pull_request) Successful in 3s
CI / cargo fmt (pull_request) Successful in 3s
CI / install.sh client upgrade (pull_request) Successful in 7s
CI / cargo deny (pull_request) Successful in 15s
CI / cargo deny advisories (pull_request) Successful in 17s
CI / cargo clippy (pull_request) Successful in 1m1s
CI / repository boundary (pull_request) Successful in 3s
CI / frontend-web (pull_request) Successful in 50s
CI / cargo test (pull_request) Successful in 4m25s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 2s
ba3e85d47c
Merge remote-tracking branch 'origin/dev' into fix/GRI-2113-video-skip-on-decode-error
All checks were successful
CI / the pre-push hook (pull_request) Successful in 4s
CI / install.sh client upgrade (pull_request) Successful in 7s
CI / cargo fmt (pull_request) Successful in 3s
CI / cargo deny (pull_request) Successful in 16s
CI / cargo deny advisories (pull_request) Successful in 22s
CI / cargo clippy (pull_request) Successful in 1m15s
CI / repository boundary (pull_request) Successful in 3s
CI / frontend-web (pull_request) Successful in 54s
CI / cargo test (pull_request) Successful in 4m26s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 3s
ccd026c0ce
# Conflicts:
#	crates/client/src/bin/grimoirix_signage_client.rs
#	crates/server/tests/ws_integration.rs
Merge branch 'dev' into fix/GRI-2113-video-skip-on-decode-error
All checks were successful
CI / the pre-push hook (pull_request) Successful in 4s
CI / install.sh client upgrade (pull_request) Successful in 9s
CI / cargo fmt (pull_request) Successful in 4s
CI / cargo deny (pull_request) Successful in 19s
CI / cargo deny advisories (pull_request) Successful in 21s
CI / cargo clippy (pull_request) Successful in 1m29s
CI / repository boundary (pull_request) Successful in 3s
CI / frontend-web (pull_request) Successful in 1m3s
CI / cargo test (pull_request) Successful in 3m33s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 1s
c367a9c9ab
Merge pull request 'GRI-2113: skip undecodable video, normalise uploads to H.264/AAC MP4' (#252) from fix/GRI-2113-video-skip-on-decode-error into dev
All checks were successful
CI / the pre-push hook (push) Successful in 3s
CI / cargo fmt (push) Successful in 4s
CI / install.sh client upgrade (push) Successful in 8s
CI / cargo deny (push) Successful in 13s
CI / cargo deny advisories (push) Successful in 25s
CI / repository boundary (push) Successful in 6s
CI / the pre-push hook (pull_request) Successful in 5s
CI / install.sh client upgrade (pull_request) Successful in 12s
CI / cargo fmt (pull_request) Successful in 6s
CI / cargo clippy (push) Successful in 1m27s
CI / frontend-web (push) Successful in 1m10s
CI / cargo deny (pull_request) Successful in 20s
CI / cargo deny advisories (pull_request) Successful in 25s
CI / cargo clippy (pull_request) Successful in 1m39s
CI / repository boundary (pull_request) Successful in 6s
CI / frontend-web (pull_request) Successful in 1m20s
CI / cargo test (push) Successful in 5m47s
CI / CI (push) Successful in 2s
CI / Notify gate failed (push) Has been skipped
CI / cargo test (pull_request) Successful in 5m57s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 2s
732b9858bd
GRI-2111: fix formatting (prettier)
All checks were successful
CI / the pre-push hook (pull_request) Successful in 3s
CI / cargo fmt (pull_request) Successful in 6s
CI / install.sh client upgrade (pull_request) Successful in 10s
CI / cargo deny (pull_request) Successful in 24s
CI / cargo deny advisories (pull_request) Successful in 32s
CI / repository boundary (pull_request) Successful in 6s
CI / cargo clippy (pull_request) Successful in 1m46s
CI / frontend-web (pull_request) Successful in 1m30s
CI / cargo test (pull_request) Successful in 4m54s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 2s
b5bb361b37
GRI-2111: gate campus move on isAdmin, not a null campusId; surface campus-list load errors
All checks were successful
CI / the pre-push hook (pull_request) Successful in 4s
CI / cargo fmt (pull_request) Successful in 6s
CI / install.sh client upgrade (pull_request) Successful in 12s
CI / cargo deny (pull_request) Successful in 24s
CI / cargo deny advisories (pull_request) Successful in 26s
CI / cargo clippy (pull_request) Successful in 2m16s
CI / repository boundary (pull_request) Successful in 7s
CI / frontend-web (pull_request) Successful in 1m36s
CI / cargo test (pull_request) Successful in 5m24s
CI / CI (pull_request) Successful in 3s
CI / Notify gate failed (pull_request) Has been skipped
6fcf85c7f9
Merge branch 'dev' into feature/GRI-2111-media-campus-selector
Some checks failed
CI / the pre-push hook (pull_request) Successful in 5s
CI / install.sh client upgrade (pull_request) Successful in 11s
CI / cargo fmt (pull_request) Successful in 5s
CI / cargo deny (pull_request) Successful in 20s
CI / cargo deny advisories (pull_request) Successful in 21s
CI / cargo clippy (pull_request) Successful in 1m26s
CI / repository boundary (pull_request) Successful in 4s
CI / frontend-web (pull_request) Failing after 33s
CI / cargo test (pull_request) Successful in 2m58s
CI / CI (pull_request) Failing after 2s
CI / Notify gate failed (pull_request) Successful in 2s
21e59a5c7e
GRI-2111: fix GRI-2121 upload tests broken by making MediaScreen's user prop required
All checks were successful
CI / the pre-push hook (pull_request) Successful in 4s
CI / cargo fmt (pull_request) Successful in 5s
CI / install.sh client upgrade (pull_request) Successful in 8s
CI / cargo deny (pull_request) Successful in 15s
CI / cargo deny advisories (pull_request) Successful in 19s
CI / repository boundary (pull_request) Successful in 5s
CI / cargo clippy (pull_request) Successful in 1m16s
CI / frontend-web (pull_request) Successful in 1m8s
CI / cargo test (pull_request) Successful in 3m18s
CI / CI (pull_request) Successful in 2s
CI / Notify gate failed (pull_request) Has been skipped
8034696c3d
Merge branch 'dev' into feature/GRI-2111-media-campus-selector
All checks were successful
CI / the pre-push hook (pull_request) Successful in 6s
CI / install.sh client upgrade (pull_request) Successful in 11s
CI / cargo fmt (pull_request) Successful in 6s
CI / cargo clippy (pull_request) Successful in 1m52s
CI / cargo deny (pull_request) Successful in 20s
CI / cargo deny advisories (pull_request) Successful in 19s
CI / repository boundary (pull_request) Successful in 7s
CI / frontend-web (pull_request) Successful in 1m26s
CI / cargo test (pull_request) Successful in 5m10s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 1s
8dbe66f9b2
Merge pull request 'GRI-2111: panel Campus selector for moving media between campuses (#242)' (#254) from feature/GRI-2111-media-campus-selector into dev
All checks were successful
CI / the pre-push hook (push) Successful in 4s
CI / cargo fmt (push) Successful in 3s
CI / install.sh client upgrade (push) Successful in 7s
CI / cargo deny (push) Successful in 12s
CI / cargo deny advisories (push) Successful in 23s
CI / repository boundary (push) Successful in 5s
CI / the pre-push hook (pull_request) Successful in 3s
CI / install.sh client upgrade (pull_request) Successful in 13s
CI / cargo fmt (pull_request) Successful in 4s
CI / cargo clippy (push) Successful in 1m2s
CI / frontend-web (push) Successful in 1m0s
CI / cargo deny (pull_request) Successful in 17s
CI / cargo deny advisories (pull_request) Successful in 20s
CI / cargo clippy (pull_request) Successful in 1m7s
CI / repository boundary (pull_request) Successful in 4s
CI / frontend-web (pull_request) Successful in 1m13s
CI / cargo test (push) Successful in 4m1s
CI / Notify gate failed (push) Has been skipped
CI / CI (push) Successful in 1s
CI / cargo test (pull_request) Successful in 3m52s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 1s
2e59f39067
Written from the issue's "Done when" before the implementation: a
.pdf/.pptx upload must answer once the file is stored, with a job the
caller polls for progress and failure, instead of blocking the request on
the conversion itself. Supersedes the old inline-conversion tests'
all-or-nothing assumption (AC-3-03, AC-3-06, and the pptx acceptance
suite), which only held while conversion ran inside the upload request.
GRI-2127: background conversion for PDF/PPTX uploads, with job progress
All checks were successful
CI / the pre-push hook (pull_request) Successful in 3s
CI / cargo fmt (pull_request) Successful in 5s
CI / install.sh client upgrade (pull_request) Successful in 8s
CI / cargo deny (pull_request) Successful in 14s
CI / cargo deny advisories (pull_request) Successful in 24s
CI / repository boundary (pull_request) Successful in 3s
CI / cargo clippy (pull_request) Successful in 58s
CI / frontend-web (pull_request) Successful in 1m5s
CI / cargo test (pull_request) Successful in 3m17s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 1s
3c54f7c3e4
An 83-slide PPTX converted inside the upload request could take more
than five minutes, long enough for a browser or server timeout to cut
the upload before it ever got an answer (forge #263, part 2 of #233).

A .pdf/.pptx upload now stores the original and answers immediately with
a placeholder media row and a queued job; conversion runs afterwards in a
spawned task. GET /media/{id}/job reports the job's state (queued /
converting / rendering / encoding / done / failed), page N of M once
known, and the failed step and error text. A .pptx's placeholder is
`kind = "pending"` until the job resolves it to video or document, since
which one it becomes isn't known until the render or its fallback runs.

A failed conversion now leaves the placeholder row and a failed job
rather than refusing the upload with no catalog entry at all (AC-3-06,
and the pptx "both paths missing" case): nothing is waiting on the
upload's answer any more, so there is no longer a clean-refusal moment
to report the failure at.
GRI-2127: fail background conversion jobs left non-terminal by a restart
All checks were successful
CI / the pre-push hook (pull_request) Successful in 5s
CI / cargo fmt (pull_request) Successful in 5s
CI / install.sh client upgrade (pull_request) Successful in 9s
CI / cargo deny (pull_request) Successful in 16s
CI / cargo deny advisories (pull_request) Successful in 15s
CI / repository boundary (pull_request) Successful in 5s
CI / cargo clippy (pull_request) Successful in 1m3s
CI / frontend-web (pull_request) Successful in 57s
CI / cargo test (pull_request) Successful in 3m59s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 1s
89cf8f8e78
A media_jobs row stuck in queued/converting/rendering/encoding by a crash
or redeploy had no task left to finish it, so the panel would poll
GET /media/{id}/job forever. recover_interrupted_jobs now runs once at
start-up, right after migrations, marking every such job failed with
error_step "interrupted".
Merge pull request 'GRI-2127: background conversion for PDF/PPTX uploads, with job progress' (#264) from feature/GRI-2127-background-conversion-progress into dev
All checks were successful
CI / the pre-push hook (push) Successful in 3s
CI / cargo fmt (push) Successful in 3s
CI / install.sh client upgrade (push) Successful in 8s
CI / cargo deny (push) Successful in 13s
CI / cargo deny advisories (push) Successful in 16s
CI / repository boundary (push) Successful in 5s
CI / the pre-push hook (pull_request) Successful in 4s
CI / install.sh client upgrade (pull_request) Successful in 8s
CI / cargo fmt (pull_request) Successful in 5s
CI / cargo clippy (push) Successful in 1m3s
CI / frontend-web (push) Successful in 1m0s
CI / cargo deny (pull_request) Successful in 14s
CI / cargo clippy (pull_request) Successful in 1m2s
CI / cargo deny advisories (pull_request) Successful in 21s
CI / repository boundary (pull_request) Successful in 4s
CI / frontend-web (pull_request) Successful in 1m16s
CI / cargo test (push) Successful in 3m58s
CI / Notify gate failed (push) Has been skipped
CI / CI (push) Successful in 2s
CI / cargo test (pull_request) Successful in 3m57s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 1s
13f1f05c56
GRI-2098: panel conversion progress for PDF/PPTX uploads (#233 part 2)
All checks were successful
CI / the pre-push hook (pull_request) Successful in 4s
CI / cargo fmt (pull_request) Successful in 4s
CI / install.sh client upgrade (pull_request) Successful in 7s
CI / cargo deny (pull_request) Successful in 20s
CI / cargo deny advisories (pull_request) Successful in 20s
CI / cargo clippy (pull_request) Successful in 1m20s
CI / repository boundary (pull_request) Successful in 5s
CI / frontend-web (pull_request) Successful in 1m12s
CI / cargo test (pull_request) Successful in 3m52s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 1s
0b64fd97dc
Merge remote-tracking branch 'origin/dev' into feature/GRI-2098-conversion-progress
All checks were successful
CI / the pre-push hook (pull_request) Successful in 3s
CI / cargo fmt (pull_request) Successful in 3s
CI / install.sh client upgrade (pull_request) Successful in 9s
CI / cargo deny (pull_request) Successful in 13s
CI / cargo deny advisories (pull_request) Successful in 18s
CI / cargo clippy (pull_request) Successful in 1m7s
CI / repository boundary (pull_request) Successful in 3s
CI / frontend-web (pull_request) Successful in 56s
CI / cargo test (pull_request) Successful in 3m29s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 1s
d7c847d439
GRI-2098: slow job poll to product cadence, retry on transient poll error
All checks were successful
CI / the pre-push hook (pull_request) Successful in 3s
CI / cargo fmt (pull_request) Successful in 3s
CI / install.sh client upgrade (pull_request) Successful in 8s
CI / cargo deny (pull_request) Successful in 12s
CI / cargo deny advisories (pull_request) Successful in 19s
CI / cargo clippy (pull_request) Successful in 57s
CI / repository boundary (pull_request) Successful in 3s
CI / frontend-web (pull_request) Successful in 57s
CI / cargo test (pull_request) Successful in 3m25s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 1s
62c646a243
Review on PR #265: the 150ms poll interval was a test artifact leaking
into the product, and a non-404 getMediaJob failure (network blip, 5xx)
stopped polling for good instead of retrying. Poll interval now defaults
to 1500ms, with a test-only override in mediaJobPoll.ts so MediaScreen.tsx
keeps exporting only its component.
Merge pull request 'GRI-2098: panel conversion progress for PDF/PPTX uploads (#233 part 2)' (#265) from feature/GRI-2098-conversion-progress into dev
All checks were successful
CI / the pre-push hook (push) Successful in 4s
CI / cargo fmt (push) Successful in 4s
CI / install.sh client upgrade (push) Successful in 7s
CI / cargo deny advisories (push) Successful in 15s
CI / cargo deny (push) Successful in 18s
CI / repository boundary (push) Successful in 4s
CI / the pre-push hook (pull_request) Successful in 5s
CI / install.sh client upgrade (pull_request) Successful in 7s
CI / cargo fmt (pull_request) Successful in 3s
CI / cargo clippy (push) Successful in 1m0s
CI / frontend-web (push) Successful in 1m5s
CI / cargo clippy (pull_request) Successful in 1m5s
CI / cargo deny (pull_request) Successful in 23s
CI / cargo deny advisories (pull_request) Successful in 18s
CI / repository boundary (pull_request) Successful in 4s
CI / frontend-web (pull_request) Successful in 1m16s
CI / cargo test (push) Successful in 3m59s
CI / Notify gate failed (push) Has been skipped
CI / CI (push) Successful in 2s
CI / cargo test (pull_request) Successful in 3m58s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 1s
297bed8c5d
GRI-2130: upgrade client restarts the player in the user's systemd manager (signage #266)
All checks were successful
CI / the pre-push hook (pull_request) Successful in 4s
CI / cargo fmt (pull_request) Successful in 4s
CI / install.sh client upgrade (pull_request) Successful in 12s
CI / cargo deny (pull_request) Successful in 13s
CI / cargo deny advisories (pull_request) Successful in 24s
CI / repository boundary (pull_request) Successful in 3s
CI / cargo clippy (pull_request) Successful in 1m2s
CI / frontend-web (pull_request) Successful in 1m3s
CI / cargo test (pull_request) Successful in 3m31s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 1s
a82f9bab25
The restart ran setsid -f, which leaves the player in the installer's
cgroup; when install.sh ran as a systemd unit, systemd stopped that cgroup
as the unit ended and the new player died seconds after being reported
running. It is now started as a transient unit of the desktop user's own
manager (systemd-run --user --machine=<user>@.host --collect), with setsid
kept only where no manager answers. The count is taken after a settle
time, and a player sharing a service cgroup with the installer is reported
as not running. install-client-unit-test.sh measures it on a real user
manager.
Merge pull request 'GRI-2130: upgrade client restarts the player in the user's systemd manager (#266)' (#267) from fix/GRI-2130-upgrade-client-cgroup into dev
Some checks failed
CI / CI (push) Has been cancelled
CI / Notify gate failed (push) Has been cancelled
CI / cargo fmt (push) Successful in 4s
CI / install.sh client upgrade (push) Successful in 13s
CI / cargo deny (push) Successful in 18s
CI / cargo deny advisories (push) Successful in 16s
CI / repository boundary (push) Successful in 3s
CI / the pre-push hook (pull_request) Successful in 2s
CI / cargo clippy (push) Successful in 1m4s
CI / cargo fmt (pull_request) Successful in 4s
CI / install.sh client upgrade (pull_request) Successful in 12s
CI / frontend-web (push) Successful in 1m8s
CI / cargo deny (pull_request) Successful in 17s
CI / cargo clippy (pull_request) Successful in 1m18s
CI / cargo deny advisories (pull_request) Successful in 25s
CI / repository boundary (pull_request) Successful in 5s
CI / frontend-web (pull_request) Successful in 1m19s
CI / cargo test (push) Successful in 4m11s
CI / cargo test (pull_request) Successful in 4m9s
CI / CI (pull_request) Successful in 1s
CI / Notify gate failed (pull_request) Has been skipped
CI / the pre-push hook (push) Failing after 12m34s
0605eb0fcc
GRI-2138: fix approved/pending device card alignment
Some checks failed
CI / the pre-push hook (pull_request) Successful in 3s
CI / cargo fmt (pull_request) Successful in 4s
CI / install.sh client upgrade (pull_request) Successful in 12s
CI / cargo clippy (pull_request) Successful in 57s
CI / cargo deny advisories (pull_request) Successful in 19s
CI / repository boundary (pull_request) Successful in 4s
CI / cargo deny (pull_request) Successful in 24s
CI / frontend-web (pull_request) Successful in 1m3s
CI / cargo test (pull_request) Failing after 2m10s
CI / CI (pull_request) Failing after 1s
CI / Notify gate failed (pull_request) Successful in 0s
1f43187b0a
Restructure ApprovedDeviceRow into a fixed three-line card: facts
(name + tags), settings (campus), and one gx-actions row for
Unassign playlist / Refresh / Block. Move the refresh notice/error
below the action row. Pending device rows share the same action row.
GRI-2138: re-run CI (cargo test flake unrelated to this frontend-only change)
All checks were successful
CI / the pre-push hook (pull_request) Successful in 4s
CI / install.sh client upgrade (pull_request) Successful in 19s
CI / cargo fmt (pull_request) Successful in 6s
CI / cargo clippy (pull_request) Successful in 1m26s
CI / cargo deny (pull_request) Successful in 20s
CI / cargo deny advisories (pull_request) Successful in 18s
CI / repository boundary (pull_request) Successful in 4s
CI / frontend-web (pull_request) Successful in 1m12s
CI / cargo test (pull_request) Successful in 3m39s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 1s
d6881d25ba
Merge pull request 'GRI-2138: fix approved/pending device card alignment' (#271) from fix/GRI-2138-approved-device-card-alignment into dev
All checks were successful
CI / the pre-push hook (push) Successful in 5s
CI / cargo fmt (push) Successful in 5s
CI / install.sh client upgrade (push) Successful in 15s
CI / cargo deny (push) Successful in 16s
CI / cargo deny advisories (push) Successful in 24s
CI / repository boundary (push) Successful in 6s
CI / the pre-push hook (pull_request) Successful in 5s
CI / install.sh client upgrade (pull_request) Successful in 16s
CI / cargo fmt (pull_request) Successful in 6s
CI / cargo clippy (push) Successful in 1m27s
CI / frontend-web (push) Successful in 1m14s
CI / cargo deny (pull_request) Successful in 21s
CI / cargo deny advisories (pull_request) Successful in 21s
CI / cargo clippy (pull_request) Successful in 1m14s
CI / repository boundary (pull_request) Successful in 4s
CI / frontend-web (pull_request) Successful in 1m18s
CI / cargo test (push) Successful in 4m25s
CI / cargo test (pull_request) Successful in 4m45s
CI / CI (push) Successful in 1s
CI / Notify gate failed (push) Has been skipped
CI / CI (pull_request) Successful in 2s
CI / Notify gate failed (pull_request) Has been skipped
1e8d09c2c5
GRI-2139: split the Settings Network / IP rules tab into two entries
All checks were successful
CI / the pre-push hook (pull_request) Successful in 5s
CI / cargo fmt (pull_request) Successful in 4s
CI / install.sh client upgrade (pull_request) Successful in 12s
CI / cargo deny advisories (pull_request) Successful in 13s
CI / cargo deny (pull_request) Successful in 19s
CI / repository boundary (pull_request) Successful in 5s
CI / cargo clippy (pull_request) Successful in 1m3s
CI / frontend-web (pull_request) Successful in 1m6s
CI / cargo test (pull_request) Successful in 4m20s
CI / CI (pull_request) Successful in 2s
CI / Notify gate failed (pull_request) Has been skipped
f71486e6aa
Network stays global settings_manage only, at /settings/network.
IP rules gets its own entry and URL, /settings/ip-rules, for any
devices_approve holder, global or campus-scoped. The old merged
/settings/network link and the legacy /ip-rules bookmark both fall
back correctly for a user who only has one of the two permissions.
Merge remote-tracking branch 'origin/dev' into feature/GRI-2139-settings-network-ip-rules-split
All checks were successful
CI / the pre-push hook (pull_request) Successful in 5s
CI / install.sh client upgrade (pull_request) Successful in 15s
CI / cargo fmt (pull_request) Successful in 5s
CI / cargo clippy (pull_request) Successful in 1m36s
CI / cargo deny (pull_request) Successful in 21s
CI / cargo deny advisories (pull_request) Successful in 20s
CI / repository boundary (pull_request) Successful in 4s
CI / frontend-web (pull_request) Successful in 1m17s
CI / cargo test (pull_request) Successful in 4m45s
CI / CI (pull_request) Successful in 1s
CI / Notify gate failed (pull_request) Has been skipped
60356a5db3
Merge pull request 'GRI-2139: split Network and IP rules into two Settings menu entries' (#273) from feature/GRI-2139-settings-network-ip-rules-split into dev
Some checks failed
CI / the pre-push hook (push) Successful in 3s
CI / cargo fmt (push) Successful in 4s
CI / install.sh client upgrade (push) Successful in 12s
CI / cargo deny (push) Successful in 18s
CI / cargo deny advisories (push) Successful in 29s
CI / repository boundary (push) Successful in 3s
CI / the pre-push hook (pull_request) Successful in 4s
CI / install.sh client upgrade (pull_request) Successful in 12s
CI / cargo clippy (push) Successful in 1m6s
CI / frontend-web (push) Successful in 1m9s
CI / cargo deny (pull_request) Successful in 19s
CI / cargo clippy (pull_request) Successful in 1m17s
CI / cargo deny advisories (pull_request) Successful in 27s
CI / repository boundary (pull_request) Successful in 5s
CI / frontend-web (pull_request) Successful in 1m20s
CI / cargo test (push) Successful in 4m23s
CI / CI (push) Successful in 3s
CI / Notify gate failed (push) Has been skipped
CI / cargo test (pull_request) Successful in 4m13s
CI / cargo fmt (pull_request) Failing after 14m35s
CI / CI (pull_request) Has been cancelled
CI / Notify gate failed (pull_request) Has been cancelled
12701a975b
GRI-2140: split Media into Add media (default) and Media library
Some checks failed
CI / cargo fmt (pull_request) Has started running
CI / the pre-push hook (pull_request) Successful in 4s
CI / install.sh client upgrade (pull_request) Successful in 12s
CI / cargo deny (pull_request) Successful in 16s
CI / cargo deny advisories (pull_request) Successful in 15s
CI / cargo clippy (pull_request) Successful in 57s
CI / repository boundary (pull_request) Successful in 3s
CI / frontend-web (pull_request) Successful in 54s
CI / cargo test (pull_request) Failing after 1m58s
CI / CI (pull_request) Has been cancelled
CI / Notify gate failed (pull_request) Has been cancelled
e6bea32a55
Add media (/media) now owns upload and Add website, each success
staying on the page and linking to the library instead of jumping
away. Media library (/media/library) owns the list: documents and
pages, campus move, expand, delete. Both get the same left sub-menu
as Settings and Playlists (#210); a user with no content_upload
permission sees only Media library, with /media falling back to it.
GRI-2140: retrigger CI (flaky cargo test unrelated to this frontend-only change)
All checks were successful
CI / the pre-push hook (pull_request) Successful in 4s
CI / install.sh client upgrade (pull_request) Successful in 14s
CI / cargo fmt (pull_request) Successful in 4s
CI / cargo deny (pull_request) Successful in 27s
CI / cargo deny advisories (pull_request) Successful in 24s
CI / cargo clippy (pull_request) Successful in 1m23s
CI / repository boundary (pull_request) Successful in 5s
CI / frontend-web (pull_request) Successful in 1m17s
CI / cargo test (pull_request) Successful in 4m25s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 1s
d1f6cdeb8a
GRI-2140: Add media's Recently added row shows failed reason and page progress
All checks were successful
CI / the pre-push hook (pull_request) Successful in 5s
CI / install.sh client upgrade (pull_request) Successful in 13s
CI / cargo fmt (pull_request) Successful in 5s
CI / cargo deny (pull_request) Successful in 38s
CI / cargo clippy (pull_request) Successful in 1m42s
CI / cargo deny advisories (pull_request) Successful in 44s
CI / repository boundary (pull_request) Successful in 5s
CI / frontend-web (pull_request) Successful in 1m11s
CI / cargo test (pull_request) Successful in 4m16s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 1s
e6b7cc6c0a
Review on PR #272 (forge #268): the row only showed a plain job-step
label, so a failed conversion and a page-by-page render looked the same
as every other in-progress state. Match MediaLibraryScreen's treatment —
role=alert with the failure reason, and Page N of M rendered with a
progress bar once the job reports a page count.
Merge branch 'dev' into feature/GRI-2140-media-add-library-split
All checks were successful
CI / the pre-push hook (pull_request) Successful in 5s
CI / install.sh client upgrade (pull_request) Successful in 16s
CI / cargo fmt (pull_request) Successful in 7s
CI / cargo deny (pull_request) Successful in 28s
CI / cargo clippy (pull_request) Successful in 1m35s
CI / cargo deny advisories (pull_request) Successful in 24s
CI / repository boundary (pull_request) Successful in 3s
CI / frontend-web (pull_request) Successful in 1m5s
CI / cargo test (pull_request) Successful in 4m16s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 1s
6acfb0e082
Merge pull request 'GRI-2140: split Media into Add media (default) and Media library' (#272) from feature/GRI-2140-media-add-library-split into dev
All checks were successful
CI / the pre-push hook (push) Successful in 3s
CI / install.sh client upgrade (push) Successful in 14s
CI / cargo fmt (push) Successful in 5s
CI / cargo deny (push) Successful in 22s
CI / cargo clippy (push) Successful in 1m5s
CI / cargo deny advisories (push) Successful in 33s
CI / repository boundary (push) Successful in 4s
CI / the pre-push hook (pull_request) Successful in 5s
CI / install.sh client upgrade (pull_request) Successful in 18s
CI / cargo fmt (pull_request) Successful in 6s
CI / frontend-web (push) Successful in 1m21s
CI / cargo deny (pull_request) Successful in 19s
CI / cargo clippy (pull_request) Successful in 1m21s
CI / cargo deny advisories (pull_request) Successful in 24s
CI / repository boundary (pull_request) Successful in 4s
CI / cargo test (push) Successful in 4m44s
CI / Notify gate failed (push) Has been skipped
CI / CI (push) Successful in 2s
CI / frontend-web (pull_request) Successful in 1m29s
CI / cargo test (pull_request) Successful in 3m58s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 2s
4353d22e12
GRI-2143: add a panel-wide notification stack for action results
All checks were successful
CI / the pre-push hook (pull_request) Successful in 4s
CI / cargo fmt (pull_request) Successful in 3s
CI / install.sh client upgrade (pull_request) Successful in 13s
CI / cargo deny (pull_request) Successful in 44s
CI / cargo deny advisories (pull_request) Successful in 38s
CI / repository boundary (pull_request) Successful in 4s
CI / cargo clippy (pull_request) Successful in 1m8s
CI / frontend-web (pull_request) Successful in 1m2s
CI / cargo test (pull_request) Successful in 4m29s
CI / CI (pull_request) Successful in 2s
CI / Notify gate failed (pull_request) Has been skipped
0f1d15a89f
One stack, top right, reports the result of every write the panel makes —
success, error and info — instead of each screen rolling its own inline
notice/error state. Newest at the bottom; a dismissed entry fades and
collapses so the ones below animate up into its place. Errors follow #236's
rule (closable, auto-dismiss paused while the pointer is on it); success and
info auto-dismiss sooner. Reuses it for devices, media, campuses and
playlists in place of their own DismissibleError/notice state.
Merge remote-tracking branch 'origin/dev' into feature/GRI-2143-notification-stack
All checks were successful
CI / the pre-push hook (pull_request) Successful in 4s
CI / cargo fmt (pull_request) Successful in 4s
CI / install.sh client upgrade (pull_request) Successful in 12s
CI / cargo deny (pull_request) Successful in 19s
CI / cargo deny advisories (pull_request) Successful in 19s
CI / cargo clippy (pull_request) Successful in 1m8s
CI / repository boundary (pull_request) Successful in 4s
CI / frontend-web (pull_request) Successful in 57s
CI / cargo test (pull_request) Successful in 3m35s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 1s
c3b913e69e
# Conflicts:
#	frontend-web/src/screens/MediaLibraryScreen.test.tsx
#	frontend-web/src/screens/MediaLibraryScreen.tsx
#	frontend-web/src/screens/settings/SettingsSectionScreen.test.tsx
Merge pull request 'GRI-2143: add a panel-wide notification stack for action results' (#280) from feature/GRI-2143-notification-stack into dev
All checks were successful
CI / the pre-push hook (push) Successful in 4s
CI / cargo fmt (push) Successful in 6s
CI / install.sh client upgrade (push) Successful in 14s
CI / cargo deny advisories (push) Successful in 22s
CI / cargo deny (push) Successful in 25s
CI / repository boundary (push) Successful in 4s
CI / the pre-push hook (pull_request) Successful in 5s
CI / install.sh client upgrade (pull_request) Successful in 16s
CI / cargo clippy (push) Successful in 1m10s
CI / cargo fmt (pull_request) Successful in 4s
CI / frontend-web (push) Successful in 1m6s
CI / cargo deny (pull_request) Successful in 20s
CI / cargo clippy (pull_request) Successful in 1m16s
CI / cargo deny advisories (pull_request) Successful in 23s
CI / repository boundary (pull_request) Successful in 4s
CI / frontend-web (pull_request) Successful in 1m27s
CI / cargo test (push) Successful in 4m39s
CI / cargo test (pull_request) Successful in 4m28s
CI / CI (push) Successful in 1s
CI / Notify gate failed (push) Has been skipped
CI / CI (pull_request) Successful in 1s
CI / Notify gate failed (pull_request) Has been skipped
40cb6aa590
GRI-2142: wire rust-i18n and a locale preference contract
All checks were successful
CI / the pre-push hook (pull_request) Successful in 4s
CI / install.sh client upgrade (pull_request) Successful in 18s
CI / cargo fmt (pull_request) Successful in 6s
CI / cargo deny (pull_request) Successful in 19s
CI / cargo clippy (pull_request) Successful in 1m25s
CI / cargo deny advisories (pull_request) Successful in 31s
CI / repository boundary (pull_request) Successful in 4s
CI / frontend-web (pull_request) Successful in 1m26s
CI / cargo test (pull_request) Successful in 4m58s
CI / CI (pull_request) Successful in 1s
CI / Notify gate failed (pull_request) Has been skipped
4ed1a0012f
Bundles land in crates/shared/locales/{en,nl}.yml, loaded via rust_i18n::i18n!
in shared and server (t! always expands to crate::_rust_i18n_t!, so each
crate that translates needs its own invocation). crates/shared/build.rs
enforces the source-first, missing-translation-warns and stale-key rules on
every build, reusing rust-i18n's own bundle loader; the source scan for a
used-but-untranslated key is hand-rolled rather than rust-i18n-extract, whose
Cargo.toml drags in the unmaintained unsafe-libyaml via serde_yaml.

UserView gains a resolved locale field (the user's own preference, or
config.i18n.default_locale for one who never set it), returned by
/setup, /session and settable with PATCH /session/locale.
Merge branch 'dev' into feature/GRI-2142-i18n-locale-contract
All checks were successful
CI / the pre-push hook (pull_request) Successful in 4s
CI / install.sh client upgrade (pull_request) Successful in 16s
CI / cargo fmt (pull_request) Successful in 6s
CI / cargo clippy (pull_request) Successful in 1m38s
CI / cargo deny (pull_request) Successful in 21s
CI / cargo deny advisories (pull_request) Successful in 21s
CI / repository boundary (pull_request) Successful in 4s
CI / frontend-web (pull_request) Successful in 1m3s
CI / cargo test (pull_request) Successful in 4m18s
CI / CI (pull_request) Successful in 3s
CI / Notify gate failed (pull_request) Has been skipped
19b8e09b4d
Merge pull request 'GRI-2142: wire rust-i18n locale preference contract for panel i18n' (#276) from feature/GRI-2142-i18n-locale-contract into dev
All checks were successful
CI / the pre-push hook (push) Successful in 5s
CI / cargo fmt (push) Successful in 4s
CI / install.sh client upgrade (push) Successful in 12s
CI / cargo deny advisories (push) Successful in 17s
CI / the pre-push hook (pull_request) Successful in 2s
CI / cargo deny (push) Successful in 15s
CI / repository boundary (push) Successful in 4s
CI / install.sh client upgrade (pull_request) Successful in 13s
CI / cargo fmt (pull_request) Successful in 3s
CI / cargo clippy (push) Successful in 1m5s
CI / frontend-web (push) Successful in 1m0s
CI / cargo deny (pull_request) Successful in 19s
CI / cargo deny advisories (pull_request) Successful in 21s
CI / cargo clippy (pull_request) Successful in 1m17s
CI / repository boundary (pull_request) Successful in 3s
CI / frontend-web (pull_request) Successful in 1m8s
CI / cargo test (push) Successful in 4m39s
CI / CI (push) Successful in 2s
CI / Notify gate failed (push) Has been skipped
CI / cargo test (pull_request) Successful in 4m42s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 1s
d54ea3268f
GRI-2143: move IP rules, users, playlist Save and playback default onto the notification stack
All checks were successful
CI / the pre-push hook (pull_request) Successful in 4s
CI / cargo fmt (pull_request) Successful in 4s
CI / install.sh client upgrade (pull_request) Successful in 13s
CI / cargo deny (pull_request) Successful in 21s
CI / cargo deny advisories (pull_request) Successful in 17s
CI / cargo clippy (pull_request) Successful in 1m6s
CI / repository boundary (pull_request) Successful in 4s
CI / frontend-web (pull_request) Successful in 56s
CI / cargo test (pull_request) Successful in 3m36s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 3s
c8f21bedc3
Delete and edit/password-set on UsersScreen, Save on PlaylistMediaTab
and PlaybackSettingsTab, and remove on IpRulesScreen now report through
the panel-wide notification stack (#279) instead of a local inline
error/notice, matching the pattern already used for devices and media.
Create-new-item forms (add user, add IP rule) keep their inline,
closable error next to the field, matching the existing convention for
that case elsewhere in the panel.

NetworkSettingsTab is left as is: its Save and its multi-step restart
share one inline status/error pair by design, and splitting the first
into a toast risks two simultaneous status announcements once a
restart follows closely behind a save.
Merge branch 'dev' into feature/GRI-2143-notification-stack-part2
All checks were successful
CI / the pre-push hook (pull_request) Successful in 3s
CI / install.sh client upgrade (pull_request) Successful in 16s
CI / cargo fmt (pull_request) Successful in 5s
CI / cargo clippy (pull_request) Successful in 1m33s
CI / cargo deny (pull_request) Successful in 18s
CI / cargo deny advisories (pull_request) Successful in 23s
CI / repository boundary (pull_request) Successful in 5s
CI / frontend-web (pull_request) Successful in 1m10s
CI / cargo test (pull_request) Successful in 3m53s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 1s
1d94ba24b0
Merge pull request 'GRI-2143: notification stack — IP rules, users, playlist save, playback default' (#282) from feature/GRI-2143-notification-stack-part2 into dev
Some checks failed
CI / CI (push) Has been cancelled
CI / Notify gate failed (push) Has been cancelled
CI / cargo fmt (push) Successful in 4s
CI / install.sh client upgrade (push) Successful in 14s
CI / cargo deny (push) Successful in 21s
CI / cargo deny advisories (push) Successful in 19s
CI / repository boundary (push) Successful in 3s
CI / cargo clippy (push) Successful in 1m3s
CI / the pre-push hook (pull_request) Successful in 5s
CI / cargo fmt (pull_request) Successful in 9s
CI / install.sh client upgrade (pull_request) Successful in 13s
CI / frontend-web (push) Successful in 1m18s
CI / cargo deny (pull_request) Successful in 25s
CI / cargo clippy (pull_request) Successful in 1m24s
CI / cargo deny advisories (pull_request) Successful in 19s
CI / repository boundary (pull_request) Successful in 5s
CI / frontend-web (pull_request) Successful in 1m21s
CI / cargo test (push) Successful in 4m34s
CI / cargo test (pull_request) Successful in 4m14s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 1s
CI / the pre-push hook (push) Failing after 11m12s
d640444830
GRI-2143: move NetworkSettingsTab Save onto the notification stack
All checks were successful
CI / the pre-push hook (pull_request) Successful in 4s
CI / cargo fmt (pull_request) Successful in 3s
CI / install.sh client upgrade (pull_request) Successful in 12s
CI / cargo deny (pull_request) Successful in 13s
CI / cargo deny advisories (pull_request) Successful in 19s
CI / cargo clippy (pull_request) Successful in 1m0s
CI / repository boundary (pull_request) Successful in 3s
CI / frontend-web (pull_request) Successful in 56s
CI / cargo test (pull_request) Successful in 3m25s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 1s
aa33cb8deb
Restart keeps its own status/error element, separate from the stack: a
multi-step flow that a toast's auto-dismiss could misreport as finished
while a later step is still running.
Merge pull request 'GRI-2143: move NetworkSettingsTab Save onto the notification stack' (#283) from feature/GRI-2143-notification-stack-part3 into dev
All checks were successful
CI / the pre-push hook (push) Successful in 5s
CI / cargo fmt (push) Successful in 3s
CI / install.sh client upgrade (push) Successful in 12s
CI / cargo deny (push) Successful in 26s
CI / cargo deny advisories (push) Successful in 33s
CI / repository boundary (push) Successful in 3s
CI / the pre-push hook (pull_request) Successful in 3s
CI / install.sh client upgrade (pull_request) Successful in 12s
CI / cargo fmt (pull_request) Successful in 5s
CI / cargo clippy (push) Successful in 1m23s
CI / frontend-web (push) Successful in 58s
CI / cargo deny (pull_request) Successful in 22s
CI / cargo deny advisories (pull_request) Successful in 27s
CI / cargo clippy (pull_request) Successful in 1m27s
CI / repository boundary (pull_request) Successful in 4s
CI / frontend-web (pull_request) Successful in 1m10s
CI / cargo test (push) Successful in 4m12s
CI / Notify gate failed (push) Has been skipped
CI / CI (push) Successful in 1s
CI / cargo test (pull_request) Successful in 4m15s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 1s
a61eed0849
GRI-2149: stop resetting the reconnect backoff on a pending hello
All checks were successful
CI / the pre-push hook (pull_request) Successful in 3s
CI / cargo fmt (pull_request) Successful in 3s
CI / install.sh client upgrade (pull_request) Successful in 13s
CI / cargo deny (pull_request) Successful in 12s
CI / cargo deny advisories (pull_request) Successful in 22s
CI / repository boundary (pull_request) Successful in 5s
CI / cargo clippy (pull_request) Successful in 1m9s
CI / frontend-web (pull_request) Successful in 1m2s
CI / cargo test (pull_request) Successful in 3m40s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 2s
89e66a67c2
Session now tracks admitted (accepted) separately from merely getting
past the hello handshake. Sync::connect_once reads it instead of
hard-coding admitted: true, so a device waiting for approval keeps
backing off between reconnects instead of resetting to ~1s every time.
Merge pull request 'GRI-2149: stop resetting the reconnect backoff on a pending hello' (#286) from fix/GRI-2149-backoff-reset-on-pending into dev
All checks were successful
CI / the pre-push hook (push) Successful in 5s
CI / cargo fmt (push) Successful in 4s
CI / install.sh client upgrade (push) Successful in 13s
CI / cargo deny (push) Successful in 12s
CI / cargo deny advisories (push) Successful in 18s
CI / repository boundary (push) Successful in 4s
CI / the pre-push hook (pull_request) Successful in 2s
CI / install.sh client upgrade (pull_request) Successful in 13s
CI / cargo fmt (pull_request) Successful in 3s
CI / cargo clippy (push) Successful in 1m5s
CI / frontend-web (push) Successful in 59s
CI / cargo deny (pull_request) Successful in 19s
CI / cargo deny advisories (pull_request) Successful in 20s
CI / cargo clippy (pull_request) Successful in 1m15s
CI / repository boundary (pull_request) Successful in 3s
CI / frontend-web (pull_request) Successful in 1m8s
CI / cargo test (push) Successful in 4m28s
CI / cargo test (pull_request) Successful in 4m45s
CI / CI (pull_request) Successful in 2s
CI / CI (push) Successful in 2s
CI / Notify gate failed (push) Has been skipped
CI / Notify gate failed (pull_request) Has been skipped
538f477e1e
GRI-2150: create the client data directory before first write
All checks were successful
CI / the pre-push hook (pull_request) Successful in 3s
CI / cargo fmt (pull_request) Successful in 4s
CI / install.sh client upgrade (pull_request) Successful in 13s
CI / cargo deny (pull_request) Successful in 14s
CI / cargo deny advisories (pull_request) Successful in 19s
CI / repository boundary (pull_request) Successful in 5s
CI / cargo clippy (pull_request) Successful in 1m12s
CI / frontend-web (pull_request) Successful in 1m2s
CI / cargo test (pull_request) Successful in 3m20s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 2s
281aede9f3
On a fresh install, Store::open never created the data directory itself,
only client.db inside it. The first write (a temporary file + rename)
then failed with ENOENT, and the device never reached the server.
Merge branch 'dev' into fix/GRI-2150-client-data-dir
All checks were successful
CI / the pre-push hook (pull_request) Successful in 3s
CI / install.sh client upgrade (pull_request) Successful in 15s
CI / cargo fmt (pull_request) Successful in 4s
CI / cargo clippy (pull_request) Successful in 1m36s
CI / cargo deny (pull_request) Successful in 18s
CI / cargo deny advisories (pull_request) Successful in 23s
CI / repository boundary (pull_request) Successful in 5s
CI / frontend-web (pull_request) Successful in 1m10s
CI / cargo test (pull_request) Successful in 3m49s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 1s
aadc86fa7d
Merge pull request 'GRI-2150: create the client data directory before first write' (#287) from fix/GRI-2150-client-data-dir into dev
All checks were successful
CI / the pre-push hook (push) Successful in 4s
CI / cargo fmt (push) Successful in 4s
CI / install.sh client upgrade (push) Successful in 12s
CI / cargo deny (push) Successful in 14s
CI / cargo deny advisories (push) Successful in 16s
CI / repository boundary (push) Successful in 4s
CI / the pre-push hook (pull_request) Successful in 5s
CI / install.sh client upgrade (pull_request) Successful in 15s
CI / cargo fmt (pull_request) Successful in 4s
CI / cargo clippy (push) Successful in 1m8s
CI / frontend-web (push) Successful in 59s
CI / cargo deny (pull_request) Successful in 21s
CI / cargo deny advisories (pull_request) Successful in 20s
CI / cargo clippy (pull_request) Successful in 1m15s
CI / repository boundary (pull_request) Successful in 4s
CI / frontend-web (pull_request) Successful in 1m11s
CI / cargo test (push) Successful in 4m9s
CI / Notify gate failed (push) Has been skipped
CI / CI (push) Successful in 1s
CI / cargo test (pull_request) Successful in 3m57s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 1s
637514c197
GRI-2131: keep the end of ffmpeg's output in a join error; real-tool render test for the sample deck (forge #229)
All checks were successful
CI / the pre-push hook (pull_request) Successful in 3s
CI / cargo fmt (pull_request) Successful in 3s
CI / install.sh client upgrade (pull_request) Successful in 13s
CI / cargo deny (pull_request) Successful in 13s
CI / cargo deny advisories (pull_request) Successful in 20s
CI / repository boundary (pull_request) Successful in 4s
CI / cargo clippy (pull_request) Successful in 1m3s
CI / frontend-web (pull_request) Successful in 1m1s
CI / cargo test (pull_request) Successful in 3m24s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 1s
a1fea0f2eb
Merge pull request 'GRI-2131: rasterise PowerPoint slides with pdftoppm, drop ghostscript (forge #229)' (#288) from fix/GRI-2131-pptx-pdftoppm into dev
Some checks failed
CI / the pre-push hook (push) Successful in 3s
CI / cargo fmt (push) Successful in 4s
CI / install.sh client upgrade (push) Successful in 12s
CI / cargo deny (push) Successful in 13s
CI / cargo deny advisories (push) Successful in 23s
CI / repository boundary (push) Successful in 4s
CI / the pre-push hook (pull_request) Successful in 3s
CI / install.sh client upgrade (pull_request) Successful in 12s
CI / cargo clippy (push) Successful in 1m5s
CI / cargo fmt (pull_request) Successful in 4s
CI / frontend-web (push) Successful in 1m9s
CI / cargo deny (pull_request) Successful in 21s
CI / cargo deny advisories (pull_request) Successful in 18s
CI / cargo clippy (pull_request) Successful in 1m19s
CI / repository boundary (pull_request) Successful in 4s
CI / frontend-web (pull_request) Failing after 57s
CI / cargo test (pull_request) Failing after 2m38s
CI / cargo test (push) Successful in 4m13s
CI / CI (pull_request) Failing after 1s
CI / Notify gate failed (pull_request) Successful in 1s
CI / Notify gate failed (push) Has been skipped
CI / CI (push) Successful in 1s
7c8e2e7a7e
GRI-2147: fail-first acceptance test for playlist default-duration inheritance
Some checks failed
CI / the pre-push hook (pull_request) Successful in 4s
CI / install.sh client upgrade (pull_request) Successful in 14s
CI / cargo fmt (pull_request) Successful in 6s
CI / cargo deny (pull_request) Successful in 23s
CI / cargo deny advisories (pull_request) Successful in 19s
CI / cargo clippy (pull_request) Successful in 1m15s
CI / repository boundary (pull_request) Successful in 4s
CI / frontend-web (pull_request) Successful in 1m12s
CI / cargo test (pull_request) Failing after 3m42s
CI / CI (pull_request) Failing after 2s
CI / Notify gate failed (pull_request) Successful in 1s
13414d52fe
GRI-2147: resolve a playlist's default playtime at push time
Some checks failed
CI / cargo fmt (pull_request) Successful in 3s
CI / the pre-push hook (pull_request) Successful in 4s
CI / install.sh client upgrade (pull_request) Successful in 12s
CI / cargo deny (pull_request) Successful in 10s
CI / cargo deny advisories (pull_request) Successful in 20s
CI / repository boundary (pull_request) Successful in 6s
CI / cargo clippy (pull_request) Successful in 1m14s
CI / frontend-web (pull_request) Successful in 1m13s
CI / CI (pull_request) Has been cancelled
CI / Notify gate failed (pull_request) Has been cancelled
CI / cargo test (pull_request) Failing after 3m16s
1768d12337
playlists.default_duration_seconds becomes nullable. NULL means inherit
the campus override (if any) or else the global default, resolved fresh
in build_wire_playlist every time a playlist reaches a device, instead
of snapshotting a value at create time that a later default change can
never reach. Every existing row is migrated to NULL (0011): there is no
way to tell a deliberate override from a value that happened to match
the default in effect, so all of them are treated as inherited.

A change to the global default (put_global) or a campus override (set
or cleared, put_campus) now re-pushes every playlist currently
inheriting it, via two new lookups in playlists::store. GET/PUT
/playlists* follow the wire contract prismancer signed off on
(forge #277 comment 14150): list/detail responses report
default_duration_seconds as {value, source: "own"|"campus"|"global"},
resolved for a whole list in one query pair (playback_settings::Defaults)
rather than one per row; PUT gains the double-option field (reusing
settings::patch, now pub(crate)) to set a playlist's own value or clear
it back to inherit. POST is unchanged — still a required value, per the
agreed proposal. PATCH's own duration change now also re-pushes to
assigned devices, the same as an items change already does, since it is
the same "content changed but nothing was pushed" gap this issue is
about.
Merge origin/dev into test/GRI-2147-playlist-default-duration-inheritance
Some checks failed
CI / the pre-push hook (pull_request) Successful in 4s
CI / cargo fmt (pull_request) Successful in 5s
CI / install.sh client upgrade (pull_request) Successful in 14s
CI / cargo deny (pull_request) Successful in 18s
CI / cargo deny advisories (pull_request) Successful in 22s
CI / repository boundary (pull_request) Successful in 4s
CI / cargo clippy (pull_request) Successful in 1m22s
CI / frontend-web (pull_request) Successful in 1m3s
CI / cargo test (pull_request) Failing after 2m48s
CI / CI (pull_request) Failing after 1s
CI / Notify gate failed (pull_request) Successful in 1s
824d3b8e54
Renumbered this branch's own migration 0011 -> 0012: dev gained its own
0011_user_locale.sql in the meantime.
Merge origin/dev into test/GRI-2147-playlist-default-duration-inheritance
All checks were successful
CI / the pre-push hook (pull_request) Successful in 3s
CI / cargo fmt (pull_request) Successful in 4s
CI / install.sh client upgrade (pull_request) Successful in 13s
CI / cargo deny (pull_request) Successful in 13s
CI / cargo deny advisories (pull_request) Successful in 24s
CI / repository boundary (pull_request) Successful in 3s
CI / cargo clippy (pull_request) Successful in 1m3s
CI / frontend-web (pull_request) Successful in 1m3s
CI / cargo test (pull_request) Successful in 3m30s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 1s
5e4fc1553d
GRI-2147: inherit the live default on POST when no value is given
All checks were successful
CI / the pre-push hook (pull_request) Successful in 5s
CI / cargo fmt (pull_request) Successful in 6s
CI / install.sh client upgrade (pull_request) Successful in 18s
CI / cargo deny (pull_request) Successful in 18s
CI / cargo deny advisories (pull_request) Successful in 27s
CI / repository boundary (pull_request) Successful in 3s
CI / cargo clippy (pull_request) Successful in 1m13s
CI / frontend-web (pull_request) Successful in 1m4s
CI / cargo test (pull_request) Successful in 3m59s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 1s
9e5cfa99a0
default_duration_seconds on create is now Option<i32>; an omitted or
null value resolves through Defaults the same way GET and PUT already
do, instead of always being written as the playlist's own value.
GRI-2147: panel reads the playlist default playtime as {value, source}
All checks were successful
CI / the pre-push hook (pull_request) Successful in 7s
CI / cargo fmt (pull_request) Successful in 8s
CI / install.sh client upgrade (pull_request) Successful in 20s
CI / cargo deny (pull_request) Successful in 25s
CI / cargo deny advisories (pull_request) Successful in 24s
CI / repository boundary (pull_request) Successful in 5s
CI / cargo clippy (pull_request) Successful in 1m35s
CI / frontend-web (pull_request) Successful in 1m11s
CI / cargo test (pull_request) Successful in 3m32s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 2s
f3dded08f1
A playlist's default duration is now an inherited value with a source
(own/campus/global), not a plain number baked in at creation. Creating a
playlist no longer sends a hardcoded 10s — the server resolves the live
campus or global default instead, so a later change of that default
reaches playlists it did not exist to copy a stale value into.
Merge pull request 'GRI-2147: fail-first acceptance test for playlist default-duration inheritance' (#281) from test/GRI-2147-playlist-default-duration-inheritance into dev
All checks were successful
CI / the pre-push hook (push) Successful in 3s
CI / cargo fmt (push) Successful in 4s
CI / install.sh client upgrade (push) Successful in 12s
CI / repository boundary (push) Successful in 5s
CI / cargo deny (push) Successful in 19s
CI / cargo deny advisories (push) Successful in 19s
CI / the pre-push hook (pull_request) Successful in 3s
CI / install.sh client upgrade (pull_request) Successful in 13s
CI / cargo fmt (pull_request) Successful in 4s
CI / cargo clippy (push) Successful in 1m4s
CI / frontend-web (push) Successful in 1m0s
CI / cargo deny (pull_request) Successful in 19s
CI / cargo deny advisories (pull_request) Successful in 21s
CI / cargo clippy (pull_request) Successful in 1m24s
CI / repository boundary (pull_request) Successful in 4s
CI / frontend-web (pull_request) Successful in 1m24s
CI / cargo test (push) Successful in 4m23s
CI / Notify gate failed (push) Has been skipped
CI / CI (push) Successful in 1s
CI / Notify gate failed (pull_request) Has been skipped
CI / cargo test (pull_request) Successful in 4m13s
CI / CI (pull_request) Successful in 1s
8ae0b2acaa
GRI-2148: playlist Settings control to show or clear its default-playtime override
Some checks failed
CI / the pre-push hook (pull_request) Successful in 3s
CI / cargo fmt (pull_request) Successful in 3s
CI / install.sh client upgrade (pull_request) Successful in 12s
CI / cargo deny (pull_request) Successful in 16s
CI / cargo deny advisories (pull_request) Successful in 20s
CI / repository boundary (pull_request) Successful in 6s
CI / cargo clippy (pull_request) Successful in 1m7s
CI / frontend-web (pull_request) Successful in 1m2s
CI / cargo test (pull_request) Failing after 2m16s
CI / CI (pull_request) Failing after 1s
CI / Notify gate failed (pull_request) Successful in 1s
a6131478f4
A playlist created or reset to inherit shows 'Default (N s, from <campus or
All campuses>)' with an 'Override with a custom value…' button; one with
its own value shows the field and a 'Use the default (...)' button back to
inherit — PATCH /playlists/{id} with null (signage #277, item 1).
GRI-2148: re-trigger CI (cargo test flaked on refuses_a_pdf_that_produces_no_pages, unrelated to this frontend-only change)
All checks were successful
CI / the pre-push hook (pull_request) Successful in 4s
CI / cargo fmt (pull_request) Successful in 3s
CI / install.sh client upgrade (pull_request) Successful in 12s
CI / cargo deny (pull_request) Successful in 24s
CI / cargo deny advisories (pull_request) Successful in 22s
CI / repository boundary (pull_request) Successful in 5s
CI / cargo clippy (pull_request) Successful in 1m8s
CI / frontend-web (pull_request) Successful in 58s
CI / cargo test (pull_request) Successful in 3m27s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 1s
a1bbfe00d2
Merge pull request 'GRI-2148: playlist Settings control for the default-playtime override' (#292) from fix/GRI-2148-playlist-inherit-control into dev
All checks were successful
CI / the pre-push hook (push) Successful in 5s
CI / cargo fmt (push) Successful in 6s
CI / install.sh client upgrade (push) Successful in 17s
CI / cargo deny (push) Successful in 20s
CI / cargo deny advisories (push) Successful in 20s
CI / repository boundary (push) Successful in 6s
CI / the pre-push hook (pull_request) Successful in 3s
CI / install.sh client upgrade (pull_request) Successful in 12s
CI / cargo fmt (pull_request) Successful in 3s
CI / cargo clippy (push) Successful in 1m11s
CI / frontend-web (push) Successful in 1m2s
CI / cargo deny (pull_request) Successful in 30s
CI / cargo clippy (pull_request) Successful in 1m9s
CI / cargo deny advisories (pull_request) Successful in 19s
CI / frontend-web (pull_request) Successful in 1m13s
CI / repository boundary (pull_request) Successful in 5s
CI / cargo test (push) Successful in 4m23s
CI / Notify gate failed (push) Has been skipped
CI / CI (push) Successful in 2s
CI / cargo test (pull_request) Successful in 4m6s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 1s
c623280d22
GRI-2156: acceptance test for in-slide build steps (forge #197)
All checks were successful
CI / the pre-push hook (pull_request) Successful in 3s
CI / cargo fmt (pull_request) Successful in 3s
CI / install.sh client upgrade (pull_request) Successful in 13s
CI / cargo deny (pull_request) Successful in 14s
CI / cargo deny advisories (pull_request) Successful in 17s
CI / repository boundary (pull_request) Successful in 5s
CI / cargo clippy (pull_request) Successful in 1m7s
CI / frontend-web (pull_request) Successful in 59s
CI / cargo test (pull_request) Successful in 3m22s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 1s
7c8f6d8a59
Adds a_deck_with_object_animations_shows_its_build_steps_over_time,
an ignored real-tool test (needs soffice, pdftoppm, ffmpeg): a one-slide
fixture deck with an entrance, an emphasis and a motion path must show
different content early and late in its dwell time once build steps are
rendered as extra frames/segments. Today it renders one static PNG per
slide regardless of animations, so the two sampled frames come out
byte-identical and the test fails -- recorded on GRI-2156.
Merge origin/dev into test/GRI-2156-pptx-object-animations
All checks were successful
CI / the pre-push hook (pull_request) Successful in 4s
CI / cargo fmt (pull_request) Successful in 4s
CI / install.sh client upgrade (pull_request) Successful in 12s
CI / cargo deny (pull_request) Successful in 17s
CI / cargo deny advisories (pull_request) Successful in 18s
CI / repository boundary (pull_request) Successful in 5s
CI / cargo clippy (pull_request) Successful in 1m6s
CI / frontend-web (pull_request) Successful in 59s
CI / cargo test (pull_request) Successful in 3m16s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 1s
bd0447b0d1
Merge pull request 'GRI-2156: acceptance test for in-slide object animations (forge #197)' (#291) from test/GRI-2156-pptx-object-animations into dev
All checks were successful
CI / the pre-push hook (push) Successful in 4s
CI / cargo fmt (push) Successful in 4s
CI / install.sh client upgrade (push) Successful in 14s
CI / cargo deny (push) Successful in 15s
CI / cargo deny advisories (push) Successful in 18s
CI / the pre-push hook (pull_request) Successful in 3s
CI / install.sh client upgrade (pull_request) Successful in 13s
CI / cargo clippy (push) Successful in 1m4s
CI / repository boundary (push) Successful in 5s
CI / cargo fmt (pull_request) Successful in 4s
CI / frontend-web (push) Successful in 1m3s
CI / cargo deny (pull_request) Successful in 17s
CI / cargo deny advisories (pull_request) Successful in 24s
CI / cargo clippy (pull_request) Successful in 1m9s
CI / repository boundary (pull_request) Successful in 4s
CI / frontend-web (pull_request) Successful in 1m6s
CI / cargo test (push) Successful in 4m30s
CI / Notify gate failed (push) Has been skipped
CI / cargo test (pull_request) Successful in 4m11s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 1s
CI / CI (push) Successful in 2s
fc90997a3c
GRI-2147: cargo fmt
All checks were successful
CI / cargo fmt (pull_request) Successful in 4s
CI / the pre-push hook (pull_request) Successful in 5s
CI / install.sh client upgrade (pull_request) Successful in 12s
CI / cargo deny (pull_request) Successful in 19s
CI / cargo deny advisories (pull_request) Successful in 26s
CI / repository boundary (pull_request) Successful in 5s
CI / cargo clippy (pull_request) Successful in 1m9s
CI / frontend-web (pull_request) Successful in 1m1s
CI / cargo test (pull_request) Successful in 3m27s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 1s
2601323ea4
Merge pull request 'GRI-2147: test POST /playlists with no default_duration_seconds inherits default' (#293) from test/GRI-2147-playlist-create-inherits-default into dev
All checks were successful
CI / the pre-push hook (push) Successful in 4s
CI / cargo fmt (push) Successful in 5s
CI / install.sh client upgrade (push) Successful in 13s
CI / cargo deny (push) Successful in 23s
CI / the pre-push hook (pull_request) Successful in 5s
CI / cargo deny advisories (push) Successful in 22s
CI / repository boundary (push) Successful in 5s
CI / install.sh client upgrade (pull_request) Successful in 13s
CI / cargo fmt (pull_request) Successful in 5s
CI / cargo clippy (push) Successful in 1m18s
CI / frontend-web (push) Successful in 1m0s
CI / cargo deny (pull_request) Successful in 20s
CI / cargo deny advisories (pull_request) Successful in 21s
CI / cargo clippy (pull_request) Successful in 1m34s
CI / repository boundary (pull_request) Successful in 4s
CI / frontend-web (pull_request) Successful in 1m17s
CI / cargo test (push) Successful in 4m32s
CI / Notify gate failed (push) Has been skipped
CI / CI (push) Successful in 1s
CI / cargo test (pull_request) Successful in 4m26s
CI / CI (pull_request) Successful in 1s
CI / Notify gate failed (pull_request) Has been skipped
3d1c75eb9f
GRI-2141: fail-first tests for panel language switching (Dutch), forge #275
Some checks failed
CI / the pre-push hook (pull_request) Successful in 3s
CI / cargo fmt (pull_request) Successful in 3s
CI / install.sh client upgrade (pull_request) Successful in 13s
CI / cargo deny (pull_request) Successful in 16s
CI / cargo deny advisories (pull_request) Successful in 20s
CI / repository boundary (pull_request) Successful in 6s
CI / frontend-web (pull_request) Failing after 36s
CI / cargo clippy (pull_request) Successful in 1m14s
CI / cargo test (pull_request) Successful in 3m27s
CI / Notify gate failed (pull_request) Successful in 1s
CI / CI (pull_request) Failing after 1s
6fe624f769
Pins the already-shipped session/locale contract (forge #274: GET/POST
/session's locale field, PATCH /session/locale, 400 unknown_locale) in
httpSessionApi.test.ts, and adds an App-level integration suite for the
not-yet-built language control: switch without reload, EN<->NL round
trip, fallback to English for panel.nav.settings (missing from nl.yml),
persistence across a fresh session load, in-flight and failed-save
states, and accessibility (name, keyboard reachability, document lang).

All 11 new/updated assertions fail against today's code (missing
updateLocale export, missing locale field, no control rendered) and
181 pre-existing tests are unaffected.
GRI-2134: wire panel locale switching, with Dutch
All checks were successful
CI / cargo fmt (pull_request) Successful in 3s
CI / the pre-push hook (pull_request) Successful in 4s
CI / install.sh client upgrade (pull_request) Successful in 12s
CI / cargo deny (pull_request) Successful in 12s
CI / cargo deny advisories (pull_request) Successful in 19s
CI / repository boundary (pull_request) Successful in 5s
CI / cargo clippy (pull_request) Successful in 1m1s
CI / frontend-web (pull_request) Successful in 1m1s
CI / cargo test (pull_request) Successful in 3m27s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 1s
9e4e17d786
Adds a LocaleProvider/useLocale context backed by English and Dutch
bundles, a language settings tab to switch and persist it via the
SessionUser locale field, and <t> wiring in the dashboard greeting.
Merge branch 'dev' into feature/GRI-2134-panel-i18n-dutch
All checks were successful
CI / the pre-push hook (pull_request) Successful in 4s
CI / cargo fmt (pull_request) Successful in 4s
CI / install.sh client upgrade (pull_request) Successful in 12s
CI / cargo deny (pull_request) Successful in 14s
CI / cargo deny advisories (pull_request) Successful in 23s
CI / repository boundary (pull_request) Successful in 5s
CI / cargo clippy (pull_request) Successful in 1m7s
CI / frontend-web (pull_request) Successful in 1m2s
CI / cargo test (pull_request) Successful in 4m14s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 2s
1945751ab3
Merge pull request 'GRI-2134: wire panel locale switching, with Dutch' (#294) from feature/GRI-2134-panel-i18n-dutch into dev
All checks were successful
CI / the pre-push hook (push) Successful in 3s
CI / cargo fmt (push) Successful in 4s
CI / install.sh client upgrade (push) Successful in 12s
CI / cargo deny (push) Successful in 30s
CI / cargo deny advisories (push) Successful in 23s
CI / repository boundary (push) Successful in 3s
CI / the pre-push hook (pull_request) Successful in 3s
CI / cargo fmt (pull_request) Successful in 3s
CI / cargo clippy (push) Successful in 1m5s
CI / frontend-web (push) Successful in 56s
CI / cargo deny (pull_request) Successful in 21s
CI / install.sh client upgrade (pull_request) Successful in 12s
CI / cargo deny advisories (pull_request) Successful in 21s
CI / cargo clippy (pull_request) Successful in 1m30s
CI / repository boundary (pull_request) Successful in 4s
CI / frontend-web (pull_request) Successful in 1m19s
CI / cargo test (push) Successful in 4m39s
CI / CI (push) Successful in 2s
CI / Notify gate failed (push) Has been skipped
CI / cargo test (pull_request) Successful in 4m43s
CI / CI (pull_request) Successful in 1s
CI / Notify gate failed (pull_request) Has been skipped
92bcba4c0e
Adds the_189_upload_note_is_removed_only_for_a_fully_supported_deck: per
GRI-2133's contract answer (MediaView.unsupported_effects: Option<Vec<String>>,
None when every in-slide effect is one this change renders, Some non-empty
otherwise), uploads a fully-supported deck (entrance/emphasis/motion-path)
and a deck with one presetClass="media" Play-trigger effect this change
cannot render, and asserts the note key is absent on the first and present
and non-empty on the second.

Written as one test, not two: a test that only checks the field is absent
on the fully-supported deck passes today -- the field does not exist at
all yet -- so it would be testing nothing. The contrast with the
unsupported deck is what gives it a failure to catch, both now and if a
future change ever set the field for a fully-supported deck too.
GRI-2156: ignore the new test, matching the criterion-1 convention
All checks were successful
CI / the pre-push hook (pull_request) Successful in 4s
CI / cargo fmt (pull_request) Successful in 4s
CI / install.sh client upgrade (pull_request) Successful in 13s
CI / cargo deny (pull_request) Successful in 1m12s
CI / cargo deny advisories (pull_request) Successful in 1m19s
CI / repository boundary (pull_request) Successful in 4s
CI / cargo clippy (pull_request) Successful in 2m20s
CI / frontend-web (pull_request) Successful in 1m8s
CI / cargo test (pull_request) Successful in 4m23s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 1s
f6c19f4cd0
cargo test --workspace (CI's own invocation, no --include-ignored) ran the
new test and genuinely failed it -- correct for tests-first, but it would
turn this branch's CI red and block it reaching dev for Nyssa to implement
against. #[ignore] it, the same way
a_deck_with_object_animations_shows_its_build_steps_over_time already is,
with the same un-ignore-once-implemented note. Fail-first evidence now
comes from running it directly with --ignored --exact; the normal
(CI-shaped) run is green: 6 passed, 1 ignored.
Merge branch 'dev' into test/GRI-2156-unsupported-effects-note
All checks were successful
CI / the pre-push hook (pull_request) Successful in 3s
CI / install.sh client upgrade (pull_request) Successful in 13s
CI / cargo fmt (pull_request) Successful in 8s
CI / cargo deny (pull_request) Successful in 22s
CI / cargo deny advisories (pull_request) Successful in 21s
CI / cargo clippy (pull_request) Successful in 1m19s
CI / repository boundary (pull_request) Successful in 4s
CI / frontend-web (pull_request) Successful in 1m13s
CI / cargo test (pull_request) Successful in 4m5s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 1s
32ea36675f
Merge branch 'dev' into test/GRI-2156-unsupported-effects-note
All checks were successful
CI / the pre-push hook (pull_request) Successful in 5s
CI / install.sh client upgrade (pull_request) Successful in 18s
CI / cargo fmt (pull_request) Successful in 6s
CI / cargo clippy (pull_request) Successful in 1m31s
CI / cargo deny (pull_request) Successful in 19s
CI / cargo deny advisories (pull_request) Successful in 23s
CI / repository boundary (pull_request) Successful in 4s
CI / frontend-web (pull_request) Successful in 1m11s
CI / cargo test (pull_request) Successful in 3m40s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 1s
93b956031b
Merge pull request 'GRI-2156: acceptance test for the #189 upload note on unsupported effects (forge #197)' (#295) from test/GRI-2156-unsupported-effects-note into dev
All checks were successful
CI / install.sh client upgrade (push) Successful in 12s
CI / cargo deny (push) Successful in 19s
CI / the pre-push hook (push) Successful in 3s
CI / cargo fmt (push) Successful in 3s
CI / cargo deny advisories (push) Successful in 23s
CI / repository boundary (push) Successful in 5s
CI / the pre-push hook (pull_request) Successful in 3s
CI / install.sh client upgrade (pull_request) Successful in 13s
CI / cargo fmt (pull_request) Successful in 4s
CI / cargo clippy (push) Successful in 1m15s
CI / frontend-web (push) Successful in 1m0s
CI / cargo deny (pull_request) Successful in 21s
CI / cargo deny advisories (pull_request) Successful in 20s
CI / cargo clippy (pull_request) Successful in 1m21s
CI / repository boundary (pull_request) Successful in 4s
CI / cargo test (push) Successful in 4m21s
CI / CI (push) Successful in 1s
CI / Notify gate failed (push) Has been skipped
CI / cargo test (pull_request) Successful in 4m9s
CI / CI (pull_request) Successful in 1s
CI / frontend-web (pull_request) Successful in 1m11s
CI / Notify gate failed (pull_request) Has been skipped
7d8cbb9284
GRI-2158: use a fully-supported fixture with no emphasis effect
All checks were successful
CI / the pre-push hook (pull_request) Successful in 6s
CI / cargo fmt (pull_request) Successful in 5s
CI / install.sh client upgrade (pull_request) Successful in 13s
CI / cargo deny (pull_request) Successful in 21s
CI / cargo deny advisories (pull_request) Successful in 18s
CI / repository boundary (pull_request) Successful in 6s
CI / cargo clippy (pull_request) Successful in 1m7s
CI / frontend-web (pull_request) Successful in 1m0s
CI / cargo test (pull_request) Successful in 3m31s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 2s
445a3b1366
animated-deck.pptx has an emphasis effect, which PR #296 review #526
(GRI-2133) makes unsupported (recognised but not drawn). Swap the
fully-supported-deck fixture for a new one with only an entrance and
a motion path, so the test still exercises a deck that is actually
fully supported.
Merge pull request 'GRI-2158: use a fully-supported fixture with no emphasis effect' (#297) from test/GRI-2158-fully-supported-fixture into dev
Some checks failed
CI / the pre-push hook (push) Successful in 5s
CI / cargo fmt (push) Successful in 5s
CI / install.sh client upgrade (push) Successful in 14s
CI / cargo deny (push) Successful in 25s
CI / cargo deny advisories (push) Successful in 44s
CI / repository boundary (push) Successful in 5s
CI / the pre-push hook (pull_request) Successful in 4s
CI / install.sh client upgrade (pull_request) Successful in 13s
CI / cargo clippy (push) Successful in 1m27s
CI / cargo fmt (pull_request) Successful in 3s
CI / frontend-web (push) Successful in 1m12s
CI / cargo deny (pull_request) Successful in 35s
CI / cargo deny advisories (pull_request) Successful in 30s
CI / cargo clippy (pull_request) Successful in 1m42s
CI / repository boundary (pull_request) Successful in 5s
CI / cargo test (push) Successful in 4m52s
CI / frontend-web (pull_request) Successful in 1m17s
CI / CI (push) Successful in 2s
CI / Notify gate failed (push) Has been skipped
CI / cargo test (pull_request) Failing after 4m35s
CI / Notify gate failed (pull_request) Successful in 2s
CI / CI (pull_request) Failing after 2s
54b7432f2a
GRI-2133: render in-slide build steps as extra MP4 frames, flag unsupported effects
All checks were successful
CI / the pre-push hook (pull_request) Successful in 5s
CI / cargo fmt (pull_request) Successful in 4s
CI / install.sh client upgrade (pull_request) Successful in 12s
CI / cargo deny (pull_request) Successful in 20s
CI / cargo deny advisories (pull_request) Successful in 57s
CI / repository boundary (pull_request) Successful in 5s
CI / cargo clippy (pull_request) Successful in 1m17s
CI / frontend-web (pull_request) Successful in 1m10s
CI / cargo test (pull_request) Successful in 4m0s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 1s
2bcf973147
Forge #197: entrance, exit and emphasis effects, plus a straight-line
motion path, read from a slide's <p:timing> tree and rendered as extra
frames within that slide's own dwell time (option 1 from GRI-2043),
instead of the slide's single final-state image. An effect this cannot
draw (a Play Sound/Video trigger, a curved motion path, an unrecognised
presetClass) is collected into a deck-level tag list and returned from
join_slides_into_mp4, threaded through to a new MediaView.unsupported_effects
field the client keys the #189 upload note on.

Per GRI-2156's acceptance tests (now unignored, both merged into dev
before this): a_deck_with_object_animations_shows_its_build_steps_over_time
and the_189_upload_note_is_removed_only_for_a_fully_supported_deck.
Review #526 on PR #296: an emphasis is read but never drawn, so counting
it as supported removed the #189 note for a deck the screen does not
actually animate, and its no-op render duplicated the previous build-step
frame. Same gap for an entrance/exit/motion-path effect with no readable
spid. Both kinds now report an unsupported tag and are excluded from
step_count, so render_stage_xml only spends a frame on a click it can
actually draw.
Merge remote-tracking branch 'origin/dev' into feature/GRI-2133-pptx-object-animations
All checks were successful
CI / the pre-push hook (pull_request) Successful in 4s
CI / install.sh client upgrade (pull_request) Successful in 16s
CI / cargo fmt (pull_request) Successful in 7s
CI / cargo clippy (pull_request) Successful in 1m27s
CI / cargo deny (pull_request) Successful in 21s
CI / cargo deny advisories (pull_request) Successful in 23s
CI / repository boundary (pull_request) Successful in 5s
CI / frontend-web (pull_request) Successful in 1m15s
CI / cargo test (pull_request) Successful in 3m47s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 1s
ecc0ca4698
Merge pull request 'GRI-2133: render in-slide build steps, flag unsupported effects' (#296) from feature/GRI-2133-pptx-object-animations into dev
All checks were successful
CI / the pre-push hook (push) Successful in 4s
CI / cargo fmt (push) Successful in 5s
CI / install.sh client upgrade (push) Successful in 12s
CI / cargo deny (push) Successful in 13s
CI / cargo deny advisories (push) Successful in 18s
CI / install.sh client upgrade (pull_request) Successful in 13s
CI / repository boundary (push) Successful in 5s
CI / the pre-push hook (pull_request) Successful in 3s
CI / cargo fmt (pull_request) Successful in 3s
CI / cargo clippy (push) Successful in 1m9s
CI / cargo deny (pull_request) Successful in 19s
CI / cargo deny advisories (pull_request) Successful in 20s
CI / frontend-web (push) Successful in 59s
CI / cargo clippy (pull_request) Successful in 1m13s
CI / repository boundary (pull_request) Successful in 3s
CI / frontend-web (pull_request) Successful in 1m7s
CI / cargo test (push) Successful in 4m28s
CI / Notify gate failed (push) Has been skipped
CI / CI (push) Successful in 1s
CI / cargo test (pull_request) Successful in 4m3s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 1s
e1cc06e1d1
GRI-2153: add fail-first tests for self-service password change
Some checks failed
CI / cargo fmt (pull_request) Successful in 5s
CI / the pre-push hook (pull_request) Successful in 7s
CI / install.sh client upgrade (pull_request) Successful in 14s
CI / cargo deny (pull_request) Successful in 15s
CI / cargo deny advisories (pull_request) Successful in 21s
CI / repository boundary (pull_request) Successful in 5s
CI / cargo clippy (pull_request) Successful in 1m10s
CI / frontend-web (pull_request) Successful in 1m3s
CI / cargo test (pull_request) Failing after 3m5s
CI / Notify gate failed (pull_request) Successful in 1s
CI / CI (pull_request) Failing after 1s
5e94a0a27c
GRI-2153: a signed-in user can change their own password
All checks were successful
CI / the pre-push hook (pull_request) Successful in 3s
CI / cargo fmt (pull_request) Successful in 4s
CI / install.sh client upgrade (pull_request) Successful in 12s
CI / cargo deny (pull_request) Successful in 12s
CI / cargo deny advisories (pull_request) Successful in 21s
CI / repository boundary (pull_request) Successful in 3s
CI / cargo clippy (pull_request) Successful in 1m2s
CI / frontend-web (pull_request) Successful in 1m1s
CI / cargo test (pull_request) Successful in 3m19s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 1s
63a8139ff7
PATCH /api/v1/session/password takes current_password, new_password
and new_password_confirmation, confirming Astraea's contract on PR
#290. Verifies the current password against a real Argon2id hash,
rejects a mismatched confirmation or a new password under 8
characters, and ends every other session on the account while
leaving the session that made the change signed in.
Merge pull request 'GRI-2153: a signed-in user can change their own password' (#298) from fix/GRI-2153-self-service-password-change into dev
All checks were successful
CI / Notify gate failed (push) Has been skipped
CI / CI (push) Successful in 1s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 1s
CI / cargo test (pull_request) Successful in 4m5s
CI / the pre-push hook (push) Successful in 4s
CI / cargo fmt (push) Successful in 3s
CI / install.sh client upgrade (push) Successful in 12s
CI / cargo deny advisories (push) Successful in 18s
CI / cargo deny (push) Successful in 12s
CI / repository boundary (push) Successful in 4s
CI / the pre-push hook (pull_request) Successful in 3s
CI / install.sh client upgrade (pull_request) Successful in 13s
CI / cargo fmt (pull_request) Successful in 3s
CI / cargo deny (pull_request) Successful in 20s
CI / cargo clippy (pull_request) Successful in 1m16s
CI / repository boundary (pull_request) Successful in 3s
CI / cargo clippy (push) Successful in 1m1s
CI / frontend-web (push) Successful in 1m1s
CI / cargo deny advisories (pull_request) Successful in 19s
CI / frontend-web (pull_request) Successful in 1m15s
CI / cargo test (push) Successful in 4m14s
d3fb23d9e2
GRI-2168: take shared styles and components from @grimoirix/design 0.2.0
All checks were successful
CI / the pre-push hook (pull_request) Successful in 3s
CI / cargo fmt (pull_request) Successful in 3s
CI / install.sh client upgrade (pull_request) Successful in 12s
CI / cargo deny (pull_request) Successful in 12s
CI / cargo deny advisories (pull_request) Successful in 18s
CI / repository boundary (pull_request) Successful in 4s
CI / cargo clippy (pull_request) Successful in 1m5s
CI / frontend-web (pull_request) Successful in 59s
CI / cargo test (pull_request) Successful in 3m23s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 1s
716cdd5bed
The neutral button, layout, section menu and notification styles and the
DismissibleError, notification and SectionNav components now live in the
shared package. Local copies are removed; the local modules re-export the
package so imports stay the same and the existing tests run against it.
Red buttons use gx-btn--danger; a test refuses the old gx-btn--secondary.
Merge pull request 'GRI-2168: take shared styles and components from @grimoirix/design 0.2.0' (#299) from feature/GRI-2168-design-0.2.0 into dev
All checks were successful
CI / cargo fmt (push) Successful in 3s
CI / install.sh client upgrade (push) Successful in 12s
CI / the pre-push hook (push) Successful in 4s
CI / cargo deny (push) Successful in 12s
CI / cargo deny advisories (push) Successful in 17s
CI / repository boundary (push) Successful in 4s
CI / the pre-push hook (pull_request) Successful in 3s
CI / install.sh client upgrade (pull_request) Successful in 12s
CI / cargo fmt (pull_request) Successful in 3s
CI / cargo clippy (push) Successful in 1m9s
CI / frontend-web (push) Successful in 58s
CI / cargo deny (pull_request) Successful in 20s
CI / cargo deny advisories (pull_request) Successful in 20s
CI / cargo clippy (pull_request) Successful in 1m15s
CI / repository boundary (pull_request) Successful in 3s
CI / frontend-web (pull_request) Successful in 1m12s
CI / cargo test (push) Successful in 4m26s
CI / cargo test (pull_request) Successful in 4m48s
CI / CI (push) Successful in 1s
CI / Notify gate failed (push) Has been skipped
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 1s
d1a9bcb269
GRI-2178: accept RUSTSEC-2026-0543 (chrono unmaintained), no safe upgrade
All checks were successful
CI / the pre-push hook (pull_request) Successful in 7s
CI / cargo fmt (pull_request) Successful in 5s
CI / install.sh client upgrade (pull_request) Successful in 17s
CI / cargo deny advisories (pull_request) Successful in 1m27s
CI / cargo clippy (pull_request) Successful in 2m13s
CI / cargo deny (pull_request) Successful in 1m28s
CI / repository boundary (pull_request) Successful in 5s
CI / frontend-web (pull_request) Successful in 1m33s
CI / cargo test (pull_request) Successful in 6m39s
CI / CI (pull_request) Successful in 1s
CI / Notify gate failed (pull_request) Has been skipped
3346fc1ee6
Merge pull request 'GRI-2178: accept RUSTSEC-2026-0543 (chrono unmaintained)' (#308) from security/GRI-2178-chrono-unmaintained-advisory into dev
Some checks failed
CI / cargo fmt (pull_request) Successful in 6s
CI / cargo deny (push) Successful in 1m19s
CI / frontend-web (push) Successful in 1m51s
CI / cargo test (push) Successful in 6m20s
CI / cargo clippy (pull_request) Successful in 2m11s
CI / cargo deny (pull_request) Successful in 1m10s
CI / repository boundary (pull_request) Successful in 6s
CI / cargo deny advisories (pull_request) Successful in 59s
CI / CI (push) Successful in 2s
CI / Notify gate failed (push) Has been skipped
CI / frontend-web (pull_request) Successful in 1m38s
CI / cargo test (pull_request) Failing after 5m14s
CI / Notify gate failed (pull_request) Successful in 10s
CI / CI (pull_request) Failing after 10s
CI / the pre-push hook (push) Successful in 7s
CI / cargo fmt (push) Successful in 4s
CI / install.sh client upgrade (push) Successful in 15s
CI / cargo deny advisories (push) Successful in 1m24s
CI / cargo clippy (push) Successful in 2m19s
CI / repository boundary (push) Successful in 8s
CI / the pre-push hook (pull_request) Successful in 5s
CI / install.sh client upgrade (pull_request) Successful in 16s
7f09d753f0
GRI-2173: mask gnome-initial-setup's first-login and upgrade-login wizards
Some checks failed
CI / the pre-push hook (pull_request) Successful in 4s
CI / cargo fmt (pull_request) Successful in 3s
CI / install.sh client upgrade (pull_request) Successful in 14s
CI / cargo deny (pull_request) Successful in 1m1s
CI / cargo deny advisories (pull_request) Failing after 1m19s
CI / repository boundary (pull_request) Successful in 6s
CI / cargo clippy (pull_request) Successful in 2m20s
CI / frontend-web (pull_request) Successful in 1m25s
CI / cargo test (pull_request) Successful in 5m38s
CI / Notify gate failed (pull_request) Successful in 1s
CI / CI (pull_request) Failing after 1s
c8230e3a67
Writing gnome-initial-setup-done only stopped the first-login wizard.
Ubuntu 26.04's gnome-initial-setup 50.0 adds a second, upgrade-login
unit that is gated on that same done file and a release-named marker,
so it opened on top of the player on every boot after an upgrade.

Mask all three per-user units (first-login, upgrade-login, and the
copy-worker they share) to /dev/null in the kiosk user's own systemd
directory, so no future release can bring them back, and keep writing
both done markers belt and braces. Everything the step creates is now
chowned with -h and a group, fixing scryglass:root ownership left by
the old `chown "$user:"` call.

Co-Authored-By: Paperclip <noreply@paperclip.ing>
Merge remote-tracking branch 'origin/dev' into fix/GRI-2173-mask-gnome-initial-setup-wizards
All checks were successful
CI / cargo fmt (pull_request) Successful in 5s
CI / the pre-push hook (pull_request) Successful in 6s
CI / install.sh client upgrade (pull_request) Successful in 14s
CI / cargo clippy (pull_request) Successful in 2m6s
CI / cargo deny (pull_request) Successful in 1m17s
CI / repository boundary (pull_request) Successful in 6s
CI / cargo deny advisories (pull_request) Successful in 1m0s
CI / frontend-web (pull_request) Successful in 1m38s
CI / cargo test (pull_request) Successful in 6m2s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 1s
5c2dfcceb4
Merge pull request 'GRI-2173: mask gnome-initial-setup's first-login and upgrade-login wizards' (#303) from fix/GRI-2173-mask-gnome-initial-setup-wizards into dev
All checks were successful
CI / cargo fmt (pull_request) Successful in 6s
CI / frontend-web (push) Successful in 1m31s
CI / cargo clippy (pull_request) Successful in 1m33s
CI / cargo deny (pull_request) Successful in 53s
CI / cargo deny advisories (pull_request) Successful in 41s
CI / repository boundary (pull_request) Successful in 5s
CI / frontend-web (pull_request) Successful in 1m26s
CI / cargo test (push) Successful in 7m39s
CI / cargo test (pull_request) Successful in 6m0s
CI / Notify gate failed (push) Has been skipped
CI / CI (push) Successful in 1s
CI / CI (pull_request) Successful in 1s
CI / Notify gate failed (pull_request) Has been skipped
CI / the pre-push hook (push) Successful in 6s
CI / cargo fmt (push) Successful in 7s
CI / install.sh client upgrade (push) Successful in 18s
CI / cargo deny (push) Successful in 2m2s
CI / cargo clippy (push) Successful in 2m59s
CI / cargo deny advisories (push) Successful in 46s
CI / repository boundary (push) Successful in 5s
CI / the pre-push hook (pull_request) Successful in 4s
CI / install.sh client upgrade (pull_request) Successful in 19s
685581104c
GRI-2174: keep kind/url/page on round-tripped playlist items
Some checks failed
CI / the pre-push hook (pull_request) Successful in 4s
CI / cargo fmt (pull_request) Successful in 4s
CI / install.sh client upgrade (pull_request) Successful in 13s
CI / cargo clippy (pull_request) Successful in 2m40s
CI / cargo deny advisories (pull_request) Failing after 1m45s
CI / cargo deny (pull_request) Successful in 1m52s
CI / repository boundary (pull_request) Successful in 16s
CI / frontend-web (pull_request) Successful in 2m7s
CI / cargo test (pull_request) Successful in 6m50s
CI / CI (pull_request) Failing after 1s
CI / Notify gate failed (pull_request) Successful in 1s
23ed9415e1
A URL or page item read back from the server carried no kind/url/page,
so replacePlaylistItems guessed kind 'image' and sent media_id: "" on
the next save. Carry kind/url/page through PlaylistItem and use them
when the library lookup by media_id has nothing; throw instead of
guessing a kind.
Merge branch 'dev' into fix/GRI-2174-playlist-url-item-resave
All checks were successful
CI / the pre-push hook (pull_request) Successful in 5s
CI / install.sh client upgrade (pull_request) Successful in 17s
CI / cargo fmt (pull_request) Successful in 6s
CI / cargo deny (pull_request) Successful in 35s
CI / cargo clippy (pull_request) Successful in 1m55s
CI / cargo deny advisories (pull_request) Successful in 36s
CI / repository boundary (pull_request) Successful in 4s
CI / frontend-web (pull_request) Successful in 1m15s
CI / cargo test (pull_request) Successful in 4m48s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 1s
78b0b7aaeb
Merge pull request 'GRI-2174: playlist with a URL item cannot be saved a second time' (#306) from fix/GRI-2174-playlist-url-item-resave into dev
Some checks failed
CI / repository boundary (push) Successful in 9s
CI / the pre-push hook (pull_request) Successful in 4s
CI / install.sh client upgrade (pull_request) Successful in 13s
CI / cargo fmt (pull_request) Successful in 5s
CI / cargo clippy (push) Successful in 1m59s
CI / frontend-web (push) Successful in 1m17s
CI / cargo deny (pull_request) Successful in 29s
CI / cargo clippy (pull_request) Successful in 1m19s
CI / cargo deny advisories (pull_request) Successful in 34s
CI / repository boundary (pull_request) Successful in 4s
CI / cargo test (push) Failing after 3m45s
CI / frontend-web (pull_request) Successful in 1m12s
CI / CI (push) Failing after 1s
CI / Notify gate failed (push) Has been skipped
CI / cargo test (pull_request) Successful in 4m59s
CI / CI (pull_request) Successful in 2s
CI / Notify gate failed (pull_request) Has been skipped
CI / the pre-push hook (push) Successful in 6s
CI / cargo fmt (push) Successful in 6s
CI / install.sh client upgrade (push) Successful in 14s
CI / cargo deny (push) Successful in 56s
CI / cargo deny advisories (push) Successful in 59s
acdbda2c8d
GRI-2180: match restrict_violation (23001) alongside foreign_key_violation (23503)
Some checks failed
CI / the pre-push hook (pull_request) Successful in 4s
CI / cargo fmt (pull_request) Successful in 4s
CI / install.sh client upgrade (pull_request) Successful in 14s
CI / cargo deny (pull_request) Successful in 1m4s
CI / cargo deny advisories (pull_request) Failing after 58s
CI / repository boundary (pull_request) Successful in 4s
CI / cargo clippy (pull_request) Successful in 2m18s
CI / frontend-web (pull_request) Successful in 1m21s
CI / cargo test (pull_request) Successful in 6m14s
CI / CI (pull_request) Failing after 1s
CI / Notify gate failed (pull_request) Successful in 2s
28163dff2d
delete_playlist, delete_media and delete_campus each kept their own copy
of is_foreign_key_violation, matching only SQLSTATE 23503. Forge issue
#223 was reopened: on the campus test server (PostgreSQL 18 via the
Ubuntu 26.04 package) that delete's RESTRICT violation was suspected to
surface under 23001 instead, so the 409 path was never taken and the
raw database error passed through as a 500.

Shares one is_foreign_key_violation in db.rs, matching both codes, used
by all three handlers.
Merge branch 'dev' into fix/GRI-2180-pg18-restrict-violation-code
All checks were successful
CI / the pre-push hook (pull_request) Successful in 4s
CI / install.sh client upgrade (pull_request) Successful in 16s
CI / cargo fmt (pull_request) Successful in 5s
CI / cargo deny (pull_request) Successful in 35s
CI / cargo clippy (pull_request) Successful in 1m57s
CI / cargo deny advisories (pull_request) Successful in 31s
CI / repository boundary (pull_request) Successful in 5s
CI / frontend-web (pull_request) Successful in 1m26s
CI / cargo test (pull_request) Successful in 5m38s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 1s
e1ec962cf2
Merge branch 'dev' into fix/GRI-2180-pg18-restrict-violation-code
All checks were successful
CI / the pre-push hook (pull_request) Successful in 3s
CI / install.sh client upgrade (pull_request) Successful in 15s
CI / cargo fmt (pull_request) Successful in 3s
CI / cargo deny (pull_request) Successful in 33s
CI / cargo clippy (pull_request) Successful in 1m54s
CI / cargo deny advisories (pull_request) Successful in 44s
CI / repository boundary (pull_request) Successful in 5s
CI / frontend-web (pull_request) Successful in 1m26s
CI / cargo test (pull_request) Successful in 5m43s
CI / CI (pull_request) Successful in 1s
CI / Notify gate failed (pull_request) Has been skipped
c9fda46de6
Merge pull request 'GRI-2180: match restrict_violation (23001) alongside foreign_key_violation (23503)' (#309) from fix/GRI-2180-pg18-restrict-violation-code into dev
All checks were successful
CI / the pre-push hook (push) Successful in 6s
CI / cargo fmt (push) Successful in 8s
CI / install.sh client upgrade (push) Successful in 21s
CI / cargo deny (push) Successful in 59s
CI / cargo deny advisories (push) Successful in 1m16s
CI / repository boundary (push) Successful in 9s
CI / the pre-push hook (pull_request) Successful in 6s
CI / install.sh client upgrade (pull_request) Successful in 18s
CI / cargo fmt (pull_request) Successful in 5s
CI / frontend-web (push) Successful in 1m31s
CI / cargo clippy (push) Successful in 2m53s
CI / cargo clippy (pull_request) Successful in 1m55s
CI / cargo deny (pull_request) Successful in 1m11s
CI / cargo deny advisories (pull_request) Successful in 1m18s
CI / repository boundary (pull_request) Successful in 5s
CI / cargo test (push) Successful in 7m8s
CI / frontend-web (pull_request) Successful in 1m57s
CI / cargo test (pull_request) Successful in 7m54s
CI / CI (push) Successful in 2s
CI / Notify gate failed (push) Has been skipped
CI / CI (pull_request) Successful in 1s
CI / Notify gate failed (pull_request) Has been skipped
aeab4f831b
GRI-2182: migrate chrono to time across client, server and shared
All checks were successful
CI / the pre-push hook (pull_request) Successful in 8s
CI / cargo fmt (pull_request) Successful in 3s
CI / install.sh client upgrade (pull_request) Successful in 17s
CI / cargo deny (pull_request) Successful in 12s
CI / cargo deny advisories (pull_request) Successful in 19s
CI / repository boundary (pull_request) Successful in 5s
CI / cargo clippy (pull_request) Successful in 1m7s
CI / frontend-web (pull_request) Successful in 1m0s
CI / cargo test (pull_request) Successful in 3m27s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 1s
cd00de6ac7
Drops the unmaintained chrono crate (RUSTSEC-2026-0543) and the sqlx
chrono feature in favour of time, which sqlx 0.8.6 supports natively.
Removes the now-stale ignore entry for the advisory from deny.toml.
Merge pull request 'GRI-2182: migrate chrono to time across client, server and shared' (#313) from feature/GRI-2182-chrono-to-time into dev
All checks were successful
CI / cargo deny (push) Successful in 19s
CI / the pre-push hook (push) Successful in 3s
CI / cargo fmt (push) Successful in 3s
CI / install.sh client upgrade (push) Successful in 13s
CI / cargo deny advisories (push) Successful in 18s
CI / repository boundary (push) Successful in 4s
CI / the pre-push hook (pull_request) Successful in 5s
CI / install.sh client upgrade (pull_request) Successful in 13s
CI / cargo fmt (pull_request) Successful in 4s
CI / cargo clippy (push) Successful in 1m7s
CI / frontend-web (push) Successful in 1m2s
CI / cargo deny (pull_request) Successful in 22s
CI / cargo clippy (pull_request) Successful in 1m13s
CI / cargo deny advisories (pull_request) Successful in 27s
CI / repository boundary (pull_request) Successful in 3s
CI / frontend-web (pull_request) Successful in 1m19s
CI / cargo test (push) Successful in 4m17s
CI / CI (push) Successful in 1s
CI / Notify gate failed (push) Has been skipped
CI / cargo test (pull_request) Successful in 4m17s
CI / CI (pull_request) Successful in 1s
CI / Notify gate failed (pull_request) Has been skipped
d7177abb95
GRI-2206: pass replace=true on second assign in re_assigning_a_device_replaces_its_previous_playlist
All checks were successful
CI / the pre-push hook (pull_request) Successful in 3s
CI / cargo fmt (pull_request) Successful in 3s
CI / install.sh client upgrade (pull_request) Successful in 13s
CI / cargo deny (pull_request) Successful in 17s
CI / cargo deny advisories (pull_request) Successful in 25s
CI / repository boundary (pull_request) Successful in 3s
CI / cargo clippy (pull_request) Successful in 1m8s
CI / frontend-web (pull_request) Successful in 1m5s
CI / cargo test (pull_request) Successful in 3m31s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 1s
26349cb1fb
Merge pull request 'GRI-2206: pass replace=true in re_assigning_a_device_replaces_its_previous_playlist' (#318) from test/GRI-2206-reassign-playlist-replace-contract into dev
All checks were successful
CI / the pre-push hook (push) Successful in 3s
CI / cargo fmt (push) Successful in 3s
CI / install.sh client upgrade (push) Successful in 12s
CI / cargo deny (push) Successful in 19s
CI / cargo deny advisories (push) Successful in 15s
CI / cargo clippy (push) Successful in 1m0s
CI / repository boundary (push) Successful in 2s
CI / the pre-push hook (pull_request) Successful in 2s
CI / install.sh client upgrade (pull_request) Successful in 12s
CI / cargo fmt (pull_request) Successful in 3s
CI / frontend-web (push) Successful in 54s
CI / cargo clippy (pull_request) Successful in 1m20s
CI / cargo deny (pull_request) Successful in 18s
CI / cargo deny advisories (pull_request) Successful in 18s
CI / repository boundary (pull_request) Successful in 4s
CI / frontend-web (pull_request) Successful in 1m17s
CI / cargo test (push) Successful in 4m18s
CI / cargo test (pull_request) Successful in 4m36s
CI / CI (push) Successful in 1s
CI / Notify gate failed (push) Has been skipped
CI / CI (pull_request) Successful in 1s
CI / Notify gate failed (pull_request) Has been skipped
5e14bb9b55
GRI-2202: fix formatting and update stale per-page-item test expectation
Some checks failed
CI / the pre-push hook (pull_request) Successful in 6s
CI / cargo fmt (pull_request) Successful in 5s
CI / install.sh client upgrade (pull_request) Successful in 12s
CI / cargo clippy (pull_request) Successful in 2m8s
CI / cargo deny advisories (pull_request) Successful in 1m10s
CI / cargo deny (pull_request) Successful in 1m8s
CI / repository boundary (pull_request) Successful in 6s
CI / frontend-web (pull_request) Failing after 1m19s
CI / cargo test (pull_request) Successful in 6m47s
CI / CI (pull_request) Failing after 1s
CI / Notify gate failed (pull_request) Successful in 1s
82503182c5
Merge branch 'dev' into feature/GRI-2202-picker-single-document-item
Some checks failed
CI / the pre-push hook (pull_request) Successful in 2s
CI / install.sh client upgrade (pull_request) Successful in 18s
CI / cargo fmt (pull_request) Successful in 6s
CI / cargo deny (pull_request) Successful in 20s
CI / cargo deny advisories (pull_request) Successful in 19s
CI / cargo clippy (pull_request) Successful in 1m27s
CI / repository boundary (pull_request) Successful in 4s
CI / frontend-web (pull_request) Successful in 1m4s
CI / cargo test (pull_request) Successful in 4m11s
CI / CI (pull_request) Successful in 1s
CI / Notify gate failed (pull_request) Failing after 12m30s
5290ac08cf
Merge pull request 'GRI-2202: picker Add N pages makes one document item with page overrides' (#316) from feature/GRI-2202-picker-single-document-item into dev
All checks were successful
CI / the pre-push hook (push) Successful in 4s
CI / cargo fmt (push) Successful in 6s
CI / install.sh client upgrade (push) Successful in 13s
CI / cargo deny (push) Successful in 11s
CI / cargo deny advisories (push) Successful in 16s
CI / repository boundary (push) Successful in 4s
CI / the pre-push hook (pull_request) Successful in 3s
CI / install.sh client upgrade (pull_request) Successful in 13s
CI / cargo fmt (pull_request) Successful in 3s
CI / cargo clippy (push) Successful in 1m5s
CI / frontend-web (push) Successful in 58s
CI / cargo deny (pull_request) Successful in 20s
CI / cargo deny advisories (pull_request) Successful in 21s
CI / cargo clippy (pull_request) Successful in 1m20s
CI / repository boundary (pull_request) Successful in 2s
CI / frontend-web (pull_request) Successful in 1m17s
CI / cargo test (push) Successful in 4m26s
CI / CI (push) Successful in 1s
CI / Notify gate failed (push) Has been skipped
CI / cargo test (pull_request) Successful in 4m18s
CI / CI (pull_request) Successful in 1s
CI / Notify gate failed (pull_request) Has been skipped
13517fef1e
Migration 0014 merges consecutive document_page items of the same document
into a single document item per run, carrying page order and per-item times
forward as page overrides. PUT /playlists/{id}/items now refuses a
document_page item with 422.
Merge remote-tracking branch 'origin/dev' into feature/GRI-2179-document-playlist-item
Some checks failed
CI / the pre-push hook (pull_request) Successful in 5s
CI / cargo fmt (pull_request) Successful in 5s
CI / install.sh client upgrade (pull_request) Successful in 17s
CI / cargo clippy (pull_request) Successful in 2m53s
CI / cargo deny advisories (pull_request) Successful in 2m1s
CI / cargo deny (pull_request) Successful in 2m9s
CI / repository boundary (pull_request) Successful in 6s
CI / cargo test (pull_request) Failing after 5m27s
CI / frontend-web (pull_request) Successful in 1m41s
CI / CI (pull_request) Failing after 1s
CI / Notify gate failed (pull_request) Successful in 1s
3ce664ea23
GRI-2179: update media_integration fixture for retired document_page playlist items
Some checks failed
CI / the pre-push hook (pull_request) Successful in 4s
CI / install.sh client upgrade (pull_request) Successful in 12s
CI / cargo fmt (pull_request) Successful in 3s
CI / cargo deny (pull_request) Successful in 43s
CI / cargo deny advisories (pull_request) Successful in 45s
CI / repository boundary (pull_request) Successful in 5s
CI / cargo clippy (pull_request) Successful in 1m52s
CI / frontend-web (pull_request) Successful in 1m22s
CI / cargo test (pull_request) Failing after 4m14s
CI / CI (pull_request) Failing after 1s
CI / Notify gate failed (pull_request) Successful in 1s
08b1941c65
insert_playlist_item's old 'document_page' kind violates the 0014
migration's CHECK (page IS NULL, kind excludes document_page). The
deletion-conflict test now inserts the item as kind='document' against
the document's own media id, matching the new model; the page column
is dropped from the helper since nothing passes it any more.
GRI-2179: run the 0014 test-helper DDL and conversion SQL via raw_sql
All checks were successful
CI / the pre-push hook (pull_request) Successful in 3s
CI / cargo fmt (pull_request) Successful in 3s
CI / install.sh client upgrade (pull_request) Successful in 13s
CI / cargo deny (pull_request) Successful in 20s
CI / cargo deny advisories (pull_request) Successful in 21s
CI / repository boundary (pull_request) Successful in 6s
CI / cargo clippy (pull_request) Successful in 1m5s
CI / frontend-web (pull_request) Successful in 56s
CI / cargo test (pull_request) Successful in 3m28s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 1s
e705af39c4
sqlx::query uses the extended protocol, which Postgres refuses for a
string carrying more than one command (42601). reopen_document_page_items
and the 0014 conversion both run several statements in one call.
GRI-2179: break a 0014 consolidation run on a non-increasing page
All checks were successful
CI / the pre-push hook (pull_request) Successful in 3s
CI / cargo fmt (pull_request) Successful in 4s
CI / install.sh client upgrade (pull_request) Successful in 12s
CI / cargo deny (pull_request) Successful in 18s
CI / cargo deny advisories (pull_request) Successful in 16s
CI / repository boundary (pull_request) Successful in 3s
CI / cargo clippy (pull_request) Successful in 1m5s
CI / frontend-web (pull_request) Successful in 1m3s
CI / cargo test (pull_request) Successful in 3m28s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 1s
98158e608f
Review #541 on PR #312: a reordered (3, 1, 2) or repeated (5, 5) run of
document_page items for the same document was merged into one item by
matching only on document id, silently changing play order or dropping
a repeated page. A run now also requires the page number to strictly
increase; otherwise it breaks and the next page starts a new item, the
same as an interleaved run. Covers both shapes with new tests.
Merge branch 'dev' into feature/GRI-2179-document-playlist-item
All checks were successful
CI / the pre-push hook (pull_request) Successful in 3s
CI / cargo fmt (pull_request) Successful in 4s
CI / install.sh client upgrade (pull_request) Successful in 12s
CI / cargo deny (pull_request) Successful in 14s
CI / cargo deny advisories (pull_request) Successful in 18s
CI / repository boundary (pull_request) Successful in 5s
CI / cargo clippy (pull_request) Successful in 1m6s
CI / frontend-web (pull_request) Successful in 1m3s
CI / cargo test (pull_request) Successful in 3m37s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 1s
53f79ba801
Merge pull request 'GRI-2179: A document is one playlist item; its pages are sub-entries, not separate media items' (#312) from feature/GRI-2179-document-playlist-item into dev
All checks were successful
CI / the pre-push hook (push) Successful in 5s
CI / cargo fmt (push) Successful in 3s
CI / install.sh client upgrade (push) Successful in 12s
CI / cargo deny (push) Successful in 15s
CI / cargo deny advisories (push) Successful in 18s
CI / repository boundary (push) Successful in 4s
CI / the pre-push hook (pull_request) Successful in 4s
CI / install.sh client upgrade (pull_request) Successful in 13s
CI / cargo fmt (pull_request) Successful in 4s
CI / cargo clippy (push) Successful in 1m1s
CI / frontend-web (push) Successful in 1m0s
CI / cargo deny (pull_request) Successful in 20s
CI / cargo deny advisories (pull_request) Successful in 21s
CI / cargo clippy (pull_request) Successful in 1m16s
CI / repository boundary (pull_request) Successful in 4s
CI / frontend-web (pull_request) Successful in 1m12s
CI / cargo test (push) Successful in 4m17s
CI / CI (push) Successful in 1s
CI / Notify gate failed (push) Has been skipped
CI / cargo test (pull_request) Successful in 4m9s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 1s
ce7f85dc7d
assign_playlist gets replace (default false); campus mismatch and
already-assigned conflicts return 409 with details via
ApiError::conflict_with_details. update_device and update_playlist refuse
campus changes that would leave a device/playlist pair mismatched.
Migration 0014 reports pre-existing mismatches without altering data.
GRI-2201: cargo fmt
Some checks failed
CI / cargo fmt (pull_request) Successful in 5s
CI / the pre-push hook (pull_request) Successful in 7s
CI / install.sh client upgrade (pull_request) Successful in 15s
CI / cargo clippy (pull_request) Successful in 2m21s
CI / cargo deny advisories (pull_request) Successful in 1m8s
CI / repository boundary (pull_request) Successful in 6s
CI / cargo test (pull_request) Failing after 4m59s
CI / frontend-web (pull_request) Successful in 1m28s
CI / cargo deny (pull_request) Failing after 15m25s
CI / CI (pull_request) Has been cancelled
CI / Notify gate failed (pull_request) Has been cancelled
618ca78623
Merge branch 'dev' into feature/GRI-2201-assign-playlist-guards
Some checks failed
CI / the pre-push hook (pull_request) Has been cancelled
CI / install.sh client upgrade (pull_request) Has been cancelled
CI / cargo fmt (pull_request) Has been cancelled
CI / cargo clippy (pull_request) Has been cancelled
CI / cargo test (pull_request) Has been cancelled
CI / cargo deny (pull_request) Has been cancelled
CI / cargo deny advisories (pull_request) Has been cancelled
CI / frontend-web (pull_request) Has been cancelled
CI / repository boundary (pull_request) Has been cancelled
CI / CI (pull_request) Has been cancelled
CI / Notify gate failed (pull_request) Has been cancelled
939f3752a8
GRI-2201: rename migration to 0015 (0014 is reserved by #312)
Some checks failed
CI / the pre-push hook (pull_request) Successful in 3s
CI / install.sh client upgrade (pull_request) Successful in 15s
CI / cargo fmt (pull_request) Successful in 4s
CI / cargo deny (pull_request) Successful in 19s
CI / cargo deny advisories (pull_request) Successful in 16s
CI / cargo clippy (pull_request) Successful in 1m21s
CI / repository boundary (pull_request) Successful in 3s
CI / frontend-web (pull_request) Successful in 1m9s
CI / cargo test (pull_request) Failing after 3m10s
CI / CI (pull_request) Failing after 1s
CI / Notify gate failed (pull_request) Successful in 1s
c6c6524851
Merge branch 'dev' into feature/GRI-2201-assign-playlist-guards
Some checks failed
CI / the pre-push hook (pull_request) Successful in 4s
CI / cargo fmt (pull_request) Successful in 4s
CI / install.sh client upgrade (pull_request) Successful in 12s
CI / cargo deny (pull_request) Successful in 11s
CI / cargo deny advisories (pull_request) Successful in 20s
CI / repository boundary (pull_request) Successful in 4s
CI / cargo clippy (pull_request) Successful in 1m1s
CI / frontend-web (pull_request) Successful in 58s
CI / cargo test (pull_request) Failing after 2m45s
CI / CI (pull_request) Failing after 0s
CI / Notify gate failed (pull_request) Successful in 1s
8e58ee313c
GRI-2207: pass replace=true in reassigning_an_applied_device_emits_pending_again
Some checks failed
CI / the pre-push hook (pull_request) Successful in 3s
CI / cargo fmt (pull_request) Successful in 4s
CI / install.sh client upgrade (pull_request) Successful in 12s
CI / cargo deny (pull_request) Successful in 12s
CI / cargo deny advisories (pull_request) Successful in 17s
CI / repository boundary (pull_request) Successful in 5s
CI / cargo clippy (pull_request) Successful in 1m8s
CI / frontend-web (pull_request) Successful in 1m7s
CI / cargo test (pull_request) Failing after 2m4s
CI / Notify gate failed (pull_request) Successful in 1s
CI / CI (pull_request) Failing after 1s
cbfddd9790
GRI-2201: retrigger CI (cargo test failure was an unrelated 200ms timing flake in pdf::tests::times_out_when_the_converter_hangs, not touched by this branch)
All checks were successful
CI / the pre-push hook (pull_request) Successful in 3s
CI / cargo fmt (pull_request) Successful in 3s
CI / install.sh client upgrade (pull_request) Successful in 12s
CI / cargo deny (pull_request) Successful in 12s
CI / cargo deny advisories (pull_request) Successful in 17s
CI / repository boundary (pull_request) Successful in 4s
CI / cargo clippy (pull_request) Successful in 1m1s
CI / frontend-web (pull_request) Successful in 1m0s
CI / cargo test (pull_request) Successful in 3m17s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 1s
14cf9504ff
Merge pull request 'GRI-2201: refuse silent playlist moves and cross-campus assignments' (#317) from feature/GRI-2201-assign-playlist-guards into dev
Some checks failed
CI / cargo fmt (push) Successful in 3s
CI / the pre-push hook (push) Successful in 4s
CI / install.sh client upgrade (push) Successful in 12s
CI / cargo deny (push) Successful in 11s
CI / cargo deny advisories (push) Successful in 16s
CI / repository boundary (push) Successful in 5s
CI / the pre-push hook (pull_request) Successful in 3s
CI / install.sh client upgrade (pull_request) Successful in 15s
CI / cargo fmt (pull_request) Successful in 4s
CI / cargo clippy (push) Successful in 1m10s
CI / frontend-web (push) Successful in 1m3s
CI / cargo deny (pull_request) Successful in 19s
CI / cargo deny advisories (pull_request) Successful in 18s
CI / cargo clippy (pull_request) Successful in 1m23s
CI / repository boundary (pull_request) Successful in 4s
CI / frontend-web (pull_request) Successful in 1m11s
CI / cargo test (push) Successful in 4m41s
CI / Notify gate failed (push) Has been skipped
CI / CI (pull_request) Successful in 1s
CI / CI (push) Successful in 2s
CI / cargo test (pull_request) Successful in 4m42s
CI / Notify gate failed (pull_request) Failing after 14m54s
c3e062ab56
GRI-2190: panel for the assign-playlist replace/campus-mismatch contract
All checks were successful
CI / the pre-push hook (pull_request) Successful in 3s
CI / cargo fmt (pull_request) Successful in 3s
CI / install.sh client upgrade (pull_request) Successful in 13s
CI / cargo deny (pull_request) Successful in 15s
CI / cargo deny advisories (pull_request) Successful in 15s
CI / repository boundary (pull_request) Successful in 4s
CI / cargo clippy (pull_request) Successful in 1m5s
CI / frontend-web (pull_request) Successful in 59s
CI / cargo test (pull_request) Successful in 3m14s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 1s
22c115147e
PlaylistDevicesTab disables a device already on another playlist, or of a
mismatching campus, naming the reason, instead of letting a tick steal a
device or cross a campus. DevicesScreen gets a playlist selector, filtered
to the device's own campus (or campus-open playlists), that assigns
directly when nothing is assigned yet and asks to confirm a move
(replace: true) when something already is.
Merge pull request 'GRI-2190: panel for the assign-playlist replace/campus-mismatch contract (forge #310)' (#319) from feature/GRI-2190-playlist-devices-panel into dev
All checks were successful
CI / the pre-push hook (push) Successful in 3s
CI / cargo fmt (push) Successful in 3s
CI / install.sh client upgrade (push) Successful in 13s
CI / cargo deny (push) Successful in 17s
CI / cargo deny advisories (push) Successful in 18s
CI / repository boundary (push) Successful in 5s
CI / the pre-push hook (pull_request) Successful in 3s
CI / install.sh client upgrade (pull_request) Successful in 15s
CI / cargo fmt (pull_request) Successful in 3s
CI / cargo clippy (push) Successful in 1m8s
CI / frontend-web (push) Successful in 1m1s
CI / cargo deny (pull_request) Successful in 20s
CI / cargo deny advisories (pull_request) Successful in 19s
CI / cargo clippy (pull_request) Successful in 1m19s
CI / repository boundary (pull_request) Successful in 3s
CI / frontend-web (pull_request) Successful in 1m16s
CI / cargo test (push) Successful in 4m18s
CI / Notify gate failed (push) Has been skipped
CI / CI (push) Successful in 1s
CI / cargo test (pull_request) Successful in 4m1s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 1s
56dd99caf0
GRI-2213: media library website item shows name with address below as a link
All checks were successful
CI / the pre-push hook (pull_request) Successful in 5s
CI / cargo fmt (pull_request) Successful in 6s
CI / install.sh client upgrade (pull_request) Successful in 16s
CI / cargo deny (pull_request) Successful in 13s
CI / cargo deny advisories (pull_request) Successful in 21s
CI / repository boundary (pull_request) Successful in 5s
CI / cargo clippy (pull_request) Successful in 1m16s
CI / frontend-web (pull_request) Successful in 1m7s
CI / cargo test (pull_request) Successful in 3m47s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 1s
79a352e60e
Merge pull request 'GRI-2213: media library website item shows name with address link below' (#324) from fix/GRI-2213-media-library-url-item into dev
All checks were successful
CI / the pre-push hook (push) Successful in 5s
CI / cargo fmt (push) Successful in 4s
CI / install.sh client upgrade (push) Successful in 14s
CI / cargo deny advisories (push) Successful in 1m6s
CI / cargo deny (push) Successful in 1m14s
CI / cargo clippy (push) Successful in 1m31s
CI / repository boundary (push) Successful in 4s
CI / the pre-push hook (pull_request) Successful in 4s
CI / cargo fmt (pull_request) Successful in 4s
CI / install.sh client upgrade (pull_request) Successful in 12s
CI / frontend-web (push) Successful in 1m0s
CI / cargo deny (pull_request) Successful in 21s
CI / cargo deny advisories (pull_request) Successful in 35s
CI / cargo clippy (pull_request) Successful in 1m39s
CI / repository boundary (pull_request) Successful in 6s
CI / frontend-web (pull_request) Successful in 1m22s
CI / cargo test (push) Successful in 5m0s
CI / CI (push) Successful in 2s
CI / Notify gate failed (push) Has been skipped
CI / cargo test (pull_request) Successful in 4m44s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 1s
acb6ae68cc
GRI-2210: show the library name for a url playlist item, not its address
All checks were successful
CI / the pre-push hook (pull_request) Successful in 4s
CI / cargo fmt (pull_request) Successful in 6s
CI / install.sh client upgrade (pull_request) Successful in 12s
CI / cargo deny (pull_request) Successful in 29s
CI / cargo deny advisories (pull_request) Successful in 28s
CI / repository boundary (pull_request) Successful in 3s
CI / cargo clippy (pull_request) Successful in 1m18s
CI / frontend-web (pull_request) Successful in 59s
CI / cargo test (pull_request) Successful in 3m46s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 1s
d69b227fb7
A url item sent to the server dropped media_id even when added from the
library, so a saved item lost its link and only the raw address remained.
replacePlaylistItems now keeps media_id for a url item that still resolves
to a library entry; itemFromWire also resolves a legacy item (no media_id)
by matching its url against library url items when exactly one matches, so
existing rows heal on load without a migration. PlaylistMediaTab now shows
the resolved library name linked to /media/library, with the address in
smaller text underneath.
GRI-2210: merge dev (keep both CSS blocks from #324 and this branch)
All checks were successful
CI / the pre-push hook (pull_request) Successful in 4s
CI / install.sh client upgrade (pull_request) Successful in 15s
CI / cargo fmt (pull_request) Successful in 4s
CI / cargo clippy (pull_request) Successful in 1m31s
CI / cargo deny (pull_request) Successful in 30s
CI / cargo deny advisories (pull_request) Successful in 22s
CI / repository boundary (pull_request) Successful in 4s
CI / frontend-web (pull_request) Successful in 1m4s
CI / cargo test (pull_request) Successful in 3m54s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 1s
e7beb18c25
Merge pull request 'GRI-2210: show the library name for a url playlist item, not its address' (#321) from feature/GRI-2210-url-item-library-name into dev
All checks were successful
CI / the pre-push hook (push) Successful in 5s
CI / cargo fmt (push) Successful in 4s
CI / install.sh client upgrade (push) Successful in 14s
CI / cargo deny (push) Successful in 21s
CI / cargo deny advisories (push) Successful in 20s
CI / cargo clippy (push) Successful in 1m30s
CI / repository boundary (push) Successful in 3s
CI / the pre-push hook (pull_request) Successful in 3s
CI / frontend-web (push) Successful in 1m2s
CI / cargo fmt (pull_request) Successful in 5s
CI / install.sh client upgrade (pull_request) Successful in 15s
CI / cargo clippy (pull_request) Successful in 1m20s
CI / cargo deny (pull_request) Successful in 19s
CI / cargo deny advisories (pull_request) Successful in 37s
CI / cargo test (push) Successful in 4m30s
CI / repository boundary (pull_request) Successful in 5s
CI / frontend-web (pull_request) Successful in 1m17s
CI / cargo test (pull_request) Successful in 4m51s
CI / CI (push) Successful in 2s
CI / Notify gate failed (push) Has been skipped
CI / CI (pull_request) Successful in 2s
CI / Notify gate failed (pull_request) Has been skipped
a4c4b81501
GRI-2214: show an Online/Offline connection label for every device
Some checks failed
CI / cargo fmt (pull_request) Successful in 5s
CI / the pre-push hook (pull_request) Successful in 5s
CI / install.sh client upgrade (pull_request) Successful in 13s
CI / cargo deny (pull_request) Successful in 45s
CI / cargo deny advisories (pull_request) Successful in 45s
CI / repository boundary (pull_request) Successful in 4s
CI / cargo clippy (pull_request) Successful in 1m25s
CI / frontend-web (pull_request) Successful in 1m13s
CI / cargo test (pull_request) Successful in 4m32s
CI / CI (pull_request) Has been cancelled
CI / Notify gate failed (pull_request) Has been cancelled
afd9ce28c8
Split the device card's one mixed tag into two: a connection tag
(Online, Offline · last seen ..., or Never connected) on every device,
and a playlist tag (Up to date / Updating) only once there is a
playlist and the device is online. The connection state updates live
from the existing rollout-status stream, with no reload.
Merge remote-tracking branch 'origin/dev' into fix/GRI-2214-devices-online-label
All checks were successful
CI / the pre-push hook (pull_request) Successful in 8s
CI / cargo fmt (pull_request) Successful in 5s
CI / install.sh client upgrade (pull_request) Successful in 16s
CI / cargo deny (pull_request) Successful in 25s
CI / cargo clippy (pull_request) Successful in 1m24s
CI / cargo deny advisories (pull_request) Successful in 22s
CI / repository boundary (pull_request) Successful in 4s
CI / frontend-web (pull_request) Successful in 1m14s
CI / cargo test (pull_request) Successful in 4m23s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 1s
f4fcb1b19f
Merge pull request 'GRI-2214: show an Online label for every device, apart from the playlist status' (#327) from fix/GRI-2214-devices-online-label into dev
All checks were successful
CI / the pre-push hook (push) Successful in 4s
CI / cargo fmt (push) Successful in 3s
CI / install.sh client upgrade (push) Successful in 13s
CI / cargo deny (push) Successful in 18s
CI / cargo deny advisories (push) Successful in 37s
CI / repository boundary (push) Successful in 6s
CI / the pre-push hook (pull_request) Successful in 3s
CI / install.sh client upgrade (pull_request) Successful in 14s
CI / cargo fmt (pull_request) Successful in 3s
CI / cargo clippy (push) Successful in 1m20s
CI / frontend-web (push) Successful in 1m11s
CI / cargo deny (pull_request) Successful in 27s
CI / cargo deny advisories (pull_request) Successful in 20s
CI / cargo clippy (pull_request) Successful in 1m27s
CI / repository boundary (pull_request) Successful in 4s
CI / frontend-web (pull_request) Successful in 1m21s
CI / cargo test (push) Successful in 4m23s
CI / CI (push) Successful in 1s
CI / Notify gate failed (push) Has been skipped
CI / cargo test (pull_request) Successful in 4m9s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 1s
5b0dd7749f
campus_id becomes three-state (absent/null/uuid) on PATCH /devices/{id}.
Clearing requires global-admin access and skips the playlist-mismatch
check, since a device with no campus fits any playlist. Panel offers
an All campuses option to global admins only.
The new campus-editor 403 test logs in via POST /session, which needs
the LoginThrottle extension the real router layers in. Missing it made
login 500 rather than exercise the test.
GRI-2212: merge dev
All checks were successful
CI / the pre-push hook (pull_request) Successful in 5s
CI / install.sh client upgrade (pull_request) Successful in 13s
CI / cargo fmt (pull_request) Successful in 4s
CI / cargo clippy (pull_request) Successful in 1m12s
CI / cargo deny (pull_request) Successful in 15s
CI / cargo deny advisories (pull_request) Successful in 21s
CI / frontend-web (pull_request) Successful in 1m14s
CI / repository boundary (pull_request) Successful in 3s
CI / cargo test (pull_request) Successful in 3m54s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 1s
7a27cf3fe4
Merge pull request 'GRI-2212: allow setting a device back to All campuses' (#328) from fix/GRI-2212-device-clear-campus into dev
All checks were successful
CI / the pre-push hook (push) Successful in 4s
CI / install.sh client upgrade (push) Successful in 12s
CI / cargo fmt (push) Successful in 3s
CI / cargo clippy (push) Successful in 1m55s
CI / cargo deny (push) Successful in 1m2s
CI / cargo deny advisories (push) Successful in 44s
CI / repository boundary (push) Successful in 4s
CI / the pre-push hook (pull_request) Successful in 5s
CI / install.sh client upgrade (pull_request) Successful in 16s
CI / cargo fmt (pull_request) Successful in 5s
CI / frontend-web (push) Successful in 1m36s
CI / cargo deny (pull_request) Successful in 23s
CI / cargo deny advisories (pull_request) Successful in 20s
CI / cargo clippy (pull_request) Successful in 1m38s
CI / repository boundary (pull_request) Successful in 3s
CI / cargo test (push) Successful in 6m15s
CI / frontend-web (pull_request) Successful in 1m32s
CI / CI (push) Successful in 1s
CI / Notify gate failed (push) Has been skipped
CI / cargo test (pull_request) Successful in 4m52s
CI / CI (pull_request) Successful in 1s
CI / Notify gate failed (pull_request) Has been skipped
20007bc17c
GRI-2212: restrict clearing a device's campus to global admins only
All checks were successful
CI / the pre-push hook (pull_request) Successful in 3s
CI / cargo fmt (pull_request) Successful in 4s
CI / install.sh client upgrade (pull_request) Successful in 15s
CI / cargo deny (pull_request) Successful in 21s
CI / cargo deny advisories (pull_request) Successful in 21s
CI / cargo clippy (pull_request) Successful in 1m30s
CI / repository boundary (pull_request) Successful in 4s
CI / frontend-web (pull_request) Successful in 1m11s
CI / cargo test (pull_request) Successful in 4m20s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 1s
e0755b9ac5
A campus-bound admin (isAdmin true, campusId set) could still see and
choose All campuses in the panel; the server already refuses that with
403, so align the client check with it.
Merge pull request 'GRI-2212: restrict clearing a device's campus to global admins only' (#329) from fix/GRI-2212-clear-campus-scoped-admin into dev
All checks were successful
CI / the pre-push hook (push) Successful in 4s
CI / cargo fmt (push) Successful in 3s
CI / install.sh client upgrade (push) Successful in 12s
CI / cargo deny (push) Successful in 21s
CI / cargo deny advisories (push) Successful in 22s
CI / repository boundary (push) Successful in 12s
CI / the pre-push hook (pull_request) Successful in 4s
CI / install.sh client upgrade (pull_request) Successful in 13s
CI / cargo fmt (pull_request) Successful in 4s
CI / cargo clippy (push) Successful in 1m24s
CI / frontend-web (push) Successful in 1m36s
CI / cargo deny (pull_request) Successful in 15s
CI / cargo clippy (pull_request) Successful in 1m16s
CI / cargo deny advisories (pull_request) Successful in 31s
CI / repository boundary (pull_request) Successful in 4s
CI / frontend-web (pull_request) Successful in 1m27s
CI / cargo test (push) Successful in 5m2s
CI / CI (push) Successful in 1s
CI / Notify gate failed (push) Has been skipped
CI / cargo test (pull_request) Successful in 4m46s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 1s
bf59402017
- install.sh and README bootstrap commands use wget instead of curl, since
  Ubuntu Desktop 26.04 ships wget but not curl
- client resends its Registration frame on every Accepted hello, not only
  while Pending
- server applies reported hostname/reported_info on reconnect via
  devices::update_reported_info, leaving the admin-set name untouched
GRI-2215: fix test deadlock from filtering Registration in receive()
All checks were successful
CI / the pre-push hook (pull_request) Successful in 4s
CI / cargo fmt (pull_request) Successful in 4s
CI / install.sh client upgrade (pull_request) Successful in 12s
CI / cargo deny (pull_request) Successful in 12s
CI / cargo deny advisories (pull_request) Successful in 15s
CI / repository boundary (pull_request) Successful in 4s
CI / cargo clippy (pull_request) Successful in 1m7s
CI / frontend-web (pull_request) Successful in 58s
CI / cargo test (pull_request) Successful in 3m35s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 1s
fbb806283e
receive() skipped every Registration frame, but the pending-device test
expects to receive exactly one. Stop filtering it generically and instead
drain the post-Accepted Registration echo explicitly where it occurs.
Merge pull request 'GRI-2215: fix curl fallback and hostname update on reconnect' (#330) from fix/GRI-2215-curl-fallback-and-hostname-update into dev
Some checks failed
CI / the pre-push hook (push) Successful in 6s
CI / cargo fmt (push) Successful in 5s
CI / install.sh client upgrade (push) Successful in 13s
CI / cargo deny (push) Successful in 22s
CI / cargo deny advisories (push) Successful in 17s
CI / cargo clippy (push) Successful in 1m10s
CI / repository boundary (push) Successful in 4s
CI / the pre-push hook (pull_request) Successful in 4s
CI / install.sh client upgrade (pull_request) Successful in 13s
CI / cargo fmt (pull_request) Successful in 3s
CI / frontend-web (push) Successful in 59s
CI / cargo deny (pull_request) Successful in 22s
CI / cargo deny advisories (pull_request) Successful in 21s
CI / cargo test (push) Failing after 2m41s
CI / repository boundary (pull_request) Successful in 4s
CI / cargo clippy (pull_request) Successful in 1m21s
CI / CI (push) Failing after 1s
CI / Notify gate failed (push) Has been skipped
CI / frontend-web (pull_request) Successful in 58s
CI / cargo test (pull_request) Failing after 2m22s
CI / CI (pull_request) Failing after 1s
CI / Notify gate failed (pull_request) Successful in 2s
f6d98ca30f
GRI-2144: test playlist page sub-list, override badge and Reset
Some checks failed
CI / the pre-push hook (pull_request) Successful in 3s
CI / cargo fmt (pull_request) Successful in 3s
CI / install.sh client upgrade (pull_request) Successful in 12s
CI / cargo deny (pull_request) Successful in 15s
CI / cargo deny advisories (pull_request) Successful in 17s
CI / repository boundary (pull_request) Successful in 4s
CI / cargo clippy (pull_request) Successful in 1m2s
CI / frontend-web (pull_request) Failing after 46s
CI / cargo test (pull_request) Successful in 3m30s
CI / Notify gate failed (pull_request) Successful in 1s
CI / CI (pull_request) Failing after 1s
f95d73d251
Replaces the cogwheel/panel-based page-overrides test with the
expand/collapse sub-list the chief of staff specified on forge #278
(comment 14538), and adds coverage for the Own-time badge and Reset
control. Both new tests fail against current dev: the gated panel
and cogwheel button still exist, and there is no badge or Reset yet.
GRI-2144: playlist page sub-list with Own time badge and Reset
Some checks failed
CI / the pre-push hook (pull_request) Successful in 3s
CI / cargo fmt (pull_request) Successful in 3s
CI / install.sh client upgrade (pull_request) Successful in 13s
CI / cargo clippy (pull_request) Successful in 1m42s
CI / cargo deny (pull_request) Successful in 17s
CI / cargo deny advisories (pull_request) Successful in 26s
CI / frontend-web (pull_request) Failing after 1m14s
CI / repository boundary (pull_request) Successful in 6s
CI / cargo test (pull_request) Successful in 6m27s
CI / CI (pull_request) Failing after 2s
CI / Notify gate failed (pull_request) Successful in 2s
8d5aa61270
GRI-2144: retrigger CI after unrelated frontend-web flake (AddMediaScreen.test.tsx timeout, not touched by this branch)
All checks were successful
CI / the pre-push hook (pull_request) Successful in 3s
CI / cargo fmt (pull_request) Successful in 3s
CI / install.sh client upgrade (pull_request) Successful in 12s
CI / cargo deny (pull_request) Successful in 17s
CI / cargo deny advisories (pull_request) Successful in 20s
CI / repository boundary (pull_request) Successful in 6s
CI / cargo clippy (pull_request) Successful in 1m12s
CI / frontend-web (pull_request) Successful in 1m1s
CI / cargo test (pull_request) Successful in 3m24s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 1s
ed6e18ed17
Merge pull request 'GRI-2144: playlist page sub-list, Own time badge and Reset' (#331) from feature/GRI-2144-playlist-page-sublist-ui into dev
All checks were successful
CI / the pre-push hook (push) Successful in 3s
CI / cargo fmt (push) Successful in 6s
CI / install.sh client upgrade (push) Successful in 17s
CI / cargo deny (push) Successful in 22s
CI / cargo deny advisories (push) Successful in 20s
CI / repository boundary (push) Successful in 5s
CI / the pre-push hook (pull_request) Successful in 4s
CI / install.sh client upgrade (pull_request) Successful in 15s
CI / cargo fmt (pull_request) Successful in 5s
CI / cargo clippy (push) Successful in 1m23s
CI / frontend-web (push) Successful in 1m8s
CI / cargo deny (pull_request) Successful in 22s
CI / cargo deny advisories (pull_request) Successful in 22s
CI / cargo clippy (pull_request) Successful in 1m36s
CI / repository boundary (pull_request) Successful in 4s
CI / frontend-web (pull_request) Successful in 1m27s
CI / cargo test (push) Successful in 5m37s
CI / Notify gate failed (push) Has been skipped
CI / CI (push) Successful in 2s
CI / cargo test (pull_request) Successful in 5m36s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 2s
4481da030c
GRI-2088: fix ETXTBSY race in pdf.rs and pptx_video acceptance test fake_program
All checks were successful
CI / the pre-push hook (pull_request) Successful in 5s
CI / install.sh client upgrade (pull_request) Successful in 19s
CI / cargo fmt (pull_request) Successful in 6s
CI / cargo clippy (pull_request) Successful in 1m52s
CI / cargo deny (pull_request) Successful in 24s
CI / cargo deny advisories (pull_request) Successful in 19s
CI / repository boundary (pull_request) Successful in 5s
CI / frontend-web (pull_request) Successful in 1m24s
CI / cargo test (pull_request) Successful in 5m18s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 1s
10fc752085
Write the fake script via a piped child sh instead of std::fs::write
in-process, matching the fix already applied to pptx_video.rs in #221.
Print the error on the bare assert!(matches!(...)) checks in pdf.rs
and pptx_video.rs so a recurrence shows the actual error.
Merge remote-tracking branch 'origin/dev' into fix/GRI-2088-pdf-etxtbsy
All checks were successful
CI / the pre-push hook (pull_request) Successful in 4s
CI / cargo fmt (pull_request) Successful in 3s
CI / install.sh client upgrade (pull_request) Successful in 13s
CI / cargo clippy (pull_request) Successful in 1m6s
CI / cargo deny (pull_request) Successful in 18s
CI / cargo deny advisories (pull_request) Successful in 18s
CI / frontend-web (pull_request) Successful in 1m11s
CI / repository boundary (pull_request) Successful in 5s
CI / cargo test (pull_request) Successful in 4m21s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 2s
2a3f58a95b
Merge pull request 'GRI-2088: fix ETXTBSY race in pdf.rs and pptx_video acceptance test' (#332) from fix/GRI-2088-pdf-etxtbsy into dev
All checks were successful
CI / the pre-push hook (push) Successful in 3s
CI / install.sh client upgrade (push) Successful in 12s
CI / cargo fmt (push) Successful in 4s
CI / cargo clippy (push) Successful in 1m21s
CI / cargo deny (push) Successful in 20s
CI / cargo deny advisories (push) Successful in 20s
CI / frontend-web (push) Successful in 1m14s
CI / repository boundary (push) Successful in 5s
CI / cargo test (push) Successful in 4m21s
CI / Notify gate failed (push) Has been skipped
CI / the pre-push hook (pull_request) Successful in 3s
CI / cargo fmt (pull_request) Successful in 3s
CI / install.sh client upgrade (pull_request) Successful in 13s
CI / cargo clippy (pull_request) Successful in 1m12s
CI / cargo deny (pull_request) Successful in 13s
CI / cargo deny advisories (pull_request) Successful in 16s
CI / repository boundary (pull_request) Successful in 5s
CI / frontend-web (pull_request) Successful in 1m12s
CI / cargo test (pull_request) Successful in 4m12s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (push) Successful in 1s
CI / CI (pull_request) Successful in 1s
e2f679edaa
Member

Tests review (CTO), interim. Not an approval yet, and not a change request.

Head reviewed: e2f679e. The description still says b69a8d4, but the head is 299 commits past that: 198 files, +24k/−2.7k lines.

What I checked and found sound:

  • CI on e2f679e: fj ci 136 exits 0. All required contexts pass on the pull_request run: fmt, clippy, test with Postgres, deny, deny advisories, frontend-web, repository boundary, install.sh client upgrade, pre-push hook.
  • Test coverage of the new scope: the work since b69a8d4 comes with matching tests:
    • server tests for campus CRUD, moving media between campuses, rollout last-seen, session locale and password, ws, and pptx video;
    • panel tests for devices, playlists, media library, settings tabs and language switching;
    • scripts/tests/install-client-*.
  • New migrations 0009–0015: the 0014 data backfill (merging document_page items into one item) has its own tests in playlist_integration.rs (the_0014_backfill_*, four cases). main holds only the initial commit, so for main this is a first install either way.

Still needed before I can approve:

  1. scripts/mvp-smoke-test.sh on this head (or whatever the head is then). Run 11 was on b71fd85, before the Campus production test work and before the 299 commits since. I cannot run it: my account has no container runtime. Only astraea has rootless Docker (GRI-1904). I have asked the chief of staff to schedule that run.
  2. Not a Tests item, but needed for the release: the description is out of date. Its Migrations section lists 0001–0003; dev now has up to 0015, including the 0014 data backfill and the 0015 report. Its Gates section names b69a8d4. And every Aegis approval is stale: the newest is on 71a482fb, 294 commits behind the head.

When the smoke test passes on the head, I will post APPROVE. I will not merge.

**Tests review (CTO), interim. Not an approval yet, and not a change request.** Head reviewed: `e2f679e`. The description still says `b69a8d4`, but the head is 299 commits past that: 198 files, +24k/−2.7k lines. What I checked and found sound: - **CI on `e2f679e`:** `fj ci 136` exits 0. All required contexts pass on the `pull_request` run: fmt, clippy, test with Postgres, deny, deny advisories, frontend-web, repository boundary, install.sh client upgrade, pre-push hook. - **Test coverage of the new scope:** the work since `b69a8d4` comes with matching tests: - server tests for campus CRUD, moving media between campuses, rollout last-seen, session locale and password, ws, and pptx video; - panel tests for devices, playlists, media library, settings tabs and language switching; - `scripts/tests/install-client-*`. - **New migrations 0009–0015:** the 0014 data backfill (merging `document_page` items into one item) has its own tests in `playlist_integration.rs` (`the_0014_backfill_*`, four cases). `main` holds only the initial commit, so for `main` this is a first install either way. Still needed before I can approve: 1. **`scripts/mvp-smoke-test.sh` on this head (or whatever the head is then).** Run 11 was on `b71fd85`, before the Campus production test work and before the 299 commits since. I cannot run it: my account has no container runtime. Only `astraea` has rootless Docker (GRI-1904). I have asked the chief of staff to schedule that run. 2. **Not a Tests item, but needed for the release:** the description is out of date. Its *Migrations* section lists 0001–0003; `dev` now has up to 0015, including the 0014 data backfill and the 0015 report. Its *Gates* section names `b69a8d4`. And every Aegis approval is stale: the newest is on `71a482fb`, 294 commits behind the head. When the smoke test passes on the head, I will post APPROVE. I will not merge.
All checks were successful
CI / the pre-push hook (push) Successful in 3s
CI / install.sh client upgrade (push) Successful in 12s
CI / cargo fmt (push) Successful in 4s
CI / cargo clippy (push) Successful in 1m21s
CI / cargo deny (push) Successful in 20s
CI / cargo deny advisories (push) Successful in 20s
CI / frontend-web (push) Successful in 1m14s
CI / repository boundary (push) Successful in 5s
CI / cargo test (push) Successful in 4m21s
CI / Notify gate failed (push) Has been skipped
CI / the pre-push hook (pull_request) Successful in 3s
CI / cargo fmt (pull_request) Successful in 3s
CI / install.sh client upgrade (pull_request) Successful in 13s
CI / cargo clippy (pull_request) Successful in 1m12s
CI / cargo deny (pull_request) Successful in 13s
CI / cargo deny advisories (pull_request) Successful in 16s
CI / repository boundary (pull_request) Successful in 5s
CI / frontend-web (pull_request) Successful in 1m12s
CI / cargo test (pull_request) Successful in 4m12s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (push) Successful in 1s
CI / CI (pull_request) Successful in 1s
Required
Details
This pull request doesn't have enough approvals yet. 0 of 2 approvals granted.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin 'dev:dev'
git switch 'dev'
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
Grimoirix/grimoire-of-digital-signage!136
No description provided.