GRI-2140: split Media into Add media (default) and Media library #272
No reviewers
Labels
No labels
Area/Backend
Area/Database
Area/Docs
Area/Frontend
Area/Infra
Area/Security
Area/Tests
Area/Tooling
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Lang/Python
Lang/Rust
Lang/Shell
Lang/SQL
Lang/TypeScript
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Routing
Auto
Routing
Hold
Routing
Human
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
Grimoirix/grimoire-of-digital-signage!272
Loading…
Reference in a new issue
No description provided.
Delete branch "feature/GRI-2140-media-add-library-split"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Closes #268.
Summary
/media, default) and Media library (/media/library).AddMediaScreenowns upload and Add website; each success stays on the page and links to the library instead of jumping away, so several files can be added one after another. A conversion still running (GRI-2127/#233) shows its progress here too.MediaLibraryScreenowns the list: documents with pages, campus move (#242), expand, delete — unchanged behaviour, just without the upload controls.MediaSectionScreenwires the menu and the fallback: a user with nocontent_uploadpermission sees only Media library, and/mediafalls back to it — same rule asSettingsSectionScreen.useMediaJobPollingso both pages can watch their own in-flight conversions independently.Test plan
npm run check(prettier, oxlint, tsc, vitest) green infrontend-web./scripts/local-gates.sh --frontend-onlygreenMediaSectionScreen.test.tsx)MediaSectionScreen.test.tsx)AddMediaScreen.test.tsx)MediaLibraryScreen.test.tsxChanges requested — one regression on the page the product owner stays on.
The split itself is right:
/mediaopens Add media,/media/libraryis the list, a view-only user falls back to the library, the success row links to the library, and the poller is shared.Blocking: the "Recently added" row on Add media loses two things the old Media page showed, and both were explicit product-owner asks:
<name>: Failed. It must renderFailed to process: <job.errorMessage>(same text asMediaLibraryScreen), as a dismissible error or a danger note.Rendering pages. It must showPage N of M renderedwith the<progress>bar, as the library does.Since he uploads and then stays on Add media (that is the point of #268), this page is where he watches the conversion. Simplest fix: extract the job-status rendering from
MediaLibraryScreeninto one small component and use it on both pages.Please add a test on
AddMediaScreenfor each: a failed job shows the reason, and a rendering job showsPage 2 of 5.Then merge
devin (dev moved with #271) and push.Both points fixed: failure reason (role=alert) and Page N of M with progress bar on Add media, each with a test. Approved. Updating with dev (after #273) for the merge.
New commits pushed, approval review dismissed automatically according to repository settings