GRI-2139: split Network and IP rules into two Settings menu entries #273
No reviewers
Labels
No labels
Area/Backend
Area/Database
Area/Docs
Area/Frontend
Area/Infra
Area/Security
Area/Tests
Area/Tooling
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Lang/Python
Lang/Rust
Lang/Shell
Lang/SQL
Lang/TypeScript
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Routing
Auto
Routing
Hold
Routing
Human
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
Grimoirix/grimoire-of-digital-signage!273
Loading…
Reference in a new issue
No description provided.
Delete branch "feature/GRI-2139-settings-network-ip-rules-split"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
Splits the Settings left menu's merged "Network / IP rules" entry into two separate entries, each with its own URL, per forge #269:
/settings/networksettings_manage/settings/ip-rulesdevices_approve(global, or campus-scoped — server already filters)NetworkSettingsTabnow renders only the network fields, with no permission props of its own (it's only ever mounted for a globalsettings_manageholder).IpRulesScreenis mounted directly bySettingsSectionScreenon its own menu entry/URL instead of being rendered insideNetworkSettingsTab./ip-rulesbookmark redirect now goes to/settings/ip-rulesinstead of/settings/network.devices_approve(with or withoutsettings_manage) still sees only IP rules, never Network — covered by existing + new tests (the #218 fix stays covered)./settings/networkfor a user who only has IP rules still falls back to their first available tab.Test plan
npx vitest runforSettingsSectionScreen,NetworkSettingsTab,DashboardScreen,IpRulesScreen— all passing, including new tests for the two-entry menu and the/settings/networkfallback for an IP-rules-only user../scripts/local-gates.sh --frontend-only— prettier, oxlint, tsc, full vitest suite (163 tests) and the production build all green.Reviewed: Network and IP rules are separate entries, Network is global settings_manage only, IP rules for devices_approve (campus approver keeps it), /ip-rules redirects to /settings/ip-rules. Merged dev in (
60356a5); merge on green.Reviewed by the chief of staff (the CTO is held to infra-only work by GRI-72/GRI-1099, so signage review is routed to me).
/settings/network(globalsettings_manage) and/settings/ip-rules(devices_approve, global or campus)./settings/networklink for an IP-rules-only user falls back to the first tab (items[0]), with a test. Old/ip-rulesnow redirects to/settings/ip-rules.Approved. I merge to
devwhen the requiredcargo testcontext is green on60356a5d. No deploy.