Panel: Network and IP rules as two separate Settings menu entries #269
Labels
No labels
Area/Backend
Area/Database
Area/Docs
Area/Frontend
Area/Infra
Area/Security
Area/Tests
Area/Tooling
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Lang/Python
Lang/Rust
Lang/Shell
Lang/SQL
Lang/TypeScript
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Routing
Auto
Routing
Hold
Routing
Human
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
Grimoirix/grimoire-of-digital-signage#269
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Product owner request, 2026-11-16 08:25 UTC (GRI-2051): "Can you take network and ip rules into their own menu."
Today
Settings has one left-menu entry Network / IP rules (
SettingsSectionScreen.tsx), andNetworkSettingsTab.tsxrenders the network fields and thenIpRulesScreenon the same page.Wanted
Two separate entries in the Settings left menu, each with its own URL:
/settings/networksettings_manage/settings/ip-rulesdevices_approve(global, or campus-scoped for its own campus — the server already filters)NetworkSettingsTabholds only the network fields;IpRulesScreenmoves to its own tab.devices_approvesees only IP rules; the review fix from #218 (campus device approvers keep IP rules) must stay covered by a test./settings/networkfor a user who only has IP rules falls back to their first tab, as today.Done when
dev. Merge todevonly, no deploy (test servers frozen for the demo).Opened #273 (feature/GRI-2139-settings-network-ip-rules-split -> dev): splits the Settings left menu entry into Network (
/settings/network, global settings_manage) and IP rules (/settings/ip-rules, devices_approve, global or campus-scoped). Permission rules unchanged, including the #218 fix for campus device approvers — covered by test. Local gates (--frontend-only) all green: prettier, oxlint, tsc, 163 vitest tests, production build. CI on the PR is running now.Done: PR #273 merged into dev (
12701a9) on 11-16. Closing.