Panel: Network and IP rules as two separate Settings menu entries #269

Closed
opened 2026-11-16 08:29:36 +00:00 by vivy · 2 comments
Owner

Product owner request, 2026-11-16 08:25 UTC (GRI-2051): "Can you take network and ip rules into their own menu."

Today

Settings has one left-menu entry Network / IP rules (SettingsSectionScreen.tsx), and NetworkSettingsTab.tsx renders the network fields and then IpRulesScreen on the same page.

Wanted

Two separate entries in the Settings left menu, each with its own URL:

Menu entry URL Who sees it
Network /settings/network global user with settings_manage
IP rules /settings/ip-rules devices_approve (global, or campus-scoped for its own campus — the server already filters)
  • NetworkSettingsTab holds only the network fields; IpRulesScreen moves to its own tab.
  • Keep the existing permission rules exactly: a campus user with devices_approve sees only IP rules; the review fix from #218 (campus device approvers keep IP rules) must stay covered by a test.
  • An old link to /settings/network for a user who only has IP rules falls back to their first tab, as today.

Done when

  • Two menu entries, two URLs, permissions unchanged, tests for both roles.
  • All gates green, branch up to date with dev. Merge to dev only, no deploy (test servers frozen for the demo).
Product owner request, 2026-11-16 08:25 UTC (GRI-2051): *"Can you take network and ip rules into their own menu."* ## Today Settings has one left-menu entry **Network / IP rules** (`SettingsSectionScreen.tsx`), and `NetworkSettingsTab.tsx` renders the network fields and then `IpRulesScreen` on the same page. ## Wanted Two separate entries in the Settings left menu, each with its own URL: | Menu entry | URL | Who sees it | |---|---|---| | **Network** | `/settings/network` | global user with `settings_manage` | | **IP rules** | `/settings/ip-rules` | `devices_approve` (global, or campus-scoped for its own campus — the server already filters) | - `NetworkSettingsTab` holds only the network fields; `IpRulesScreen` moves to its own tab. - Keep the existing permission rules exactly: a campus user with `devices_approve` sees only **IP rules**; the review fix from #218 (campus device approvers keep IP rules) must stay covered by a test. - An old link to `/settings/network` for a user who only has IP rules falls back to their first tab, as today. ## Done when - Two menu entries, two URLs, permissions unchanged, tests for both roles. - All gates green, branch up to date with `dev`. Merge to `dev` only, no deploy (test servers frozen for the demo).
Member

Opened #273 (feature/GRI-2139-settings-network-ip-rules-split -> dev): splits the Settings left menu entry into Network (/settings/network, global settings_manage) and IP rules (/settings/ip-rules, devices_approve, global or campus-scoped). Permission rules unchanged, including the #218 fix for campus device approvers — covered by test. Local gates (--frontend-only) all green: prettier, oxlint, tsc, 163 vitest tests, production build. CI on the PR is running now.

Opened #273 (feature/GRI-2139-settings-network-ip-rules-split -> dev): splits the Settings left menu entry into Network (`/settings/network`, global settings_manage) and IP rules (`/settings/ip-rules`, devices_approve, global or campus-scoped). Permission rules unchanged, including the #218 fix for campus device approvers — covered by test. Local gates (`--frontend-only`) all green: prettier, oxlint, tsc, 163 vitest tests, production build. CI on the PR is running now.
Author
Owner

Done: PR #273 merged into dev (12701a9) on 11-16. Closing.

Done: PR #273 merged into dev (12701a9) on 11-16. Closing.
vivy closed this issue 2026-11-17 09:18:59 +00:00
Sign in to join this conversation.
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
Grimoirix/grimoire-of-digital-signage#269
No description provided.