GRI-2138: fix approved/pending device card alignment #271

Merged
vivy merged 2 commits from fix/GRI-2138-approved-device-card-alignment into dev 2026-11-16 09:33:14 +00:00
Member

Closes #270.

Summary

  • ApprovedDeviceRow in DevicesScreen.tsx now renders a fixed three-line card: facts (name + tags), settings (campus), and one gx-actions row for Unassign playlist / Refresh / Block. The refresh notice/error moved below the action row, out of the row itself.
  • Pending device rows share the same gx-actions row structure.
  • Added .gx-device-card / .gx-device-card__row CSS so each row keeps a consistent baseline.

Test plan

  • npm run check (prettier, oxlint, tsc, vitest) — 165/165 tests green
  • Added a structural test asserting the approved and pending action buttons share one gx-actions parent
  • Visual check at desktop (1280px) and narrow (380px) widths, with and without a playlist assigned, and after a Refresh click — screenshots below
  • scripts/local-gates.sh --frontend-only passes

desktop
desktop with playlist
desktop refreshed
narrow
narrow with playlist

Closes #270. ## Summary - `ApprovedDeviceRow` in `DevicesScreen.tsx` now renders a fixed three-line card: facts (name + tags), settings (campus), and one `gx-actions` row for Unassign playlist / Refresh / Block. The refresh notice/error moved below the action row, out of the row itself. - Pending device rows share the same `gx-actions` row structure. - Added `.gx-device-card` / `.gx-device-card__row` CSS so each row keeps a consistent baseline. ## Test plan - [x] `npm run check` (prettier, oxlint, tsc, vitest) — 165/165 tests green - [x] Added a structural test asserting the approved and pending action buttons share one `gx-actions` parent - [x] Visual check at desktop (1280px) and narrow (380px) widths, with and without a playlist assigned, and after a Refresh click — screenshots below - [x] `scripts/local-gates.sh --frontend-only` passes ![desktop](https://git.grimoirix.org/attachments/b99a57a3-3e00-4a63-9b51-6dfb2d5e749d) ![desktop with playlist](https://git.grimoirix.org/attachments/8ce9d110-67b2-4706-b387-7f7b9d80ea7a) ![desktop refreshed](https://git.grimoirix.org/attachments/d2ac691d-49f9-4db2-87e2-e08d7627ff04) ![narrow](https://git.grimoirix.org/attachments/384a449f-150a-40c1-a46b-9a3b30bcef13) ![narrow with playlist](https://git.grimoirix.org/attachments/019f0e21-821e-4835-b89a-f524df818e8d)
GRI-2138: fix approved/pending device card alignment
Some checks failed
CI / the pre-push hook (pull_request) Successful in 3s
CI / cargo fmt (pull_request) Successful in 4s
CI / install.sh client upgrade (pull_request) Successful in 12s
CI / cargo clippy (pull_request) Successful in 57s
CI / cargo deny advisories (pull_request) Successful in 19s
CI / repository boundary (pull_request) Successful in 4s
CI / cargo deny (pull_request) Successful in 24s
CI / frontend-web (pull_request) Successful in 1m3s
CI / cargo test (pull_request) Failing after 2m10s
CI / CI (pull_request) Failing after 1s
CI / Notify gate failed (pull_request) Successful in 0s
1f43187b0a
Restructure ApprovedDeviceRow into a fixed three-line card: facts
(name + tags), settings (campus), and one gx-actions row for
Unassign playlist / Refresh / Block. Move the refresh notice/error
below the action row. Pending device rows share the same action row.
GRI-2138: re-run CI (cargo test flake unrelated to this frontend-only change)
All checks were successful
CI / the pre-push hook (pull_request) Successful in 4s
CI / install.sh client upgrade (pull_request) Successful in 19s
CI / cargo fmt (pull_request) Successful in 6s
CI / cargo clippy (pull_request) Successful in 1m26s
CI / cargo deny (pull_request) Successful in 20s
CI / cargo deny advisories (pull_request) Successful in 18s
CI / repository boundary (pull_request) Successful in 4s
CI / frontend-web (pull_request) Successful in 1m12s
CI / cargo test (pull_request) Successful in 3m39s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 1s
d6881d25ba
vivy merged commit 1e8d09c2c5 into dev 2026-11-16 09:33:14 +00:00
vivy deleted branch fix/GRI-2138-approved-device-card-alignment 2026-11-16 09:33:15 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
Grimoirix/grimoire-of-digital-signage!271
No description provided.