Panel: approved device cards are not aligned #270

Closed
opened 2026-11-16 08:29:37 +00:00 by vivy · 0 comments
Owner

Product owner report, 2026-11-16 08:25 UTC (GRI-2051): "the 'approved devices' content is not aligned within itself", with this screenshot:

approved devices

(screenshot: the Name field, then three tags floating at the input's height; on the second line the Campus select, then Refresh and Block — Refresh sits higher than Block and neither lines up with the select.)

Cause

DeviceRow in frontend-web/src/screens/DevicesScreen.tsx puts everything in one wrapping flex row: two gx-field blocks (label + control), three loose gx-tag spans, the Refresh button wrapped in a gx-field with no label, and Block as a bare button. Items of different heights in one row land at different heights.

Wanted

A fixed layout for each approved device card:

  1. Line 1 — facts: name (editable) and the tags (host, token, playlist, rollout status from #228), tags vertically centred against the input.
  2. Line 2 — settings: Campus select (with its label).
  3. Line 3 — actions, in one gx-actions row, bottom-aligned with each other: Unassign playlist, Refresh, Block. All buttons the same height; Block stays the only danger button (#230). The Refresh notice/error goes under the action row, not inside it.

Check the same at a narrow window width — the rows may wrap but every item in a row keeps the same baseline. Pending devices (the list above) should use the same action row.

Done when

  • Screenshot in the PR at desktop and narrow width.
  • Test that the actions render in one action row.
  • All gates green, branch up to date with dev. Merge to dev only, no deploy.
Product owner report, 2026-11-16 08:25 UTC (GRI-2051): *"the 'approved devices' content is not aligned within itself"*, with this screenshot: ![approved devices](https://git.grimoirix.org/attachments/8f0b6a6f-6722-46d8-9705-c68878fbda42) (screenshot: the Name field, then three tags floating at the input's height; on the second line the Campus select, then **Refresh** and **Block** — Refresh sits higher than Block and neither lines up with the select.) ## Cause `DeviceRow` in `frontend-web/src/screens/DevicesScreen.tsx` puts everything in one wrapping flex row: two `gx-field` blocks (label + control), three loose `gx-tag` spans, the Refresh button wrapped in a `gx-field` with no label, and Block as a bare button. Items of different heights in one row land at different heights. ## Wanted A fixed layout for each approved device card: 1. **Line 1 — facts:** name (editable) and the tags (host, token, playlist, rollout status from #228), tags vertically centred against the input. 2. **Line 2 — settings:** Campus select (with its label). 3. **Line 3 — actions**, in one `gx-actions` row, bottom-aligned with each other: Unassign playlist, Refresh, Block. All buttons the same height; Block stays the only danger button (#230). The Refresh notice/error goes under the action row, not inside it. Check the same at a narrow window width — the rows may wrap but every item in a row keeps the same baseline. Pending devices (the list above) should use the same action row. ## Done when - Screenshot in the PR at desktop and narrow width. - Test that the actions render in one action row. - All gates green, branch up to date with `dev`. Merge to `dev` only, no deploy.
vivy closed this issue 2026-11-16 09:33:14 +00:00
Sign in to join this conversation.
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
Grimoirix/grimoire-of-digital-signage#270
No description provided.