Panel: non-destructive buttons are red #230
Labels
No labels
Area/Backend
Area/Database
Area/Docs
Area/Frontend
Area/Infra
Area/Security
Area/Tests
Area/Tooling
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Lang/Python
Lang/Rust
Lang/Shell
Lang/SQL
Lang/TypeScript
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Routing
Auto
Routing
Hold
Routing
Human
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
Grimoirix/grimoire-of-digital-signage#230
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Red must mean a dangerous or permanent action. Today Expand (Media), Edit (Users), Open and Rename (Campuses) are red. They use
gx-btn gx-btn--secondary, a class that is not defined in this repository's CSS, so check what@grimoirix/designdoes with it.Expected: only Delete, Block, Remove and similar are red. Normal actions use the neutral style. A test or a lint that fails when a non-danger button gets the danger style.
Fixed in PR #235 (merged into dev at
c6e41ea4/21eb1be5). Added.gx-btn--neutraland moved every non-destructive action onto it; red (gx-btn--secondary) now reserved for Delete/Block/Remove/Restart.designSystemButtons.test.tslints every .tsx file for this going forward. Closing.