Panel: non-destructive buttons are red #230

Closed
opened 2026-11-15 16:53:08 +00:00 by vivy · 1 comment
Owner

Red must mean a dangerous or permanent action. Today Expand (Media), Edit (Users), Open and Rename (Campuses) are red. They use gx-btn gx-btn--secondary, a class that is not defined in this repository's CSS, so check what @grimoirix/design does with it.

Expected: only Delete, Block, Remove and similar are red. Normal actions use the neutral style. A test or a lint that fails when a non-danger button gets the danger style.

Red must mean a dangerous or permanent action. Today Expand (Media), Edit (Users), Open and Rename (Campuses) are red. They use `gx-btn gx-btn--secondary`, a class that is not defined in this repository's CSS, so check what `@grimoirix/design` does with it. Expected: only Delete, Block, Remove and similar are red. Normal actions use the neutral style. A test or a lint that fails when a non-danger button gets the danger style.
Member

Fixed in PR #235 (merged into dev at c6e41ea4 / 21eb1be5). Added .gx-btn--neutral and moved every non-destructive action onto it; red (gx-btn--secondary) now reserved for Delete/Block/Remove/Restart. designSystemButtons.test.ts lints every .tsx file for this going forward. Closing.

Fixed in PR #235 (merged into dev at c6e41ea4 / 21eb1be5). Added `.gx-btn--neutral` and moved every non-destructive action onto it; red (`gx-btn--secondary`) now reserved for Delete/Block/Remove/Restart. `designSystemButtons.test.ts` lints every .tsx file for this going forward. Closing.
Sign in to join this conversation.
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
Grimoirix/grimoire-of-digital-signage#230
No description provided.