Playlist editor: show which screens show a playlist, assign several at once #156
Labels
No labels
Area/Backend
Area/Database
Area/Docs
Area/Frontend
Area/Infra
Area/Security
Area/Tests
Area/Tooling
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Lang/Python
Lang/Rust
Lang/Shell
Lang/SQL
Lang/TypeScript
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Routing
Auto
Routing
Hold
Routing
Human
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
Grimoirix/grimoire-of-digital-signage#156
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What
Users think they must assign every screen to the playlist again after each change. They do not: a device keeps its playlist, and a saved playlist reaches it by itself. The panel does not say so.
Today
PlaylistEditorScreen.tsxAssignToDeviceForm: one device per click, no list of devices that already show this playlist, and Save gives no hint that devices update automatically.Done when
Field feedback from the product owner on GRI-1960.
Released to prismancer, after the small push follow-up on #155. Hold removed.
Implemented. On
feature/GRI-1972-playlist-editor-assign-multi(not yet pushed, pending local-gates).Backend (
crates/server/src/playlists/{handlers,store}.rs,mod.rs,plan/server/rest-api.md):GET /playlists/{id}now returnsassigned_devices: [{id, name}]— the devices currently showing it.GET /device-playlist-assignments→[{device_id, playlist_id, playlist_name}], every device's current assignment.POST /devices/{device_id}/playlistonce per device, just several times in one click.getting_a_playlist_lists_the_devices_assigned_to_it_by_nameandlisting_device_playlist_assignments_returns_every_devices_current_playlisttoplaylist_integration.rs; full suite (24 tests) green against a real Postgres.Frontend (
frontend-web/src):PlaylistEditorScreen: "Shown on: , …" line;AssignToDeviceFormis now a checkbox list (was a single-select), already-assigned devices read checked and disabled;assignPlaylistToDevicesfires one request per selected device; after Save, "Saved. N devices get the change automatically." (or "no devices yet").DevicesScreen: each approved device's row now has aPlaylist: <name>/Playlist: none assignedtag, from the newGET /device-playlist-assignments.api/types.ts,httpPlaylistsApi.ts,mockPlaylistsApi.ts,playlistsApi.tsupdated for the new shapes on both the real and mock backends.DevicesScreen.test.tsxandPlaylistsScreen.test.tsxfor: no-playlist / has-playlist device rows, multi-select assign, already-assigned checkbox state, and the "Shown on"/"Saved. N devices…" copy.npm run check(prettier + oxlint + tsc + vitest, 37 tests) is green.cargo fmt,cargo clippy -p server --all-targetsclean.Loading/empty/error states: unchanged existing ones still apply (loading spinner, retry-on-error, "no approved devices yet" when the device list is empty); the new "Shown on" line reads "no devices yet." when the list is empty, same pattern as the rest of the screen.
Running the full
./scripts/local-gates.shnow (background); will push once it's green.@prismancer PR #169 now conflicts with dev: #167 (your GRI-1962 fix) also changed crates/server/src/playlists/handlers.rs. Please merge origin/dev into the branch, resolve, and push. CI was green before the conflict, so I merge as soon as it is green again.