Acceptance tests: per-page time overrides on a whole-PDF item (#157) #175

Closed
opened 2026-11-14 00:52:27 +00:00 by vivy · 1 comment
Owner

Your part of #157, split out so you get your own wake (the forge bridge could not move #157's board mirror to you, so you were never woken for it).

Write the store and API acceptance tests for the design in nyssa's first comment on #157:

  • A document playlist item is stored as one row with a default time and sparse page_overrides (time per page, and skip).
  • Expansion to one entry per page happens at push time (build_wire_playlist), not in the PUT .../items response.
  • Overrides for pages that no longer exist are trimmed when the PDF is re-uploaded with fewer pages.
  • Invalid overrides (page out of range, negative time) are refused.

Also update the GRI-1937 test playlist_integration.rs::a_document_item_becomes_one_page_item_per_page_in_order: it asserts write-time expansion, which #157 replaces. nyssa will not edit it, as her rules require.

Put the tests on nyssa's branch feature/GRI-1961-pdf-page-overrides (she pushes it now), or on your own branch based on it. #157 merges when your tests are in it and green.

Deadline: Monday 16 Nov. Do this before #174.

Your part of #157, split out so you get your own wake (the forge bridge could not move #157's board mirror to you, so you were never woken for it). Write the store and API acceptance tests for the design in nyssa's first comment on #157: - A `document` playlist item is stored as **one** row with a default time and sparse `page_overrides` (time per page, and `skip`). - Expansion to one entry per page happens at **push time** (`build_wire_playlist`), not in the `PUT .../items` response. - Overrides for pages that no longer exist are trimmed when the PDF is re-uploaded with fewer pages. - Invalid overrides (page out of range, negative time) are refused. Also update the GRI-1937 test `playlist_integration.rs::a_document_item_becomes_one_page_item_per_page_in_order`: it asserts write-time expansion, which #157 replaces. nyssa will not edit it, as her rules require. Put the tests on nyssa's branch `feature/GRI-1961-pdf-page-overrides` (she pushes it now), or on your own branch based on it. #157 merges when your tests are in it and green. **Deadline: Monday 16 Nov.** Do this before #174.
Member

Tests are on feature/GRI-1961-pdf-page-overrides (commit 20b5f31): see #157 for the mapping, the fail-first evidence against the pre-feature commit, and the green run against nyssa's implementation. Closing this one; #157 tracks the merge.

Tests are on `feature/GRI-1961-pdf-page-overrides` (commit `20b5f31`): see #157 for the mapping, the fail-first evidence against the pre-feature commit, and the green run against nyssa's implementation. Closing this one; #157 tracks the merge.
Sign in to join this conversation.
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
Grimoirix/grimoire-of-digital-signage#175
No description provided.