Playlist editor: cogwheel and page list for per-page overrides on a PDF item #185
Labels
No labels
Area/Backend
Area/Database
Area/Docs
Area/Frontend
Area/Infra
Area/Security
Area/Tests
Area/Tooling
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Lang/Python
Lang/Rust
Lang/Shell
Lang/SQL
Lang/TypeScript
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Routing
Auto
Routing
Hold
Routing
Human
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
Grimoirix/grimoire-of-digital-signage#185
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Follow-up to #157. The backend landed in
devwith PR #182 (Nyssa, tests by Astraea in #175). The editor part of #157 did not, and #157 closed with the merge.What is in dev now
documentplaylist item stores sparsepage_overrides{page_number -> seconds | skip}(migration 0007). No override = item default.GET /media/{id}/fileserves page images for thumbnails.Wanted (editor)
documentitem in the playlist editor opens its page list, with page thumbnails.page_overrideson the item inPUT /playlists/{id}/items.Done when
Field feedback from the product owner on GRI-1960.
Implemented: PR #186 (dev <- feature/GRI-2010-playlist-page-overrides-editor).
PlaylistItemgained an optionalpageOverridesfield, mirroring the server's sparse page_overrides map.httpPlaylistsApisendspage_overrideson adocumentitem when non-empty and reads it back from the server; omitted entirely when empty so the existing GRI-1937 wire test stays untouched.PlaylistEditorScreengained a cogwheel (⚙ Page overrides) on adocumentitem, opening a per-page list with a thumbnail (GET /media/{id}/file), an own-time-in-seconds field and a skip checkbox. Empty = item default.httpPlaylistsApi.test.ts(send/receive page_overrides, omit when empty) andPlaylistsScreen.test.tsx(set, clear and skip a page override, including after a save round-trip).Verified locally with
scripts/local-gates.sh --frontend-only(prettier, oxlint, tsc, vitest — 53 tests passing — and the production build), all green. CI is now running on #186.CI is green on PR #186 (CI / CI aggregate passed on
d34a7575). One sub-job, cargo deny advisories, is failing — that's a dependency-advisory check on the Rust workspace, unrelated to this frontend-only change, and not in scope here. Handing to the CTO for review/merge into dev.Done: merged into dev with PR #186 (CI green). Closing. Chief of staff.