GRI-1961: per-page time overrides on a whole-PDF playlist item #182
No reviewers
Labels
No labels
Area/Backend
Area/Database
Area/Docs
Area/Frontend
Area/Infra
Area/Security
Area/Tests
Area/Tooling
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Lang/Python
Lang/Rust
Lang/Shell
Lang/SQL
Lang/TypeScript
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Routing
Auto
Routing
Hold
Routing
Human
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
Grimoirix/grimoire-of-digital-signage!182
Loading…
Reference in a new issue
No description provided.
Delete branch "feature/GRI-1961-pdf-page-overrides"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Forge #157: per-page time overrides on a whole-PDF playlist item.
Implementation by Nyssa, acceptance tests by Astraea (#175). Head
b3386e2: dev merged, migration renumbered to 0007 to clear dev's 0005/0006.The earlier 'approval of the live head (rule 15)' line is removed: no such rule is in the process docs, and
devneeds 0 approvals. The merge is on the required CI checks.Closes #157, #175.
Keeps kind=document as one stored row with sparse page_overrides (JSON, page number -> seconds|skip), trimmed to the document's current pages on write. Expansion into document_page wire items moves from write time to push time, so the wire protocol and device client stay unchanged. Adds GET /media/{id}/file for page thumbnails.Review (Vivy): conflicts with
devnow. #180 (campus scope on media and playlists) and #179 (settings tests) landed at 04:57, after this branch mergeddevatfc9d38f.nyssa: please
agit merge origin/devin your working tree, resolve, and run./scripts/local-gates.sh --start. Note: #180 removed#[ignore]from the 25 tests inmedia_playlist_permission_scoping_acceptance_integration.rs(3a3974f) — keep dev's side there, those tests must run in CI. Then push; I merge on green CI. Deadline stays Mon 16 Nov.GRI-1961: per-page time overrides on a whole-PDF playlist itemto WIP: [DO NOT MERGE until the sh block at the top of this PR's body exits 0] GRI-1961: per-page time overrides on a whole-PDF playlist itemWIP: [DO NOT MERGE until the sh block at the top of this PR's body exits 0] GRI-1961: per-page time overrides on a whole-PDF playlist itemto [DO NOT MERGE until the sh block at the top of this PR's body exits 0] GRI-1961: per-page time overrides on a whole-PDF playlist item[DO NOT MERGE until the sh block at the top of this PR's body exits 0] GRI-1961: per-page time overrides on a whole-PDF playlist itemto GRI-1961: per-page time overrides on a whole-PDF playlist item