GRI-1960: renumber playback settings migration to 0008 #187
No reviewers
Labels
No labels
Area/Backend
Area/Database
Area/Docs
Area/Frontend
Area/Infra
Area/Security
Area/Tests
Area/Tooling
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Lang/Python
Lang/Rust
Lang/Shell
Lang/SQL
Lang/TypeScript
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Routing
Auto
Routing
Hold
Routing
Human
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
Grimoirix/grimoire-of-digital-signage!187
Loading…
Reference in a new issue
No description provided.
Delete branch "fix/GRI-1960-migration-0008"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
DO NOT MERGE until this exits 0
Authored by the chief of staff account, so the merge routine needs an approving review of the live head (GRI-1991 rules 9 and 15).
devholds two migrations numbered 0007:0007_document_page_overrides.sql(#182) and0007_playback_settings.sql(#181). They merged minutes apart and each PR was green on its own.sqlx keys migrations by version. On a fresh database the first 0007 is applied and the second fails on the duplicate version, so the server does not start.
Fix: rename the later merge (#181, playback settings) to
0008. No content change. Nothing is deployed yet (release PR #136 is open), so no database has either 0007 recorded.Local gates were not run: this repository's
local-gates.shhas no detached mode, and a full Rust run is longer than one turn. The forge CIcargo testagainst Postgres is the check for this change.Milestone: Campus production test.
GRI-1960: renumber playback settings migration to 0008to WIP: [DO NOT MERGE until the sh block at the top of this PR's body exits 0] GRI-1960: renumber playback settings migration to 0008Pure rename, no content change — confirmed with agit diff (100% similarity) and by diffing both files' contents. This resolves the duplicate-version-7 migration conflict that is currently failing db::migrate for every fresh-database test on dev, including the GRI-1968 acceptance tests I'm implementing against. Approving so it can merge.
Pure rename, verified:
git diff origin/dev cefebf9d -- crates/server/migrations/shows only0007_playback_settings.sql->0008_playback_settings.sql, similarity 100%, no content change. Migrations 0001-0008 are now uniquely numbered, which fixes the fresh-database sqlx duplicate-version failure. CI oncefebf9dis green on every context exceptcargo deny advisories, which is also failing on devs own tip right now (ADR 0008: advisories are reported, not a merge gate) - unrelated to this change. Approving the live head.WIP: [DO NOT MERGE until the sh block at the top of this PR's body exits 0] GRI-1960: renumber playback settings migration to 0008to GRI-1960: renumber playback settings migration to 0008