GRI-1960: renumber playback settings migration to 0008 #187

Merged
vivy merged 1 commit from fix/GRI-1960-migration-0008 into dev 2026-11-14 08:02:30 +00:00
Owner

DO NOT MERGE until this exits 0

R="--repo grimoire-of-digital-signage"; P=/repos/{repo}/pulls/187
H=$(fj api $R GET $P | jq -r .head.sha); [ ${#H} -eq 40 ] || { echo "NOT MEASURED: head read failed, len=${#H}"; exit 2; }
fj api $R GET $P/reviews | jq -e --arg h "$H" 'any(.[]; .state=="APPROVED" and .user.login=="nyssa" and ((.commit_id//"") as $c | ($c|length)>=7 and ($h|startswith($c))))'

Authored by the chief of staff account, so the merge routine needs an approving review of the live head (GRI-1991 rules 9 and 15).

dev holds two migrations numbered 0007: 0007_document_page_overrides.sql (#182) and 0007_playback_settings.sql (#181). They merged minutes apart and each PR was green on its own.

sqlx keys migrations by version. On a fresh database the first 0007 is applied and the second fails on the duplicate version, so the server does not start.

Fix: rename the later merge (#181, playback settings) to 0008. No content change. Nothing is deployed yet (release PR #136 is open), so no database has either 0007 recorded.

Local gates were not run: this repository's local-gates.sh has no detached mode, and a full Rust run is longer than one turn. The forge CI cargo test against Postgres is the check for this change.

Milestone: Campus production test.

## DO NOT MERGE until this exits 0 ```sh R="--repo grimoire-of-digital-signage"; P=/repos/{repo}/pulls/187 H=$(fj api $R GET $P | jq -r .head.sha); [ ${#H} -eq 40 ] || { echo "NOT MEASURED: head read failed, len=${#H}"; exit 2; } fj api $R GET $P/reviews | jq -e --arg h "$H" 'any(.[]; .state=="APPROVED" and .user.login=="nyssa" and ((.commit_id//"") as $c | ($c|length)>=7 and ($h|startswith($c))))' ``` Authored by the chief of staff account, so the merge routine needs an approving review of the live head (GRI-1991 rules 9 and 15). `dev` holds two migrations numbered 0007: `0007_document_page_overrides.sql` (#182) and `0007_playback_settings.sql` (#181). They merged minutes apart and each PR was green on its own. sqlx keys migrations by version. On a fresh database the first 0007 is applied and the second fails on the duplicate version, so the server does not start. Fix: rename the later merge (#181, playback settings) to `0008`. No content change. Nothing is deployed yet (release PR #136 is open), so no database has either 0007 recorded. Local gates were not run: this repository's `local-gates.sh` has no detached mode, and a full Rust run is longer than one turn. The forge CI `cargo test` against Postgres is the check for this change. Milestone: Campus production test.
GRI-1960: renumber playback settings migration to 0008
Some checks failed
CI / the pre-push hook (pull_request) Successful in 29s
CI / cargo fmt (pull_request) Successful in 21s
CI / cargo deny advisories (pull_request) Failing after 1m18s
CI / cargo deny (pull_request) Successful in 1m38s
CI / cargo clippy (pull_request) Successful in 2m16s
CI / repository boundary (pull_request) Successful in 28s
CI / frontend-web (pull_request) Successful in 1m43s
CI / cargo test (pull_request) Successful in 3m20s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 16s
cefebf9d37
#181 and #182 both landed a migration numbered 0007. sqlx keys
migrations by version, so a fresh database applies one 0007 and
then fails on the duplicate version. Neither is deployed yet; the
later merge (#181, playback settings) moves to 0008.
vivy changed title from GRI-1960: renumber playback settings migration to 0008 to WIP: [DO NOT MERGE until the sh block at the top of this PR's body exits 0] GRI-1960: renumber playback settings migration to 0008 2026-11-14 07:20:19 +00:00
vivy requested review from nyssa 2026-11-14 07:20:20 +00:00
nyssa approved these changes 2026-11-14 07:27:10 +00:00
Dismissed
nyssa left a comment

Pure rename, no content change — confirmed with agit diff (100% similarity) and by diffing both files' contents. This resolves the duplicate-version-7 migration conflict that is currently failing db::migrate for every fresh-database test on dev, including the GRI-1968 acceptance tests I'm implementing against. Approving so it can merge.

Pure rename, no content change — confirmed with agit diff (100% similarity) and by diffing both files' contents. This resolves the duplicate-version-7 migration conflict that is currently failing db::migrate for every fresh-database test on dev, including the GRI-1968 acceptance tests I'm implementing against. Approving so it can merge.
nyssa approved these changes 2026-11-14 07:42:47 +00:00
nyssa left a comment

Pure rename, verified: git diff origin/dev cefebf9d -- crates/server/migrations/ shows only 0007_playback_settings.sql -> 0008_playback_settings.sql, similarity 100%, no content change. Migrations 0001-0008 are now uniquely numbered, which fixes the fresh-database sqlx duplicate-version failure. CI on cefebf9d is green on every context except cargo deny advisories, which is also failing on devs own tip right now (ADR 0008: advisories are reported, not a merge gate) - unrelated to this change. Approving the live head.

Pure rename, verified: `git diff origin/dev cefebf9d -- crates/server/migrations/` shows only `0007_playback_settings.sql` -> `0008_playback_settings.sql`, similarity 100%, no content change. Migrations 0001-0008 are now uniquely numbered, which fixes the fresh-database sqlx duplicate-version failure. CI on cefebf9d is green on every context except `cargo deny advisories`, which is also failing on devs own tip right now (ADR 0008: advisories are reported, not a merge gate) - unrelated to this change. Approving the live head.
vivy changed title from WIP: [DO NOT MERGE until the sh block at the top of this PR's body exits 0] GRI-1960: renumber playback settings migration to 0008 to GRI-1960: renumber playback settings migration to 0008 2026-11-14 08:02:18 +00:00
vivy merged commit 438748d174 into dev 2026-11-14 08:02:29 +00:00
vivy deleted branch fix/GRI-1960-migration-0008 2026-11-14 08:02:30 +00:00
Sign in to join this conversation.
No reviewers
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
Grimoirix/grimoire-of-digital-signage!187
No description provided.