GRI-2010: playlist editor cogwheel and page list for per-page overrides #186

Merged
vivy merged 1 commit from feature/GRI-2010-playlist-page-overrides-editor into dev 2026-11-14 07:02:05 +00:00
Member

Follow-up to #157/#182. GRI-2010.

What changed

  • PlaylistItem gained an optional pageOverrides field (sparse,
    keyed by page number as a string, {seconds} or {skip: true}),
    matching the server's wire shape directly.
  • httpPlaylistsApi: a document item's page_overrides is sent on
    PUT /playlists/{id}/items when non-empty, and read back from
    GET/PUT responses. Omitted entirely when there is nothing to
    send, so the existing GRI-1937 wire-shape test is untouched.
  • PlaylistEditorScreen: a document item now shows a "⚙ Page
    overrides" button. It opens a page list — one row per page, each
    with a thumbnail (GET /media/{id}/file), an "Own time (seconds)"
    field and a "Skip this page" checkbox. Empty field and unchecked
    skip both mean the item's own default time.

Tests

  • httpPlaylistsApi.test.ts: a document item's page overrides are
    sent and read back; a document item with no overrides sends no
    page_overrides key at all.
  • PlaylistsScreen.test.tsx: set, clear and skip a page override
    through the cogwheel, including after a save round-trip through the
    (mock) API.

Verified

  • scripts/local-gates.sh --frontend-only: prettier, oxlint, tsc,
    vitest (53 tests, all passing) and the production build all green.
    No Rust files touched, so the Rust gates were not re-run locally —
    CI runs the full suite on the pull request regardless.
Follow-up to #157/#182. GRI-2010. ## What changed - `PlaylistItem` gained an optional `pageOverrides` field (sparse, keyed by page number as a string, `{seconds}` or `{skip: true}`), matching the server's wire shape directly. - `httpPlaylistsApi`: a `document` item's `page_overrides` is sent on `PUT /playlists/{id}/items` when non-empty, and read back from `GET`/`PUT` responses. Omitted entirely when there is nothing to send, so the existing GRI-1937 wire-shape test is untouched. - `PlaylistEditorScreen`: a `document` item now shows a "⚙ Page overrides" button. It opens a page list — one row per page, each with a thumbnail (`GET /media/{id}/file`), an "Own time (seconds)" field and a "Skip this page" checkbox. Empty field and unchecked skip both mean the item's own default time. ## Tests - `httpPlaylistsApi.test.ts`: a document item's page overrides are sent and read back; a document item with no overrides sends no `page_overrides` key at all. - `PlaylistsScreen.test.tsx`: set, clear and skip a page override through the cogwheel, including after a save round-trip through the (mock) API. ## Verified - `scripts/local-gates.sh --frontend-only`: prettier, oxlint, tsc, vitest (53 tests, all passing) and the production build all green. No Rust files touched, so the Rust gates were not re-run locally — CI runs the full suite on the pull request regardless.
GRI-2010: playlist editor cogwheel and page list for document page overrides
Some checks failed
CI / the pre-push hook (pull_request) Successful in 8s
CI / cargo fmt (pull_request) Successful in 9s
CI / cargo deny advisories (pull_request) Failing after 1m17s
CI / cargo deny (pull_request) Successful in 1m17s
CI / cargo clippy (pull_request) Successful in 1m54s
CI / repository boundary (pull_request) Successful in 36s
CI / frontend-web (pull_request) Successful in 1m30s
CI / cargo test (pull_request) Successful in 3m5s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 3s
d34a757520
Adds a cogwheel on a document item in the playlist editor that opens its
page list, with thumbnails from GET /media/{id}/file. Per page: own time
in seconds or skip, empty meaning the item's default. Save sends
page_overrides on the item in PUT /playlists/{id}/items (signage#185,
follow-up to #157/#182).
vivy merged commit 32e78a64e1 into dev 2026-11-14 07:02:05 +00:00
vivy deleted branch feature/GRI-2010-playlist-page-overrides-editor 2026-11-14 07:02:06 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
Grimoirix/grimoire-of-digital-signage!186
No description provided.