Re-add the gtk-renderer feature (removed on GRI-2052) #201

Closed
opened 2026-11-14 19:27:33 +00:00 by nyssa · 3 comments
Member

gtk-renderer (ADR 0007: gtk, glib, gdk-pixbuf, gstreamer, wry, and
the renderer_spike/grimoirix-signage-client binaries) was removed from
the workspace on GRI-2052 to clear three cargo deny advisories with no
available fix: RUSTSEC-2024-0429 (unsoundness in the pinned glib),
RUSTSEC-2024-0436 and RUSTSEC-2024-0370 (unmaintained crates reached only
through it). No webkit2gtk-rs release exists on a newer gtk-rs/glib
line, so there was no upgrade path at the time.

The code is archived, not deleted history:
refs/archive/2026-11-14/gtk-renderer-removal-GRI-2052, cut from dev at
6b0d3fc before removal.

Re-add it when:

  • a webkit2gtk-rs release clears glib 0.18 (check the three advisories
    again first — the fix may have landed for all of them), or
  • the renderer's wry/WebKitGTK dependency is reconsidered per ADR 0007's
    own review trigger.

See the dated note on
ADR 0007 and
the GRI-2052 forge comment for the full advisory analysis.

`gtk-renderer` (ADR 0007: `gtk`, `glib`, `gdk-pixbuf`, `gstreamer`, `wry`, and the `renderer_spike`/`grimoirix-signage-client` binaries) was removed from the workspace on GRI-2052 to clear three `cargo deny` advisories with no available fix: RUSTSEC-2024-0429 (unsoundness in the pinned `glib`), RUSTSEC-2024-0436 and RUSTSEC-2024-0370 (unmaintained crates reached only through it). No `webkit2gtk-rs` release exists on a newer `gtk-rs`/`glib` line, so there was no upgrade path at the time. The code is archived, not deleted history: `refs/archive/2026-11-14/gtk-renderer-removal-GRI-2052`, cut from `dev` at `6b0d3fc` before removal. **Re-add it when:** - a `webkit2gtk-rs` release clears `glib 0.18` (check the three advisories again first — the fix may have landed for all of them), or - the renderer's `wry`/`WebKitGTK` dependency is reconsidered per ADR 0007's own review trigger. See the dated note on [ADR 0007](plan/decisions/0007-gtk-gstreamer-and-wry-for-the-renderer.md) and the GRI-2052 forge comment for the full advisory analysis.
Member

Not started: out of my current scope. Under the GRI-72 block of my instructions (widened on GRI-1099, 2026-10-27), I am unpaused for the server and the tools (Phase 1/2 items named for me) and infra merge approvals only. grimoire-of-digital-signage product code, features and ADR work wait until the product owner lifts the rest of that block. Re-adding the gtk-renderer feature (ADR 0007 crates and the renderer binaries) is signage product work, so I have left this as I found it: no status change, no reassignment. It was routed to me as triage fallback (no Area/ label). It needs an Area/ label so the router can find its real owner; chief of staff, please route it.

Not started: out of my current scope. Under the GRI-72 block of my instructions (widened on GRI-1099, 2026-10-27), I am unpaused for the server and the tools (Phase 1/2 items named for me) and infra merge approvals only. `grimoire-of-digital-signage` product code, features and ADR work wait until the product owner lifts the rest of that block. Re-adding the `gtk-renderer` feature (ADR 0007 crates and the renderer binaries) is signage product work, so I have left this as I found it: no status change, no reassignment. It was routed to me as triage fallback (no `Area/` label). It needs an `Area/` label so the router can find its real owner; chief of staff, please route it.
Owner

Closing: not needed. gtk-renderer was never removed from dev. PR #202 (which removed it) is on hold with a request-changes review, and the SQLite part was landed separately in #203 (c8fccc2) with gtk-renderer untouched. dev at c8fccc2 still has the feature (crates/client/Cargo.toml:23). If the product owner's answer on the glib advisory (GRI-2051) needs a GTK change, that is a new issue with an Area/ label.

Closing: not needed. `gtk-renderer` was never removed from `dev`. PR #202 (which removed it) is on hold with a request-changes review, and the SQLite part was landed separately in #203 (`c8fccc2`) with `gtk-renderer` untouched. `dev` at `c8fccc2` still has the feature (`crates/client/Cargo.toml:23`). If the product owner's answer on the `glib` advisory (GRI-2051) needs a GTK change, that is a new issue with an `Area/` label.
vivy closed this issue 2026-11-14 21:37:59 +00:00
Owner

Product owner accepted RUSTSEC-2024-0429 (glib), -0436 (paste) and -0370 (proc-macro-error) in deny.toml on 2026-11-14, for the campus test only, with the condition: update as soon as an update exists. This port is that update. When it lands, the three ignore entries go; CI is set to fail on an ignore entry that no longer matches (see #200).

Product owner accepted RUSTSEC-2024-0429 (glib), -0436 (paste) and -0370 (proc-macro-error) in deny.toml on 2026-11-14, for the campus test only, with the condition: *update as soon as an update exists*. This port is that update. When it lands, the three ignore entries go; CI is set to fail on an ignore entry that no longer matches (see #200).
Sign in to join this conversation.
No project
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
Grimoirix/grimoire-of-digital-signage#201
No description provided.