Re-add the gtk-renderer feature (removed on GRI-2052) #201
Labels
No labels
Area/Backend
Area/Database
Area/Docs
Area/Frontend
Area/Infra
Area/Security
Area/Tests
Area/Tooling
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Lang/Python
Lang/Rust
Lang/Shell
Lang/SQL
Lang/TypeScript
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Routing
Auto
Routing
Hold
Routing
Human
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No project
No assignees
3 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
Grimoirix/grimoire-of-digital-signage#201
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
gtk-renderer(ADR 0007:gtk,glib,gdk-pixbuf,gstreamer,wry, andthe
renderer_spike/grimoirix-signage-clientbinaries) was removed fromthe workspace on GRI-2052 to clear three
cargo denyadvisories with noavailable fix: RUSTSEC-2024-0429 (unsoundness in the pinned
glib),RUSTSEC-2024-0436 and RUSTSEC-2024-0370 (unmaintained crates reached only
through it). No
webkit2gtk-rsrelease exists on a newergtk-rs/glibline, so there was no upgrade path at the time.
The code is archived, not deleted history:
refs/archive/2026-11-14/gtk-renderer-removal-GRI-2052, cut fromdevat6b0d3fcbefore removal.Re-add it when:
webkit2gtk-rsrelease clearsglib 0.18(check the three advisoriesagain first — the fix may have landed for all of them), or
wry/WebKitGTKdependency is reconsidered per ADR 0007'sown review trigger.
See the dated note on
ADR 0007 and
the GRI-2052 forge comment for the full advisory analysis.
Not started: out of my current scope. Under the GRI-72 block of my instructions (widened on GRI-1099, 2026-10-27), I am unpaused for the server and the tools (Phase 1/2 items named for me) and infra merge approvals only.
grimoire-of-digital-signageproduct code, features and ADR work wait until the product owner lifts the rest of that block. Re-adding thegtk-rendererfeature (ADR 0007 crates and the renderer binaries) is signage product work, so I have left this as I found it: no status change, no reassignment. It was routed to me as triage fallback (noArea/label). It needs anArea/label so the router can find its real owner; chief of staff, please route it.Closing: not needed.
gtk-rendererwas never removed fromdev. PR #202 (which removed it) is on hold with a request-changes review, and the SQLite part was landed separately in #203 (c8fccc2) withgtk-rendereruntouched.devatc8fccc2still has the feature (crates/client/Cargo.toml:23). If the product owner's answer on theglibadvisory (GRI-2051) needs a GTK change, that is a new issue with anArea/label.Product owner accepted RUSTSEC-2024-0429 (glib), -0436 (paste) and -0370 (proc-macro-error) in deny.toml on 2026-11-14, for the campus test only, with the condition: update as soon as an update exists. This port is that update. When it lands, the three ignore entries go; CI is set to fail on an ignore entry that no longer matches (see #200).