GRI-2052: keep gtk-renderer, accept the three advisories with a dated reason #202
No reviewers
Labels
No labels
Area/Backend
Area/Database
Area/Docs
Area/Frontend
Area/Infra
Area/Security
Area/Tests
Area/Tooling
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Lang/Python
Lang/Rust
Lang/Shell
Lang/SQL
Lang/TypeScript
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Routing
Auto
Routing
Hold
Routing
Human
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
Grimoirix/grimoire-of-digital-signage!202
Loading…
Reference in a new issue
No description provided.
Delete branch "security/GRI-2052-cargo-deny-advisories"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Closes forge #200.
Summary
devwas red oncargo deny check advisories(four RUSTSEC advisories). Theproduct owner's rule evolved twice on forge #200/#201/#2051 — the final
decision (GRI-2051, 23:15 UTC, his words): "Because our code does not call
that security risk, I will allow it for this. But as soon as there is a
update, you need to update it."
sqlx'ssqlitefeature):already cleared on
devby #203 — the client's state(
crates/client/src/state.rs) is one JSON file, written through atemporary file and renamed into place for an atomic replace. No change
here.
glibunsoundness,VariantStrIter),RUSTSEC-2024-0436 (
paste, unmaintained) and RUSTSEC-2024-0370(
proc-macro-error, unmaintained), all reached only throughgtk-renderer: no fix exists upstream. An earlier version of this PRmoved the whole
gtk-rendererstack out of the workspace, which wouldhave dropped
grimoirix-signage-client— the full-screen player the.debinstalls and the campus production test needs. Per the productowner's final call,
gtk-rendererstays, and all three advisories areaccepted in
deny.tomlwith a dated reason (2026-11-14) and a link toforge #201, which tracks the removal condition for each.
cargo deny check advisories -D advisory-not-detectedis now therequired, blocking gate in CI and in
scripts/local-gates.sh(no morecontinue-on-error).-D advisory-not-detectedturns cargo-deny's lintfor "an
ignoreentry that no longer matches any reported advisory" intoan error, so the day a fix lands for one of the three, the entry stops
matching and the gate goes red until it is removed — enforced by the
gate, not by memory. Proved locally: added a fake
ignoreentry, ran thecheck, got
error[advisory-not-detected]/advisories FAILED; removedit and confirmed clean again.
amendment recording this exception and its enforcement.
Test plan
cargo deny check -D advisory-not-detected—advisories ok, bans ok, licenses ok, sources okignoreentry fails witherror[advisory-not-detected];removed, confirmed clean
cargo check --workspace --all-targets --features client/gtk-renderer— clean,
gtk-rendererbuildscargo test --workspace --all-targets --lockedandcargo test --workspace --doc --locked— passedcargo clippy --workspace --all-targets --locked -- -D warnings—clean
cargo fmt --all --check— clean./scripts/local-gates.sh --rust-only— every gate passedrepo-boundary --staged— every path belongsCI verdict:
fj ci 202Hold — do not merge. The advisory work is right and
ignore = []is right, but this PR removes the production client.grimoirix-signage-client(src/bin/grimoirix_signage_client.rs) is the full-screen player the.debinstalls, and it was behindgtk-renderer. With this PR,package-client-deb.shandmvp-smoke-test.shexit 1. The campus test (#29) would have no player to install. The direction I gave on #200 assumedgtk-rendererwas dev-only; that was wrong, and the fault is mine, not the author's.The JSON state file instead of SQLite is fine as a change, and the CI change (advisories blocking, in
cineeds) is fine.What happens to the
glib/paste/proc-macro-errorpart is a product-owner decision, asked on GRI-2051. Until he answers, leave this PR open as it is.Held — do not merge. This PR removes the screen player itself, not a spike.
gtk-renderergates the binarygrimoirix-signage-client(crates/client/Cargo.toml:32-35ondev).scripts/package-client-deb.sh:32builds exactly that binary into the.deb, andinstall.sh:110/425installs that.debon each display. There is no other player in the tree (no browser/kiosk path). So after this PR the campus mini PCs have nothing to run, and #29 (on-device acceptance) and the release #136 cannot happen.The claim on #200 that
gtk-rendereris "not part of the campus deploy" was wrong, and I relayed it into the plan without checking. My mistake, not Nyssa's.The JSON-file state for RUSTSEC-2026-0459 looks like a sound answer on its own. The
glibpart needs a product-owner decision; question is on #200.GRI-2052: clear the four cargo-deny advisories blocking devto WIP: [DO NOT MERGE until the product owner answers the glib/paste/proc-macro-error question on forge #200] GRI-2052: clear the four cargo-deny advisories blocking devWIP: [DO NOT MERGE until the product owner answers the glib/paste/proc-macro-error question on forge #200] GRI-2052: clear the four cargo-deny advisories blocking devto GRI-2052: keep gtk-renderer, accept the three advisories with a dated reasonApproved on
ec8c3956. My hold is resolved:gtk-rendererand both binaries are back (client Cargo.toml identical to dev), deny.toml ignores exactly RUSTSEC-2024-0429/0436/0370 with dated reasons and #201, advisories job has no continue-on-error and runs with-D advisory-not-detected(proved with a fake entry per GRI-2052). Six required contexts green. Note: Cargo.lock also carries transitive bumps (wry 0.57.2, dom_query 0.29, rustls-webpki 0.103.17, …) from the earlier commit; tests green, accepted.