GRI-2052: drop SQLite from the client to clear RUSTSEC-2026-0459 #203
No reviewers
Labels
No labels
Area/Backend
Area/Database
Area/Docs
Area/Frontend
Area/Infra
Area/Security
Area/Tests
Area/Tooling
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Lang/Python
Lang/Rust
Lang/Shell
Lang/SQL
Lang/TypeScript
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Routing
Auto
Routing
Hold
Routing
Human
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
Grimoirix/grimoire-of-digital-signage!203
Loading…
Reference in a new issue
No description provided.
Delete branch "fix/GRI-2052-client-state-json"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Splits the SQLite part off GRI-2052 into its own PR, per the chief of staff's direction on the forge issue: the gtk-renderer / advisories-blocking decision is still waiting on the product owner, but this part is needed whatever he decides.
What this does
Clears RUSTSEC-2026-0459 (bundled SQLite CVE in
libsqlite3-sys, pulled in throughsqlx'ssqlitefeature on the client) by dropping SQLite from the client entirely for this release:crates/client/src/state.rs: the client's device state (client.db) is now one JSON document, written through a temporary file and renamed into place for an atomic replace, instead of asqlx/SQLitedatabase. Public API (Store::open,Store::update) is unchanged, so every caller — including thegtk-renderer-gated binaries — needs no changes.crates/client/Cargo.toml: dropssqlxwith thesqlitefeature;tempfilemoves from dev-dependencies to a regular dependency for the atomic-replace temp file.gtk-renderer, its feature flag, and its two binaries are untouched.crates/client/migrations/0001_device_state.sql: removed — there is no database to migrate any more.deny.toml: replaces the singlerusqliteban with two bans (sqlx-sqliteandrusqlite), each explaining why neither can be used here — a realCargo.lockresolver conflict betweenlibsqlite3-sysversions, not a style preference. Reproduction is in the GRI-2052 forge comment.plan/decisions/0003-postgres-on-the-server-sqlite-on-the-client.md: dated note explaining the SQLite part of this ADR is paused, not reversed, and why.plan/client/offline-first.md: updated to describe the state file as JSON instead of a SQLite schema.What this deliberately does not touch
gtk-renderer,grimoirix-signage-client,renderer_spike,keep_awake, the renderer modules — all untouched. The campus production test still gets its full-screen player..github/workflows/ci.yml/scripts/local-gates.shadvisories handling —advisoriesstayscontinue-on-error: trueas it is ondev. Whether it blocks a merge is the product owner's call on GRI-2051/ADR 0013, not part of this PR.deny.toml's[advisories] ignorelist — still empty. The three remaining advisories (glib unsoundness,paste/proc-macro-errorunmaintained) are untouched and still entangled withgtk-renderer; they are not part of this PR.Verification
cargo check -p clientandcargo check -p client --features gtk-rendererboth build clean.cargo test -p client --lib state::— 11/11 pass.cargo fmt --check -p clientclean;cargo clippy -p client --all-targets -- -D warningsclean.cargo deny check advisories— RUSTSEC-2026-0459 no longer appears; the three pre-existing gtk-renderer-related advisories remain (expected, out of scope here).cargo deny check banspasses — the newsqlx-sqlite/rusqlitebans do not fire../scripts/local-gates.sh --rust-onlyrun in full.repo-boundary --stagedclean.