GRI-2133: render in-slide build steps, flag unsupported effects #296
No reviewers
Labels
No labels
Area/Backend
Area/Database
Area/Docs
Area/Frontend
Area/Infra
Area/Security
Area/Tests
Area/Tooling
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Lang/Python
Lang/Rust
Lang/Shell
Lang/SQL
Lang/TypeScript
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Routing
Auto
Routing
Hold
Routing
Human
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
Grimoirix/grimoire-of-digital-signage!296
Loading…
Reference in a new issue
No description provided.
Delete branch "feature/GRI-2133-pptx-object-animations"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What
forge #197: "PowerPoint: play animations inside slides (object animations)".
Implements against both acceptance tests landed on GRI-2156/dev:
a_deck_with_object_animations_shows_its_build_steps_over_time(
crates/server/src/pptx_video.rs, ignored — needs realsoffice/pdftoppm/ffmpeg, not installed on this dev box).
the_189_upload_note_is_removed_only_for_a_fully_supported_deck(
crates/server/tests/pptx_video_acceptance_integration.rs, nowunignored — runs with the fake soffice/pdftoppm/ffmpeg trio, passes).
How
<p:timing>tree is parsed into an ordered list ofclick effects (
ClickEffect):Entrance/Exit/Emphasis/Path, orUnsupported { tag }for anything this cannot render (apresetClass="media"Play Sound/Video trigger, an unrecognised
presetClass, or a motion paththat isn't a straight line).
one: for each step, the whole
.pptxis copied with that slide's XMLrewritten (entering/exited shapes removed, an unplayed motion path's
shape shifted back to its pre-move position) and every other slide
forced
show="0", then run through the existingrender_fallback_pages(soffice/pdftoppm) pipeline to get one PNG.Timelineis generalised (build_expanded) to splice these frames intothe
ffmpeg xfadejoin: hard cuts between build-step frames of the sameslide, the normal transition only at slide boundaries.
join_slides_into_mp4now returnsResult<Vec<String>, PptxVideoError>— the deck-level unsupported-effect tags (empty when every effect in the
deck is one this module draws) — instead of
Result<(), _>.MediaView.unsupported_effects: Option<Vec<String>>, backed by a newmedia.unsupported_effects text[]column (migration 0013), set fromjoin_slides_into_mp4's return value viaresolve_pending_as_video.The client keys the #189 "animations are not shown" note on this field —
contract agreed with Astraea on GRI-2156/forge #197 comment 14410.
Known limitation
Emphasis effects (colour/size changes) are recognised (count toward
step_count, not tagged unsupported) but not drawn — a<p:by>relativecolour shift has no absolute end value in the XML to render without
re-implementing PowerPoint's own colour math. Documented on
ClickEffect::Emphasis.Test plan
cargo test -p server --lib pptx_video— 43 passed, 2 ignored (onepre-existing real-tool test, one newly-relevant real-tool test this
dev box cannot run — no poppler-utils installed here).
cargo test -p server --test pptx_video_acceptance_integration— 7passed, including the newly-unignored
the_189_upload_note_…test.cargo test -p server --test media_acceptance_integration— 6passed, 1 pre-existing ignore (poppler-utils).
cargo clippy --workspace --all-targets --locked -- -D warnings— clean.cargo fmt --check— clean../scripts/local-gates.sh --rust-only— every gate passed.Request changes — one blocking point, one follow-up.
Blocking: an emphasis effect is reported as supported, but it is not drawn.
ClickEffect::Emphasiscounts towardstep_countand returns nounsupported_tag, whilerender_stage_xmlleaves the XML unchanged for it. So a deck whose only animations are emphasis effects (colour/size change) getsunsupported_effects = NULL, and the #189 "animations are not shown" note is removed — but the screen shows no animation at all. Worse, each emphasis step adds an extra frame that is identical to the one before, so the slide just holds longer.The note exists to tell the uploader what the screen will not show. "Recognised but not drawn" is "not shown". Fix:
emphasis) until it is really drawn, andSame rule for an Entrance/Exit/Path whose
spidcould not be read: it is left as is today without a tag. It should be tagged too (e.g.unsupported_effect), so the note stays.Follow-up (not blocking this PR): nothing in
frontend-web/srcreadsunsupported_effectsyet, so the panel shows no note either way. Say on forge #197 who does the panel part, or add it here.Otherwise: CI 7/7 green, up to date with
dev, migration has a rollback. Good work on the expanded timeline.Review #526 is fixed in
eee9453. An emphasis, and an entrance, exit or motion path with no readable spid, now report a tag and spend no frame.render_stage_xmlcounts only effects that render, so later clicks keep the right stage number. The tests cover the emphasis tag, the step count of 3 and the case with no spid. The head is up to date with dev, and the 7 required checks pass. Approved.CI green again on
ecc0ca46after merging origin/dev (#297's no-emphasis fixture). All 11 checks pass, including both GRI-2156 acceptance tests. Review #526's fixes are included. Ready for another look.