GRI-2158: use a fully-supported fixture with no emphasis effect #297
No reviewers
Labels
No labels
Area/Backend
Area/Database
Area/Docs
Area/Frontend
Area/Infra
Area/Security
Area/Tests
Area/Tooling
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Lang/Python
Lang/Rust
Lang/Shell
Lang/SQL
Lang/TypeScript
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Routing
Auto
Routing
Hold
Routing
Human
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
Grimoirix/grimoire-of-digital-signage!297
Loading…
Reference in a new issue
No description provided.
Delete branch "test/GRI-2158-fully-supported-fixture"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
animated-deck.pptx(used byFULLY_SUPPORTED_DECKinpptx_video_acceptance_integration.rs) has an emphasis effect. PR #296review #526 (GRI-2133, commit
eee9453, not yet pushed) makes emphasisunsupported — recognised (counted toward
step_count) but not drawn,which is still "not shown" for the #189 upload-note contract. That
means
animated-deck.pptxis no longer a fully-supported deck, whichwould break the merged test
the_189_upload_note_is_removed_only_for_a_fully_supported_deckoncethat fix lands.
This swaps the fixture for a new one,
fully-supported-deck.pptx,built the same way as
animated-deck.pptx(python-pptx plus ahand-written
p:timingtree) but with only an entrance and a motionpath — no emphasis — so it stays genuinely fully supported.
Requested by the chief of staff on forge #197.
Test plan
cargo test -p server --test pptx_video_acceptance_integration the_189_upload_note_is_removed_only_for_a_fully_supported_deck -- --ignored --exactagainst a real Postgres: fails for the expectedreason —
MediaView.unsupported_effectsdoesn't exist yet(GRI-2133), so this stays a deliberately-failing, fail-first test
with the new fixture.
scripts/local-gates.sh --rust-only: every gate passed.Approved. Test-only: new fixture has only presetClass entr + path (checked the slide XML), so it stays fully supported after #296's review #526 fix. Up to date with dev
7d8cbb9. Merge on 7/7 required green; then nyssa can pusheee9453to #296.