GRI-2158: use a fully-supported fixture with no emphasis effect #297

Merged
vivy merged 1 commit from test/GRI-2158-fully-supported-fixture into dev 2026-11-17 01:30:09 +00:00
Member

Summary

animated-deck.pptx (used by FULLY_SUPPORTED_DECK in
pptx_video_acceptance_integration.rs) has an emphasis effect. PR #296
review #526 (GRI-2133, commit eee9453, not yet pushed) makes emphasis
unsupported — recognised (counted toward step_count) but not drawn,
which is still "not shown" for the #189 upload-note contract. That
means animated-deck.pptx is no longer a fully-supported deck, which
would break the merged test
the_189_upload_note_is_removed_only_for_a_fully_supported_deck once
that fix lands.

This swaps the fixture for a new one, fully-supported-deck.pptx,
built the same way as animated-deck.pptx (python-pptx plus a
hand-written p:timing tree) but with only an entrance and a motion
path — no emphasis — so it stays genuinely fully supported.

Requested by the chief of staff on forge #197.

Test plan

  • cargo test -p server --test pptx_video_acceptance_integration the_189_upload_note_is_removed_only_for_a_fully_supported_deck -- --ignored --exact against a real Postgres: fails for the expected
    reason — MediaView.unsupported_effects doesn't exist yet
    (GRI-2133), so this stays a deliberately-failing, fail-first test
    with the new fixture.
  • scripts/local-gates.sh --rust-only: every gate passed.
## Summary `animated-deck.pptx` (used by `FULLY_SUPPORTED_DECK` in `pptx_video_acceptance_integration.rs`) has an emphasis effect. PR #296 review #526 (GRI-2133, commit `eee9453`, not yet pushed) makes emphasis unsupported — recognised (counted toward `step_count`) but not drawn, which is still "not shown" for the #189 upload-note contract. That means `animated-deck.pptx` is no longer a fully-supported deck, which would break the merged test `the_189_upload_note_is_removed_only_for_a_fully_supported_deck` once that fix lands. This swaps the fixture for a new one, `fully-supported-deck.pptx`, built the same way as `animated-deck.pptx` (python-pptx plus a hand-written `p:timing` tree) but with only an entrance and a motion path — no emphasis — so it stays genuinely fully supported. Requested by the chief of staff on forge #197. ## Test plan - [x] `cargo test -p server --test pptx_video_acceptance_integration the_189_upload_note_is_removed_only_for_a_fully_supported_deck -- --ignored --exact` against a real Postgres: fails for the expected reason — `MediaView.unsupported_effects` doesn't exist yet (GRI-2133), so this stays a deliberately-failing, fail-first test with the new fixture. - [x] `scripts/local-gates.sh --rust-only`: every gate passed.
GRI-2158: use a fully-supported fixture with no emphasis effect
All checks were successful
CI / the pre-push hook (pull_request) Successful in 6s
CI / cargo fmt (pull_request) Successful in 5s
CI / install.sh client upgrade (pull_request) Successful in 13s
CI / cargo deny (pull_request) Successful in 21s
CI / cargo deny advisories (pull_request) Successful in 18s
CI / repository boundary (pull_request) Successful in 6s
CI / cargo clippy (pull_request) Successful in 1m7s
CI / frontend-web (pull_request) Successful in 1m0s
CI / cargo test (pull_request) Successful in 3m31s
CI / Notify gate failed (pull_request) Has been skipped
CI / CI (pull_request) Successful in 2s
445a3b1366
animated-deck.pptx has an emphasis effect, which PR #296 review #526
(GRI-2133) makes unsupported (recognised but not drawn). Swap the
fully-supported-deck fixture for a new one with only an entrance and
a motion path, so the test still exercises a deck that is actually
fully supported.
vivy approved these changes 2026-11-17 01:14:45 +00:00
vivy left a comment

Approved. Test-only: new fixture has only presetClass entr + path (checked the slide XML), so it stays fully supported after #296's review #526 fix. Up to date with dev 7d8cbb9. Merge on 7/7 required green; then nyssa can push eee9453 to #296.

Approved. Test-only: new fixture has only presetClass entr + path (checked the slide XML), so it stays fully supported after #296's review #526 fix. Up to date with dev 7d8cbb9. Merge on 7/7 required green; then nyssa can push eee9453 to #296.
vivy merged commit 54b7432f2a into dev 2026-11-17 01:30:09 +00:00
vivy deleted branch test/GRI-2158-fully-supported-fixture 2026-11-17 01:30:10 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
Grimoirix/grimoire-of-digital-signage!297
No description provided.