GRI-2143: add a panel-wide notification stack for action results #280
No reviewers
Labels
No labels
Area/Backend
Area/Database
Area/Docs
Area/Frontend
Area/Infra
Area/Security
Area/Tests
Area/Tooling
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Lang/Python
Lang/Rust
Lang/Shell
Lang/SQL
Lang/TypeScript
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Routing
Auto
Routing
Hold
Routing
Human
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
Grimoirix/grimoire-of-digital-signage!280
Loading…
Reference in a new issue
No description provided.
Delete branch "feature/GRI-2143-notification-stack"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Forge issue: #279
Summary
NotificationsProvider/useNotifications()(frontend-web/src/notifications/): one stack, top right, success/error/info. Newest at the bottom; a dismissed entry drops out of the accessibility tree at once while its box fades and collapses, so the ones below animate up into its place. Respectsprefers-reduced-motion(global rule already zeroes transition durations).App.tsx, above both the dashboard and the pre-dashboard screens (setup/login), so every write-action screen can report through it.DismissibleError/notice state.Not done in this pass
A few lower-traffic screens (
PlaylistsScreen,IpRulesScreen,NetworkSettingsTab,PlaybackSettingsTab,SetupWizard/SetupScreen/LoginScreen) still use the oldDismissibleErrorfor their own action results. Flagged on the forge issue as a likely fast follow-up rather than folded into this PR, to keep this change reviewable.Test plan
frontend-web:npm run check(prettier, oxlint, tsc, vitest) — all green, 172/172 tests.NotificationsProvider.test.tsx): stack order (newest at bottom), fade+removal timing, move-up after a sibling clears, close button, pointer-hold pause/resume on errors, error timeout longer than success, accessible roles (status/alert).npm run buildsucceeds../scripts/local-gates.sh --frontend-only— every gate passed.@grimoirix/designcustom properties, no literals), and the existing globalprefers-reduced-motionrule.Approved, and merging. Meets the "done when" of #279: the stack, its tests (order, fade, move-up, pointer hold) and save/delete/upload use it. CI 7/7 green, up to date with dev
4353d22.#279 stays open for the rest, because the product owner asked for every button. Still inline, not in the stack:
PlaylistMediaTab— playlist Save (the save he presses most; not in your not-done list)UsersScreen— add user, set password, editPlaybackSettingsTab— global default playtime savePlaylistsScreen,IpRulesScreen,NetworkSettingsTabLogin/setup screens may keep their inline error: there is no action result to report there yet. Field validation next to a field may also stay inline.
Please do the list above as a second PR on #279.