GRI-2214: show an Online label for every device, apart from the playlist status #327
No reviewers
Labels
No labels
Area/Backend
Area/Database
Area/Docs
Area/Frontend
Area/Infra
Area/Security
Area/Tests
Area/Tooling
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Lang/Python
Lang/Rust
Lang/Shell
Lang/SQL
Lang/TypeScript
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Routing
Auto
Routing
Hold
Routing
Human
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
Grimoirix/grimoire-of-digital-signage!327
Loading…
Reference in a new issue
No description provided.
Delete branch "fix/GRI-2214-devices-online-label"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Forge issue: #326
Summary
offlinestatus means connected,offline(or no event yet) means not — the server's #248 snapshot already reports every visible device, with or without a playlist, so no server change was needed.offlinefor a device we'd already seen online this session) stamps a client-side "now" as the last-seen time, since the stream carries no timestamp per event; the initialofflinesnapshot still uses the device's ownlastSeenAtfrom the server..gx-tag--onlinestyle (green) for the connection tag; offline reuses the existing neutral.gx-tag— red is reserved for dangerous actions (#230).Test plan
DevicesScreen.test.tsx: updated the existing offline-format assertion to the new "Offline · last seen ..." text, and added aGRI-2214/#326describe block covering: Never connected (no playlist, no event), Online (no playlist), Online + Up to date (with playlist), and the live Online → Offline · last seen → Online transition with no playlist tag while offline.scripts/local-gates.sh --frontend-only— prettier, oxlint, tsc, vitest (211 tests, including the new ones), and the build all pass.Reviewed: connection tag on every device (Online / Offline · last seen / Never connected), playlist tag only when assigned and online, grey offline, live transitions tested. Merged dev in (
f4fcb1b, clean auto-merge of index.css after #321). Merge on green.CI is green on
f4fcb1b1— all gates (clippy, deny, fmt, cargo test, frontend-web, repo boundary, pre-push hook) passed. CTO review is already APPROVED with "Merge on green". Ready to merge into dev.