GRI-2173: mask gnome-initial-setup's first-login and upgrade-login wizards #303
No reviewers
Labels
No labels
Area/Backend
Area/Database
Area/Docs
Area/Frontend
Area/Infra
Area/Security
Area/Tests
Area/Tooling
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Lang/Python
Lang/Rust
Lang/Shell
Lang/SQL
Lang/TypeScript
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Routing
Auto
Routing
Hold
Routing
Human
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No project
No assignees
3 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
Grimoirix/grimoire-of-digital-signage!303
Loading…
Reference in a new issue
No description provided.
Delete branch "fix/GRI-2173-mask-gnome-initial-setup-wizards"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
Fixes #301
install.shalready wrote~/.config/gnome-initial-setup-donefor the kioskuser, which stops only
gnome-initial-setup-first-login.service. Ubuntu26.04's
gnome-initial-setup50.0 adds a second per-user unit,gnome-initial-setup-upgrade-login.service, that is gated on that same donefile plus a release-named marker (
upgrade-<VERSION_ID>-done) — so writingthe done file is exactly what triggers the upgrade wizard, and it opens on
top of the player after every boot following an Ubuntu upgrade.
kiosk_apply's wizard step is replaced with a newkiosk_skip_wizardfunction that, for the kiosk user only:
gnome-initial-setup-first-login,gnome-initial-setup-upgrade-login,gnome-initial-setup-copy-worker) to/dev/nullunder~/.config/systemd/user/, so no future release canbring them back by name alone.
gnome-initial-setup-done, and also writes~/.config/gnome-initial-setup/upgrade-<VERSION_ID>-doneread from/etc/os-release(now$OS_RELEASE, overridable like the other pathvariables), belt and braces in case a unit is ever renamed.
chown -h "$user:$user"every directory, marker and symlink created —fixing the old
chown "$user:"call, which left~/.configasscryglass:rootrather thanscryglass:scryglass.-hmatters herebecause the masks are symlinks and the old call (without
-h) would tryto chown their target,
/dev/null.never touches another user's home or masks the units system-wide — the
admin's own account keeps gnome-initial-setup working normally.
Test plan
scripts/tests/install-client-kiosk-test.shextended with a dedicated"wizard masks" section (fixture
/etc/os-releasecontent, checks allthree masks, both done markers,
chown -h user:groupon every path,idempotency on a second run, and the no-os-release fallback) plus
matching assertions inside the existing "whole step" install/upgrade
integration test. All assertions pass locally.
scripts/tests/install-client-unit-test.shandscripts/tests/install-client-upgrade-test.shstill pass unmodified(confirmed the former's "no systemd user manager" skip is pre-existing
on this build host, unrelated to this change).
bash -n install.sh— syntax clean..github/workflows/ci.ymljob "install.shclient upgrade" runs this exact test file).
confirm no Welcome window, and the session journal shows the three
units masked/skipped.
Security judgement and fix: PR #308 accepts RUSTSEC-2026-0543 (chrono, unmaintained, no CVE, no fix available) with a dated
deny.tomlentry, same shape as the existing three. Full reasoning on issue #305. Once #308 merges todev, rebasing this branch should clearcargo deny advisories.#308 is in
dev: the RUSTSEC-2026-0543 red is fixed there. Mergeorigin/devinto this branch (or re-run CI) to pick it up.