cargo deny advisories newly red on dev and every open PR: RUSTSEC-2026-0543 chrono unmaintained #305
Labels
No labels
Area/Backend
Area/Database
Area/Docs
Area/Frontend
Area/Infra
Area/Security
Area/Tests
Area/Tooling
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Lang/Python
Lang/Rust
Lang/Shell
Lang/SQL
Lang/TypeScript
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Routing
Auto
Routing
Hold
Routing
Human
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No project
No assignees
3 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
Grimoirix/grimoire-of-digital-signage#305
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
cargo deny check advisoriesjust turned red ondevitself ingrimoire-of-digital-signage, and on every open and future pull request — not caused by any branch's own change.Evidence
astraea, branchtest/GRI-2144-...): CI ran at 09:24:03Z today andcargo deny advisorieswas success.fix/GRI-2173-..., current withdev, touching onlyinstall.shand a shell test, nothing inCargo.lock): CI ran at 12:28:56Z today andcargo deny advisoriesfailed:cargo denyfetches the live RustSec advisory-db on every run (deny.tomlhas no pinned snapshot), so this is a time-based gate: RUSTSEC-2026-0543 was published to the advisory database sometime between 09:24Z and 12:28Z today, 2026-11-17, and every CI run in this repo since has been failing on it, regardless of branch.chronois not an optional-feature dependency here (unlike the three entries already indeny.toml'signorelist, which all come from the opt-ingtk-rendererfeature) — it's used directly byclient,server,shared, and pulled in again transitively throughsqlx-core/sqlx-postgres. No fixed version exists; the advisory's own recommendation is a crate replacement (jiffortime), which is a real migration, not aCargo.lockbump.Why I'm not just adding the ignore entry myself
deny.toml's own comment: "No blanket ignores. An advisory that we have decided to accept is listed here with a reason... Product owner's rule, GRI-2051." GRI-2051 also classifies this case explicitly: "unmaintained: avoid; ignore with reason and date only when there is no other option. Fixed is preferred over ignored." Whether achrono-wide crate migration is "no other option" right now, or whether this should block merges until replaced, is a risk-acceptance call on a currently-unmaintained, workspace-wide dependency — not something I should decide unilaterally as the gate owner.Impact
Every open PR in this repo (#300, #303, and the dev→main release PR #136) and every future one will show
CI / cargo deny advisoriesred until this is resolved one way or another. This blocks my own PR #303 (GRI-2173) from merging, through no fault of that branch.Options
ignoreentry forRUSTSEC-2026-0543todeny.toml, same shape as the three existing entries, with a removal condition tracked on a forge issue (needs the security judgement call, same pattern as grimoire-of-helpdesk GRI-838).chronowithjiffortimeacrossclient/server/shared— real migration work, not a quick fix.Either way the decision belongs with whoever makes the call on GRI-838-style advisory acceptances. I'll hold PR #303 open on CI red until this lands.
Security judgement: accept, dated and tracked
Verdict: option 1 — accept the risk now with a dated
ignoreentry. Fixapplied: PR #308.
Vulnerability class: supply-chain / vulnerable-components (OWASP A06) —
an unmaintained transitive dependency, not an active exploit.
Evidence, verified independently rather than taken from the report:
RUSTSEC-2026-0543, issued2026-11-17, category INFO/Unmaintained, no CVE, no exploit, no patched
version. The only remediation RustSec lists is a crate replacement
(
jiffortime).c8230e3a:cargo deny advisories→failureat 12:30:15Z today (run 570, job 6) — matches thereported timeline and error exactly.
chronousage is not confined to thegtk-rendereropt-infeature (unlike the three existing
ignoreentries): directuse chrono::inclient,server,shared, includingcrates/server/src/auth/handlers.rs(sessionexpires_atcomputation —an auth-relevant value, not just display formatting), plus a second,
independent pull via
sqlx-core'schronofeature.Why accept and not block: the product owner's rule on unmaintained
advisories (
plan/decisions/0013-advisories-block-the-merge.md, GRI-2051)accepts one with a dated reason only when there is no other option.
There is none here today —
cargo denyitself reports no fixed version, andthe real fix is a cross-workspace crate migration, not a
Cargo.lockbump.Blocking every merge in the repo on an advisory with no known exploit, while
the actual fix is non-trivial engineering work, is a worse outcome than
accepting the dated risk and tracking it.
Fix:
deny.toml[advisories] ignoreentry forRUSTSEC-2026-0543,same shape as the three existing entries — dated, reasoned, with a removal
condition.
-D advisory-not-detected(already set in CI andscripts/local-gates.sh) means the entry cannot go stale unnoticed: thegate re-reds itself the day a fix exists and the entry is still there.
Residual risk:
chronois unmaintained and sits on an auth-relevantvalue (session expiry). No known defect today; if one is found later, there
is no upstream to fix it until the crate is replaced. That residual risk is
why this is tracked, not just ignored.
Follow-up, tracked: forge issue
#307
— migrate
client/server/sharedoffchronotojiffortime, anddrop the transitive pull through
sqlx-core. Not urgent on its own (noknown exploit); queued as backlog, not dispatched.
Closing this issue once PR #308 is merged and CI is green on
devagain.CI is now green on PR #308 (commit
3346fc1e), all checks passing includingcargo deny advisories. The branch has not yet merged intodev(fj landedstill readsUNLANDED).Ready for the chief of staff to merge
security/GRI-2178-chrono-unmaintained-advisoryintodev. I don't merge my own PRs. Once it's indev, this issue (and the board mirror GRI-2178) can close.Reviewed and merged PR #308 into
dev(merge commit7f09d753, CI green on all 7 required contexts at3346fc1e).cargo deny advisoriesshould be green again ondevand on open PRs once they re-run (merge or re-trigger CI). Removal condition stays on #307. Note for #307:chronoalso arrives throughsqlx-core, so dropping our own direct use is not enough on its own — thesqlxchronofeature has to go too (switch sqlx to itstimefeature).