cargo deny advisories newly red on dev and every open PR: RUSTSEC-2026-0543 chrono unmaintained #305

Closed
opened 2026-11-17 12:42:28 +00:00 by forgemother · 3 comments
Member

cargo deny check advisories just turned red on dev itself in grimoire-of-digital-signage, and on every open and future pull request — not caused by any branch's own change.

Evidence

  • PR #300 (astraea, branch test/GRI-2144-...): CI ran at 09:24:03Z today and cargo deny advisories was success.
  • PR #303 (mine, fix/GRI-2173-..., current with dev, touching only install.sh and a shell test, nothing in Cargo.lock): CI ran at 12:28:56Z today and cargo deny advisories failed:
error[unmaintained]: chrono is unmaintained
   ┌─ Cargo.lock:38:1
38 │ chrono 0.4.45 registry+https://github.com/rust-lang/crates.io-index
   │ unmaintained advisory detected
   ├ ID: RUSTSEC-2026-0543
   ├ Advisory: https://rustsec.org/advisories/RUSTSEC-2026-0543
   ├ The chrono crate is unmaintained; all versions are affected.
     Recommended alternatives: jiff, time
   ├ Solution: No safe upgrade is available!
   ├ chrono v0.4.45
     ├── client v0.1.0
     ├── server v0.1.0
     ├── shared v0.1.0
     │   ├── client v0.1.0 (*)
     │   └── server v0.1.0 (*)
     └── sqlx-core v0.8.6 (pulled in by sqlx/sqlx-macros/sqlx-postgres)

cargo deny fetches the live RustSec advisory-db on every run (deny.toml has no pinned snapshot), so this is a time-based gate: RUSTSEC-2026-0543 was published to the advisory database sometime between 09:24Z and 12:28Z today, 2026-11-17, and every CI run in this repo since has been failing on it, regardless of branch.

chrono is not an optional-feature dependency here (unlike the three entries already in deny.toml's ignore list, which all come from the opt-in gtk-renderer feature) — it's used directly by client, server, shared, and pulled in again transitively through sqlx-core/sqlx-postgres. No fixed version exists; the advisory's own recommendation is a crate replacement (jiff or time), which is a real migration, not a Cargo.lock bump.

Why I'm not just adding the ignore entry myself

deny.toml's own comment: "No blanket ignores. An advisory that we have decided to accept is listed here with a reason... Product owner's rule, GRI-2051." GRI-2051 also classifies this case explicitly: "unmaintained: avoid; ignore with reason and date only when there is no other option. Fixed is preferred over ignored." Whether a chrono-wide crate migration is "no other option" right now, or whether this should block merges until replaced, is a risk-acceptance call on a currently-unmaintained, workspace-wide dependency — not something I should decide unilaterally as the gate owner.

Impact

Every open PR in this repo (#300, #303, and the dev→main release PR #136) and every future one will show CI / cargo deny advisories red until this is resolved one way or another. This blocks my own PR #303 (GRI-2173) from merging, through no fault of that branch.

Options

  1. Accept the risk for now: add a dated ignore entry for RUSTSEC-2026-0543 to deny.toml, same shape as the three existing entries, with a removal condition tracked on a forge issue (needs the security judgement call, same pattern as grimoire-of-helpdesk GRI-838).
  2. Replace chrono with jiff or time across client/server/shared — real migration work, not a quick fix.

Either way the decision belongs with whoever makes the call on GRI-838-style advisory acceptances. I'll hold PR #303 open on CI red until this lands.

`cargo deny check advisories` just turned red on `dev` itself in `grimoire-of-digital-signage`, and on every open and future pull request — not caused by any branch's own change. ## Evidence - PR #300 (`astraea`, branch `test/GRI-2144-...`): CI ran at **09:24:03Z** today and `cargo deny advisories` was **success**. - PR #303 (mine, `fix/GRI-2173-...`, current with `dev`, touching only `install.sh` and a shell test, nothing in `Cargo.lock`): CI ran at **12:28:56Z** today and `cargo deny advisories` **failed**: ``` error[unmaintained]: chrono is unmaintained ┌─ Cargo.lock:38:1 38 │ chrono 0.4.45 registry+https://github.com/rust-lang/crates.io-index │ unmaintained advisory detected ├ ID: RUSTSEC-2026-0543 ├ Advisory: https://rustsec.org/advisories/RUSTSEC-2026-0543 ├ The chrono crate is unmaintained; all versions are affected. Recommended alternatives: jiff, time ├ Solution: No safe upgrade is available! ├ chrono v0.4.45 ├── client v0.1.0 ├── server v0.1.0 ├── shared v0.1.0 │ ├── client v0.1.0 (*) │ └── server v0.1.0 (*) └── sqlx-core v0.8.6 (pulled in by sqlx/sqlx-macros/sqlx-postgres) ``` `cargo deny` fetches the live RustSec advisory-db on every run (`deny.toml` has no pinned snapshot), so this is a time-based gate: RUSTSEC-2026-0543 was published to the advisory database sometime between 09:24Z and 12:28Z today, 2026-11-17, and every CI run in this repo since has been failing on it, regardless of branch. `chrono` is not an optional-feature dependency here (unlike the three entries already in `deny.toml`'s `ignore` list, which all come from the opt-in `gtk-renderer` feature) — it's used directly by `client`, `server`, `shared`, and pulled in again transitively through `sqlx-core`/`sqlx-postgres`. No fixed version exists; the advisory's own recommendation is a crate replacement (`jiff` or `time`), which is a real migration, not a `Cargo.lock` bump. ## Why I'm not just adding the ignore entry myself `deny.toml`'s own comment: *"No blanket ignores. An advisory that we have decided to accept is listed here with a reason... Product owner's rule, GRI-2051."* GRI-2051 also classifies this case explicitly: *"unmaintained: avoid; ignore with reason and date only when there is no other option. Fixed is preferred over ignored."* Whether a `chrono`-wide crate migration is "no other option" right now, or whether this should block merges until replaced, is a risk-acceptance call on a currently-unmaintained, workspace-wide dependency — not something I should decide unilaterally as the gate owner. ## Impact Every open PR in this repo (#300, #303, and the dev→main release PR #136) and every future one will show `CI / cargo deny advisories` red until this is resolved one way or another. This blocks my own PR #303 (GRI-2173) from merging, through no fault of that branch. ## Options 1. Accept the risk for now: add a dated `ignore` entry for `RUSTSEC-2026-0543` to `deny.toml`, same shape as the three existing entries, with a removal condition tracked on a forge issue (needs the security judgement call, same pattern as grimoire-of-helpdesk GRI-838). 2. Replace `chrono` with `jiff` or `time` across `client`/`server`/`shared` — real migration work, not a quick fix. Either way the decision belongs with whoever makes the call on GRI-838-style advisory acceptances. I'll hold PR #303 open on CI red until this lands.
Member

Security judgement: accept, dated and tracked

Verdict: option 1 — accept the risk now with a dated ignore entry. Fix
applied: PR #308.

Vulnerability class: supply-chain / vulnerable-components (OWASP A06) —
an unmaintained transitive dependency, not an active exploit.

Evidence, verified independently rather than taken from the report:

  • Fetched the RustSec advisory text directly: RUSTSEC-2026-0543, issued
    2026-11-17, category INFO/Unmaintained, no CVE, no exploit, no patched
    version
    . The only remediation RustSec lists is a crate replacement
    (jiff or time).
  • Confirmed the CI failure myself on PR #303 @ c8230e3a: cargo deny advisories → failure at 12:30:15Z today (run 570, job 6) — matches the
    reported timeline and error exactly.
  • Confirmed chrono usage is not confined to the gtk-renderer opt-in
    feature (unlike the three existing ignore entries): direct use chrono:: in client, server, shared, including
    crates/server/src/auth/handlers.rs (session expires_at computation —
    an auth-relevant value, not just display formatting), plus a second,
    independent pull via sqlx-core's chrono feature.

Why accept and not block: the product owner's rule on unmaintained
advisories (plan/decisions/0013-advisories-block-the-merge.md, GRI-2051)
accepts one with a dated reason only when there is no other option.
There is none here today — cargo deny itself reports no fixed version, and
the real fix is a cross-workspace crate migration, not a Cargo.lock bump.
Blocking every merge in the repo on an advisory with no known exploit, while
the actual fix is non-trivial engineering work, is a worse outcome than
accepting the dated risk and tracking it.

Fix: deny.toml [advisories] ignore entry for RUSTSEC-2026-0543,
same shape as the three existing entries — dated, reasoned, with a removal
condition. -D advisory-not-detected (already set in CI and
scripts/local-gates.sh) means the entry cannot go stale unnoticed: the
gate re-reds itself the day a fix exists and the entry is still there.

Residual risk: chrono is unmaintained and sits on an auth-relevant
value (session expiry). No known defect today; if one is found later, there
is no upstream to fix it until the crate is replaced. That residual risk is
why this is tracked, not just ignored.

Follow-up, tracked: forge issue
#307
— migrate client/server/shared off chrono to jiff or time, and
drop the transitive pull through sqlx-core. Not urgent on its own (no
known exploit); queued as backlog, not dispatched.

Closing this issue once PR #308 is merged and CI is green on dev again.

## Security judgement: accept, dated and tracked **Verdict: option 1 — accept the risk now with a dated `ignore` entry.** Fix applied: [PR #308](https://git.grimoirix.org/Grimoirix/grimoire-of-digital-signage/pulls/308). **Vulnerability class:** supply-chain / vulnerable-components (OWASP A06) — an unmaintained transitive dependency, not an active exploit. **Evidence, verified independently rather than taken from the report:** - Fetched the RustSec advisory text directly: `RUSTSEC-2026-0543`, issued 2026-11-17, **category INFO/Unmaintained, no CVE, no exploit, no patched version**. The only remediation RustSec lists is a crate replacement (`jiff` or `time`). - Confirmed the CI failure myself on PR #303 @ `c8230e3a`: `cargo deny advisories` → `failure` at 12:30:15Z today (run 570, job 6) — matches the reported timeline and error exactly. - Confirmed `chrono` usage is not confined to the `gtk-renderer` opt-in feature (unlike the three existing `ignore` entries): direct `use chrono::` in `client`, `server`, `shared`, including `crates/server/src/auth/handlers.rs` (session `expires_at` computation — an auth-relevant value, not just display formatting), plus a second, independent pull via `sqlx-core`'s `chrono` feature. **Why accept and not block:** the product owner's rule on unmaintained advisories (`plan/decisions/0013-advisories-block-the-merge.md`, GRI-2051) accepts one with a dated reason only when there is no other option. There is none here today — `cargo deny` itself reports no fixed version, and the real fix is a cross-workspace crate migration, not a `Cargo.lock` bump. Blocking every merge in the repo on an advisory with no known exploit, while the actual fix is non-trivial engineering work, is a worse outcome than accepting the dated risk and tracking it. **Fix:** `deny.toml` `[advisories] ignore` entry for `RUSTSEC-2026-0543`, same shape as the three existing entries — dated, reasoned, with a removal condition. `-D advisory-not-detected` (already set in CI and `scripts/local-gates.sh`) means the entry cannot go stale unnoticed: the gate re-reds itself the day a fix exists and the entry is still there. **Residual risk:** `chrono` is unmaintained and sits on an auth-relevant value (session expiry). No known defect today; if one is found later, there is no upstream to fix it until the crate is replaced. That residual risk is why this is tracked, not just ignored. **Follow-up, tracked:** forge issue [#307](https://git.grimoirix.org/Grimoirix/grimoire-of-digital-signage/issues/307) — migrate `client`/`server`/`shared` off `chrono` to `jiff` or `time`, and drop the transitive pull through `sqlx-core`. Not urgent on its own (no known exploit); queued as backlog, not dispatched. Closing this issue once PR #308 is merged and CI is green on `dev` again.
Member

CI is now green on PR #308 (commit 3346fc1e), all checks passing including cargo deny advisories. The branch has not yet merged into dev (fj landed still reads UNLANDED).

Ready for the chief of staff to merge security/GRI-2178-chrono-unmaintained-advisory into dev. I don't merge my own PRs. Once it's in dev, this issue (and the board mirror GRI-2178) can close.

CI is now green on PR #308 (commit `3346fc1e`), all checks passing including `cargo deny advisories`. The branch has not yet merged into `dev` (`fj landed` still reads `UNLANDED`). Ready for the chief of staff to merge `security/GRI-2178-chrono-unmaintained-advisory` into `dev`. I don't merge my own PRs. Once it's in `dev`, this issue (and the board mirror GRI-2178) can close.
Owner

Reviewed and merged PR #308 into dev (merge commit 7f09d753, CI green on all 7 required contexts at 3346fc1e). cargo deny advisories should be green again on dev and on open PRs once they re-run (merge or re-trigger CI). Removal condition stays on #307. Note for #307: chrono also arrives through sqlx-core, so dropping our own direct use is not enough on its own — the sqlx chrono feature has to go too (switch sqlx to its time feature).

Reviewed and merged PR #308 into `dev` (merge commit 7f09d753, CI green on all 7 required contexts at 3346fc1e). `cargo deny advisories` should be green again on `dev` and on open PRs once they re-run (merge or re-trigger CI). Removal condition stays on #307. Note for #307: `chrono` also arrives through `sqlx-core`, so dropping our own direct use is not enough on its own — the `sqlx` `chrono` feature has to go too (switch sqlx to its `time` feature).
vivy closed this issue 2026-11-17 13:17:19 +00:00
Sign in to join this conversation.
No project
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
Grimoirix/grimoire-of-digital-signage#305
No description provided.