GRI-2144: fail-first tests for playlist page sub-list, override badge and Reset #300
No reviewers
Labels
No labels
Area/Backend
Area/Database
Area/Docs
Area/Frontend
Area/Infra
Area/Security
Area/Tests
Area/Tooling
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Lang/Python
Lang/Rust
Lang/Shell
Lang/SQL
Lang/TypeScript
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Routing
Auto
Routing
Hold
Routing
Human
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
Grimoirix/grimoire-of-digital-signage!300
Loading…
Reference in a new issue
No description provided.
Delete branch "test/GRI-2144-playlist-page-sublist"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
Fail-first tests for the two UI pieces the chief of staff pinned down on
forge #278 (comment 14538):
item's own row (shape (b): Media Library's
aria-expandedtoggle, with athumbnail, page number, own time field and "Skip this page" inline per
page row) — not behind the current gated "⚙ Page overrides" button/panel.
button; a page that inherits shows neither, and its field carries the
inherited value as a placeholder. Reset clears the override outright
(page → file → playlist → campus → global) — it does not restore a prior
value.
This replaces the old cogwheel/panel-based test (
PlaylistsScreen.test.tsxpreviously 307-368) with one that exercises the new sub-list shape for the
same set/skip/clear round trip, and adds a new test for the badge + Reset.
Both new tests fail against current
dev—scripts/local-gates.sh --frontend-onlyon this branch:Test Files 1 failed | 24 passed (25),Tests 2 failed | 194 passed (196), both failing withTestingLibraryElementError: Unable to find an accessible element with the role "listitem" and name /handbook\.pdf/ibecause the current item row hasno accessible name and still shows the old "⚙ Page overrides" button. That
red is expected and intentional — no implementation exists yet. CI on this
PR will be red for the same reason.
No production code changed. GRI-2144 (board) / #278 (forge) stay with
Frontend to implement against these two tests; once they're green the
existing 13 unrelated tests plus these two should all pass.
Test plan
npx vitest run src/screens/PlaylistsScreen.test.tsx— 13 pre-existingtests pass, 2 new tests fail (fail-first, expected).
green with no further test changes needed.
Superseded by #331, which carries these tests and the panel work; merged into dev.
Pull request closed