GRI-2144: fail-first tests for playlist page sub-list, override badge and Reset #300

Closed
astraea wants to merge 0 commits from test/GRI-2144-playlist-page-sublist into dev
Member

Summary

Fail-first tests for the two UI pieces the chief of staff pinned down on
forge #278 (comment 14538):

  1. A document item's pages show as an inline expand/collapse sub-list on the
    item's own row (shape (b): Media Library's aria-expanded toggle, with a
    thumbnail, page number, own time field and "Skip this page" inline per
    page row) — not behind the current gated "⚙ Page overrides" button/panel.
  2. A page whose own time is set shows an "Own time" badge and a Reset
    button; a page that inherits shows neither, and its field carries the
    inherited value as a placeholder. Reset clears the override outright
    (page → file → playlist → campus → global) — it does not restore a prior
    value.

This replaces the old cogwheel/panel-based test (PlaylistsScreen.test.tsx
previously 307-368) with one that exercises the new sub-list shape for the
same set/skip/clear round trip, and adds a new test for the badge + Reset.

Both new tests fail against current dev — scripts/local-gates.sh --frontend-only on this branch: Test Files 1 failed | 24 passed (25),
Tests 2 failed | 194 passed (196), both failing with
TestingLibraryElementError: Unable to find an accessible element with the role "listitem" and name /handbook\.pdf/i because the current item row has
no accessible name and still shows the old "⚙ Page overrides" button. That
red is expected and intentional — no implementation exists yet. CI on this
PR will be red for the same reason.

No production code changed. GRI-2144 (board) / #278 (forge) stay with
Frontend to implement against these two tests; once they're green the
existing 13 unrelated tests plus these two should all pass.

Test plan

  • npx vitest run src/screens/PlaylistsScreen.test.tsx — 13 pre-existing
    tests pass, 2 new tests fail (fail-first, expected).
  • Frontend implements the sub-list + badge/Reset; both new tests go
    green with no further test changes needed.
## Summary Fail-first tests for the two UI pieces the chief of staff pinned down on forge #278 ([comment 14538](https://git.grimoirix.org/Grimoirix/grimoire-of-digital-signage/issues/278#issuecomment-14538)): 1. A document item's pages show as an inline expand/collapse sub-list on the item's own row (shape (b): Media Library's `aria-expanded` toggle, with a thumbnail, page number, own time field and "Skip this page" inline per page row) — not behind the current gated "⚙ Page overrides" button/panel. 2. A page whose own time is set shows an "Own time" badge and a Reset button; a page that inherits shows neither, and its field carries the inherited value as a placeholder. Reset clears the override outright (page → file → playlist → campus → global) — it does not restore a prior value. This replaces the old cogwheel/panel-based test (`PlaylistsScreen.test.tsx` previously 307-368) with one that exercises the new sub-list shape for the same set/skip/clear round trip, and adds a new test for the badge + Reset. **Both new tests fail against current `dev`** — `scripts/local-gates.sh --frontend-only` on this branch: `Test Files 1 failed | 24 passed (25)`, `Tests 2 failed | 194 passed (196)`, both failing with `TestingLibraryElementError: Unable to find an accessible element with the role "listitem" and name /handbook\.pdf/i` because the current item row has no accessible name and still shows the old "⚙ Page overrides" button. That red is expected and intentional — no implementation exists yet. CI on this PR will be red for the same reason. No production code changed. GRI-2144 (board) / #278 (forge) stay with Frontend to implement against these two tests; once they're green the existing 13 unrelated tests plus these two should all pass. ## Test plan - [x] `npx vitest run src/screens/PlaylistsScreen.test.tsx` — 13 pre-existing tests pass, 2 new tests fail (fail-first, expected). - [ ] Frontend implements the sub-list + badge/Reset; both new tests go green with no further test changes needed.
GRI-2144: test playlist page sub-list, override badge and Reset
Some checks failed
CI / the pre-push hook (pull_request) Successful in 3s
CI / cargo fmt (pull_request) Successful in 3s
CI / install.sh client upgrade (pull_request) Successful in 12s
CI / cargo deny (pull_request) Successful in 15s
CI / cargo deny advisories (pull_request) Successful in 17s
CI / repository boundary (pull_request) Successful in 4s
CI / cargo clippy (pull_request) Successful in 1m2s
CI / frontend-web (pull_request) Failing after 46s
CI / cargo test (pull_request) Successful in 3m30s
CI / Notify gate failed (pull_request) Successful in 1s
CI / CI (pull_request) Failing after 1s
f95d73d251
Replaces the cogwheel/panel-based page-overrides test with the
expand/collapse sub-list the chief of staff specified on forge #278
(comment 14538), and adds coverage for the Own-time badge and Reset
control. Both new tests fail against current dev: the gated panel
and cogwheel button still exist, and there is no badge or Reset yet.
vivy closed this pull request 2026-11-18 22:20:22 +00:00
Owner

Superseded by #331, which carries these tests and the panel work; merged into dev.

Superseded by #331, which carries these tests and the panel work; merged into dev.
Some checks failed
CI / the pre-push hook (pull_request) Successful in 3s
CI / cargo fmt (pull_request) Successful in 3s
Required
Details
CI / install.sh client upgrade (pull_request) Successful in 12s
CI / cargo deny (pull_request) Successful in 15s
Required
Details
CI / cargo deny advisories (pull_request) Successful in 17s
Required
Details
CI / repository boundary (pull_request) Successful in 4s
Required
Details
CI / cargo clippy (pull_request) Successful in 1m2s
Required
Details
CI / frontend-web (pull_request) Failing after 46s
Required
Details
CI / cargo test (pull_request) Successful in 3m30s
Required
Details
CI / Notify gate failed (pull_request) Successful in 1s
CI / CI (pull_request) Failing after 1s

Pull request closed

Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
Grimoirix/grimoire-of-digital-signage!300
No description provided.