Settings: global and per-campus, with fallback #161
Labels
No labels
Area/Backend
Area/Database
Area/Docs
Area/Frontend
Area/Infra
Area/Security
Area/Tests
Area/Tooling
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Lang/Python
Lang/Rust
Lang/Shell
Lang/SQL
Lang/TypeScript
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Routing
Auto
Routing
Hold
Routing
Human
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
Grimoirix/grimoire-of-digital-signage#161
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What
Two levels of settings. Global (whole server): reverse proxy / trusted proxies, public URL, mail, sign-in. Per campus: defaults such as the default time per page/item, and other playback defaults. A campus value overrides the global default; unset falls back to it.
Done when
Depends on the campus issue. Before the one-campus production test (GRI-1960).
Product owner decision (GRI-1960, 2026-11-13): campuses are AM, HE, JO, NO; an object belongs to one campus or all (#159). Per-campus settings follow the same shape: a global value, with an optional override per campus. Still held until #159 and #44 land.
Released to prismancer (chief of staff, GRI-1967). Backend + panel. QA-first: ask astraea for acceptance tests on a test/ branch before you implement, same as #172/#174. No hard-coding of server-location values (GRI-1884). One item: this one.
Asked astraea for acceptance tests before implementing (QA-first, per your comment): #178, with the proposed contract (new
playback_settingstable, global vs per-campus playback-defaults endpoints, 404-not-403 for out-of-scope campus access, and a gap in the existingSetupOrSignedIncheck that lets a campus-scopedsettings_manageuser see/change the server-wide settings today). Waiting on #178's tests before writing the implementation; will pick the backend work up as soon as they land on a branch.Implemented against #178's acceptance tests: migration 0007 (playback_settings, one global row plus one per campus), /settings/playback and /campuses/{id}/settings/playback routes, and the SetupOrSignedIn gap closed. All 16 of astraea's acceptance tests pass, plus the panel: SettingsScreen gets the global playback-default field (unscoped settings_manage only), and a new CampusSettingsScreen shows a campus's effective value/source with a way to set or clear its override, routed to from the dashboard for a campus-scoped settings_manage holder.
PR #181 (feature/GRI-1992-campus-playback-settings -> dev), CI running: #181
Done: merged into dev with PR #181 (16 acceptance tests un-ignored, CI green). Closing. Chief of staff.