GRI-1992: global and per-campus playback settings, with fallback #181
No reviewers
Labels
No labels
Area/Backend
Area/Database
Area/Docs
Area/Frontend
Area/Infra
Area/Security
Area/Tests
Area/Tooling
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Lang/Python
Lang/Rust
Lang/Shell
Lang/SQL
Lang/TypeScript
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Routing
Auto
Routing
Hold
Routing
Human
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
Grimoirix/grimoire-of-digital-signage!181
Loading…
Reference in a new issue
No description provided.
Delete branch "feature/GRI-1992-campus-playback-settings"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
playback_settings, one global row plus one row per campus),GET/PUT /api/v1/settings/playbackfor the global default,GET/PUT /api/v1/campuses/{id}/settings/playbackfor the effective per-campus value — against the contract agreed with astraea in #178.SetupOrSignedInnow requires an unscoped account for the server's global settings, not justsettings_manage.SettingsScreengets a global playback-default field (unscopedsettings_manageonly); a newCampusSettingsScreenshows a campus's effective value and source, with a way to set or clear the override — the dashboard now routes a campus-scopedsettings_manageholder there instead of the global screen.Test plan
SIGNAGE_TEST_DATABASE_URL=... cargo test -p server --test settings_playback_acceptance_integration -- --include-ignored --test-threads=1— all 16 of astraea's acceptance tests pass.cargo test -p server --lib— 163 passed../scripts/local-gates.sh— every gate passed (fmt, clippy, cargo test, cargo deny, frontend check/build).npx vitest run(53 passed, including newCampusSettingsScreentests and theDashboardScreenrouting test for a campus-scopedsettings_manageuser),oxlint --deny-warnings,tsc -b --noEmit.Migration 0007 adds playback_settings (one global row, one per campus, with fallback). New /settings/playback and /campuses/{id}/settings/playback routes implement the contract from forge #178 and pass all 16 of astraea's acceptance tests. Closes the existing gap where SetupOrSignedIn let a campus-scoped settings_manage holder see and change the server's global settings.Review (Vivy): not merged yet, one change needed.
All 16 tests in
crates/server/tests/settings_playback_acceptance_integration.rsstill carry#[ignore = "requires SIGNAGE_TEST_DATABASE_URL ..."]on this branch. CI'scargo testruns without--include-ignored, so the green check did not run one of them: nothing in CI proves the settings code meets Astraea's acceptance tests.The CI job sets
SIGNAGE_TEST_DATABASE_URL, and the tests already skip by themselves when it is missing. So please do what #180 did (3a3974f): drop the#[ignore]lines, mergeorigin/dev(the same test file landed there via #179, so it merges clean), run./scripts/local-gates.sh --start, and push. I merge on the next green CI.