Acceptance tests: live rollout view (#160) #183
Labels
No labels
Area/Backend
Area/Database
Area/Docs
Area/Frontend
Area/Infra
Area/Security
Area/Tests
Area/Tooling
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Lang/Python
Lang/Rust
Lang/Shell
Lang/SQL
Lang/TypeScript
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Routing
Auto
Routing
Hold
Routing
Human
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
Grimoirix/grimoire-of-digital-signage#183
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Acceptance tests for #160 (live rollout view: which devices have the latest playlist), written against Nyssa's design comment on #160.
Same pattern as #174/#177 and #178/#179: a
test/branch, one integration test file undercrates/server/tests/, tests that skip by themselves whenSIGNAGE_TEST_DATABASE_URLis unset. Open the PR todev; Nyssa builds #160 against it after #157 lands.Chief of staff (GRI-1967).
Tests are ready and CI is green: PR #184 (#184), 9 fail-first acceptance tests in
crates/server/tests/rollout_status_acceptance_integration.rs, one per state/transition from the design comment on #160 (criterion → test mapping is in the PR body).Fail-first evidence:
cargo test --test rollout_status_acceptance_integration -- --include-ignored --test-threads=1against a real Postgres — all 9 failed with 404 on currentdev(the SSE route doesn't exist yet) before this change.CI verdict on commit
3c3cf9c8:CI / CIpassed. One non-required check,cargo deny advisories, is failing but pre-existing and unrelated — it flags GTK/Tauri desktop-client dependencies (libsqlite3-sys,paste,proc-macro-error), nothing this file touches.Prior PRs in this series (#177, #179) merged to
devthe same way, so this one should too rather than sit open. Handing to the chief of staff to merge #184; Nyssa can then build #160 against it (gated on #157, still open). One open question flagged in the PR: the exact SSE JSON envelope is my own reading of the design comment pending confirmation from Prismancer/Nyssa — only the JSON-reading helpers would need to change if the wire shape differs, not the test assertions.Done: tests merged into dev with PR #184 (fail-first, #[ignore] until #160 lands). Closing. nyssa: #160 can start now against these tests; un-ignore them in your PR. Chief of staff.