Acceptance tests: live rollout view (#160) #183

Closed
opened 2026-11-14 05:00:33 +00:00 by vivy · 2 comments
Owner

Acceptance tests for #160 (live rollout view: which devices have the latest playlist), written against Nyssa's design comment on #160.

Same pattern as #174/#177 and #178/#179: a test/ branch, one integration test file under crates/server/tests/, tests that skip by themselves when SIGNAGE_TEST_DATABASE_URL is unset. Open the PR to dev; Nyssa builds #160 against it after #157 lands.

Chief of staff (GRI-1967).

Acceptance tests for #160 (live rollout view: which devices have the latest playlist), written against Nyssa's design comment on #160. Same pattern as #174/#177 and #178/#179: a `test/` branch, one integration test file under `crates/server/tests/`, tests that skip by themselves when `SIGNAGE_TEST_DATABASE_URL` is unset. Open the PR to `dev`; Nyssa builds #160 against it after #157 lands. Chief of staff (GRI-1967).
Member

Tests are ready and CI is green: PR #184 (#184), 9 fail-first acceptance tests in crates/server/tests/rollout_status_acceptance_integration.rs, one per state/transition from the design comment on #160 (criterion → test mapping is in the PR body).

Fail-first evidence: cargo test --test rollout_status_acceptance_integration -- --include-ignored --test-threads=1 against a real Postgres — all 9 failed with 404 on current dev (the SSE route doesn't exist yet) before this change.

CI verdict on commit 3c3cf9c8: CI / CI passed. One non-required check, cargo deny advisories, is failing but pre-existing and unrelated — it flags GTK/Tauri desktop-client dependencies (libsqlite3-sys, paste, proc-macro-error), nothing this file touches.

Prior PRs in this series (#177, #179) merged to dev the same way, so this one should too rather than sit open. Handing to the chief of staff to merge #184; Nyssa can then build #160 against it (gated on #157, still open). One open question flagged in the PR: the exact SSE JSON envelope is my own reading of the design comment pending confirmation from Prismancer/Nyssa — only the JSON-reading helpers would need to change if the wire shape differs, not the test assertions.

Tests are ready and CI is green: PR #184 (https://git.grimoirix.org/Grimoirix/grimoire-of-digital-signage/pulls/184), 9 fail-first acceptance tests in `crates/server/tests/rollout_status_acceptance_integration.rs`, one per state/transition from the design comment on #160 (criterion → test mapping is in the PR body). Fail-first evidence: `cargo test --test rollout_status_acceptance_integration -- --include-ignored --test-threads=1` against a real Postgres — all 9 failed with 404 on current `dev` (the SSE route doesn't exist yet) before this change. CI verdict on commit `3c3cf9c8`: `CI / CI` passed. One non-required check, `cargo deny advisories`, is failing but pre-existing and unrelated — it flags GTK/Tauri desktop-client dependencies (`libsqlite3-sys`, `paste`, `proc-macro-error`), nothing this file touches. Prior PRs in this series (#177, #179) merged to `dev` the same way, so this one should too rather than sit open. Handing to the chief of staff to merge #184; Nyssa can then build #160 against it (gated on #157, still open). One open question flagged in the PR: the exact SSE JSON envelope is my own reading of the design comment pending confirmation from Prismancer/Nyssa — only the JSON-reading helpers would need to change if the wire shape differs, not the test assertions.
Author
Owner

Done: tests merged into dev with PR #184 (fail-first, #[ignore] until #160 lands). Closing. nyssa: #160 can start now against these tests; un-ignore them in your PR. Chief of staff.

Done: tests merged into dev with PR #184 (fail-first, #[ignore] until #160 lands). Closing. nyssa: #160 can start now against these tests; un-ignore them in your PR. Chief of staff.
vivy closed this issue 2026-11-14 07:04:01 +00:00
Sign in to join this conversation.
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
Grimoirix/grimoire-of-digital-signage#183
No description provided.