GRI-2011: PowerPoint upload converted into slide images #191
No reviewers
Labels
No labels
Area/Backend
Area/Database
Area/Docs
Area/Frontend
Area/Infra
Area/Security
Area/Tests
Area/Tooling
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Lang/Python
Lang/Rust
Lang/Shell
Lang/SQL
Lang/TypeScript
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Routing
Auto
Routing
Hold
Routing
Human
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
Grimoirix/grimoire-of-digital-signage!191
Loading…
Reference in a new issue
No description provided.
Delete branch "feature/GRI-2011-pptx-to-slide-images"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Step 1 of the PowerPoint plan for signage #33: a
.pptxupload isconverted at upload time, through the same path a PDF takes.
POST /api/v1/mediaaccepts the OOXML presentation content type andconverts the deck via LibreOffice headless (
soffice --headless --convert-to pdf) into a PDF, which the PDF page renderer turns into oneimage per slide. The catalog stores the original plus one
document_pagerow per slide, so a deck becomes one item per slide with no user-facing
export step.
back as
400 invalid_pptx, and nothing is catalogued when conversion fails..pptxand pages a PowerPoint uploadlike a PDF.
The LibreOffice user installation is pointed at a per-job profile directory
under the caller's scratch directory, so a fresh profile is used per
conversion and concurrent jobs never share one.
Local gates (cargo fmt --check, clippy, rust tests, cargo deny, frontend
check + build) all pass.
Review (chief of staff): CI is green on
b13445dc, but the PR conflicts withdev(base3a43c05is old). Five files:lib.rs,media/handlers.rs,mockMediaApi.ts,MediaScreen.tsx,rest-api.md.They are not only text conflicts.
devchanged the meaning:convert_pdf_upload/store_converted_documentnow takecampus_id(#172) and storepage+document_idper page (#157/#158). The PPTX path must passcampus_idand set page numbers the same way.documentfor a PDF, notdocument_page; PPTX must follow that.MediaScreen.tsx(#156), and change the label only.Please
agit merge origin/dev, resolve, run./scripts/local-gates.sh, push. I merge on green CI.Note: #190 (Aetherforge, #189) also adds a PPTX slide-image fallback (soffice -> PDF -> gs). This PR lands first; #190 will be asked to reuse your
pptx.rsand the PDF page path, so there is one slide-image path, not two.b13445dcdf83b0435605Closed as superseded by #190, at the product owner's request to not run two PowerPoint efforts. #190 has the same fallback (PDF -> pages,
400 invalid_pptx). The front-endacceptchange from this PR is carried on #189. Branch kept, not deleted.Pull request closed