GRI-2099: client install logs a screen account in at boot (auto-login, no password) #234
No reviewers
Labels
No labels
Area/Backend
Area/Database
Area/Docs
Area/Frontend
Area/Infra
Area/Security
Area/Tests
Area/Tooling
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Lang/Python
Lang/Rust
Lang/Shell
Lang/SQL
Lang/TypeScript
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Routing
Auto
Routing
Hold
Routing
Human
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
Grimoirix/grimoire-of-digital-signage!234
Loading…
Reference in a new issue
No description provided.
Delete branch "feature/GRI-2099-kiosk-autologin"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Closes #232 (board GRI-2099).
After a power cut a screen stood at the GDM login page, and the player only starts in a desktop session.
install.sh clientnow sets the device up to log in by itself:scryglass(or--kiosk-user NAME/SCRYGLASS_KIOSK_USER), created when missing, no admin group. An existing account with sudo, or a system account (uid < 1000), is refused.passwd -d), per GRI-2051.--kiosk-password-keepleaves the password alone and sets only the auto-login.AutomaticLoginEnable=true,AutomaticLogin=<user>in[daemon]of/etc/gdm3/custom.conf(Ubuntu) ordaemon.conf(Debian). Only those two keys change. The original is kept once as<file>.before-scryglass.PermitEmptyPasswordsline (Match blocks included), saysyes./etc/grimoirix-signage/install.toml. An upgrade never re-creates the account, never changes an existing password, and keeps an auto-login that was already set to something else (another user, or turned off by hand).--no-kioskis remembered too.Tests:
scripts/tests/install-client-kiosk-test.sh, 62 assertions, no root needed. It covers the custom.conf edit (keys set, all other lines kept, second run byte-identical), the plan for install/upgrade/reinstall, the refusals, precedence (flag > env > install.toml > default), and the whole step run twice on a private root (second run writes nothing). It runs in the CIinstallerjob and inlocal-gates.sh.local-gates.sh --frontend-onlypassed locally; no Rust changed.Not yet measured: the real reboot on a device. This host has no root and no container, and I have no access to the test client 10.0.0.188. Done-when item 1 needs somebody who has it to run
install.sh clientand then reboot.Review (Vivy, GRI-2099 / GRI-2110): approved. Checked: refusals come before the build (system uid, sudo/admin member, sshd
PermitEmptyPasswords yesincl.sshd_config.dand Match blocks); GDM edit keeps the rest of the file and saves.before-scryglass; upgrade keeps an auto-login someone set by hand; dconf keys are locked and scoped to the screen account only. No hard-coded paths:SCRYGLASS_GDM_CONFoverrides.One behaviour to know, and it is tested on purpose:
upgrade clienton a device installed before this change creates the passwordless screen account and turns on auto-login. That follows from GRI-2051, but it is a change on existing screens at the next upgrade, so it belongs in the release notes. Raspberry Pi OS (LightDM) gets thenogdmmessage and no auto-login.Branch updated from
dev; merging when CI is green.